39849 2010-05-27 10:58:32 -0700 We don't test the async DB success callback in an isolated world. 2010-05-28 22:33:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ericu ericu abarth commit-queue dumi eric ossy webkit.review.bot oldest_to_newest 231367 0 ericu 2010-05-27 10:58:32 -0700 We've got a test for the error callback, but not the success callback. They go through slightly different code, so we should test both. 231424 1 57268 ericu 2010-05-27 13:00:25 -0700 Created attachment 57268 Patch 231444 2 dumi 2010-05-27 13:39:57 -0700 LGTM. 231883 3 57268 dimich 2010-05-28 12:50:39 -0700 Comment on attachment 57268 Patch r=me 232059 4 57268 commit-queue 2010-05-28 20:33:53 -0700 Comment on attachment 57268 Patch Clearing flags on attachment: 57268 Committed r60386: <http://trac.webkit.org/changeset/60386> 232060 5 commit-queue 2010-05-28 20:33:58 -0700 All reviewed patches have been landed. Closing bug. 232065 6 webkit.review.bot 2010-05-28 20:58:13 -0700 http://trac.webkit.org/changeset/60386 might have broken Qt Linux Release 232067 7 eric 2010-05-28 22:12:33 -0700 Looks like it needs a skip on qt. On my phone or I'd be happy to. 232068 8 ossy 2010-05-28 22:33:43 -0700 (In reply to comment #7) > Looks like it needs a skip on qt. On my phone or I'd be happy to Absolutely true, I did it: http://trac.webkit.org/changeset/60388 Thx for the notification. 57268 2010-05-27 13:00:25 -0700 2010-05-28 20:33:53 -0700 Patch bug-39849-20100527130024.patch text/plain 3159 ericu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwMzExKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjcgIEVyaWMgVWhyaGFuZSAgPGVy aWN1QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZSBkb24ndCB0ZXN0IHRoZSBhc3luYyBEQiBzdWNjZXNzIGNhbGxiYWNrIGlu IGFuIGlzb2xhdGVkIHdvcmxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzk4NDkKKworICAgICAgICBUaGlzIHByZXR0eSBtdWNoIGEgY29weSBvZiB0 cmFuc2FjdGlvbi1lcnJvci1jYWxsYmFjay1pc29sYXRlZC13b3JsZC5odG1sLgorICAgICAgICAq IHN0b3JhZ2UvdHJhbnNhY3Rpb24tc3VjY2Vzcy1jYWxsYmFjay1pc29sYXRlZC13b3JsZC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN0b3JhZ2UvdHJhbnNhY3Rpb24tc3VjY2Vzcy1j YWxsYmFjay1pc29sYXRlZC13b3JsZC5odG1sOiBBZGRlZC4KKwogMjAxMC0wNS0yNyAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaGlu aWNoaXJvIEhhbWFqaS4KSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2UvdHJhbnNhY3Rpb24tc3Vj Y2Vzcy1jYWxsYmFjay1pc29sYXRlZC13b3JsZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvc3RvcmFnZS90cmFuc2FjdGlvbi1zdWNjZXNzLWNhbGxiYWNrLWlzb2xhdGVk LXdvcmxkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2Uv dHJhbnNhY3Rpb24tc3VjY2Vzcy1jYWxsYmFjay1pc29sYXRlZC13b3JsZC1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorQUxFUlQ6IHVuZGVmaW5lZAorQUxFUlQ6IFBB U1M6IGRvY3VtZW50LmJvZHkuYmFyIHZpc2libGUgaW4gYSBjYWxsYmFjayBjcmVhdGVkIGluIHRo aXMgd29ybGQuCitUaGlzIHRlc3QgdGVzdHMgdGhhdCB0aGUgdHJhbnNhY3Rpb24gc3VjY2VzcyBj YWxsYmFjayBpcyBjYWxsZWQgaW4gdGhlIHJpZ2h0IHdvcmxkLgorCkluZGV4OiBMYXlvdXRUZXN0 cy9zdG9yYWdlL3RyYW5zYWN0aW9uLXN1Y2Nlc3MtY2FsbGJhY2staXNvbGF0ZWQtd29ybGQuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL3RyYW5zYWN0aW9uLXN1Y2Nlc3Mt Y2FsbGJhY2staXNvbGF0ZWQtd29ybGQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L3N0b3JhZ2UvdHJhbnNhY3Rpb24tc3VjY2Vzcy1jYWxsYmFjay1pc29sYXRlZC13b3JsZC5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGJvZHk+CitUaGlzIHRlc3QgdGVzdHMgdGhhdCB0aGUgdHJhbnNhY3Rpb24gc3VjY2VzcyBjYWxs YmFjayBpcyBjYWxsZWQgaW4gdGhlIHJpZ2h0IHdvcmxkLgorPGRpdiBpZD0iY29uc29sZSI+PC9k aXY+Cis8c2NyaXB0PgordmFyIHRyYW5zYWN0aW9uU3VjY2Vzc0NhbGxiYWNrc0ludm9rZWQgPSAw OworZnVuY3Rpb24gZG9uZSgpCit7CisgICAgaWYgKCgrK3RyYW5zYWN0aW9uU3VjY2Vzc0NhbGxi YWNrc0ludm9rZWQgPT0gMikgJiYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikpCisgICAg ICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKworZnVuY3Rpb24gdHJh bnNhY3Rpb25TdWNjZXNzQ2FsbGJhY2sxKHR4KQoreworICAgIGFsZXJ0KCJGQUlMOiBWaXNpYmxl IGluIGlzb2xhdGVkIHdvcmxkLiIpOworICAgIGRvbmUoKTsKK30KKworZnVuY3Rpb24gdHJhbnNh Y3Rpb25TdWNjZXNzQ2FsbGJhY2syKHR4KQoreworICAgIGFsZXJ0KGRvY3VtZW50LmJvZHkuYmFy KTsKKyAgICBkb25lKCk7Cit9CisKK2RvY3VtZW50LmJvZHkuZm9vID0gIkZBSUw6IGRvY3VtZW50 LmJvZHkuZm9vIHZpc2libGUgaW4gaXNvbGF0ZWQgd29ybGQuIjsKK2RvY3VtZW50LmJvZHkuYmFy ID0gIlBBU1M6IGRvY3VtZW50LmJvZHkuYmFyIHZpc2libGUgaW4gYSBjYWxsYmFjayBjcmVhdGVk IGluIHRoaXMgd29ybGQuIjsKKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor ICAgIGxheW91dFRlc3RDb250cm9sbGVyLmNsZWFyQWxsRGF0YWJhc2VzKCk7CisgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndh aXRVbnRpbERvbmUoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ldmFsdWF0ZVNjcmlwdElu SXNvbGF0ZWRXb3JsZCgKKyAgICAgICAgMCwKKyAgICAgICAgImZ1bmN0aW9uIHRyYW5zYWN0aW9u U3VjY2Vzc0NhbGxiYWNrMSh0eClcbiIgKworICAgICAgICAie1xuIiArCisgICAgICAgICIgICAg YWxlcnQoZG9jdW1lbnQuYm9keS5mb28pO1xuIiArCisgICAgICAgICIgICAgd2luZG93LmxvY2F0 aW9uPSdqYXZhc2NyaXB0OmRvbmUoKSc7XG4iICsKKyAgICAgICAgIn1cbiIgKworICAgICAgICAi dmFyIGRiMSA9IG9wZW5EYXRhYmFzZSgnVHJhbnNhY3Rpb25TdWNjZXNzQ2FsbGJhY2tJc29sYXRl ZFdvcmxkMScsICcxLjAnLCAnJywgMSk7XG4iICsKKyAgICAgICAgImRiMS50cmFuc2FjdGlvbihm dW5jdGlvbih0eCkgeyB9LCBudWxsLCB0cmFuc2FjdGlvblN1Y2Nlc3NDYWxsYmFjazEpOyIpOwor CisgICAgdmFyIGRiMiA9IG9wZW5EYXRhYmFzZSgnVHJhbnNhY3Rpb25TdWNjZXNzQ2FsbGJhY2tJ c29sYXRlZFdvcmxkMicsICcxLjAnLCAnJywgMSk7CisgICAgZGIyLnRyYW5zYWN0aW9uKGZ1bmN0 aW9uKHR4KSB7IH0sIG51bGwsIHRyYW5zYWN0aW9uU3VjY2Vzc0NhbGxiYWNrMik7Cit9Cis8L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K