39841 2010-05-27 08:20:03 -0700 Build break in FileStream.cpp 2010-05-27 15:26:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benm benm commit-queue jianli oldest_to_newest 231312 0 benm 2010-05-27 08:20:03 -0700 Undefined variable in FileStream.cpp:114 - when building with ENABLE_BLOB_SLICE undefined. I assume it should be m_totalBytesToRead rather than m_total? Patch coming. 231317 1 57248 benm 2010-05-27 08:28:56 -0700 Created attachment 57248 Patch. 231343 2 57248 jianli 2010-05-27 10:10:10 -0700 Comment on attachment 57248 Patch. Looks good. Thanks for fixing this. r=me 231479 3 57248 commit-queue 2010-05-27 15:26:27 -0700 Comment on attachment 57248 Patch. Clearing flags on attachment: 57248 Committed r60325: <http://trac.webkit.org/changeset/60325> 231480 4 commit-queue 2010-05-27 15:26:32 -0700 All reviewed patches have been landed. Closing bug. 57248 2010-05-27 08:28:56 -0700 2010-05-27 15:26:26 -0700 Patch. 39841.txt text/plain 1271 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDMwMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMjcgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxk IGJyZWFrIGluIEZpbGVTdHJlYW0uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zOTg0MQorCisgICAgICAgIFdoZW4gRU5BQkxFX0JMT0JfU0xJQ0Ug aXMgbm90IGRlZmluZWQsIGFuIHVuZGVmaW5lZCB2YXJpYWJsZSBpcyB1c2VkCisgICAgICAgIGlu IEZpbGVTdHJlYW0uY3BwOjExNC4gRml4IGJ5IHVzaW5nIHRoZSBjb3JyZWN0IHZhcmlhYmxlLgor CisgICAgICAgIEJ1aWxkIGZpeCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0Zp bGVTdHJlYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmlsZVN0cmVhbTo6b3BlbkZvclJlYWQp OiBSZXBsYWNlIHVuZGVmaW5lZCB2YXJpYWJsZSB3aXRoIGEgZGVmaW5lZCBvbmUuCisKIDIwMTAt MDUtMjcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IFdlYkNvcmUvaHRtbC9GaWxlU3RyZWFt LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvRmlsZVN0cmVhbS5jcHAJKHJldmlzaW9u IDYwMzAxKQorKysgV2ViQ29yZS9odG1sL0ZpbGVTdHJlYW0uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMTEsNyArMTExLDcgQEAgdm9pZCBGaWxlU3RyZWFtOjpvcGVuRm9yUmVhZChCbG9iKiBibG9i KQogICAgIGlmIChtX3RvdGFsQnl0ZXNUb1JlYWQgPT0gQmxvYjo6dG9FbmRPZkZpbGUpCiAgICAg ICAgIG1fdG90YWxCeXRlc1RvUmVhZCA9IGJsb2ItPnNpemUoKSAtIGJsb2ItPnN0YXJ0KCk7CiAj ZWxzZQotICAgIG1fdG90YWwgPSBibG9iLT5zaXplKCk7CisgICAgbV90b3RhbEJ5dGVzVG9SZWFk ID0gYmxvYi0+c2l6ZSgpOwogI2VuZGlmCiAKICAgICBtX2NsaWVudC0+ZGlkR2V0U2l6ZShtX3Rv dGFsQnl0ZXNUb1JlYWQpOwo=