39838 2010-05-27 07:44:45 -0700 [v8] Web Inspector: notify ScriptDebugListener when execution is resumed 2010-05-27 10:14:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 231297 0 yurys 2010-05-27 07:44:45 -0700 ScriptDebugListener::didContinue should be invoked when script execution is resumed. 231302 1 57244 yurys 2010-05-27 08:02:13 -0700 Created attachment 57244 Patch 231306 2 57244 pfeldman 2010-05-27 08:07:31 -0700 Comment on attachment 57244 Patch WebCore/bindings/v8/ScriptDebugServer.cpp:307 + Consider removing this blank line :) 231309 3 57244 yurys 2010-05-27 08:16:35 -0700 Comment on attachment 57244 Patch Clearing flags on attachment: 57244 Committed r60302: <http://trac.webkit.org/changeset/60302> 231310 4 yurys 2010-05-27 08:16:45 -0700 All reviewed patches have been landed. Closing bug. 231337 5 yurys 2010-05-27 09:56:16 -0700 We should check that the listener was not removed while messages were dispatched in the nested loop. 231338 6 57253 yurys 2010-05-27 09:59:19 -0700 Created attachment 57253 Patch 231345 7 joepeck 2010-05-27 10:12:01 -0700 That compiles? I've never been a fan of shadowing variables by reusing a variable name in an inner block. I realize this is v8 only, but you might want to consider changing the new variable name from "listener" to something else. 231346 8 yurys 2010-05-27 10:14:16 -0700 Committed r60309(In reply to comment #7) > That compiles? I've never been a fan of shadowing variables by reusing a variable name in an inner block. I realize this is v8 only, but you might want to consider changing the new variable name from "listener" to something else. I've already committed the patch as r60309. Will address your comment in one of the next patches. 57244 2010-05-27 08:02:13 -0700 2010-05-27 09:59:11 -0700 Patch bug-39838-20100527190210.patch text/plain 1257 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDE1OGZhNTYzOGM1NWM0NmYwMjA5NTFjYTQ1MDUxM2QyOGJlZjAwMC4uZmFlOWEwNDY1Mjc4NzIy OGExNGViNTRhZjdmMmVmYWU2ODliM2EyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0yNyAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIFdlYiBJbnNwZWN0b3I6IG5vdGlmeSBT Y3JpcHREZWJ1Z0xpc3RlbmVyIHdoZW4gZXhlY3V0aW9uIGlzIHJlc3VtZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5ODM4CisKKyAgICAgICAgKiBi aW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3Jp cHREZWJ1Z1NlcnZlcjo6aGFuZGxlVjhEZWJ1Z0V2ZW50KToKKwogMjAxMC0wNS0yNyAgQW5kZXJz IEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZp ZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2 ZXIuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKaW5kZXgg ZTQ0NGNhNmNlYjUwZmI0YTI0MGFlNmJmZGE5NzY2ZDBmNGEzNjJiNy4uNzQ1YTM1OTViY2IxYWE1 M2Q0ZmUzODAxYjY0M2MzNmVjODJhZTBjOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92 OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRE ZWJ1Z1NlcnZlci5jcHAKQEAgLTMwNCw2ICszMDQsOCBAQCB2b2lkIFNjcmlwdERlYnVnU2VydmVy OjpoYW5kbGVWOERlYnVnRXZlbnQoY29uc3Qgdjg6OkRlYnVnOjpFdmVudERldGFpbHMmIGV2ZW50 RAogICAgICAgICAgICAgICAgIC8vIFdhaXQgZm9yIGNvbnRpbnVlIG9yIHN0ZXAgY29tbWFuZC4K ICAgICAgICAgICAgICAgICBtX2NsaWVudE1lc3NhZ2VMb29wLT5ydW4obV9wYXVzZWRQYWdlKTsK ICAgICAgICAgICAgICAgICBBU1NFUlQoIW1fcGF1c2VkUGFnZSk7CisKKyAgICAgICAgICAgICAg ICBsaXN0ZW5lci0+ZGlkQ29udGludWUoKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAg IH0K 57253 2010-05-27 09:59:19 -0700 2010-05-27 10:06:59 -0700 Patch bug-39838-20100527205916.patch text/plain 1559 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzQyMmQyYTRkMzAwZmM3Y2FhMDQyNjhmMTZmYmQ2NTA0YTQyMzk3ZS4uMmIxMzA4NDFlMjRkYjU3 ZjI2NWY3MDY2NmUzNGQ5YjM2OTc4ZjU2YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMC0wNS0yNyAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIFdlYiBJbnNwZWN0b3I6IGNoZWNrIHRo YXQgU2NyaXB0RGVidWdMaXN0ZW5lciB3YXMgbm90IHJlbW92ZWQKKyAgICAgICAgd2hpbGUgbWVz c2FnZXMgd2VyZSBkaXNwYXRjaGVkIGluIHRoZSBuZXN0ZWQgbG9vcC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5ODM4CisKKyAgICAgICAgKiBiaW5k aW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRE ZWJ1Z1NlcnZlcjo6aGFuZGxlVjhEZWJ1Z0V2ZW50KToKKworMjAxMC0wNS0yNyAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBQYXZl bCBGZWxkbWFuLgogCiAgICAgICAgIFt2OF0gV2ViIEluc3BlY3RvcjogdW5kZWZpbmVkIHNjcmlw dCBVUkwgdmFsdWUgc2hvdWxkIGJlIGNvbnZlcnRlZCB0byBhbiBlbXRweQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAgYi9XZWJDb3JlL2JpbmRp bmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmNwcAppbmRleCAwNGZlZWMwYWQwZjRlMDM0MDU3NWY1 YjJlYzBiMWQ1MTM2MjZhN2QxLi5jNTEyOTVhZWQzZDcxZjJiMzkyODEzNjcxOTMxMDYyYzU1NGU1 ODE4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmNw cAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmNwcApAQCAtMzA1 LDcgKzMwNSw5IEBAIHZvaWQgU2NyaXB0RGVidWdTZXJ2ZXI6OmhhbmRsZVY4RGVidWdFdmVudChj b25zdCB2ODo6RGVidWc6OkV2ZW50RGV0YWlscyYgZXZlbnRECiAgICAgICAgICAgICAgICAgbV9j bGllbnRNZXNzYWdlTG9vcC0+cnVuKG1fcGF1c2VkUGFnZSk7CiAgICAgICAgICAgICAgICAgQVNT RVJUKCFtX3BhdXNlZFBhZ2UpOwogCi0gICAgICAgICAgICAgICAgbGlzdGVuZXItPmRpZENvbnRp bnVlKCk7CisgICAgICAgICAgICAgICAgLy8gVGhlIGxpc3RlbmVyIG1heSBoYXZlIGJlZW4gcmVt b3ZlZCBpbiB0aGUgbmVzdGVkIGxvb3AuCisgICAgICAgICAgICAgICAgaWYgKFNjcmlwdERlYnVn TGlzdGVuZXIqIGxpc3RlbmVyID0gbV9saXN0ZW5lcnNNYXAuZ2V0KGZyYW1lLT5wYWdlKCkpCisg ICAgICAgICAgICAgICAgICAgIGxpc3RlbmVyLT5kaWRDb250aW51ZSgpOwogICAgICAgICAgICAg fQogICAgICAgICB9CiAgICAgfQo=