39835 2010-05-27 07:06:07 -0700 [Chromium] Default popup window size should not depend on zoom level 2010-05-27 14:57:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 hans webkit-unassigned andreip commit-queue jorlow oldest_to_newest 231282 0 57238 hans 2010-05-27 07:06:07 -0700 Created attachment 57238 Test page When doing a call to window.open() without passing arguments for the window size, the size gets influenced by the zoom level of the current window. For example, see the attached test page: First, try clicking the "my popup" link without zooming. Then, close the popup, zoom in a couple of steps, and click the link again. Notice how the popup is much smaller this time. (See also http://crbug.com/45167). 231288 1 57241 hans 2010-05-27 07:26:29 -0700 Created attachment 57241 Patch 231293 2 jorlow 2010-05-27 07:37:06 -0700 r=me 231475 3 57241 commit-queue 2010-05-27 14:57:25 -0700 Comment on attachment 57241 Patch Clearing flags on attachment: 57241 Committed r60324: <http://trac.webkit.org/changeset/60324> 231476 4 commit-queue 2010-05-27 14:57:31 -0700 All reviewed patches have been landed. Closing bug. 57238 2010-05-27 07:06:07 -0700 2010-05-27 07:06:07 -0700 Test page popup.html text/html 359 hans PGh0bWwgeG1sOmxhbmc9ImVuIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCIg bGFuZz0iZW4iPgo8aGVhZD4KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgpmdW5jdGlv biBwb3B1cChteWxpbmssIHdpbmRvd25hbWUpCnsKICBpZiAoIXdpbmRvdy5mb2N1cykKICAgIHJl dHVybiB0cnVlOwoKICB3aW5kb3cub3BlbihteWxpbmssIHdpbmRvd25hbWUsICdzY3JvbGxiYXJz PXllcycpOwogIHJldHVybiBmYWxzZTsKfQo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KPGEgaHJl Zj0iamF2YXNjcmlwdDpwb3B1cCgnYWJvdXQ6YmxhbmsnLCAnbm90ZXMnKSI+bXkgcG9wdXA8L2E+ CjwvYm9keT4KPC9odG1sPgo= 57241 2010-05-27 07:26:29 -0700 2010-05-27 14:57:25 -0700 Patch bug-39835-20100527152627.patch text/plain 2501 hans ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWM2ODRlNzY4NTQ5Y2Y4MjBlNzk2MzIxY2QwMGI5ZmMzZGNlYWRmNC4uNjVkNmQ4ZTZiZDE4OTdh NDFiYjQ0YWRmZTBmNWZjY2JlNzAyZDIwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wNS0yNyAgSGFu cyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gRGVmYXVsdCBwb3B1cCB3aW5kb3cg c2l6ZSBzaG91bGQgbm90IGRlcGVuZCBvbiB6b29tIGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTgzNQorCisgICAgICAgIFY4RE9NV2luZG93 OjpvcGVuQ2FsbGJhY2sgc2hvdWxkIG5vdCBzZXQgd2lkdGggYW5kIGhlaWdodCBvZiBuZXcKKyAg ICAgICAgd2luZG93IHVubGVzcyBzcGVjaWZpZWQgaW4gdGhlIGZ1bmN0aW9uJ3MgYXJndW1lbnRz LgorCisgICAgICAgIFRoZXJlIGlzIGFscmVhZHkgY29kZSB0byByZXNldCB0aGUgbmV3IHdpbmRv dydzIG9yaWdpbiBjb29yZGluYXRlcywKKyAgICAgICAgYnV0IHRoZSBzYW1lIHRoaW5nIHNob3Vs ZCBiZSBkb25lIHRvIGl0cyBkaW1lbnNpb25zIGFzIHdlbGwuIE90aGVyd2lzZSwKKyAgICAgICAg YSBuZXcgcG9wdXAgd2l0aCB1bnNwZWNpZmllZCBzaXplIHdpbGwgaGF2ZSBpdHMgc2l6ZSBkZXBl bmRpbmcgb24gdGhlCisgICAgICAgIHBhcmVudCdzIHpvb20gbGV2ZWwsIHdoaWNoIGlzIG5vdCBk ZXNpcmFibGUuCisKKyAgICAgICAgVGhpcyBpcyB0aGUgc2FtZSBhcyB3aGF0IGlzIGRvbmUgaW4K KyAgICAgICAgYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwOjgyNi4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpWOERPTVdpbmRvdzo6b3BlbkNhbGxiYWNrKToKKwogMjAxMC0wNS0yNiAgWGFuIExv cGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsrIGJ1aWxk IGZpeC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93 Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9t LmNwcAppbmRleCBkZTRmY2JmNTdlODRkMWYyNzBjZmMzMTdkYWRjOGQ4OWI5NjllNzc2Li44OGM2 YmYxZDcyYzFjNTIyMjhmMmZkYzhlN2ZmZGM0NDhlMWI3MDA0IDEwMDY0NAotLS0gYS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCkBAIC02ODYsNyArNjg2LDcg QEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4RE9NV2luZG93OjpvcGVuQ2FsbGJhY2soY29uc3Qg djg6OkFyZ3VtZW50cyYgYXJncykKICAgICB3aW5kb3dGZWF0dXJlcy5oZWlnaHQgPSB3aW5kb3dS ZWN0LmhlaWdodCgpOwogICAgIHdpbmRvd0ZlYXR1cmVzLndpZHRoID0gd2luZG93UmVjdC53aWR0 aCgpOwogCi0gICAgLy8gSWYgZWl0aGVyIG9mIHRoZSBvcmlnaW4gY29vcmRpbmF0ZXMgd2VyZW4n dCBzZXQgaW4gdGhlIG9yaWdpbmFsCisgICAgLy8gSWYgZWl0aGVyIG9mIHRoZSBvcmlnaW4gY29v cmRpbmF0ZXMgb3IgZGltZW5zaW9ucyB3ZXJlbid0IHNldCBpbiB0aGUgb3JpZ2luYWwKICAgICAv LyBzdHJpbmcsIG1ha2Ugc3VyZSB0aGV5IGFyZW4ndCBzZXQgbm93LgogICAgIGlmICghcmF3RmVh dHVyZXMueFNldCkgewogICAgICAgICB3aW5kb3dGZWF0dXJlcy54ID0gMDsKQEAgLTY5Niw2ICs2 OTYsMTQgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4RE9NV2luZG93OjpvcGVuQ2FsbGJhY2so Y29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKICAgICAgICAgd2luZG93RmVhdHVyZXMueSA9IDA7 CiAgICAgICAgIHdpbmRvd0ZlYXR1cmVzLnlTZXQgPSBmYWxzZTsKICAgICB9CisgICAgaWYgKCFy YXdGZWF0dXJlcy53aWR0aFNldCkgeworICAgICAgd2luZG93RmVhdHVyZXMud2lkdGggPSAwOwor ICAgICAgd2luZG93RmVhdHVyZXMud2lkdGhTZXQgPSBmYWxzZTsKKyAgICB9CisgICAgaWYgKCFy YXdGZWF0dXJlcy5oZWlnaHRTZXQpIHsKKyAgICAgIHdpbmRvd0ZlYXR1cmVzLmhlaWdodCA9IDA7 CisgICAgICB3aW5kb3dGZWF0dXJlcy5oZWlnaHRTZXQgPSBmYWxzZTsKKyAgICB9CiAKICAgICBm cmFtZSA9IFY4QmluZGluZ0RPTVdpbmRvdzo6Y3JlYXRlV2luZG93KFY4QmluZGluZ1N0YXRlOjpP bmx5KCksIGNhbGxpbmdGcmFtZSwgZW50ZXJlZEZyYW1lLCBmcmFtZSwgdXJsU3RyaW5nLCBmcmFt ZU5hbWUsIHdpbmRvd0ZlYXR1cmVzLCB2ODo6TG9jYWw8djg6OlZhbHVlPigpKTsKIAo=