39832 2010-05-27 05:57:16 -0700 Web Inspector: [CRASH] Get CSS rule offsets lazily. 2010-05-30 23:46:28 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein eemeli.kantola joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 231252 0 pfeldman 2010-05-27 05:57:16 -0700 There is no need to re-parse CSS and get rule offsets unless we start editing. Also: when getting the offsets, create dummy stylesheet with proper owner node - otherwise urls are not resolved and parsing crashes. 231256 1 57230 pfeldman 2010-05-27 06:04:13 -0700 Created attachment 57230 [PATCH] Proposed fix. 231257 2 57230 yurys 2010-05-27 06:07:52 -0700 Comment on attachment 57230 [PATCH] Proposed fix. WebCore/inspector/InspectorCSSStore.cpp:@ + SourceRange InspectorCSSStore::getStartEndOffsets(CSSStyleRule* rule) Consider removing unused method. 231261 3 pfeldman 2010-05-27 06:12:57 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... D LayoutTests/inspector/styles-source-offsets-expected.txt D LayoutTests/inspector/styles-source-offsets.html M WebCore/ChangeLog M WebCore/inspector/InspectorCSSStore.cpp M WebCore/inspector/InspectorDOMAgent.cpp Committed r60297 232275 4 pfeldman 2010-05-30 23:46:28 -0700 *** Bug 39870 has been marked as a duplicate of this bug. *** 57230 2010-05-27 06:04:13 -0700 2010-05-27 06:07:52 -0700 [PATCH] Proposed fix. styles_crash text/plain 4545 pfeldman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMtc291cmNlLW9mZnNldHMt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy1zb3VyY2Utb2Zmc2V0 cy1leHBlY3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGY1MDM1ZGQuLjAw MDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy1zb3VyY2Utb2Zmc2V0cy1l eHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSw2ICswLDAgQEAKLVRlc3RzIHRoYXQgcHJv cGVyIHN0YXJ0L2VuZCBvZmZzZXQgcG9zaXRpb25zIGFyZSByZXBvcnRlZCBmb3IgQ1NTIHJ1bGUg Ym9kaWVzLgotCi1ib2R5OiBbNS0yOF0KLWJvZHkubWFpbjE6IFs5OC0xMjRdCi1ib2R5Lm1haW4y OiBbMTUwLTE2OV0KLQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy1z b3VyY2Utb2Zmc2V0cy5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy1zb3VyY2Ut b2Zmc2V0cy5odG1sCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA2NDhiOGM1Li4wMDAw MDAwCi0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMtc291cmNlLW9mZnNldHMuaHRt bAorKysgL2Rldi9udWxsCkBAIC0xLDU1ICswLDAgQEAKLTxodG1sPgotPGhlYWQ+Ci0KLTxsaW5r IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0icmVzb3VyY2VzL3N0eWxlcy1zb3VyY2Utb2Zmc2V0cy5j c3MiIC0tPgotCi08c2NyaXB0IHNyYz0iLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdG9y LXRlc3QuanMiPjwvc2NyaXB0PgotPHNjcmlwdCBzcmM9ImVsZW1lbnRzLXRlc3RzLmpzIj48L3Nj cmlwdD4KLTxzY3JpcHQ+Ci0KLWZ1bmN0aW9uIGRvaXQoKQotewotICAgIGZ1bmN0aW9uIGNhbGxi YWNrKHN0eWxlcykKLSAgICB7Ci0gICAgICAgIGlmIChzdHlsZXMgPT09ICJyZWZyZXNoaW5nIikK LSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgdmFyIG1hdGNoZWRDU1NSdWxlcyA9IHN0eWxl cy5tYXRjaGVkQ1NTUnVsZXM7Ci0gICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbWF0Y2hlZENT U1J1bGVzLmxlbmd0aDsgKytpKQotICAgICAgICAgICAgb3V0cHV0KG1hdGNoZWRDU1NSdWxlc1tp XS5zZWxlY3RvclRleHQgKyAiOiBbIiArIG1hdGNoZWRDU1NSdWxlc1tpXS5ib2R5U3RhcnRPZmZz ZXQgKyAiLSIgKyBtYXRjaGVkQ1NTUnVsZXNbaV0uYm9keUVuZE9mZnNldCArICJdIik7Ci0KLSAg ICAgICAgbm90aWZ5RG9uZSgpOwotICAgIH0KLSAgICBldmFsdWF0ZUluV2ViSW5zcGVjdG9yKCJm cm9udGVuZF9kdW1wQm9keU9mZnNldHMiLCBjYWxsYmFjayk7Ci19Ci0KLQotLy8gRnJvbnRlbmQg ZnVuY3Rpb25zLgotCi1mdW5jdGlvbiBmcm9udGVuZF9kdW1wQm9keU9mZnNldHModGVzdENvbnRy b2xsZXIpCi17Ci0gICAgaWYgKCFXZWJJbnNwZWN0b3IucGFuZWxzLnJlc291cmNlcy5yZXNvdXJj ZVRyYWNraW5nRW5hYmxlZCkgewotICAgICAgICBJbnNwZWN0b3JCYWNrZW5kLmVuYWJsZVJlc291 cmNlVHJhY2tpbmcoZmFsc2UpOwotICAgICAgICByZXR1cm4gInJlZnJlc2hpbmciOwotICAgIH0K LQotICAgIHRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKLSAgICBmcm9udGVuZF9leHBh bmRET01TdWJ0cmVlKFdlYkluc3BlY3Rvci5kb21BZ2VudC5kb2N1bWVudCk7Ci0gICAgdGVzdENv bnRyb2xsZXIucnVuQWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlcyhmdW5jdGlvbigpIHsKLSAgICAgICAg ZnVuY3Rpb24gY2FsbGJhY2soc3R5bGVzKQotICAgICAgICB7Ci0gICAgICAgICAgICB0ZXN0Q29u dHJvbGxlci5ub3RpZnlEb25lKHN0eWxlcyk7Ci0gICAgICAgIH0KLSAgICAgICAgSW5zcGVjdG9y QmFja2VuZC5nZXRTdHlsZXMoV2ViSW5zcGVjdG9yLkNhbGxiYWNrLndyYXAoY2FsbGJhY2spLCBX ZWJJbnNwZWN0b3IuZG9tQWdlbnQuZG9jdW1lbnQuYm9keS5pZCwgdHJ1ZSk7Ci0gICAgfSk7Ci19 Ci0KLTwvc2NyaXB0PgotPC9oZWFkPgotCi08Ym9keSBjbGFzcz0ibWFpbjEgbWFpbjIiIG9ubG9h ZD0ib25sb2FkKCkiPgotPHA+Ci1UZXN0cyB0aGF0IHByb3BlciBzdGFydC9lbmQgb2Zmc2V0IHBv c2l0aW9ucyBhcmUgcmVwb3J0ZWQgZm9yIENTUyBydWxlIGJvZGllcy4KLTwvcD4KLQotPC9ib2R5 PgotPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCA5MzVkNmM5Li4zNjY3NzA4IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTI3ICBQ YXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEdldCBDU1MgcnVs ZSBvZmZzZXRzIGxhemlseS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDU1NTdG9y ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDU1NTdG9yZTo6Z2V0U3RhcnRFbmRP ZmZzZXRzKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9yUnVsZSk6CisK IDIwMTAtMDUtMjcgIEpvb25lIEh1ciAgPGpvb25lQGtsZHAub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNTU1N0b3JlLmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNTU1N0b3JlLmNwcApv bGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IGZjMGJiZjYuLmRkZTRlNWMKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ1NTU3RvcmUuY3BwCisrKyBiL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvckNTU1N0b3JlLmNwcApAQCAtMTIzLDcgKzEyMyw3IEBAIFNvdXJj ZVJhbmdlIEluc3BlY3RvckNTU1N0b3JlOjpnZXRTdGFydEVuZE9mZnNldHMoQ1NTU3R5bGVSdWxl KiBydWxlKQogICAgICAgICBJbnNwZWN0b3JSZXNvdXJjZSogcmVzb3VyY2UgPSBtX2luc3BlY3Rv ckNvbnRyb2xsZXItPnJlc291cmNlRm9yVVJMKHBhcmVudFN0eWxlU2hlZXQtPmZpbmFsVVJMKCku c3RyaW5nKCkpOwogICAgICAgICBpZiAocmVzb3VyY2UpIHsKICAgICAgICAgICAgIG9mZnNldFZl Y3RvciA9IG5ldyBWZWN0b3I8U291cmNlUmFuZ2U+OwotICAgICAgICAgICAgUmVmUHRyPENTU1N0 eWxlU2hlZXQ+IG5ld1N0eWxlU2hlZXQgPSBDU1NTdHlsZVNoZWV0OjpjcmVhdGUoKTsKKyAgICAg ICAgICAgIFJlZlB0cjxDU1NTdHlsZVNoZWV0PiBuZXdTdHlsZVNoZWV0ID0gQ1NTU3R5bGVTaGVl dDo6Y3JlYXRlKHBhcmVudFN0eWxlU2hlZXQtPm93bmVyTm9kZSgpKTsKICAgICAgICAgICAgIENT U1BhcnNlciBwOwogICAgICAgICAgICAgcC5wYXJzZVNoZWV0KG5ld1N0eWxlU2hlZXQuZ2V0KCks IHJlc291cmNlLT5zb3VyY2VTdHJpbmcoKSwgb2Zmc2V0VmVjdG9yKTsKICAgICAgICAgICAgIG1f c3R5bGVTaGVldFRvT2Zmc2V0cy5zZXQocGFyZW50U3R5bGVTaGVldCwgb2Zmc2V0VmVjdG9yKTsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcCBiL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApvbGQgbW9kZSAxMDA2NDQKbmV3 IG1vZGUgMTAwNzU1CmluZGV4IGExNjhjNjIuLjUxYWFkYjMKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckRPTUFnZW50LmNwcApAQCAtMTE5MCwxMSArMTE5MCw2IEBAIFNjcmlwdE9iamVjdCBJbnNwZWN0 b3JET01BZ2VudDo6YnVpbGRPYmplY3RGb3JSdWxlKERvY3VtZW50KiBvd25lckRvY3VtZW50LCBD U1NTCiAgICAgcmVzdWx0LnNldCgic2VsZWN0b3JUZXh0IiwgcnVsZS0+c2VsZWN0b3JUZXh0KCkp OwogICAgIHJlc3VsdC5zZXQoImNzc1RleHQiLCBydWxlLT5jc3NUZXh0KCkpOwogICAgIHJlc3Vs dC5zZXQoInNvdXJjZUxpbmUiLCBydWxlLT5zb3VyY2VMaW5lKCkpOwotICAgIHN0ZDo6cGFpcjx1 bnNpZ25lZCwgdW5zaWduZWQ+IHN0YXJ0RW5kID0gY3NzU3RvcmUoKS0+Z2V0U3RhcnRFbmRPZmZz ZXRzKHJ1bGUpOwotICAgIGlmIChzdGFydEVuZC5zZWNvbmQpIHsKLSAgICAgICAgcmVzdWx0LnNl dCgiYm9keVN0YXJ0T2Zmc2V0Iiwgc3RhcnRFbmQuZmlyc3QpOwotICAgICAgICByZXN1bHQuc2V0 KCJib2R5RW5kT2Zmc2V0Iiwgc3RhcnRFbmQuc2Vjb25kKTsKLSAgICB9CiAgICAgaWYgKHBhcmVu dFN0eWxlU2hlZXQpIHsKICAgICAgICAgU2NyaXB0T2JqZWN0IHBhcmVudFN0eWxlU2hlZXRWYWx1 ZSA9IG1fZnJvbnRlbmQtPm5ld1NjcmlwdE9iamVjdCgpOwogICAgICAgICByZXN1bHQuc2V0KCJw YXJlbnRTdHlsZVNoZWV0IiwgcGFyZW50U3R5bGVTaGVldFZhbHVlKTsK