39819 2010-05-27 01:08:46 -0700 [Qt] REGRESSION(r60258): It broke 10 tests. 2010-05-27 12:08:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P1 Critical --- 39700 1 ossy webkit-unassigned andersca darin oldest_to_newest 231165 0 ossy 2010-05-27 01:08:46 -0700 http://build.webkit.org/results/Qt%20Linux%20Release/r60258%20(12428)/results.html 231178 1 ossy 2010-05-27 01:31:22 -0700 I'm on a conference and I can't investigate this regression now, and I think the author and the reviewer is sleeping now, so I put the tests into the skipped list temporarily, because we don't want to block commit queue. http://trac.webkit.org/changeset/60281 231363 2 57259 andersca 2010-05-27 10:54:59 -0700 Created attachment 57259 Patch 231365 3 andersca 2010-05-27 10:55:46 -0700 Ignore the unrelated WebKit2 patch. 231407 4 ossy 2010-05-27 11:51:59 -0700 (In reply to comment #2) > Created an attachment (id=57259) [details] > Patch LGTM. I tested this patch (ignoring unrelated WebKit2 changes) and it works without any regression. It is a good fix, as GTK fix landed before: http://trac.webkit.org/changeset/60260 I'd like to give you an r+, but I'm not a reviewer to do it. 231411 5 57259 aroben 2010-05-27 11:59:35 -0700 Comment on attachment 57259 Patch r=me if you remove the WebKit2 stuff 231415 6 andersca 2010-05-27 12:08:01 -0700 Committed r60316: <http://trac.webkit.org/changeset/60316> 57259 2010-05-27 10:54:59 -0700 2010-05-27 11:59:34 -0700 Patch bug-39819-20100527105458.patch text/plain 3896 andersca SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDMxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbUXRdIFJFR1JFU1NJT04ocjYwMjU4KTogSXQgYnJva2UgMTAgdGVzdHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTgxOQorCisgICAgICAgICog cGx1Z2lucy9xdC9QbHVnaW5EYXRhUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luRGF0 YTo6aW5pdFBsdWdpbnMpOgorICAgICAgICBBcHBlbmQgdGhlIE1pbWVDbGFzc0luZm8gb2JqZWN0 IGFmdGVyIGl0J3MgYmVlbiBpbml0aWFsaXplZC4KKwogMjAxMC0wNS0yNyAgQ2hyaXMgRmxlaXph Y2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIE5vIHJldmlldywgYnVpbGQgZml4 YWdlLgpJbmRleDogV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpbkRhdGFRdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpbkRhdGFRdC5jcHAJKHJldmlzaW9uIDYwMzA4 KQorKysgV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpbkRhdGFRdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTc3LDcgKzc3LDYgQEAgdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiAgICAgICAg IE1JTUVUb0Rlc2NyaXB0aW9uc01hcDo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbWltZVRvRGVzY3Jp cHRpb25zLmVuZCgpOwogICAgICAgICBmb3IgKE1JTUVUb0Rlc2NyaXB0aW9uc01hcDo6Y29uc3Rf aXRlcmF0b3IgaXQgPSBtaW1lVG9EZXNjcmlwdGlvbnMuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0 KSB7CiAgICAgICAgICAgICBNaW1lQ2xhc3NJbmZvIG1pbWU7Ci0gICAgICAgICAgICBpbmZvLm1p bWVzLmFwcGVuZChtaW1lKTsKIAogICAgICAgICAgICAgbWltZS50eXBlID0gaXQtPmZpcnN0Owog ICAgICAgICAgICAgbWltZS5kZXNjID0gaXQtPnNlY29uZDsKQEAgLTkxLDYgKzkwLDggQEAgdm9p ZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiAKICAgICAgICAgICAgICAgICBtaW1lLnN1ZmZp eGVzICs9IGV4dGVuc2lvbnNbaV07CiAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGluZm8u bWltZXMuYXBwZW5kKG1pbWUpOwogICAgICAgICB9CiAKICAgICAgICAgbV9wbHVnaW5zLmFwcGVu ZChpbmZvKTsKSW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIv Q2hhbmdlTG9nCShyZXZpc2lvbiA2MDMxMSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMjcgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjYwMjU4KTogSXQgYnJva2UgMTAgdGVzdHMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTgxOQorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaDoKKyAgICAgICAgKFdlYktp dDo6V0tSZXRhaW5QdHI6On5XS1JldGFpblB0cik6CisKIDIwMTAtMDUtMjUgIEFkYSBDaGFuICA8 YWRhY2hhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCklu ZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2NwcC9XS1JldGFpblB0ci5oCShyZXZpc2lvbiA2MDMw OCkKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaAkod29ya2luZyBj b3B5KQpAQCAtODcsNyArODcsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBXS1JldGFpbihwdHIp OwogICAgIH0KIAotICAgIH5SZXRhaW5QdHIoKQorICAgIH5XS1JldGFpblB0cigpCiAgICAgewog ICAgICAgICBpZiAoUHRyVHlwZSBwdHIgPSBtX3B0cikKICAgICAgICAgICAgIFdLUmVsZWFzZShw dHIpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjAzMTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNS0yNyAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtRdF0gUkVHUkVTU0lPTihyNjAyNTgpOiBJdCBicm9rZSAxMCB0 ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5 ODE5CisKKyAgICAgICAgUmVtb3ZlIHRlc3RzIGZyb20gdGhlIHNraXBwZWQgbGlzdC4KKworICAg ICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMTAtMDUtMjcgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBI YW1hamkuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlzaW9uIDYwMzA4KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtNTEwMCwx NiArNTEwMCwzIEBAIGZhc3QvaGlzdG9yeS9zZWxmLWlzLXZpc2l0ZWQuaHRtbAogIyBbUXRdIG1l ZGlhL21lZGlhLWNhbi1wbGF5LW9nZy5odG1sIGNyYXNoZXMgaW50ZXJtaXR0ZW50bHkgb24gdGhl IGJvdAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk0ODEKIG1l ZGlhL2F1ZGlvLW9ubHktdmlkZW8taW50cmluc2ljLXNpemUuaHRtbAotCi0jIFtRdF0gUkVHUkVT U0lPTihyNjAyNTgpOiBJdCBicm9rZSAxMCB0ZXN0cy4KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM5ODE5Ci1mYXN0L2V2ZW50cy94c2wtb25sb2FkLnhodG1sCi1m YXN0L3hzbC9kb2N1bWVudC1mdW5jdGlvbi54bWwKLWZhc3QveHNsL3N1YmZyYW1lLWxvY2F0aW9u Lmh0bWwKLWZhc3QveHNsL3hzbHQtZG9jLW5vZW5jLnhtbAotZmFzdC94c2wveHNsdC1lbnRpdHkt ZW5jLnhtbAotZmFzdC94c2wveHNsdC1yZWN1cnNpb24ueG1sCi1wbHVnaW5zL3BsdWdpbi1qYXZh c2NyaXB0LWFjY2Vzcy5odG1sCi1odHRwL3Rlc3RzL21pc2MvbG9jYXRpb24tdGVzdC14c2wtc3R5 bGUtc2hlZXQueG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQteHNsLWV4dGVybmFs LWVudGl0eS1yZWRpcmVjdC54bWwKLWh0dHAvdGVzdHMvc2VjdXJpdHkveHNzLURFTklFRC14c2wt ZXh0ZXJuYWwtZW50aXR5LnhtbAo=