39809 2010-05-26 22:49:04 -0700 The HTML5 parser shouldn't ASSERT on document.write 2010-05-27 00:24:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED WONTFIX P2 Normal --- 39259 1 abarth abarth eric oldest_to_newest 231112 0 abarth 2010-05-26 22:49:04 -0700 The HTML5 parser shouldn't ASSERT on document.write 231113 1 57195 abarth 2010-05-26 22:50:55 -0700 Created attachment 57195 Patch 231114 2 57195 eric 2010-05-26 22:53:15 -0700 Comment on attachment 57195 Patch OK. Seems reasonable. 231120 3 57195 abarth 2010-05-26 23:05:43 -0700 Comment on attachment 57195 Patch This patch might not be needed after Eric's real ultimate power script patch. 231122 4 57195 darin 2010-05-26 23:08:06 -0700 Comment on attachment 57195 Patch > + token = new HTML5Token(); I suggest omitting the parentheses on lines of code like this. I suggest using OwnPtr<HTML5Token> for the local variable too and using swap rather than using a raw pointer and set/release. 231123 5 abarth 2010-05-26 23:16:24 -0700 Thanks. I'm actually hopeful we won't need this patch if my reading of Eric's patch is correct. 57195 2010-05-26 22:50:55 -0700 2010-05-26 23:08:06 -0700 Patch bug-39809-20100526225053.patch text/plain 2280 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDI5ZGRhMjQ3NzIzYjc1ZjMxM2EyYTM0NTYzMWI4MzVjODZmNzczMi4uMzI2MGMyNjFhOGI3Zjdi MTIxODJmMDk4ZGZjNDgwNTczNTBhNDlhOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMyBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFRoZSBIVE1MNSBwYXJzZXIgc2hvdWxk bid0IEFTU0VSVCBvbiBkb2N1bWVudC53cml0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk4MDkKKworICAgICAgICBXZSBuZWVkIHRvIGhhdmUgbW9y ZSB0aGFuIG9uZSB3b3JraW5nIHRva2VuIGZvciBkb2N1bWVudC53cml0ZSBiZWNhdXNlCisgICAg ICAgIHB1bXBMZXhlciBnZXRzIHJlLWVudGVyZWQuICBEb2N1bWVudC53cml0ZSBzdGlsbCBpc24n dCB3b3JraW5nLCBidXQgYXQKKyAgICAgICAgbGVhc3QgdGhpcyBwYXRjaCBzdG9wcyBpdCBmcm9t IGFsd2F5cyB0cmlnZ2VyaW5nIGFuIEFTU0VSVC4KKworICAgICAgICBUZXN0czogQ292ZXJlZCBi eSBMYXlvdXRUZXN0cy4KKworICAgICAgICAqIGh0bWwvSFRNTDVUb2tlbml6ZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTDVUb2tlbml6ZXI6OnB1bXBMZXhlcik6CisgICAgICAgICogaHRt bC9IVE1MNVRva2VuaXplci5oOgorCisyMDEwLTA1LTI2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAg ICAgSW1wbGVtZW50IFNlZ21lbnRlZFN0cmluZzo6bG9va0FoZWFkU2xvd0Nhc2UKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5ODAyCiAKZGlmZiAtLWdp dCBhL1dlYkNvcmUvaHRtbC9IVE1MNVRva2VuaXplci5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTDVU b2tlbml6ZXIuY3BwCmluZGV4IDUwN2Q0Nzc1YWMzNzg5NzJjMTg0NDE0ODNlODA0NjcyNThlMTk5 ZWMuLjNkZTkyYTg2OGYzNzM4YTBlY2RjZDUxZTcwODIzZDg4Njk2YzExMmUgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaHRtbC9IVE1MNVRva2VuaXplci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUw1 VG9rZW5pemVyLmNwcApAQCAtNTEsMTAgKzUxLDE2IEBAIHZvaWQgSFRNTDVUb2tlbml6ZXI6OmJl Z2luKCkKIAogdm9pZCBIVE1MNVRva2VuaXplcjo6cHVtcExleGVyKCkKIHsKLSAgICB3aGlsZSAo bV9sZXhlci0+bmV4dFRva2VuKG1fc291cmNlLCBtX3Rva2VuKSkgewotICAgICAgICBtX3RyZWVC dWlsZGVyLT5jb25zdHJ1Y3RUcmVlRnJvbVRva2VuKG1fdG9rZW4pOwotICAgICAgICBtX3Rva2Vu LmNsZWFyKCk7CisgICAgSFRNTDVUb2tlbiogdG9rZW4gPSBtX3Rva2VuLnJlbGVhc2UoKTsKKyAg ICBpZiAoIXRva2VuKQorICAgICAgICB0b2tlbiA9IG5ldyBIVE1MNVRva2VuKCk7CisKKyAgICB3 aGlsZSAobV9sZXhlci0+bmV4dFRva2VuKG1fc291cmNlLCAqdG9rZW4pKSB7CisgICAgICAgIG1f dHJlZUJ1aWxkZXItPmNvbnN0cnVjdFRyZWVGcm9tVG9rZW4oKnRva2VuKTsKKyAgICAgICAgdG9r ZW4tPmNsZWFyKCk7CiAgICAgfQorCisgICAgbV90b2tlbi5zZXQodG9rZW4pOwogfQogCiB2b2lk IEhUTUw1VG9rZW5pemVyOjp3cml0ZShjb25zdCBTZWdtZW50ZWRTdHJpbmcmIHNvdXJjZSwgYm9v bCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MNVRva2VuaXplci5oIGIvV2ViQ29yZS9o dG1sL0hUTUw1VG9rZW5pemVyLmgKaW5kZXggM2IwNDFiMTUwZGRiZjZjZjc5NTYwZDY5ZDk2ZGM3 NmU0YTc3ZWQ2Ny4uMzI4ZDJlMmIzYWY5ODBjNjI1YmYzMTRlMzI2MzMyYTFhOGVjZmM3ZiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUw1VG9rZW5pemVyLmgKKysrIGIvV2ViQ29yZS9odG1s L0hUTUw1VG9rZW5pemVyLmgKQEAgLTYyLDcgKzYyLDcgQEAgcHJpdmF0ZToKICAgICBTZWdtZW50 ZWRTdHJpbmcgbV9zb3VyY2U7CiAKICAgICAvLyBXZSBob2xkIG1fdG9rZW4gaGVyZSBiZWNhdXNl IGl0IG1pZ2h0IGJlIHBhcnRpYWxseSBjb21wbGV0ZS4KLSAgICBIVE1MNVRva2VuIG1fdG9rZW47 CisgICAgT3duUHRyPEhUTUw1VG9rZW4+IG1fdG9rZW47CiAKICAgICBPd25QdHI8SFRNTDVMZXhl cj4gbV9sZXhlcjsKICAgICBPd25QdHI8SFRNTDVUcmVlQnVpbGRlcj4gbV90cmVlQnVpbGRlcjsK