39792 2010-05-26 15:32:52 -0700 [chromium] Accessibility focus change notifications should be triggered from ChromeClientImpl::focusedNodeChanged 2010-06-04 12:14:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue oldest_to_newest 230966 0 jcivelli 2010-05-26 15:32:52 -0700 The accessibility notifications that a new accessible node was focused in the page are fired from the ChromeClientImpl::focus() method. This method is currently wrongly invoked every time the focus change in the page, it should only be invoked when the containing Widget gets the focus. Therefore the accessibility notifications should be fired from the more appropriate ChromeClientImpl::focusedNodeChanged(). 230970 1 57171 jcivelli 2010-05-26 15:35:25 -0700 Created attachment 57171 First version of the patch 231764 2 57171 fishd 2010-05-28 10:15:51 -0700 Comment on attachment 57171 First version of the patch WebKit/chromium/src/ChromeClientImpl.cpp:195 + WebURL focusUrl; nit: webkit style is focusURL (see the Names section at http://webkit.org/coding/coding-style.html). WebKit/chromium/src/ChromeClientImpl.cpp:201 + hitTest.setURLElement(reinterpret_cast<Element*>(node)); nit: this should use static_cast since an Element "is a" Node. WebKit/chromium/src/ChromeClientImpl.cpp:211 + ASSERT_NOT_REACHED(); nit: indent by 4 spaces otherwise, LGTM. please correct those nits, and then good to commit. 232782 3 57552 jcivelli 2010-06-01 09:31:48 -0700 Created attachment 57552 Applied fishd suggested changes 232845 4 57568 jcivelli 2010-06-01 10:58:06 -0700 Created attachment 57568 Prevent a crasher when NULL passed to ChromeClientImpl::focusedNodeChanged() 233154 5 57171 eric 2010-06-02 02:25:47 -0700 Comment on attachment 57171 First version of the patch Cleared Darin Fisher's review+ from obsolete attachment 57171 so that this bug does not appear in http://webkit.org/pending-commit. 234274 6 57568 dglazkov 2010-06-04 10:36:41 -0700 Comment on attachment 57568 Prevent a crasher when NULL passed to ChromeClientImpl::focusedNodeChanged() this makes sense. 234322 7 57568 commit-queue 2010-06-04 12:13:55 -0700 Comment on attachment 57568 Prevent a crasher when NULL passed to ChromeClientImpl::focusedNodeChanged() Clearing flags on attachment: 57568 Committed r60695: <http://trac.webkit.org/changeset/60695> 234323 8 commit-queue 2010-06-04 12:14:00 -0700 All reviewed patches have been landed. Closing bug. 57171 2010-05-26 15:35:25 -0700 2010-06-02 02:25:47 -0700 First version of the patch focus_notif.patch text/plain 3619 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2MDI1NSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0yNiAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjZXNzaWJpbGl0eSBmb2N1cyBjaGFuZ2Ugbm90 aWZpY2F0aW9ucyBhcmUgbm93IHNlbnQgZnJvbQorICAgICAgICBDaHJvbWVDbGllbnRJbXBsOjpm b2N1c2VkTm9kZUNoYW5nZWQoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM5NzkyCisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OmZvY3VzKToKKyAgICAgICAgKFdl YktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5vZGVDaGFuZ2VkKToKKwogMjAxMC0wNS0y NiAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmll d2VkIGNocm9taXVtIGJ1aWxkIGZpeApJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVD bGllbnRJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDYwMTg5KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9D aHJvbWVDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYzLDMxICsxNjMsNiBAQCB2 b2lkIENocm9tZUNsaWVudEltcGw6OmZvY3VzKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV93 ZWJWaWV3LT5jbGllbnQoKS0+ZGlkRm9jdXMoKTsKLQotICAgIC8vIElmIGFjY2Vzc2liaWxpdHkg aXMgZW5hYmxlZCwgd2Ugc2hvdWxkIG5vdGlmeSBhc3Npc3RpdmUgdGVjaG5vbG9neSB0aGF0Ci0g ICAgLy8gdGhlIGFjdGl2ZSBBY2Nlc3NpYmlsaXR5T2JqZWN0IGNoYW5nZWQuCi0gICAgY29uc3Qg RnJhbWUqIGZyYW1lID0gbV93ZWJWaWV3LT5mb2N1c2VkV2ViQ29yZUZyYW1lKCk7Ci0gICAgaWYg KCFmcmFtZSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgRG9jdW1lbnQqIGRvYyA9IGZyYW1lLT5k b2N1bWVudCgpOwotCi0gICAgaWYgKGRvYyAmJiBkb2MtPmF4T2JqZWN0Q2FjaGUoKS0+YWNjZXNz aWJpbGl0eUVuYWJsZWQoKSkgewotICAgICAgICBOb2RlKiBmb2N1c2VkTm9kZSA9IG1fd2ViVmll dy0+Zm9jdXNlZFdlYkNvcmVOb2RlKCk7Ci0KLSAgICAgICAgaWYgKCFmb2N1c2VkTm9kZSkgewot ICAgICAgICAgICAgLy8gQ291bGQgbm90IHJldHJpZXZlIGZvY3VzZWQgTm9kZS4KLSAgICAgICAg ICAgIHJldHVybjsKLSAgICAgICAgfQotCi0gICAgICAgIC8vIFJldHJpZXZlIHRoZSBmb2N1c2Vk IEFjY2Vzc2liaWxpdHlPYmplY3QuCi0gICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGZvY3Vz ZWRBY2NPYmogPQotICAgICAgICAgICAgZG9jLT5heE9iamVjdENhY2hlKCktPmdldE9yQ3JlYXRl KGZvY3VzZWROb2RlLT5yZW5kZXJlcigpKTsKLQotICAgICAgICAvLyBBbGVydCBhc3Npc3RpdmUg dGVjaG5vbG9neSB0aGF0IGZvY3VzIGNoYW5nZWQuCi0gICAgICAgIGlmIChmb2N1c2VkQWNjT2Jq KQotICAgICAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+Zm9jdXNBY2Nlc3NpYmlsaXR5T2Jq ZWN0KFdlYkFjY2Vzc2liaWxpdHlPYmplY3QoZm9jdXNlZEFjY09iaikpOwotICAgIH0KIH0KIAog dm9pZCBDaHJvbWVDbGllbnRJbXBsOjp1bmZvY3VzKCkKQEAgLTIxNywxNyArMTkyLDM0IEBAIHZv aWQgQ2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5vZGVDaGFuZ2UKIHsKICAgICBtX3dlYlZpZXct PmNsaWVudCgpLT5mb2N1c2VkTm9kZUNoYW5nZWQoV2ViTm9kZShub2RlKSk7CiAKLSAgICBXZWJV UkwgZm9jdXNfdXJsOworICAgIFdlYlVSTCBmb2N1c1VybDsKICAgICBpZiAobm9kZSAmJiBub2Rl LT5pc0xpbmsoKSkgewogICAgICAgICAvLyBUaGlzIEhpdFRlc3RSZXN1bHQgaGFjayBpcyB0aGUg ZWFzaWVzdCB3YXkgdG8gZ2V0IGEgbGluayBVUkwgb3V0IG9mIGEKICAgICAgICAgLy8gV2ViQ29y ZTo6Tm9kZS4KLSAgICAgICAgSGl0VGVzdFJlc3VsdCBoaXRfdGVzdChJbnRQb2ludCgwLCAwKSk7 CisgICAgICAgIEhpdFRlc3RSZXN1bHQgaGl0VGVzdChJbnRQb2ludCgwLCAwKSk7CiAgICAgICAg IC8vIFRoaXMgY2FzdCBtdXN0IGJlIHZhbGlkIGJlY2F1c2Ugb2YgdGhlIGlzTGluaygpIGNoZWNr LgotICAgICAgICBoaXRfdGVzdC5zZXRVUkxFbGVtZW50KHJlaW50ZXJwcmV0X2Nhc3Q8RWxlbWVu dCo+KG5vZGUpKTsKLSAgICAgICAgaWYgKGhpdF90ZXN0LmlzTGl2ZUxpbmsoKSkKLSAgICAgICAg ICAgIGZvY3VzX3VybCA9IGhpdF90ZXN0LmFic29sdXRlTGlua1VSTCgpOworICAgICAgICBoaXRU ZXN0LnNldFVSTEVsZW1lbnQocmVpbnRlcnByZXRfY2FzdDxFbGVtZW50Kj4obm9kZSkpOworICAg ICAgICBpZiAoaGl0VGVzdC5pc0xpdmVMaW5rKCkpCisgICAgICAgICAgICBmb2N1c1VybCA9IGhp dFRlc3QuYWJzb2x1dGVMaW5rVVJMKCk7CisgICAgfQorICAgIG1fd2ViVmlldy0+Y2xpZW50KCkt PnNldEtleWJvYXJkRm9jdXNVUkwoZm9jdXNVcmwpOworICAgIAorICAgIC8vIElmIGFjY2Vzc2li aWxpdHkgaXMgZW5hYmxlZCwgd2Ugc2hvdWxkIG5vdGlmeSBhc3Npc3RpdmUgdGVjaG5vbG9neSB0 aGF0CisgICAgLy8gdGhlIGFjdGl2ZSBBY2Nlc3NpYmlsaXR5T2JqZWN0IGNoYW5nZWQuCisgICAg RG9jdW1lbnQqIGRvY3VtZW50ID0gbm9kZS0+ZG9jdW1lbnQoKTsKKyAgICBpZiAoIWRvY3VtZW50 KSB7CisgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgIHJldHVybjsKKyAgICB9IAor ICAgIGlmIChkb2N1bWVudCAmJiBkb2N1bWVudC0+YXhPYmplY3RDYWNoZSgpLT5hY2Nlc3NpYmls aXR5RW5hYmxlZCgpKSB7CisgICAgICAgIC8vIFJldHJpZXZlIHRoZSBmb2N1c2VkIEFjY2Vzc2li aWxpdHlPYmplY3QuCisgICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGZvY3VzZWRBY2NPYmog PQorICAgICAgICAgICAgZG9jdW1lbnQtPmF4T2JqZWN0Q2FjaGUoKS0+Z2V0T3JDcmVhdGUobm9k ZS0+cmVuZGVyZXIoKSk7CisKKyAgICAgICAgLy8gQWxlcnQgYXNzaXN0aXZlIHRlY2hub2xvZ3kg dGhhdCBmb2N1cyBjaGFuZ2VkLgorICAgICAgICBpZiAoZm9jdXNlZEFjY09iaikKKyAgICAgICAg ICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmZvY3VzQWNjZXNzaWJpbGl0eU9iamVjdChXZWJBY2Nl c3NpYmlsaXR5T2JqZWN0KGZvY3VzZWRBY2NPYmopKTsKICAgICB9Ci0gICAgbV93ZWJWaWV3LT5j bGllbnQoKS0+c2V0S2V5Ym9hcmRGb2N1c1VSTChmb2N1c191cmwpOwogfQogCiBQYWdlKiBDaHJv bWVDbGllbnRJbXBsOjpjcmVhdGVXaW5kb3coCg== 57552 2010-06-01 09:31:48 -0700 2010-06-01 10:58:06 -0700 Applied fishd suggested changes focus_notif.patch text/plain 3618 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2MDMyNSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0yNyAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjZXNzaWJpbGl0eSBmb2N1cyBjaGFuZ2Ugbm90 aWZpY2F0aW9ucyBhcmUgbm93IHNlbnQgZnJvbQorICAgICAgICBDaHJvbWVDbGllbnRJbXBsOjpm b2N1c2VkTm9kZUNoYW5nZWQoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM5NzkyCisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OmZvY3VzKToKKyAgICAgICAgKFdl YktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5vZGVDaGFuZ2VkKToKKwogMjAxMC0wNS0y NyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVD bGllbnRJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDYwMzMwKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9D aHJvbWVDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYzLDMxICsxNjMsNiBAQCB2 b2lkIENocm9tZUNsaWVudEltcGw6OmZvY3VzKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV93 ZWJWaWV3LT5jbGllbnQoKS0+ZGlkRm9jdXMoKTsKLQotICAgIC8vIElmIGFjY2Vzc2liaWxpdHkg aXMgZW5hYmxlZCwgd2Ugc2hvdWxkIG5vdGlmeSBhc3Npc3RpdmUgdGVjaG5vbG9neSB0aGF0Ci0g ICAgLy8gdGhlIGFjdGl2ZSBBY2Nlc3NpYmlsaXR5T2JqZWN0IGNoYW5nZWQuCi0gICAgY29uc3Qg RnJhbWUqIGZyYW1lID0gbV93ZWJWaWV3LT5mb2N1c2VkV2ViQ29yZUZyYW1lKCk7Ci0gICAgaWYg KCFmcmFtZSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgRG9jdW1lbnQqIGRvYyA9IGZyYW1lLT5k b2N1bWVudCgpOwotCi0gICAgaWYgKGRvYyAmJiBkb2MtPmF4T2JqZWN0Q2FjaGUoKS0+YWNjZXNz aWJpbGl0eUVuYWJsZWQoKSkgewotICAgICAgICBOb2RlKiBmb2N1c2VkTm9kZSA9IG1fd2ViVmll dy0+Zm9jdXNlZFdlYkNvcmVOb2RlKCk7Ci0KLSAgICAgICAgaWYgKCFmb2N1c2VkTm9kZSkgewot ICAgICAgICAgICAgLy8gQ291bGQgbm90IHJldHJpZXZlIGZvY3VzZWQgTm9kZS4KLSAgICAgICAg ICAgIHJldHVybjsKLSAgICAgICAgfQotCi0gICAgICAgIC8vIFJldHJpZXZlIHRoZSBmb2N1c2Vk IEFjY2Vzc2liaWxpdHlPYmplY3QuCi0gICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGZvY3Vz ZWRBY2NPYmogPQotICAgICAgICAgICAgZG9jLT5heE9iamVjdENhY2hlKCktPmdldE9yQ3JlYXRl KGZvY3VzZWROb2RlLT5yZW5kZXJlcigpKTsKLQotICAgICAgICAvLyBBbGVydCBhc3Npc3RpdmUg dGVjaG5vbG9neSB0aGF0IGZvY3VzIGNoYW5nZWQuCi0gICAgICAgIGlmIChmb2N1c2VkQWNjT2Jq KQotICAgICAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+Zm9jdXNBY2Nlc3NpYmlsaXR5T2Jq ZWN0KFdlYkFjY2Vzc2liaWxpdHlPYmplY3QoZm9jdXNlZEFjY09iaikpOwotICAgIH0KIH0KIAog dm9pZCBDaHJvbWVDbGllbnRJbXBsOjp1bmZvY3VzKCkKQEAgLTIxNywxNyArMTkyLDM0IEBAIHZv aWQgQ2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5vZGVDaGFuZ2UKIHsKICAgICBtX3dlYlZpZXct PmNsaWVudCgpLT5mb2N1c2VkTm9kZUNoYW5nZWQoV2ViTm9kZShub2RlKSk7CiAKLSAgICBXZWJV UkwgZm9jdXNfdXJsOworICAgIFdlYlVSTCBmb2N1c1VSTDsKICAgICBpZiAobm9kZSAmJiBub2Rl LT5pc0xpbmsoKSkgewogICAgICAgICAvLyBUaGlzIEhpdFRlc3RSZXN1bHQgaGFjayBpcyB0aGUg ZWFzaWVzdCB3YXkgdG8gZ2V0IGEgbGluayBVUkwgb3V0IG9mIGEKICAgICAgICAgLy8gV2ViQ29y ZTo6Tm9kZS4KLSAgICAgICAgSGl0VGVzdFJlc3VsdCBoaXRfdGVzdChJbnRQb2ludCgwLCAwKSk7 CisgICAgICAgIEhpdFRlc3RSZXN1bHQgaGl0VGVzdChJbnRQb2ludCgwLCAwKSk7CiAgICAgICAg IC8vIFRoaXMgY2FzdCBtdXN0IGJlIHZhbGlkIGJlY2F1c2Ugb2YgdGhlIGlzTGluaygpIGNoZWNr LgotICAgICAgICBoaXRfdGVzdC5zZXRVUkxFbGVtZW50KHJlaW50ZXJwcmV0X2Nhc3Q8RWxlbWVu dCo+KG5vZGUpKTsKLSAgICAgICAgaWYgKGhpdF90ZXN0LmlzTGl2ZUxpbmsoKSkKLSAgICAgICAg ICAgIGZvY3VzX3VybCA9IGhpdF90ZXN0LmFic29sdXRlTGlua1VSTCgpOworICAgICAgICBoaXRU ZXN0LnNldFVSTEVsZW1lbnQoc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpKTsKKyAgICAgICAg aWYgKGhpdFRlc3QuaXNMaXZlTGluaygpKQorICAgICAgICAgICAgZm9jdXNVUkwgPSBoaXRUZXN0 LmFic29sdXRlTGlua1VSTCgpOworICAgIH0KKyAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5zZXRL ZXlib2FyZEZvY3VzVVJMKGZvY3VzVVJMKTsKKyAgICAKKyAgICAvLyBJZiBhY2Nlc3NpYmlsaXR5 IGlzIGVuYWJsZWQsIHdlIHNob3VsZCBub3RpZnkgYXNzaXN0aXZlIHRlY2hub2xvZ3kgdGhhdAor ICAgIC8vIHRoZSBhY3RpdmUgQWNjZXNzaWJpbGl0eU9iamVjdCBjaGFuZ2VkLgorICAgIERvY3Vt ZW50KiBkb2N1bWVudCA9IG5vZGUtPmRvY3VtZW50KCk7CisgICAgaWYgKCFkb2N1bWVudCkgewor ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0gCisg ICAgaWYgKGRvY3VtZW50ICYmIGRvY3VtZW50LT5heE9iamVjdENhY2hlKCktPmFjY2Vzc2liaWxp dHlFbmFibGVkKCkpIHsKKyAgICAgICAgLy8gUmV0cmlldmUgdGhlIGZvY3VzZWQgQWNjZXNzaWJp bGl0eU9iamVjdC4KKyAgICAgICAgQWNjZXNzaWJpbGl0eU9iamVjdCogZm9jdXNlZEFjY09iaiA9 CisgICAgICAgICAgICBkb2N1bWVudC0+YXhPYmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZShub2Rl LT5yZW5kZXJlcigpKTsKKworICAgICAgICAvLyBBbGVydCBhc3Npc3RpdmUgdGVjaG5vbG9neSB0 aGF0IGZvY3VzIGNoYW5nZWQuCisgICAgICAgIGlmIChmb2N1c2VkQWNjT2JqKQorICAgICAgICAg ICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+Zm9jdXNBY2Nlc3NpYmlsaXR5T2JqZWN0KFdlYkFjY2Vz c2liaWxpdHlPYmplY3QoZm9jdXNlZEFjY09iaikpOwogICAgIH0KLSAgICBtX3dlYlZpZXctPmNs aWVudCgpLT5zZXRLZXlib2FyZEZvY3VzVVJMKGZvY3VzX3VybCk7CiB9CiAKIFBhZ2UqIENocm9t ZUNsaWVudEltcGw6OmNyZWF0ZVdpbmRvdygK 57568 2010-06-01 10:58:06 -0700 2010-06-04 12:13:55 -0700 Prevent a crasher when NULL passed to ChromeClientImpl::focusedNodeChanged() focus_notif.patch text/plain 3809 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA2MDQ4MCkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wMSAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjZXNzaWJpbGl0eSBmb2N1cyBjaGFuZ2Ugbm90 aWZpY2F0aW9ucyBhcmUgbm93IHNlbnQgZnJvbQorICAgICAgICBDaHJvbWVDbGllbnRJbXBsOjpm b2N1c2VkTm9kZUNoYW5nZWQoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM5NzkyCisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OmZvY3VzKToKKyAgICAgICAgKFdl YktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5vZGVDaGFuZ2VkKToKKwogMjAxMC0wNi0w MSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjYwNDcwLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3Ny Yy9DaHJvbWVDbGllbnRJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9z cmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDYwNDgwKQorKysgV2ViS2l0L2Nocm9t aXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU5LDM1ICsx NTksOCBAQCBmbG9hdCBDaHJvbWVDbGllbnRJbXBsOjpzY2FsZUZhY3RvcigpCiAKIHZvaWQgQ2hy b21lQ2xpZW50SW1wbDo6Zm9jdXMoKQogewotICAgIGlmICghbV93ZWJWaWV3LT5jbGllbnQoKSkK LSAgICAgICAgcmV0dXJuOwotCi0gICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+ZGlkRm9jdXMoKTsK LQotICAgIC8vIElmIGFjY2Vzc2liaWxpdHkgaXMgZW5hYmxlZCwgd2Ugc2hvdWxkIG5vdGlmeSBh c3Npc3RpdmUgdGVjaG5vbG9neSB0aGF0Ci0gICAgLy8gdGhlIGFjdGl2ZSBBY2Nlc3NpYmlsaXR5 T2JqZWN0IGNoYW5nZWQuCi0gICAgY29uc3QgRnJhbWUqIGZyYW1lID0gbV93ZWJWaWV3LT5mb2N1 c2VkV2ViQ29yZUZyYW1lKCk7Ci0gICAgaWYgKCFmcmFtZSkKLSAgICAgICAgcmV0dXJuOwotCi0g ICAgRG9jdW1lbnQqIGRvYyA9IGZyYW1lLT5kb2N1bWVudCgpOwotCi0gICAgaWYgKGRvYyAmJiBk b2MtPmF4T2JqZWN0Q2FjaGUoKS0+YWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkgewotICAgICAgICBO b2RlKiBmb2N1c2VkTm9kZSA9IG1fd2ViVmlldy0+Zm9jdXNlZFdlYkNvcmVOb2RlKCk7Ci0KLSAg ICAgICAgaWYgKCFmb2N1c2VkTm9kZSkgewotICAgICAgICAgICAgLy8gQ291bGQgbm90IHJldHJp ZXZlIGZvY3VzZWQgTm9kZS4KLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQotCi0gICAg ICAgIC8vIFJldHJpZXZlIHRoZSBmb2N1c2VkIEFjY2Vzc2liaWxpdHlPYmplY3QuCi0gICAgICAg IEFjY2Vzc2liaWxpdHlPYmplY3QqIGZvY3VzZWRBY2NPYmogPQotICAgICAgICAgICAgZG9jLT5h eE9iamVjdENhY2hlKCktPmdldE9yQ3JlYXRlKGZvY3VzZWROb2RlLT5yZW5kZXJlcigpKTsKLQot ICAgICAgICAvLyBBbGVydCBhc3Npc3RpdmUgdGVjaG5vbG9neSB0aGF0IGZvY3VzIGNoYW5nZWQu Ci0gICAgICAgIGlmIChmb2N1c2VkQWNjT2JqKQotICAgICAgICAgICAgbV93ZWJWaWV3LT5jbGll bnQoKS0+Zm9jdXNBY2Nlc3NpYmlsaXR5T2JqZWN0KFdlYkFjY2Vzc2liaWxpdHlPYmplY3QoZm9j dXNlZEFjY09iaikpOwotICAgIH0KKyAgICBpZiAobV93ZWJWaWV3LT5jbGllbnQoKSkKKyAgICAg ICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+ZGlkRm9jdXMoKTsKIH0KIAogdm9pZCBDaHJvbWVDbGll bnRJbXBsOjp1bmZvY3VzKCkKQEAgLTIxNywxNyArMTkwLDM3IEBAIHZvaWQgQ2hyb21lQ2xpZW50 SW1wbDo6Zm9jdXNlZE5vZGVDaGFuZ2UKIHsKICAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5mb2N1 c2VkTm9kZUNoYW5nZWQoV2ViTm9kZShub2RlKSk7CiAKLSAgICBXZWJVUkwgZm9jdXNfdXJsOwor ICAgIFdlYlVSTCBmb2N1c1VSTDsKICAgICBpZiAobm9kZSAmJiBub2RlLT5pc0xpbmsoKSkgewog ICAgICAgICAvLyBUaGlzIEhpdFRlc3RSZXN1bHQgaGFjayBpcyB0aGUgZWFzaWVzdCB3YXkgdG8g Z2V0IGEgbGluayBVUkwgb3V0IG9mIGEKICAgICAgICAgLy8gV2ViQ29yZTo6Tm9kZS4KLSAgICAg ICAgSGl0VGVzdFJlc3VsdCBoaXRfdGVzdChJbnRQb2ludCgwLCAwKSk7CisgICAgICAgIEhpdFRl c3RSZXN1bHQgaGl0VGVzdChJbnRQb2ludCgwLCAwKSk7CiAgICAgICAgIC8vIFRoaXMgY2FzdCBt dXN0IGJlIHZhbGlkIGJlY2F1c2Ugb2YgdGhlIGlzTGluaygpIGNoZWNrLgotICAgICAgICBoaXRf dGVzdC5zZXRVUkxFbGVtZW50KHJlaW50ZXJwcmV0X2Nhc3Q8RWxlbWVudCo+KG5vZGUpKTsKLSAg ICAgICAgaWYgKGhpdF90ZXN0LmlzTGl2ZUxpbmsoKSkKLSAgICAgICAgICAgIGZvY3VzX3VybCA9 IGhpdF90ZXN0LmFic29sdXRlTGlua1VSTCgpOworICAgICAgICBoaXRUZXN0LnNldFVSTEVsZW1l bnQoc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpKTsKKyAgICAgICAgaWYgKGhpdFRlc3QuaXNM aXZlTGluaygpKQorICAgICAgICAgICAgZm9jdXNVUkwgPSBoaXRUZXN0LmFic29sdXRlTGlua1VS TCgpOworICAgIH0KKyAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5zZXRLZXlib2FyZEZvY3VzVVJM KGZvY3VzVVJMKTsKKyAgICAKKyAgICBpZiAoIW5vZGUpCisgICAgICAgIHJldHVybjsKKworICAg IC8vIElmIGFjY2Vzc2liaWxpdHkgaXMgZW5hYmxlZCwgd2Ugc2hvdWxkIG5vdGlmeSBhc3Npc3Rp dmUgdGVjaG5vbG9neSB0aGF0CisgICAgLy8gdGhlIGFjdGl2ZSBBY2Nlc3NpYmlsaXR5T2JqZWN0 IGNoYW5nZWQuCisgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gbm9kZS0+ZG9jdW1lbnQoKTsKKyAg ICBpZiAoIWRvY3VtZW50KSB7CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAg ICByZXR1cm47CisgICAgfSAKKyAgICBpZiAoZG9jdW1lbnQgJiYgZG9jdW1lbnQtPmF4T2JqZWN0 Q2FjaGUoKS0+YWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkgeworICAgICAgICAvLyBSZXRyaWV2ZSB0 aGUgZm9jdXNlZCBBY2Nlc3NpYmlsaXR5T2JqZWN0LgorICAgICAgICBBY2Nlc3NpYmlsaXR5T2Jq ZWN0KiBmb2N1c2VkQWNjT2JqID0KKyAgICAgICAgICAgIGRvY3VtZW50LT5heE9iamVjdENhY2hl KCktPmdldE9yQ3JlYXRlKG5vZGUtPnJlbmRlcmVyKCkpOworCisgICAgICAgIC8vIEFsZXJ0IGFz c2lzdGl2ZSB0ZWNobm9sb2d5IHRoYXQgZm9jdXMgY2hhbmdlZC4KKyAgICAgICAgaWYgKGZvY3Vz ZWRBY2NPYmopCisgICAgICAgICAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5mb2N1c0FjY2Vzc2li aWxpdHlPYmplY3QoV2ViQWNjZXNzaWJpbGl0eU9iamVjdChmb2N1c2VkQWNjT2JqKSk7CiAgICAg fQotICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPnNldEtleWJvYXJkRm9jdXNVUkwoZm9jdXNfdXJs KTsKIH0KIAogUGFnZSogQ2hyb21lQ2xpZW50SW1wbDo6Y3JlYXRlV2luZG93KAo=