39784 2010-05-26 14:12:56 -0700 [Qt] REGRESSION(r59837): Incorrect clipping of TransparencyLayers 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All CLOSED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-unassigned commit-queue hausmann kenneth oldest_to_newest 230884 0 kling 2010-05-26 14:12:56 -0700 This change: http://trac.webkit.org/changeset/59837 Introduced a clipping bug that can be seen here: http://andreaskling.com/r59837/ 230889 1 57135 kling 2010-05-26 14:19:17 -0700 Created attachment 57135 Proposed patch This patch fixes the regression and doesn't break http://panic.com/transmit/ (unlike a full revert.) I'm not sure this is 100% correct though, needs some eyeing over. 231661 2 57135 kenneth 2010-05-28 06:19:17 -0700 Comment on attachment 57135 Proposed patch I am not 100% certain either, but the earlier code was working so far and this fixes the part that wasn't working, so it should be fine. r=me. 231716 3 57135 commit-queue 2010-05-28 08:23:34 -0700 Comment on attachment 57135 Proposed patch Clearing flags on attachment: 57135 Committed r60360: <http://trac.webkit.org/changeset/60360> 231717 4 commit-queue 2010-05-28 08:23:41 -0700 All reviewed patches have been landed. Closing bug. 232146 5 hausmann 2010-05-29 14:44:04 -0700 Revision r60360 cherry-picked into qtwebkit-2.0 with commit 4114cde5d6116333343fe87e4cd5e63c1a9c59de 57135 2010-05-26 14:19:17 -0700 2010-05-28 08:23:34 -0700 Proposed patch bug-39784.diff text/plain 1940 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODJhNDBhOS4uMmM0OGEwZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0yNiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUkVHUkVTU0lPTihyNTk4MzcpOiBJbmNvcnJlY3Qg Y2xpcHBpbmcgb2YgVHJhbnNwYXJlbmN5TGF5ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc4NAorCisgICAgICAgIE1vdmUgY29vcmRpbmF0ZSB0 cmFuc2Zvcm1hdGlvbiBmcm9tIFRyYW5zcGFyZW5jeUxheWVyIHRvIGNsaXBUb0ltYWdlQnVmZmVy KCkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlRyYW5zcGFyZW5jeUxheWVyOjpUcmFuc3BhcmVuY3lMYXll cik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmNsaXBUb0ltYWdlQnVmZmVy KToKKwogMjAxMC0wNS0yNiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcAppbmRleCA2OTEyMWM4Li5i ZGI4MTBhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz Q29udGV4dFF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz Q29udGV4dFF0LmNwcApAQCAtMTczLDcgKzE3Myw3IEBAIHN0cnVjdCBUcmFuc3BhcmVuY3lMYXll ciA6IEZhc3RBbGxvY0Jhc2UgewogICAgICAgICAsIGFscGhhTWFzayhhbHBoYU1hc2spCiAgICAg ICAgICwgc2F2ZUNvdW50ZXIoMSkgLy8gc2VlIHRoZSBjb21tZW50IGZvciBzYXZlQ291bnRlcgog ICAgIHsKLSAgICAgICAgb2Zmc2V0ID0gcC0+dHJhbnNmb3JtKCkubWFwUmVjdChyZWN0KS50b3BM ZWZ0KCk7CisgICAgICAgIG9mZnNldCA9IHJlY3QudG9wTGVmdCgpOwogICAgICAgICBwaXhtYXAu ZmlsbChRdDo6dHJhbnNwYXJlbnQpOwogICAgICAgICBwYWludGVyLmJlZ2luKCZwaXhtYXApOwog ICAgICAgICBwYWludGVyLnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OkFudGlhbGlhc2luZywgcC0+ dGVzdFJlbmRlckhpbnQoUVBhaW50ZXI6OkFudGlhbGlhc2luZykpOwpAQCAtMTEyNSw3ICsxMTI1 LDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNsaXBUb0ltYWdlQnVmZmVyKGNvbnN0IEZsb2F0 UmVjdCYgZmxvYXRSZWN0LCBjb25zdCBJbWFnZUIKICAgICBpZiAoYWxwaGFNYXNrLndpZHRoKCkg IT0gcmVjdC53aWR0aCgpIHx8IGFscGhhTWFzay5oZWlnaHQoKSAhPSByZWN0LmhlaWdodCgpKQog ICAgICAgICBhbHBoYU1hc2sgPSBhbHBoYU1hc2suc2NhbGVkKHJlY3Qud2lkdGgoKSwgcmVjdC5o ZWlnaHQoKSk7CiAKLSAgICBtX2RhdGEtPmxheWVycy5wdXNoKG5ldyBUcmFuc3BhcmVuY3lMYXll cihtX2RhdGEtPnAoKSwgcmVjdCwgMS4wLCBhbHBoYU1hc2spKTsKKyAgICBtX2RhdGEtPmxheWVy cy5wdXNoKG5ldyBUcmFuc3BhcmVuY3lMYXllcihtX2RhdGEtPnAoKSwgbV9kYXRhLT5wKCktPnRy YW5zZm9ybSgpLm1hcFJlY3QocmVjdCksIDEuMCwgYWxwaGFNYXNrKSk7CiB9CiAKIHZvaWQgR3Jh cGhpY3NDb250ZXh0OjphZGRJbm5lclJvdW5kZWRSZWN0Q2xpcChjb25zdCBJbnRSZWN0JiByZWN0 LAo=