39782 2010-05-26 13:48:30 -0700 notifications: in display+close layout test, should wait for display to close 2010-06-03 16:19:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 johnnyg johnnyg commit-queue yael oldest_to_newest 230867 0 johnnyg 2010-05-26 13:48:30 -0700 The notification spec says display is async; in this test we shouldn't try to close the notification before the display has fired. 230987 1 57177 johnnyg 2010-05-26 16:04:00 -0700 Created attachment 57177 Patch 231028 2 57177 levin 2010-05-26 18:09:36 -0700 Comment on attachment 57177 Patch > Index: LayoutTests/ChangeLog > + notifications: in display+close layout test, expect async events Your title in the bug is better than this (considering fixing this one to match the bug). 231277 3 yael 2010-05-27 06:52:56 -0700 Please note that there is one more issue with the layout tests. According to the spec at http://dev.w3.org/2006/webapi/WebNotifications/publish (8.2.2) "If the fetch algorithm returns error information, fire the error event on the notification object and stop executing this algorithm." Since the icon urls in the layout tests don't point to valid icons, almost all the tests should fire an error, or am I missing something? 231333 4 johnnyg 2010-05-27 09:27:01 -0700 Yael, yes you are correct, it's just that the current test harness for notifications doesn't implement any loading, so I'm just verifying that the icon URL supplied gets passed to the NotificationPresenter. It would be nice to separate some of the other functionality from the icon loading, so in this case of testing the display and close events, I will change it to have no icon. It probably makes sense to do that for most of the tests, and then we can isolate the loading success and failure in different tests. 231339 5 yael 2010-05-27 10:00:05 -0700 (In reply to comment #4) > I will change it to have no icon. It probably makes sense to do that for most of the tests, and then we can isolate the loading success and failure in different tests. Thanks for making the change. 231396 6 57262 johnnyg 2010-05-27 11:20:11 -0700 Created attachment 57262 Patch 233975 7 57262 commit-queue 2010-06-03 16:19:24 -0700 Comment on attachment 57262 Patch Clearing flags on attachment: 57262 Committed r60643: <http://trac.webkit.org/changeset/60643> 233976 8 commit-queue 2010-06-03 16:19:29 -0700 All reviewed patches have been landed. Closing bug. 57177 2010-05-26 16:04:00 -0700 2010-05-27 11:20:06 -0700 Patch bug-39782-20100526160358.patch text/plain 1846 johnnyg SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwMjU1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUtMjYgIEpvaG4gR3JlZ2cgIDxqb2hu bnlnQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgbm90aWZpY2F0aW9uczogaW4gZGlzcGxheStjbG9zZSBsYXlvdXQgdGVzdCwgZXhw ZWN0IGFzeW5jIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzk3ODIKKworICAgICAgICAqIGZhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRp b25zLWRpc3BsYXktY2xvc2UtZXZlbnRzLmh0bWw6CisKIDIwMTAtMDUtMjYgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLWRpc3Bs YXktY2xvc2UtZXZlbnRzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ub3Rp ZmljYXRpb25zL25vdGlmaWNhdGlvbnMtZGlzcGxheS1jbG9zZS1ldmVudHMuaHRtbAkocmV2aXNp b24gNjAyNDUpCisrKyBMYXlvdXRUZXN0cy9mYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9u cy1kaXNwbGF5LWNsb3NlLWV2ZW50cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMiw2ICsxMiw3 IEBACiAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICAg ICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZ3JhbnREZXNrdG9wTm90aWZpY2F0aW9u UGVybWlzc2lvbigiZmlsZTovLyIpOwogICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53 YWl0VW50aWxEb25lKCk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGlmICghd2luZG93 LndlYmtpdE5vdGlmaWNhdGlvbnMpIHsKQEAgLTE5LDEwICsyMCw5IEBACiAgICAgICAgICAgICB9 CiAgICAgICAgICAgICAKICAgICAgICAgICAgIHZhciBOID0gd2luZG93LndlYmtpdE5vdGlmaWNh dGlvbnMuY3JlYXRlTm90aWZpY2F0aW9uKCJodHRwOi8vbG9jYWxob3N0L215X2ljb24ucG5nIiwg Ik5ldyBFLW1haWwiLCAiTWVldCBtZSB0b25pZ2h0IGF0IDghIik7Ci0gICAgICAgICAgICBOLm9u ZGlzcGxheSA9IGZ1bmN0aW9uKCkgeyBsb2coIlBBU1M6IGRpc3BsYXkgZXZlbnQgaW52b2tlZC4i KTsgfQotICAgICAgICAgICAgTi5vbmNsb3NlID0gZnVuY3Rpb24oKSB7IGxvZygiUEFTUzogY2xv c2UgZXZlbnQgaW52b2tlZC4iKTsgfQorICAgICAgICAgICAgTi5vbmRpc3BsYXkgPSBmdW5jdGlv bigpIHsgbG9nKCJQQVNTOiBkaXNwbGF5IGV2ZW50IGludm9rZWQuIik7IE4uY2FuY2VsKCk7IH0K KyAgICAgICAgICAgIE4ub25jbG9zZSA9IGZ1bmN0aW9uKCkgeyBsb2coIlBBU1M6IGNsb3NlIGV2 ZW50IGludm9rZWQuIik7IGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsgfQogICAg ICAgICAgICAgTi5zaG93KCk7Ci0gICAgICAgICAgICBOLmNhbmNlbCgpOwogICAgICAgICB9CiAg ICAgPC9zY3JpcHQ+CiA8L2hlYWQ+Cg== 57262 2010-05-27 11:20:11 -0700 2010-06-03 16:19:24 -0700 Patch bug-39782-20100527112009.patch text/plain 2800 johnnyg SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwMjU1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEpvaG4gR3JlZ2cgIDxqb2hu bnlnQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgbm90aWZpY2F0aW9uczogaW4gZGlzcGxheStjbG9zZSBsYXlvdXQgdGVzdCwgZG9u J3QgY2xvc2UgdGhlIG5vdGlmaWNhdGlvbgorICAgICAgICB1bnRpbCB0aGUgZGlzcGxheSBldmVu dCBoYXMgYmVlbiByZWNlaXZlZCBhc3luY2hyb25vdXNseTsgYWxzbyBkb24ndCB1c2UKKyAgICAg ICAgYW4gaW52YWxpZCBpY29uIFVSTCwgc2luY2UgdGhhdCBzaG91bGQgZ2VuZXJhdGUgYW4gZXJy b3IgZXZlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zOTc4MgorCisgICAgICAgICogZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMtZGlz cGxheS1jbG9zZS1ldmVudHMuaHRtbDoKKwogMjAxMC0wNS0yNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMtZGlzcGxheS1jbG9z ZS1ldmVudHMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvbm90 aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLWRpc3BsYXktY2xvc2UtZXZlbnRzLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gNjAyNDUpCisrKyBMYXlvdXRUZXN0cy9mYXN0L25vdGlmaWNhdGlvbnMvbm90 aWZpY2F0aW9ucy1kaXNwbGF5LWNsb3NlLWV2ZW50cy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTEsNCArMSw0IEBACi1ERVNLVE9QIE5PVElGSUNBVElPTjogaWNvbiBodHRwOi8vbG9j YWxob3N0L215X2ljb24ucG5nLCB0aXRsZSBOZXcgRS1tYWlsLCB0ZXh0IE1lZXQgbWUgdG9uaWdo dCBhdCA4IQorREVTS1RPUCBOT1RJRklDQVRJT046IGljb24gLCB0aXRsZSBOZXcgRS1tYWlsLCB0 ZXh0IE1lZXQgbWUgdG9uaWdodCBhdCA4IQogREVTS1RPUCBOT1RJRklDQVRJT04gQ0xPU0VEOiBO ZXcgRS1tYWlsCiBTZW5kaW5nIG5vdGlmaWNhdGlvbnMgd2l0aCBwZXJtaXNzaW9uLi4uCiAKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLWRpc3BsYXkt Y2xvc2UtZXZlbnRzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ub3RpZmlj YXRpb25zL25vdGlmaWNhdGlvbnMtZGlzcGxheS1jbG9zZS1ldmVudHMuaHRtbAkocmV2aXNpb24g NjAyNDUpCisrKyBMYXlvdXRUZXN0cy9mYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1k aXNwbGF5LWNsb3NlLWV2ZW50cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMiwxNyArMTIsMTcg QEAKICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICAg ICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ncmFudERlc2t0b3BOb3RpZmljYXRpb25Q ZXJtaXNzaW9uKCJmaWxlOi8vIik7CiAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndh aXRVbnRpbERvbmUoKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKCF3aW5kb3cu d2Via2l0Tm90aWZpY2F0aW9ucykgewogICAgICAgICAgICAgICAgIGxvZygiRkFJTDogTm8gd2Vi a2l0Tm90aWZpY2F0aW9ucyBpbnRlcmZhY2UhIik7CiAgICAgICAgICAgICB9CiAgICAgICAgICAg ICAKLSAgICAgICAgICAgIHZhciBOID0gd2luZG93LndlYmtpdE5vdGlmaWNhdGlvbnMuY3JlYXRl Tm90aWZpY2F0aW9uKCJodHRwOi8vbG9jYWxob3N0L215X2ljb24ucG5nIiwgIk5ldyBFLW1haWwi LCAiTWVldCBtZSB0b25pZ2h0IGF0IDghIik7Ci0gICAgICAgICAgICBOLm9uZGlzcGxheSA9IGZ1 bmN0aW9uKCkgeyBsb2coIlBBU1M6IGRpc3BsYXkgZXZlbnQgaW52b2tlZC4iKTsgfQotICAgICAg ICAgICAgTi5vbmNsb3NlID0gZnVuY3Rpb24oKSB7IGxvZygiUEFTUzogY2xvc2UgZXZlbnQgaW52 b2tlZC4iKTsgfQorICAgICAgICAgICAgdmFyIE4gPSB3aW5kb3cud2Via2l0Tm90aWZpY2F0aW9u cy5jcmVhdGVOb3RpZmljYXRpb24oIiIsICJOZXcgRS1tYWlsIiwgIk1lZXQgbWUgdG9uaWdodCBh dCA4ISIpOworICAgICAgICAgICAgTi5vbmRpc3BsYXkgPSBmdW5jdGlvbigpIHsgbG9nKCJQQVNT OiBkaXNwbGF5IGV2ZW50IGludm9rZWQuIik7IE4uY2FuY2VsKCk7IH0KKyAgICAgICAgICAgIE4u b25jbG9zZSA9IGZ1bmN0aW9uKCkgeyBsb2coIlBBU1M6IGNsb3NlIGV2ZW50IGludm9rZWQuIik7 IGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsgfQogICAgICAgICAgICAgTi5zaG93 KCk7Ci0gICAgICAgICAgICBOLmNhbmNlbCgpOwogICAgICAgICB9CiAgICAgPC9zY3JpcHQ+CiA8 L2hlYWQ+Cg==