39781 2010-05-26 13:39:09 -0700 [Qt] ClipboardQt.cpp has coding-style errors 2010-06-09 12:13:14 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230864 0 agbakken 2010-05-26 13:39:09 -0700 WebCore/platform/qt/ClipboardQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/ClipboardQt.cpp:42: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/ClipboardQt.cpp:52: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/ClipboardQt.cpp:229: Should have a space between // and comment [whitespace/comments] [4] WebCore/platform/qt/ClipboardQt.cpp:236: Declaration has space between type name and * in QPixmap *pixmap [whitespace/declaration] [3] Total errors found: 5 in 1 files 230929 1 57162 agbakken 2010-05-26 14:47:30 -0700 Created attachment 57162 Patch that fixes the coding style issues 231101 2 peojala11 2010-05-26 21:54:20 -0700 QtTriaged 231372 3 57162 levin 2010-05-27 11:10:50 -0700 Comment on attachment 57162 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234495 4 57957 agbakken 2010-06-04 20:26:35 -0700 Created attachment 57957 Patch 234523 5 57957 eric 2010-06-04 22:12:38 -0700 Comment on attachment 57957 Patch What's this for? // WebCore::writeURL(m_writableDataObject.get(), url, title, true, false); generally we don't commit commented-out code, it's possible that line should simply be removed. 235926 6 57957 commit-queue 2010-06-09 12:13:08 -0700 Comment on attachment 57957 Patch Clearing flags on attachment: 57957 Committed r60905: <http://trac.webkit.org/changeset/60905> 235927 7 commit-queue 2010-06-09 12:13:14 -0700 All reviewed patches have been landed. Closing bug. 57162 2010-05-26 14:47:30 -0700 2010-06-04 20:26:30 -0700 Patch that fixes the coding style issues patch.39781 text/plain 2591 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2xpcGJvYXJkUXQuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc4MQorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvQ2xpcGJvYXJkUXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q2xpcGJvYXJkUXQ6OmRlY2xhcmVBbmRXcml0ZURyYWdJbWFnZSk6 CisKIDIwMTAtMDUtMjYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE9qYW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L0NsaXBib2FyZFF0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3F0L0NsaXBib2FyZFF0LmNwcAko cmV2aXNpb24gNjAyNDcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L0NsaXBib2FyZFF0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjIsMTQgKzIyLDE0IEBACiAgKiBQUk9GSVRTOyBPUiBCVVNJTkVT UyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCiAgKiBPRiBM SUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQK ICAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB WSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9G IFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4gCisgKiBPRiBUSElTIFNPRlRXQVJFLCBF VkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJDbGlwYm9hcmRRdC5oIgogCi0jaW5jbHVk ZSAiQ2FjaGVkSW1hZ2UuaCIKICNpbmNsdWRlICJDU1NIZWxwZXIuaCIKKyNpbmNsdWRlICJDYWNo ZWRJbWFnZS5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRWxlbWVudC5oIgog I2luY2x1ZGUgIkZpbGVMaXN0LmgiCkBAIC0zOCwxOSArMzgsMTkgQEAKICNpbmNsdWRlICJJbWFn ZS5oIgogI2luY2x1ZGUgIkludFBvaW50LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgotI2luY2x1ZGUg Im1hcmt1cC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGxhdGZv cm1TdHJpbmcuaCIKICNpbmNsdWRlICJSYW5nZS5oIgogI2luY2x1ZGUgIlJlbmRlckltYWdlLmgi CiAjaW5jbHVkZSAiU3RyaW5nSGFzaC5oIgorI2luY2x1ZGUgIm1hcmt1cC5oIgogCisjaW5jbHVk ZSA8UUFwcGxpY2F0aW9uPgorI2luY2x1ZGUgPFFDbGlwYm9hcmQ+CiAjaW5jbHVkZSA8UUxpc3Q+ CiAjaW5jbHVkZSA8UU1pbWVEYXRhPgogI2luY2x1ZGUgPFFTdHJpbmdMaXN0PgogI2luY2x1ZGUg PFFVcmw+Ci0jaW5jbHVkZSA8UUFwcGxpY2F0aW9uPgotI2luY2x1ZGUgPFFDbGlwYm9hcmQ+CiAj aW5jbHVkZSA8cWRlYnVnLmg+CiAKICNkZWZpbmUgbWV0aG9kRGVidWcoKSBxRGVidWcoIkNsaXBi b2FyZFF0OiAlcyIsIF9fRlVOQ1RJT05fXykKQEAgLTIyNiwxNCArMjI2LDE0IEBAIHZvaWQgQ2xp cGJvYXJkUXQ6OmRlY2xhcmVBbmRXcml0ZURyYWdJbWEKIHsKICAgICBBU1NFUlQoZnJhbWUpOwog Ci0gICAgLy9XZWJDb3JlOjp3cml0ZVVSTChtX3dyaXRhYmxlRGF0YU9iamVjdC5nZXQoKSwgdXJs LCB0aXRsZSwgdHJ1ZSwgZmFsc2UpOworICAgIC8vIFdlYkNvcmU6OndyaXRlVVJMKG1fd3JpdGFi bGVEYXRhT2JqZWN0LmdldCgpLCB1cmwsIHRpdGxlLCB0cnVlLCBmYWxzZSk7CiAgICAgaWYgKCFt X3dyaXRhYmxlRGF0YSkKICAgICAgICAgbV93cml0YWJsZURhdGEgPSBuZXcgUU1pbWVEYXRhOwog CiAgICAgQ2FjaGVkSW1hZ2UqIGNhY2hlZEltYWdlID0gZ2V0Q2FjaGVkSW1hZ2UoZWxlbWVudCk7 CiAgICAgaWYgKCFjYWNoZWRJbWFnZSB8fCAhY2FjaGVkSW1hZ2UtPmltYWdlKCkgfHwgIWNhY2hl ZEltYWdlLT5pc0xvYWRlZCgpKQogICAgICAgICByZXR1cm47Ci0gICAgUVBpeG1hcCAqcGl4bWFw ID0gY2FjaGVkSW1hZ2UtPmltYWdlKCktPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7Cisg ICAgUVBpeG1hcCogcGl4bWFwID0gY2FjaGVkSW1hZ2UtPmltYWdlKCktPm5hdGl2ZUltYWdlRm9y Q3VycmVudEZyYW1lKCk7CiAgICAgaWYgKHBpeG1hcCkKICAgICAgICAgbV93cml0YWJsZURhdGEt PnNldEltYWdlRGF0YSgqcGl4bWFwKTsKIAo= 57957 2010-06-04 20:26:35 -0700 2010-06-09 12:13:08 -0700 Patch bug-39781-20100604202634.patch text/plain 2687 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uN2I5OTkwMGJhZWM5MzAy MDkwOWI5NmZmNDhlNmRlM2JkNzE3NmEzNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENsaXBib2FyZFF0LmNwcCBoYXMgY29kaW5n LXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzk3ODEKKworICAgICAgICAqIHBsYXRmb3JtL3F0L0NsaXBib2FyZFF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZFF0OjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2UpOgor CiAyMDEwLTA2LTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL3F0L0NsaXBib2FyZFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ2xpcGJvYXJkUXQu Y3BwCmluZGV4IGMyM2U0MmVhYWM5MGE2MjAyY2RiZGE2NWJkZTA2MWRkMTY5NjIyMjYuLmM5OGM3 OWE1NTQ2ZjhkOTYzZDQzZmM3YTk0NGI5YTk5MDBkN2IxN2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vcXQvQ2xpcGJvYXJkUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ2xp cGJvYXJkUXQuY3BwCkBAIC0yMiwxNCArMjIsMTQgQEAKICAqIFBST0ZJVFM7IE9SIEJVU0lORVNT IElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKICAqIE9GIExJ QUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAog ICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZ IE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLiAKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVW RU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAog I2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNsaXBib2FyZFF0LmgiCiAKLSNpbmNsdWRl ICJDYWNoZWRJbWFnZS5oIgogI2luY2x1ZGUgIkNTU0hlbHBlci5oIgorI2luY2x1ZGUgIkNhY2hl ZEltYWdlLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJFbGVtZW50LmgiCiAj aW5jbHVkZSAiRmlsZUxpc3QuaCIKQEAgLTM4LDE5ICszOCwxOSBAQAogI2luY2x1ZGUgIkltYWdl LmgiCiAjaW5jbHVkZSAiSW50UG9pbnQuaCIKICNpbmNsdWRlICJLVVJMLmgiCi0jaW5jbHVkZSAi bWFya3VwLmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKICNpbmNsdWRlICJQbGF0Zm9y bVN0cmluZy5oIgogI2luY2x1ZGUgIlJhbmdlLmgiCiAjaW5jbHVkZSAiUmVuZGVySW1hZ2UuaCIK ICNpbmNsdWRlICJTdHJpbmdIYXNoLmgiCisjaW5jbHVkZSAibWFya3VwLmgiCiAKKyNpbmNsdWRl IDxRQXBwbGljYXRpb24+CisjaW5jbHVkZSA8UUNsaXBib2FyZD4KICNpbmNsdWRlIDxRTGlzdD4K ICNpbmNsdWRlIDxRTWltZURhdGE+CiAjaW5jbHVkZSA8UVN0cmluZ0xpc3Q+CiAjaW5jbHVkZSA8 UVVybD4KLSNpbmNsdWRlIDxRQXBwbGljYXRpb24+Ci0jaW5jbHVkZSA8UUNsaXBib2FyZD4KICNp bmNsdWRlIDxxZGVidWcuaD4KIAogI2RlZmluZSBtZXRob2REZWJ1ZygpIHFEZWJ1ZygiQ2xpcGJv YXJkUXQ6ICVzIiwgX19GVU5DVElPTl9fKQpAQCAtMjI2LDE0ICsyMjYsMTQgQEAgdm9pZCBDbGlw Ym9hcmRRdDo6ZGVjbGFyZUFuZFdyaXRlRHJhZ0ltYWdlKEVsZW1lbnQqIGVsZW1lbnQsIGNvbnN0 IEtVUkwmIHVybCwgY28KIHsKICAgICBBU1NFUlQoZnJhbWUpOwogCi0gICAgLy9XZWJDb3JlOjp3 cml0ZVVSTChtX3dyaXRhYmxlRGF0YU9iamVjdC5nZXQoKSwgdXJsLCB0aXRsZSwgdHJ1ZSwgZmFs c2UpOworICAgIC8vIFdlYkNvcmU6OndyaXRlVVJMKG1fd3JpdGFibGVEYXRhT2JqZWN0LmdldCgp LCB1cmwsIHRpdGxlLCB0cnVlLCBmYWxzZSk7CiAgICAgaWYgKCFtX3dyaXRhYmxlRGF0YSkKICAg ICAgICAgbV93cml0YWJsZURhdGEgPSBuZXcgUU1pbWVEYXRhOwogCiAgICAgQ2FjaGVkSW1hZ2Uq IGNhY2hlZEltYWdlID0gZ2V0Q2FjaGVkSW1hZ2UoZWxlbWVudCk7CiAgICAgaWYgKCFjYWNoZWRJ bWFnZSB8fCAhY2FjaGVkSW1hZ2UtPmltYWdlKCkgfHwgIWNhY2hlZEltYWdlLT5pc0xvYWRlZCgp KQogICAgICAgICByZXR1cm47Ci0gICAgUVBpeG1hcCAqcGl4bWFwID0gY2FjaGVkSW1hZ2UtPmlt YWdlKCktPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CisgICAgUVBpeG1hcCogcGl4bWFw ID0gY2FjaGVkSW1hZ2UtPmltYWdlKCktPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CiAg ICAgaWYgKHBpeG1hcCkKICAgICAgICAgbV93cml0YWJsZURhdGEtPnNldEltYWdlRGF0YSgqcGl4 bWFwKTsKIAo=