39780 2010-05-26 13:38:32 -0700 [Qt] ContextMenuItemQt.cpp has coding-style errors 2010-06-05 05:15:51 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230863 0 agbakken 2010-05-26 13:38:32 -0700 WebCore/platform/qt/ContextMenuItemQt.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 1 in 1 files 230928 1 57161 agbakken 2010-05-26 14:47:11 -0700 Created attachment 57161 Patch that fixes the coding style issues 231100 2 peojala11 2010-05-26 21:53:40 -0700 QtTriaged 231374 3 57161 levin 2010-05-27 11:11:56 -0700 Comment on attachment 57161 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234494 4 57956 agbakken 2010-06-04 20:25:28 -0700 Created attachment 57956 Patch 234603 5 57956 commit-queue 2010-06-05 05:15:39 -0700 Comment on attachment 57956 Patch Clearing flags on attachment: 57956 Committed r60751: <http://trac.webkit.org/changeset/60751> 234604 6 commit-queue 2010-06-05 05:15:51 -0700 All reviewed patches have been landed. Closing bug. 57161 2010-05-26 14:47:11 -0700 2010-06-04 20:25:23 -0700 Patch that fixes the coding style issues patch.39780 text/plain 1270 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29udGV4dE1lbnVJdGVtUXQuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc4MAorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvQ29udGV4dE1lbnVJ dGVtUXQuY3BwOgorCiAyMDEwLTA1LTI2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBPamFuLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9D b250ZXh0TWVudUl0ZW1RdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9D b250ZXh0TWVudUl0ZW1RdC5jcHAJKHJldmlzaW9uIDYwMjQ3KQorKysgV2ViQ29yZS9wbGF0Zm9y bS9xdC9Db250ZXh0TWVudUl0ZW1RdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxLDExICsyMSwx MiBAQAogICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNF RCBBTkQgT04gQU5ZIFRIRU9SWQogICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNU LCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCiAgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1Ig T1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKLSAqIE9GIFRISVMg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuIAorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiQ29udGV4dE1lbnVJdGVtLmgiCisKICNpbmNsdWRlICJDb250ZXh0TWVudS5oIgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7Cg== 57956 2010-06-04 20:25:28 -0700 2010-06-05 05:15:39 -0700 Patch bug-39780-20100604202527.patch text/plain 1332 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uODE5ZWIwMzAwMDU5MjVh ZDRhMjdjYWZmNDVlYjkxNTBhZDExMmE3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENvbnRleHRNZW51SXRlbVF0LmNwcCBoYXMg Y29kaW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzk3ODAKKworICAgICAgICAqIHBsYXRmb3JtL3F0L0NvbnRleHRNZW51SXRl bVF0LmNwcDoKKwogMjAxMC0wNi0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9xdC9Db250ZXh0TWVudUl0ZW1RdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3Jt L3F0L0NvbnRleHRNZW51SXRlbVF0LmNwcAppbmRleCBjZjIzNTg3MzYzZjUwZGM3ZGYwZWY1ZTFm ZGMxMmFiZTdiZjZjMTVmLi5iOTFhMmE3NTYwYzQzY2YwZDdhZTY4NmUzZjdjMzBkOWMzMDhiMmJh IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0NvbnRleHRNZW51SXRlbVF0LmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L0NvbnRleHRNZW51SXRlbVF0LmNwcApAQCAtMjEsMTEg KzIxLDEyIEBACiAgKiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIg Q0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCiAgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09O VFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKICAqIChJTkNMVURJTkcgTkVHTElHRU5D RSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICogT0Yg VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNI IERBTUFHRS4gCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKICNp bmNsdWRlICJDb250ZXh0TWVudUl0ZW0uaCIKKwogI2luY2x1ZGUgIkNvbnRleHRNZW51LmgiCiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsK