39778 2010-05-26 13:37:38 -0700 [Qt] CookieJarQt.cpp has coding-style errors 2011-01-08 16:48:01 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P5 Normal --- 1 agbakken webkit-unassigned benjamin commit-queue levin peojala11 oldest_to_newest 230861 0 agbakken 2010-05-26 13:37:38 -0700 WebCore/platform/qt/CookieJarQt.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/CookieJarQt.cpp:38: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/CookieJarQt.cpp:48: Declaration has space between type name and * in Frame *frame [whitespace/declaration] [3] WebCore/platform/qt/CookieJarQt.cpp:51: Declaration has space between type name and * in FrameLoader *loader [whitespace/declaration] [3] WebCore/platform/qt/CookieJarQt.cpp:125: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 5 in 1 files 230925 1 57159 agbakken 2010-05-26 14:46:34 -0700 Created attachment 57159 Patch that fixes the coding style issues 231098 2 peojala11 2010-05-26 21:52:16 -0700 Qt, QtTriaged 231377 3 57159 levin 2010-05-27 11:12:28 -0700 Comment on attachment 57159 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234492 4 57954 agbakken 2010-06-04 20:22:41 -0700 Created attachment 57954 Patch 234522 5 57954 eric 2010-06-04 22:11:26 -0700 Comment on attachment 57954 Patch Seems silly to not just make this a one-line function call now: QNetworkCookieJar* jar = cookieJar(document); 125 return (jar != 0); 125 return jar; You could use !!cookieJar(document) to make it clear that your'e returnign a bool if you like. 237936 6 57954 levin 2010-06-14 11:32:19 -0700 Comment on attachment 57954 Patch Please consider Eric's comment. 330889 7 benjamin 2011-01-07 11:41:27 -0800 Anders, what is the status of this? 330907 8 78255 benjamin 2011-01-07 12:12:41 -0800 Created attachment 78255 Patch 330908 9 78255 kenneth 2011-01-07 12:14:08 -0800 Comment on attachment 78255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78255&action=review > WebCore/platform/qt/CookieJarQt.cpp:117 > - return networkAccessManager(document); > + return !!networkAccessManager(document); It this in the coding style guide? 330910 10 78255 kling 2011-01-07 12:15:35 -0800 Comment on attachment 78255 Patch Oh, let's answer Kenneth's question first. 330916 11 benjamin 2011-01-07 12:17:48 -0800 (In reply to comment #9) > > WebCore/platform/qt/CookieJarQt.cpp:117 > > - return networkAccessManager(document); > > + return !!networkAccessManager(document); > > It this in the coding style guide? No, it was to address Eric Seidel comment (comment 5). 331317 12 78255 commit-queue 2011-01-08 16:47:54 -0800 Comment on attachment 78255 Patch Clearing flags on attachment: 78255 Committed r75334: <http://trac.webkit.org/changeset/75334> 331318 13 commit-queue 2011-01-08 16:48:01 -0800 All reviewed patches have been landed. Closing bug. 57159 2010-05-26 14:46:34 -0700 2010-06-04 20:22:36 -0700 Patch that fixes the coding style issues patch.39778 text/plain 1884 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29va2llSmFyUXQuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc3OAorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y29va2llSmFyKToKKyAgICAgICAgKFdlYkNvcmU6OmNvb2tpZXNF bmFibGVkKToKKwogMjAxMC0wNS0yNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvQ29v a2llSmFyUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFy UXQuY3BwCShyZXZpc2lvbiA2MDI0NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFy UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCwyNSArMzAsMjUgQEAKIAogI2luY2x1ZGUgIkNv b2tpZS5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiRnJhbWVMb2FkZXJDbGll bnRRdC5oIgogI2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgot Ci0jaW5jbHVkZSAicXdlYnBhZ2UuaCIKICNpbmNsdWRlICJxd2ViZnJhbWUuaCIKLSNpbmNsdWRl ICJGcmFtZUxvYWRlckNsaWVudFF0LmgiCisjaW5jbHVkZSAicXdlYnBhZ2UuaCIKICNpbmNsdWRl IDxRTmV0d29ya0FjY2Vzc01hbmFnZXI+CiAjaW5jbHVkZSA8UU5ldHdvcmtDb29raWU+CiAKKwog bmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0aWMgUU5ldHdvcmtDb29raWVKYXIgKmNvb2tpZUph cihjb25zdCBEb2N1bWVudCAqZG9jdW1lbnQpCiB7CiAgICAgaWYgKCFkb2N1bWVudCkKICAgICAg ICAgcmV0dXJuIDA7Ci0gICAgRnJhbWUgKmZyYW1lID0gZG9jdW1lbnQtPmZyYW1lKCk7CisgICAg RnJhbWUqIGZyYW1lID0gZG9jdW1lbnQtPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSkKICAgICAg ICAgcmV0dXJuIDA7Ci0gICAgRnJhbWVMb2FkZXIgKmxvYWRlciA9IGZyYW1lLT5sb2FkZXIoKTsK KyAgICBGcmFtZUxvYWRlciogbG9hZGVyID0gZnJhbWUtPmxvYWRlcigpOwogICAgIGlmICghbG9h ZGVyKQogICAgICAgICByZXR1cm4gMDsKICAgICBRV2ViRnJhbWUqIHdlYkZyYW1lID0gc3RhdGlj X2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRRdCo+KGxvYWRlci0+Y2xpZW50KCkpLT53ZWJGcmFtZSgp OwpAQCAtMTIyLDcgKzEyMiw3IEBAIFN0cmluZyBjb29raWVSZXF1ZXN0SGVhZGVyRmllbGRWYWx1 ZShjb24KIGJvb2wgY29va2llc0VuYWJsZWQoY29uc3QgRG9jdW1lbnQqIGRvY3VtZW50KQogewog ICAgIFFOZXR3b3JrQ29va2llSmFyKiBqYXIgPSBjb29raWVKYXIoZG9jdW1lbnQpOwotICAgIHJl dHVybiAoamFyICE9IDApOworICAgIHJldHVybiBqYXI7CiB9CiAKIGJvb2wgZ2V0UmF3Q29va2ll cyhjb25zdCBEb2N1bWVudCosIGNvbnN0IEtVUkwmLCBWZWN0b3I8Q29va2llPiYgcmF3Q29va2ll cykK 57954 2010-06-04 20:22:41 -0700 2011-01-07 12:12:36 -0800 Patch bug-39778-20100604202239.patch text/plain 1979 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uY2EwMDQyN2I3NjVjZDYw NWE4M2U3NDkzOGRiYzM4ZmU0NGQ3MzI0NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENvb2tpZUphclF0LmNwcCBoYXMgY29kaW5n LXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzk3NzgKKworICAgICAgICAqIHBsYXRmb3JtL3F0L0Nvb2tpZUphclF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmNvb2tpZUphcik6CisgICAgICAgIChXZWJDb3JlOjpjb29raWVzRW5h YmxlZCk6CisKIDIwMTAtMDYtMDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29r aWVKYXJRdC5jcHAKaW5kZXggMTUwNTNlYmY2YTExNzM1ODVkODAwMzM3ZTlkYTA5YWNjZTE4YmQz NC4uMWZiZjRkZWNhMWJhZmFkYzc2OTNhM2JlZjZiNmIwODg5NjM4NTZhYiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9xdC9Db29raWVKYXJRdC5jcHAKQEAgLTMwLDI1ICszMCwyNSBAQAogCiAjaW5jbHVkZSAiQ29v a2llLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKKyNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVu dFF0LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCi0K LSNpbmNsdWRlICJxd2VicGFnZS5oIgogI2luY2x1ZGUgInF3ZWJmcmFtZS5oIgotI2luY2x1ZGUg IkZyYW1lTG9hZGVyQ2xpZW50UXQuaCIKKyNpbmNsdWRlICJxd2VicGFnZS5oIgogI2luY2x1ZGUg PFFOZXR3b3JrQWNjZXNzTWFuYWdlcj4KICNpbmNsdWRlIDxRTmV0d29ya0Nvb2tpZT4KIAorCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBRTmV0d29ya0Nvb2tpZUphciAqY29va2llSmFy KGNvbnN0IERvY3VtZW50ICpkb2N1bWVudCkKIHsKICAgICBpZiAoIWRvY3VtZW50KQogICAgICAg ICByZXR1cm4gMDsKLSAgICBGcmFtZSAqZnJhbWUgPSBkb2N1bWVudC0+ZnJhbWUoKTsKKyAgICBG cmFtZSogZnJhbWUgPSBkb2N1bWVudC0+ZnJhbWUoKTsKICAgICBpZiAoIWZyYW1lKQogICAgICAg ICByZXR1cm4gMDsKLSAgICBGcmFtZUxvYWRlciAqbG9hZGVyID0gZnJhbWUtPmxvYWRlcigpOwor ICAgIEZyYW1lTG9hZGVyKiBsb2FkZXIgPSBmcmFtZS0+bG9hZGVyKCk7CiAgICAgaWYgKCFsb2Fk ZXIpCiAgICAgICAgIHJldHVybiAwOwogICAgIFFXZWJGcmFtZSogd2ViRnJhbWUgPSBzdGF0aWNf Y2FzdDxGcmFtZUxvYWRlckNsaWVudFF0Kj4obG9hZGVyLT5jbGllbnQoKSktPndlYkZyYW1lKCk7 CkBAIC0xMjIsNyArMTIyLDcgQEAgU3RyaW5nIGNvb2tpZVJlcXVlc3RIZWFkZXJGaWVsZFZhbHVl KGNvbnN0IERvY3VtZW50KiBkb2N1bWVudCwgY29uc3QgS1VSTCAmdXJsKQogYm9vbCBjb29raWVz RW5hYmxlZChjb25zdCBEb2N1bWVudCogZG9jdW1lbnQpCiB7CiAgICAgUU5ldHdvcmtDb29raWVK YXIqIGphciA9IGNvb2tpZUphcihkb2N1bWVudCk7Ci0gICAgcmV0dXJuIChqYXIgIT0gMCk7Cisg ICAgcmV0dXJuIGphcjsKIH0KIAogYm9vbCBnZXRSYXdDb29raWVzKGNvbnN0IERvY3VtZW50Kiwg Y29uc3QgS1VSTCYsIFZlY3RvcjxDb29raWU+JiByYXdDb29raWVzKQo= 78255 2011-01-07 12:12:41 -0800 2011-01-08 16:47:54 -0800 Patch bug-39778-20110107211753.patch text/plain 2172 benjamin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzUxMjFhY2Q3MGMyMWZiZTMyMGZlZTk5ODM2YmQ1MDE1NzU5NTdkNy4uNTViYjVkNDM5YmM2ZTBj NzViZTkwMDc0YTczNjIxYWI0ZmMzNDE3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0wNyAgQmVu amFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ29va2llSmFyUXQuY3Bw IGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zOTc3OAorCisgICAgICAgIEltcHJvdmUgdGhlIGNvZGluZyBzdHls ZSBvZiBDb29raWVKYXJRdC5jcHAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Db29raWVKYXJR dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpuZXR3b3JrQWNjZXNzTWFuYWdlcik6CisgICAgICAg IChXZWJDb3JlOjpjb29raWVzRW5hYmxlZCk6CisKIDIwMTEtMDEtMDcgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRp biBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQu Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKaW5kZXggZTVkMzZiYWJh ZmI4ZDQwM2EzNjhlMWNmMWE2NTUyZDY5Y2RhN2Y2YS4uNTNlMzliOWFkZGE1YzE3NjdiNGIxZmRi NTk1NDQ0YzM4YjNjNWFiOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVK YXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKQEAgLTMw LDE0ICszMCwxMyBAQAogCiAjaW5jbHVkZSAiQ29va2llLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQu aCIKKyNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudFF0LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgot I2luY2x1ZGUgIlF0TkFNVGhyZWFkU2FmZVByb3h5LmgiCiAjaW5jbHVkZSAiTmV0d29ya2luZ0Nv bnRleHQuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgotCi0jaW5jbHVkZSAicXdlYnBh Z2UuaCIKKyNpbmNsdWRlICJRdE5BTVRocmVhZFNhZmVQcm94eS5oIgogI2luY2x1ZGUgInF3ZWJm cmFtZS5oIgotI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50UXQuaCIKKyNpbmNsdWRlICJxd2Vi cGFnZS5oIgogI2luY2x1ZGUgPFFOZXR3b3JrQWNjZXNzTWFuYWdlcj4KICNpbmNsdWRlIDxRTmV0 d29ya0Nvb2tpZT4KICNpbmNsdWRlIDxRU3RyaW5nTGlzdD4KQEAgLTQ5LDEwICs0OCwxMCBAQCBz dGF0aWMgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyICpuZXR3b3JrQWNjZXNzTWFuYWdlcihjb25zdCBE b2N1bWVudCAqZG9jdW1lbnQpCiB7CiAgICAgaWYgKCFkb2N1bWVudCkKICAgICAgICAgcmV0dXJu IDA7Ci0gICAgRnJhbWUgKmZyYW1lID0gZG9jdW1lbnQtPmZyYW1lKCk7CisgICAgRnJhbWUqIGZy YW1lID0gZG9jdW1lbnQtPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJu IDA7Ci0gICAgRnJhbWVMb2FkZXIgKmxvYWRlciA9IGZyYW1lLT5sb2FkZXIoKTsKKyAgICBGcmFt ZUxvYWRlciogbG9hZGVyID0gZnJhbWUtPmxvYWRlcigpOwogICAgIGlmICghbG9hZGVyKQogICAg ICAgICByZXR1cm4gMDsKICAgICByZXR1cm4gbG9hZGVyLT5uZXR3b3JraW5nQ29udGV4dCgpLT5u ZXR3b3JrQWNjZXNzTWFuYWdlcigpOwpAQCAtMTE1LDcgKzExNCw3IEBAIFN0cmluZyBjb29raWVS ZXF1ZXN0SGVhZGVyRmllbGRWYWx1ZShjb25zdCBEb2N1bWVudCogZG9jdW1lbnQsIGNvbnN0IEtV UkwgJnVybCkKIAogYm9vbCBjb29raWVzRW5hYmxlZChjb25zdCBEb2N1bWVudCogZG9jdW1lbnQp CiB7Ci0gICAgcmV0dXJuIG5ldHdvcmtBY2Nlc3NNYW5hZ2VyKGRvY3VtZW50KTsKKyAgICByZXR1 cm4gISFuZXR3b3JrQWNjZXNzTWFuYWdlcihkb2N1bWVudCk7CiB9CiAKIGJvb2wgZ2V0UmF3Q29v a2llcyhjb25zdCBEb2N1bWVudCosIGNvbnN0IEtVUkwmLCBWZWN0b3I8Q29va2llPiYgcmF3Q29v a2llcykK