<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>39776</bug_id>
          
          <creation_ts>2010-05-26 13:36:36 -0700</creation_ts>
          <short_desc>[Qt] FileChooserQt.cpp has coding-style errors</short_desc>
          <delta_ts>2010-06-05 04:04:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Bakken">agbakken</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>levin</cc>
    
    <cc>peojala11</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>230859</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Bakken">agbakken</who>
    <bug_when>2010-05-26 13:36:36 -0700</bug_when>
    <thetext>WebCore/platform/qt/FileChooserQt.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 1 files</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>230923</commentid>
    <comment_count>1</comment_count>
      <attachid>57157</attachid>
    <who name="Anders Bakken">agbakken</who>
    <bug_when>2010-05-26 14:45:46 -0700</bug_when>
    <thetext>Created attachment 57157
Patch that fixes the coding style issues</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231096</commentid>
    <comment_count>2</comment_count>
    <who name="Petri Ojala">peojala11</who>
    <bug_when>2010-05-26 21:51:28 -0700</bug_when>
    <thetext>QtTriaged</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231380</commentid>
    <comment_count>3</comment_count>
      <attachid>57157</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2010-05-27 11:13:10 -0700</bug_when>
    <thetext>Comment on attachment 57157
Patch that fixes the coding style issues

&gt;   No new tests. (OOPS!)
Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>234490</commentid>
    <comment_count>4</comment_count>
      <attachid>57952</attachid>
    <who name="Anders Bakken">agbakken</who>
    <bug_when>2010-06-04 20:20:14 -0700</bug_when>
    <thetext>Created attachment 57952
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>234595</commentid>
    <comment_count>5</comment_count>
      <attachid>57952</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-05 04:04:25 -0700</bug_when>
    <thetext>Comment on attachment 57952
Patch

Clearing flags on attachment: 57952

Committed r60748: &lt;http://trac.webkit.org/changeset/60748&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>234596</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-05 04:04:31 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>57157</attachid>
            <date>2010-05-26 14:45:46 -0700</date>
            <delta_ts>2010-06-04 20:20:09 -0700</delta_ts>
            <desc>Patch that fixes the coding style issues</desc>
            <filename>patch.39776</filename>
            <type>text/plain</type>
            <size>967</size>
            <attacher name="Anders Bakken">agbakken</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp
bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
RmlsZUNob29zZXJRdC5jcHAgaGFzIGNvZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5Nzc2CisKKyAgICAgICAgTm8gbmV3
IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9GaWxlQ2hvb3NlclF0LmNw
cDoKKwogMjAxMC0wNS0yNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgT2phbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvRmlsZUNob29z
ZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9GaWxlQ2hvb3NlclF0
LmNwcAkocmV2aXNpb24gNjAyNDcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVDaG9vc2Vy
UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMSw4ICsyMSw4IEBACiAjaW5jbHVkZSAiY29uZmln
LmgiCiAjaW5jbHVkZSAiRmlsZUNob29zZXIuaCIKIAotI2luY2x1ZGUgIkxvY2FsaXplZFN0cmlu
Z3MuaCIKICNpbmNsdWRlICJGb250LmgiCisjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgog
I2luY2x1ZGUgPFFDb3JlQXBwbGljYXRpb24+CiAjaW5jbHVkZSA8UUZvbnRNZXRyaWNzPgogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>57952</attachid>
            <date>2010-06-04 20:20:14 -0700</date>
            <delta_ts>2010-06-05 04:04:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-39776-20100604202012.patch</filename>
            <type>text/plain</type>
            <size>1025</size>
            <attacher name="Anders Bakken">agbakken</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uZTVkODE0ZGQwNjY0OGY3
ODI0OTM3MzNhZGVmODQyNWViMDk5MzQ1MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k
ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpbGVDaG9vc2VyUXQuY3BwIGhhcyBjb2Rp
bmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0zOTc3NgorCisgICAgICAgICogcGxhdGZvcm0vcXQvRmlsZUNob29zZXJRdC5jcHA6
CisKIDIwMTAtMDYtMDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh
dGZvcm0vcXQvRmlsZUNob29zZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVDaG9v
c2VyUXQuY3BwCmluZGV4IDMwNzg3NmNlZGY1Mzk1ZTZlOGIyMThiMzZjZTk1ZmVjYTI5MmIxOWMu
LjhiMWRmMGE5NjA3M2Q3OTIxNDY2YzQ5NTUyNjZmN2EzNTM1MzBhOTAgMTAwNjQ0Ci0tLSBhL1dl
YkNvcmUvcGxhdGZvcm0vcXQvRmlsZUNob29zZXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9y
bS9xdC9GaWxlQ2hvb3NlclF0LmNwcApAQCAtMjEsOCArMjEsOCBAQAogI2luY2x1ZGUgImNvbmZp
Zy5oIgogI2luY2x1ZGUgIkZpbGVDaG9vc2VyLmgiCiAKLSNpbmNsdWRlICJMb2NhbGl6ZWRTdHJp
bmdzLmgiCiAjaW5jbHVkZSAiRm9udC5oIgorI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIK
ICNpbmNsdWRlIDxRQ29yZUFwcGxpY2F0aW9uPgogI2luY2x1ZGUgPFFGb250TWV0cmljcz4KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>