39775 2010-05-26 13:35:36 -0700 [Qt] FileSystemQt.cpp has coding-style errors 2010-06-05 03:52:49 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230858 0 agbakken 2010-05-26 13:35:36 -0700 WebCore/platform/qt/FileSystemQt.cpp:38: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/FileSystemQt.cpp:41: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/FileSystemQt.cpp:42: "QDateTime" already included at WebCore/platform/qt/FileSystemQt.cpp:38 [build/include] [4] Total errors found: 3 in 1 files 230922 1 57156 agbakken 2010-05-26 14:45:23 -0700 Created attachment 57156 Patch that fixes the coding style issues 231095 2 peojala11 2010-05-26 21:51:04 -0700 QtTriaged 231381 3 57156 levin 2010-05-27 11:13:21 -0700 Comment on attachment 57156 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234489 4 57951 agbakken 2010-06-04 20:18:47 -0700 Created attachment 57951 Patch 234593 5 57951 commit-queue 2010-06-05 03:52:43 -0700 Comment on attachment 57951 Patch Clearing flags on attachment: 57951 Committed r60747: <http://trac.webkit.org/changeset/60747> 234594 6 commit-queue 2010-06-05 03:52:49 -0700 All reviewed patches have been landed. Closing bug. 57156 2010-05-26 14:45:23 -0700 2010-06-04 20:18:41 -0700 Patch that fixes the coding style issues patch.39775 text/plain 2098 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RmlsZVN5c3RlbVF0LmNwcCBoYXMgY29kaW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk3NzUKKworICAgICAgICBObyBuZXcg dGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1RdC5jcHA6 CisKIDIwMTAtMDUtMjYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE9qYW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1R dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQuY3Bw CShyZXZpc2lvbiA2MDI0NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vcXQvRmlsZVN5c3RlbVF0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtOSwxMyArOSwxMyBAQAogICogYXJlIG1ldDoKICAqCiAgKiAx LiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBj b3B5cmlnaHQKLSAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg Zm9sbG93aW5nIGRpc2NsYWltZXIuIAorICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KICAqIDIuICBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAogICog ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lciBpbiB0aGUKLSAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlh bHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLiAKKyAqICAgICBkb2N1bWVudGF0aW9u IGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgog ICogMy4gIE5laXRoZXIgdGhlIG5hbWUgb2YgQXBwbGUgQ29tcHV0ZXIsIEluYy4gKCJBcHBsZSIp IG5vciB0aGUgbmFtZXMgb2YKICAqICAgICBpdHMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRv IGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkCi0gKiAgICAgZnJvbSB0aGlzIHNv ZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLiAKKyAqICAg ICBmcm9tIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1p c3Npb24uCiAgKgogICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRT IENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBBTlkKICAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKQEAgLTMz LDE0ICszMywxMiBAQAogI2luY2x1ZGUgIkZpbGVTeXN0ZW0uaCIKIAogI2luY2x1ZGUgIlBsYXRm b3JtU3RyaW5nLmgiCi0jaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgotCiAjaW5jbHVkZSA8 UURhdGVUaW1lPgorI2luY2x1ZGUgPFFEaXI+CiAjaW5jbHVkZSA8UUZpbGU+Ci0jaW5jbHVkZSA8 UVRlbXBvcmFyeUZpbGU+CiAjaW5jbHVkZSA8UUZpbGVJbmZvPgotI2luY2x1ZGUgPFFEYXRlVGlt ZT4KLSNpbmNsdWRlIDxRRGlyPgorI2luY2x1ZGUgPFFUZW1wb3JhcnlGaWxlPgorI2luY2x1ZGUg PHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCg== 57951 2010-06-04 20:18:47 -0700 2010-06-05 03:52:43 -0700 Patch bug-39775-20100604201845.patch text/plain 2155 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uNDdkNGRlMWE2MzcxYjA2 ZGZjZDJjYTc3ZjQwNTliMDZkYjcwZDJkMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpbGVTeXN0ZW1RdC5jcHAgaGFzIGNvZGlu Zy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM5Nzc1CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQuY3BwOgor CiAyMDEwLTA2LTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL3F0L0ZpbGVTeXN0ZW1RdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1R dC5jcHAKaW5kZXggZTQyY2E2NzE4ZWY5MWJlNTIxMjVmNjhlNjY0ZmM2MWYyMzgxMzE1Yi4uMDNk ZmM4ZmJlNWFkZGI2YTFlOTY3NDMwMzM1YzIzNjRiMmQzMjNiYyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQv RmlsZVN5c3RlbVF0LmNwcApAQCAtOSwxMyArOSwxMyBAQAogICogYXJlIG1ldDoKICAqCiAgKiAx LiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBj b3B5cmlnaHQKLSAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg Zm9sbG93aW5nIGRpc2NsYWltZXIuIAorICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KICAqIDIuICBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAogICog ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lciBpbiB0aGUKLSAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlh bHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLiAKKyAqICAgICBkb2N1bWVudGF0aW9u IGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgog ICogMy4gIE5laXRoZXIgdGhlIG5hbWUgb2YgQXBwbGUgQ29tcHV0ZXIsIEluYy4gKCJBcHBsZSIp IG5vciB0aGUgbmFtZXMgb2YKICAqICAgICBpdHMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRv IGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkCi0gKiAgICAgZnJvbSB0aGlzIHNv ZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLiAKKyAqICAg ICBmcm9tIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1p c3Npb24uCiAgKgogICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRT IENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBBTlkKICAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKQEAgLTMz LDE0ICszMywxMiBAQAogI2luY2x1ZGUgIkZpbGVTeXN0ZW0uaCIKIAogI2luY2x1ZGUgIlBsYXRm b3JtU3RyaW5nLmgiCi0jaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgotCiAjaW5jbHVkZSA8 UURhdGVUaW1lPgorI2luY2x1ZGUgPFFEaXI+CiAjaW5jbHVkZSA8UUZpbGU+Ci0jaW5jbHVkZSA8 UVRlbXBvcmFyeUZpbGU+CiAjaW5jbHVkZSA8UUZpbGVJbmZvPgotI2luY2x1ZGUgPFFEYXRlVGlt ZT4KLSNpbmNsdWRlIDxRRGlyPgorI2luY2x1ZGUgPFFUZW1wb3JhcnlGaWxlPgorI2luY2x1ZGUg PHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCg==