39774 2010-05-26 13:35:00 -0700 [Qt] KURLQt.cpp has coding-style errors 2010-06-05 03:27:43 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230857 0 agbakken 2010-05-26 13:35:00 -0700 WebCore/platform/qt/KURLQt.cpp:21: You should add a blank line after implementation file's own header. [build/include_order] [4] WebCore/platform/qt/KURLQt.cpp:25: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 1 files 230921 1 57155 agbakken 2010-05-26 14:45:03 -0700 Created attachment 57155 Patch that fixes the coding style issues 231094 2 peojala11 2010-05-26 21:50:27 -0700 QtTriaged 231382 3 57155 levin 2010-05-27 11:14:22 -0700 Comment on attachment 57155 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234488 4 57950 agbakken 2010-06-04 20:16:27 -0700 Created attachment 57950 Patch 234591 5 57950 commit-queue 2010-06-05 03:27:37 -0700 Comment on attachment 57950 Patch Clearing flags on attachment: 57950 Committed r60746: <http://trac.webkit.org/changeset/60746> 234592 6 commit-queue 2010-06-05 03:27:43 -0700 All reviewed patches have been landed. Closing bug. 57155 2010-05-26 14:45:03 -0700 2010-06-04 20:16:21 -0700 Patch that fixes the coding style issues patch.39774 text/plain 984 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg S1VSTFF0LmNwcCBoYXMgY29kaW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk3NzQKKworICAgICAgICBObyBuZXcgdGVzdHMu IChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL3F0L0tVUkxRdC5jcHA6CisKIDIwMTAtMDUt MjYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE9qYW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCShyZXZpc2lvbiA2MDI0NykKKysrIFdl YkNvcmUvcGxhdGZvcm0vcXQvS1VSTFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTksMTEgKzE5 LDExIEBACiAgKi8KICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJLVVJMLmgiCi0jaW5j bHVkZSAiVGV4dEVuY29kaW5nLmgiCi0jaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCiAj aW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKyNpbmNsdWRlICJUZXh0RW5jb2RpbmcuaCIKICNp bmNsdWRlICJxdXJsLmgiCisjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAK 57950 2010-06-04 20:16:27 -0700 2010-06-05 03:27:37 -0700 Patch bug-39774-20100604201625.patch text/plain 1035 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uMTI0MDRiM2E0MjFiZWQ1 MzdhYTBjNjliMmIxZThiYTQzYTcwNTBmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEtVUkxRdC5jcHAgaGFzIGNvZGluZy1zdHls ZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM5Nzc0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9LVVJMUXQuY3BwOgorCiAyMDEwLTA2LTA0 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg R2F2aW4gQmFycmFjbG91Z2guCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxR dC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKaW5kZXggZWExYTc5NTM4YTVl ODFmODA3MDQwNDYzOTEzZTc2OTIzOWM3ZTUyOS4uZjZkMmE4NmUxOTI3OTQyNjNiNGQyYjI4ZjIx ZWI0YTJlNDJjYWUyYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvS1VSTFF0LmNwcApAQCAtMTksMTEgKzE5LDExIEBA CiAgKi8KICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJLVVJMLmgiCi0jaW5jbHVkZSAi VGV4dEVuY29kaW5nLmgiCi0jaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCiAjaW5jbHVk ZSAiTm90SW1wbGVtZW50ZWQuaCIKKyNpbmNsdWRlICJUZXh0RW5jb2RpbmcuaCIKICNpbmNsdWRl ICJxdXJsLmgiCisjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAK