39773 2010-05-26 13:34:31 -0700 [Qt] Localizations.cpp has coding-style errors 2010-06-04 20:52:25 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 webkit.review.bot oldest_to_newest 230856 0 agbakken 2010-05-26 13:34:31 -0700 WebCore/platform/qt/Localizations.cpp:31: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/qt/Localizations.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/Localizations.cpp:482: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/platform/qt/Localizations.cpp:486: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/platform/qt/Localizations.cpp:490: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/platform/qt/Localizations.cpp:494: One space before end of line comments [whitespace/comments] [5] Total errors found: 6 in 1 files 230920 1 57154 agbakken 2010-05-26 14:44:42 -0700 Created attachment 57154 Patch that fixes the coding style issues 230927 2 webkit.review.bot 2010-05-26 14:47:10 -0700 Attachment 57154 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/qt/Localizations.cpp:30: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 230943 3 57154 agbakken 2010-05-26 15:02:51 -0700 Comment on attachment 57154 Patch that fixes the coding style issues The style error relates to this: https://bugs.webkit.org/show_bug.cgi?id=39787 231093 4 peojala11 2010-05-26 21:50:03 -0700 QtTriaged 231384 5 57154 levin 2010-05-27 11:16:02 -0700 Comment on attachment 57154 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 231385 6 levin 2010-05-27 11:16:39 -0700 (In reply to comment #3) > (From update of attachment 57154 [details]) > The style error relates to this: > > https://bugs.webkit.org/show_bug.cgi?id=39787 Feel free to fix. Should be pretty easy :) 234290 7 57896 agbakken 2010-06-04 11:00:29 -0700 Created attachment 57896 Patch 234296 8 webkit.review.bot 2010-06-04 11:04:06 -0700 Attachment 57896 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/qt/Localizations.cpp:30: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 234499 9 57896 commit-queue 2010-06-04 20:52:19 -0700 Comment on attachment 57896 Patch Clearing flags on attachment: 57896 Committed r60730: <http://trac.webkit.org/changeset/60730> 234500 10 commit-queue 2010-06-04 20:52:25 -0700 All reviewed patches have been landed. Closing bug. 57154 2010-05-26 14:44:42 -0700 2010-06-04 11:00:23 -0700 Patch that fixes the coding style issues patch.39773 text/plain 2307 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TG9jYWxpemF0aW9ucy5jcHAgaGFzIGNvZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NzczCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Mb2NhbGl6YXRpb25zLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmxvY2FsaXplZE1lZGlhVGltZURlc2NyaXB0aW9uKToKKwog MjAxMC0wNS0yNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgT2phbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvTG9jYWxpemF0aW9ucy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9Mb2NhbGl6YXRpb25zLmNwcAko cmV2aXNpb24gNjAyNDcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L0xvY2FsaXphdGlvbnMuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yNywxNSArMjcsMTUgQEAKICAqLwogCiAjaW5jbHVkZSAiY29u ZmlnLmgiCisjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogCiAjaW5jbHVkZSAiSW50U2l6 ZS5oIgotI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1l bnRlZC5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCi0jaW5jbHVkZSA8d3RmL01hdGhF eHRyYXMuaD4KLQogI2luY2x1ZGUgPFFDb3JlQXBwbGljYXRpb24+CiAjaW5jbHVkZSA8UUxvY2Fs ZT4KKyNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgorCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IApAQCAtMzUwLDcgKzM1MCw3IEBAIFN0cmluZyBBWE1lbnVMaXN0QWN0aW9uVmVyYigpCiB7CiAg ICAgcmV0dXJuIFN0cmluZygpOwogfQotICAgIAorCiBTdHJpbmcgbWlzc2luZ1BsdWdpblRleHQo KQogewogICAgIHJldHVybiBRQ29yZUFwcGxpY2F0aW9uOjp0cmFuc2xhdGUoIlFXZWJQYWdlIiwg Ik1pc3NpbmcgUGx1Zy1pbiIsICJMYWJlbCB0ZXh0IHRvIGJlIHVzZWQgd2hlbiBhIHBsdWctaW4g aXMgbWlzc2luZyIpOwpAQCAtNDc3LDIxICs0NzcsMTggQEAgU3RyaW5nIGxvY2FsaXplZE1lZGlh VGltZURlc2NyaXB0aW9uKGZsbwogICAgIGludCBtaW51dGVzID0gKHNlY29uZHMgLyA2MCkgJSA2 MDsKICAgICBzZWNvbmRzICU9IDYwOwogCi0gICAgaWYgKGRheXMpIHsKKyAgICBpZiAoZGF5cykK ICAgICAgICAgcmV0dXJuIFFDb3JlQXBwbGljYXRpb246OnRyYW5zbGF0ZSgiUVdlYlBhZ2UiLCAi JTEgZGF5cyAlMiBob3VycyAlMyBtaW51dGVzICU0IHNlY29uZHMiLCAiTWVkaWEgdGltZSBkZXNj cmlwdGlvbiIpLmFyZyhkYXlzKS5hcmcoaG91cnMpLmFyZyhtaW51dGVzKS5hcmcoc2Vjb25kcyk7 Ci0gICAgfQogCi0gICAgaWYgKGhvdXJzKSB7CisgICAgaWYgKGhvdXJzKQogICAgICAgICByZXR1 cm4gUUNvcmVBcHBsaWNhdGlvbjo6dHJhbnNsYXRlKCJRV2ViUGFnZSIsICIlMSBob3VycyAlMiBt aW51dGVzICUzIHNlY29uZHMiLCAiTWVkaWEgdGltZSBkZXNjcmlwdGlvbiIpLmFyZyhob3Vycyku YXJnKG1pbnV0ZXMpLmFyZyhzZWNvbmRzKTsKLSAgICB9CiAKLSAgICBpZiAobWludXRlcykgewor ICAgIGlmIChtaW51dGVzKQogICAgICAgICByZXR1cm4gUUNvcmVBcHBsaWNhdGlvbjo6dHJhbnNs YXRlKCJRV2ViUGFnZSIsICIlMSBtaW51dGVzICUyIHNlY29uZHMiLCAiTWVkaWEgdGltZSBkZXNj cmlwdGlvbiIpLmFyZyhtaW51dGVzKS5hcmcoc2Vjb25kcyk7Ci0gICAgfQogCiAgICAgcmV0dXJu IFFDb3JlQXBwbGljYXRpb246OnRyYW5zbGF0ZSgiUVdlYlBhZ2UiLCAiJTEgc2Vjb25kcyIsICJN ZWRpYSB0aW1lIGRlc2NyaXB0aW9uIikuYXJnKHNlY29uZHMpOwogfQotI2VuZGlmICAvLyBFTkFC TEUoVklERU8pCisjZW5kaWYgLy8gRU5BQkxFKFZJREVPKQogCiBTdHJpbmcgdmFsaWRhdGlvbk1l c3NhZ2VWYWx1ZU1pc3NpbmdUZXh0KCkKIHsK 57896 2010-06-04 11:00:29 -0700 2010-06-04 20:52:18 -0700 Patch bug-39773-20100604105927.patch text/plain 2369 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGEwNDY4YmQyOThkZTU4MzdmYjE2MGI0NGQzZWFhZGZhN2U4MjlkNS4uZDAzOTYxZmQ4NzRkYWFk YjQ3ZGU1MWJkMGMxNmIwYTdhN2VmOTVjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIExvY2FsaXphdGlvbnMuY3BwIGhhcyBjb2Rp bmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTc3MworCisgICAgICAgICogcGxhdGZvcm0vcXQvTG9jYWxpemF0aW9ucy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpsb2NhbGl6ZWRNZWRpYVRpbWVEZXNjcmlwdGlvbik6CisKIDIw MTAtMDYtMDQgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9M b2NhbGl6YXRpb25zLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvTG9jYWxpemF0aW9ucy5jcHAK aW5kZXggOGZkZDY2NjkyZGQyNjE2YWJlMTQ0ZjIyZmU1Y2I1NDJhZDNjYzkzMy4uNDU0ODcyYTQ3 MjIyOTY0ZmQ2MmJlOTc3MzdjZWFjOWYzMTkwODY5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0 Zm9ybS9xdC9Mb2NhbGl6YXRpb25zLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L0xvY2Fs aXphdGlvbnMuY3BwCkBAIC0yNywxNSArMjcsMTUgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmln LmgiCisjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogCiAjaW5jbHVkZSAiSW50U2l6ZS5o IgotI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRl ZC5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCi0jaW5jbHVkZSA8d3RmL01hdGhFeHRy YXMuaD4KLQogI2luY2x1ZGUgPFFDb3JlQXBwbGljYXRpb24+CiAjaW5jbHVkZSA8UUxvY2FsZT4K KyNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgorCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApA QCAtMzUwLDcgKzM1MCw3IEBAIFN0cmluZyBBWE1lbnVMaXN0QWN0aW9uVmVyYigpCiB7CiAgICAg cmV0dXJuIFN0cmluZygpOwogfQotICAgIAorCiBTdHJpbmcgbWlzc2luZ1BsdWdpblRleHQoKQog ewogICAgIHJldHVybiBRQ29yZUFwcGxpY2F0aW9uOjp0cmFuc2xhdGUoIlFXZWJQYWdlIiwgIk1p c3NpbmcgUGx1Zy1pbiIsICJMYWJlbCB0ZXh0IHRvIGJlIHVzZWQgd2hlbiBhIHBsdWctaW4gaXMg bWlzc2luZyIpOwpAQCAtNDc3LDIxICs0NzcsMTggQEAgU3RyaW5nIGxvY2FsaXplZE1lZGlhVGlt ZURlc2NyaXB0aW9uKGZsb2F0IHRpbWUpCiAgICAgaW50IG1pbnV0ZXMgPSAoc2Vjb25kcyAvIDYw KSAlIDYwOwogICAgIHNlY29uZHMgJT0gNjA7CiAKLSAgICBpZiAoZGF5cykgeworICAgIGlmIChk YXlzKQogICAgICAgICByZXR1cm4gUUNvcmVBcHBsaWNhdGlvbjo6dHJhbnNsYXRlKCJRV2ViUGFn ZSIsICIlMSBkYXlzICUyIGhvdXJzICUzIG1pbnV0ZXMgJTQgc2Vjb25kcyIsICJNZWRpYSB0aW1l IGRlc2NyaXB0aW9uIikuYXJnKGRheXMpLmFyZyhob3VycykuYXJnKG1pbnV0ZXMpLmFyZyhzZWNv bmRzKTsKLSAgICB9CiAKLSAgICBpZiAoaG91cnMpIHsKKyAgICBpZiAoaG91cnMpCiAgICAgICAg IHJldHVybiBRQ29yZUFwcGxpY2F0aW9uOjp0cmFuc2xhdGUoIlFXZWJQYWdlIiwgIiUxIGhvdXJz ICUyIG1pbnV0ZXMgJTMgc2Vjb25kcyIsICJNZWRpYSB0aW1lIGRlc2NyaXB0aW9uIikuYXJnKGhv dXJzKS5hcmcobWludXRlcykuYXJnKHNlY29uZHMpOwotICAgIH0KIAotICAgIGlmIChtaW51dGVz KSB7CisgICAgaWYgKG1pbnV0ZXMpCiAgICAgICAgIHJldHVybiBRQ29yZUFwcGxpY2F0aW9uOjp0 cmFuc2xhdGUoIlFXZWJQYWdlIiwgIiUxIG1pbnV0ZXMgJTIgc2Vjb25kcyIsICJNZWRpYSB0aW1l IGRlc2NyaXB0aW9uIikuYXJnKG1pbnV0ZXMpLmFyZyhzZWNvbmRzKTsKLSAgICB9CiAKICAgICBy ZXR1cm4gUUNvcmVBcHBsaWNhdGlvbjo6dHJhbnNsYXRlKCJRV2ViUGFnZSIsICIlMSBzZWNvbmRz IiwgIk1lZGlhIHRpbWUgZGVzY3JpcHRpb24iKS5hcmcoc2Vjb25kcyk7CiB9Ci0jZW5kaWYgIC8v IEVOQUJMRShWSURFTykKKyNlbmRpZiAvLyBFTkFCTEUoVklERU8pCiAKIFN0cmluZyB2YWxpZGF0 aW9uTWVzc2FnZVZhbHVlTWlzc2luZ1RleHQoKQogewo=