39772 2010-05-26 13:33:54 -0700 [Qt] LoggingQt.cpp has coding-style errors 2010-06-05 03:12:49 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230854 0 agbakken 2010-05-26 13:33:54 -0700 WebCore/platform/qt/LoggingQt.cpp:21: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 1 in 1 files 230916 1 57152 agbakken 2010-05-26 14:38:55 -0700 Created attachment 57152 Patch that fixes the coding style issues 231092 2 peojala11 2010-05-26 21:49:03 -0700 Qt, QtTriaged 231386 3 57152 levin 2010-05-27 11:16:59 -0700 Comment on attachment 57152 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234487 4 57949 agbakken 2010-06-04 20:15:17 -0700 Created attachment 57949 Patch 234588 5 57949 commit-queue 2010-06-05 03:12:43 -0700 Comment on attachment 57949 Patch Clearing flags on attachment: 57949 Committed r60745: <http://trac.webkit.org/changeset/60745> 234589 6 commit-queue 2010-06-05 03:12:49 -0700 All reviewed patches have been landed. Closing bug. 57152 2010-05-26 14:38:55 -0700 2010-06-04 20:15:12 -0700 Patch that fixes the coding style issues patch.39772 text/plain 911 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TG9nZ2luZ1F0LmNwcCBoYXMgY29kaW5nLXN0eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk3NzIKKworICAgICAgICBObyBuZXcgdGVz dHMuIChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL3F0L0xvZ2dpbmdRdC5jcHA6CisKIDIw MTAtMDUtMjYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE9qYW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L0xvZ2dpbmdRdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9Mb2dnaW5nUXQuY3BwCShyZXZpc2lvbiA2 MDI0NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vcXQvTG9nZ2luZ1F0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTksOCArMTksOCBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9n Z2luZy5oIgotI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKKyNpbmNsdWRlICJQbGF0Zm9y bVN0cmluZy5oIgogI2luY2x1ZGUgPFFEZWJ1Zz4KICNpbmNsdWRlIDxRU3RyaW5nTGlzdD4KIAo= 57949 2010-06-04 20:15:17 -0700 2010-06-05 03:12:43 -0700 Patch bug-39772-20100604201516.patch text/plain 965 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uMzJlMWM4N2YxMzQzNDRi MzUxYmJjMTQxYjJiNDc1M2U5Mzc5YjY4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIExvZ2dpbmdRdC5jcHAgaGFzIGNvZGluZy1z dHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM5NzcyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Mb2dnaW5nUXQuY3BwOgorCiAyMDEw LTA2LTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0 L0xvZ2dpbmdRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L0xvZ2dpbmdRdC5jcHAKaW5kZXgg Mjg1NDk1MzRjMzk1ZDgxMGQ5ODE2NWNlNWZhZGI0OGNiOWRiMzQwNS4uODE3ODg3ZDg2MmIyZWZh ODEwY2RlM2VjYTE5MTBhMmRmOTAwYjI2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9x dC9Mb2dnaW5nUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvTG9nZ2luZ1F0LmNwcApA QCAtMTksOCArMTksOCBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9nZ2lu Zy5oIgotI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKKyNpbmNsdWRlICJQbGF0Zm9ybVN0 cmluZy5oIgogI2luY2x1ZGUgPFFEZWJ1Zz4KICNpbmNsdWRlIDxRU3RyaW5nTGlzdD4KIAo=