39768 2010-05-26 13:31:13 -0700 [Qt] PlatformScreenQt.cpp has coding-style errors 2010-06-05 02:00:37 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230848 0 agbakken 2010-05-26 13:31:13 -0700 WebCore/platform/qt/PlatformScreenQt.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 1 files 230911 1 57148 agbakken 2010-05-26 14:37:37 -0700 Created attachment 57148 Patch that fixes the coding style issues 231085 2 peojala11 2010-05-26 21:45:55 -0700 QtTriaged 231391 3 57148 levin 2010-05-27 11:18:00 -0700 Comment on attachment 57148 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234471 4 57943 agbakken 2010-06-04 18:49:22 -0700 Created attachment 57943 Patch 234516 5 57943 eric 2010-06-04 22:03:58 -0700 Comment on attachment 57943 Patch Its sad that we have this code repeated twice. 234577 6 57943 commit-queue 2010-06-05 02:00:31 -0700 Comment on attachment 57943 Patch Clearing flags on attachment: 57943 Committed r60743: <http://trac.webkit.org/changeset/60743> 234578 7 commit-queue 2010-06-05 02:00:37 -0700 All reviewed patches have been landed. Closing bug. 57148 2010-05-26 14:37:37 -0700 2010-06-04 18:49:17 -0700 Patch that fixes the coding style issues patch.39769 text/plain 2850 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UGxhdGZvcm1Nb3VzZUV2ZW50UXQuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc2OQorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1N b3VzZUV2ZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Nb3VzZUV2ZW50OjpQ bGF0Zm9ybU1vdXNlRXZlbnQpOgorCiAyMDEwLTA1LTI2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuLgpJbmRleDogV2ViQ29yZS9wbGF0 Zm9ybS9xdC9QbGF0Zm9ybU1vdXNlRXZlbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9xdC9QbGF0Zm9ybU1vdXNlRXZlbnRRdC5jcHAJKHJldmlzaW9uIDYwMjQ3KQorKysg V2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybU1vdXNlRXZlbnRRdC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI4LDEwICsyOCw5IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUGxh dGZvcm1Nb3VzZUV2ZW50LmgiCiAKLSNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KLQotI2lu Y2x1ZGUgPFFNb3VzZUV2ZW50PgogI2luY2x1ZGUgPFFHcmFwaGljc1NjZW5lTW91c2VFdmVudD4K KyNpbmNsdWRlIDxRTW91c2VFdmVudD4KKyNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC02NSwxMCArNjQsMTAgQEAgUGxhdGZvcm1Nb3VzZUV2 ZW50OjpQbGF0Zm9ybU1vdXNlRXZlbnQoUQogICAgICAgICBtX2J1dHRvbiA9IE5vQnV0dG9uOwog CiAgICAgbV9jbGlja0NvdW50ID0gY2xpY2tDb3VudDsKLSAgICBtX3NoaWZ0S2V5ID0gIChldmVu dC0+bW9kaWZpZXJzKCkgJiBRdDo6U2hpZnRNb2RpZmllcikgIT0gMDsKLSAgICBtX2N0cmxLZXkg PSAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OkNvbnRyb2xNb2RpZmllcikgIT0gMDsKLSAgICBt X2FsdEtleSA9ICAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OkFsdE1vZGlmaWVyKSAhPSAwOwot ICAgIG1fbWV0YUtleSA9IChldmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6TWV0YU1vZGlmaWVyKSAh PSAwOworICAgIG1fc2hpZnRLZXkgPSAgKGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpTaGlmdE1v ZGlmaWVyKTsKKyAgICBtX2N0cmxLZXkgPSAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OkNvbnRy b2xNb2RpZmllcik7CisgICAgbV9hbHRLZXkgPSAgKGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpB bHRNb2RpZmllcik7CisgICAgbV9tZXRhS2V5ID0gKGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpN ZXRhTW9kaWZpZXIpOwogfQogCiBQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVu dChRSW5wdXRFdmVudCogZXZlbnQsIGludCBjbGlja0NvdW50KQpAQCAtOTQsNyArOTMsNyBAQCBQ bGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudChRCiAjaWZuZGVmIFFUX05PX0NP TlRFWFRNRU5VCiAgICAgY2FzZSBRRXZlbnQ6OkNvbnRleHRNZW51OiB7CiAgICAgICAgIG1fZXZl bnRUeXBlID0gTW91c2VFdmVudFByZXNzZWQ7Ci0gICAgICAgIFFDb250ZXh0TWVudUV2ZW50ICpj ZSA9IHN0YXRpY19jYXN0PFFDb250ZXh0TWVudUV2ZW50ICo+KGV2ZW50KTsKKyAgICAgICAgUUNv bnRleHRNZW51RXZlbnQqIGNlID0gc3RhdGljX2Nhc3Q8UUNvbnRleHRNZW51RXZlbnQqPihldmVu dCk7CiAgICAgICAgIG1fcG9zaXRpb24gPSBJbnRQb2ludChjZS0+cG9zKCkpOwogICAgICAgICBt X2dsb2JhbFBvc2l0aW9uID0gSW50UG9pbnQoY2UtPmdsb2JhbFBvcygpKTsKICAgICAgICAgbV9i dXR0b24gPSBSaWdodEJ1dHRvbjsKQEAgLTEyMCwxMCArMTE5LDEwIEBAIFBsYXRmb3JtTW91c2VF dmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KFEKICAgICB9CiAKICAgICBtX2NsaWNrQ291bnQgPSBj bGlja0NvdW50OwotICAgIG1fc2hpZnRLZXkgPSAgKGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpT aGlmdE1vZGlmaWVyKSAhPSAwOwotICAgIG1fY3RybEtleSA9IChldmVudC0+bW9kaWZpZXJzKCkg JiBRdDo6Q29udHJvbE1vZGlmaWVyKSAhPSAwOwotICAgIG1fYWx0S2V5ID0gIChldmVudC0+bW9k aWZpZXJzKCkgJiBRdDo6QWx0TW9kaWZpZXIpICE9IDA7Ci0gICAgbV9tZXRhS2V5ID0gKGV2ZW50 LT5tb2RpZmllcnMoKSAmIFF0OjpNZXRhTW9kaWZpZXIpICE9IDA7CisgICAgbV9zaGlmdEtleSA9 ICAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OlNoaWZ0TW9kaWZpZXIpOworICAgIG1fY3RybEtl eSA9IChldmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6Q29udHJvbE1vZGlmaWVyKTsKKyAgICBtX2Fs dEtleSA9ICAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OkFsdE1vZGlmaWVyKTsKKyAgICBtX21l dGFLZXkgPSAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6Ok1ldGFNb2RpZmllcik7CiB9CiAKIH0K 57943 2010-06-04 18:49:22 -0700 2010-06-05 02:00:31 -0700 Patch bug-39768-20100604184920.patch text/plain 3019 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uNWJkYzdjNjY0OGJlMjk5 ZTFjNjA2YzI5NTJlNGM3ZWJhOTUwZGI3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFBsYXRmb3JtU2NyZWVuUXQuY3BwIGhhcyBj b2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zOTc2OAorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1Nb3VzZUV2 ZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Nb3VzZUV2ZW50OjpQbGF0Zm9y bU1vdXNlRXZlbnQpOgorCiAyMDEwLTA2LTA0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtTW91c2VFdmVudFF0LmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vcXQvUGxhdGZvcm1Nb3VzZUV2ZW50UXQuY3BwCmluZGV4IGU0ODZlNjgzM2QwM2Mz M2Q4M2Y4M2FmZjUwMmZjOGQ4NmI0MzIxOGIuLmE4OTU2YmZjMTJkZTNlNTc2NGVmZjhlYWZlMmNm YzE2ZmVhYThhN2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1Nb3Vz ZUV2ZW50UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1Nb3VzZUV2ZW50 UXQuY3BwCkBAIC0yOCwxMCArMjgsOSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg IlBsYXRmb3JtTW91c2VFdmVudC5oIgogCi0jaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+Ci0K LSNpbmNsdWRlIDxRTW91c2VFdmVudD4KICNpbmNsdWRlIDxRR3JhcGhpY3NTY2VuZU1vdXNlRXZl bnQ+CisjaW5jbHVkZSA8UU1vdXNlRXZlbnQ+CisjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNjUsMTAgKzY0LDEwIEBAIFBsYXRmb3JtTW91 c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KFFHcmFwaGljc1NjZW5lTW91c2VFdmVudCogZXZl bnQsIGludCBjbGljCiAgICAgICAgIG1fYnV0dG9uID0gTm9CdXR0b247CiAKICAgICBtX2NsaWNr Q291bnQgPSBjbGlja0NvdW50OwotICAgIG1fc2hpZnRLZXkgPSAgKGV2ZW50LT5tb2RpZmllcnMo KSAmIFF0OjpTaGlmdE1vZGlmaWVyKSAhPSAwOwotICAgIG1fY3RybEtleSA9IChldmVudC0+bW9k aWZpZXJzKCkgJiBRdDo6Q29udHJvbE1vZGlmaWVyKSAhPSAwOwotICAgIG1fYWx0S2V5ID0gIChl dmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6QWx0TW9kaWZpZXIpICE9IDA7Ci0gICAgbV9tZXRhS2V5 ID0gKGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpNZXRhTW9kaWZpZXIpICE9IDA7CisgICAgbV9z aGlmdEtleSA9ICAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OlNoaWZ0TW9kaWZpZXIpOworICAg IG1fY3RybEtleSA9IChldmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6Q29udHJvbE1vZGlmaWVyKTsK KyAgICBtX2FsdEtleSA9ICAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OkFsdE1vZGlmaWVyKTsK KyAgICBtX21ldGFLZXkgPSAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6Ok1ldGFNb2RpZmllcik7 CiB9CiAKIFBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KFFJbnB1dEV2ZW50 KiBldmVudCwgaW50IGNsaWNrQ291bnQpCkBAIC05NCw3ICs5Myw3IEBAIFBsYXRmb3JtTW91c2VF dmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KFFJbnB1dEV2ZW50KiBldmVudCwgaW50IGNsaWNrQ291 bnQpCiAjaWZuZGVmIFFUX05PX0NPTlRFWFRNRU5VCiAgICAgY2FzZSBRRXZlbnQ6OkNvbnRleHRN ZW51OiB7CiAgICAgICAgIG1fZXZlbnRUeXBlID0gTW91c2VFdmVudFByZXNzZWQ7Ci0gICAgICAg IFFDb250ZXh0TWVudUV2ZW50ICpjZSA9IHN0YXRpY19jYXN0PFFDb250ZXh0TWVudUV2ZW50ICo+ KGV2ZW50KTsKKyAgICAgICAgUUNvbnRleHRNZW51RXZlbnQqIGNlID0gc3RhdGljX2Nhc3Q8UUNv bnRleHRNZW51RXZlbnQqPihldmVudCk7CiAgICAgICAgIG1fcG9zaXRpb24gPSBJbnRQb2ludChj ZS0+cG9zKCkpOwogICAgICAgICBtX2dsb2JhbFBvc2l0aW9uID0gSW50UG9pbnQoY2UtPmdsb2Jh bFBvcygpKTsKICAgICAgICAgbV9idXR0b24gPSBSaWdodEJ1dHRvbjsKQEAgLTEyMCwxMCArMTE5 LDEwIEBAIFBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1Nb3VzZUV2ZW50KFFJbnB1dEV2ZW50 KiBldmVudCwgaW50IGNsaWNrQ291bnQpCiAgICAgfQogCiAgICAgbV9jbGlja0NvdW50ID0gY2xp Y2tDb3VudDsKLSAgICBtX3NoaWZ0S2V5ID0gIChldmVudC0+bW9kaWZpZXJzKCkgJiBRdDo6U2hp ZnRNb2RpZmllcikgIT0gMDsKLSAgICBtX2N0cmxLZXkgPSAoZXZlbnQtPm1vZGlmaWVycygpICYg UXQ6OkNvbnRyb2xNb2RpZmllcikgIT0gMDsKLSAgICBtX2FsdEtleSA9ICAoZXZlbnQtPm1vZGlm aWVycygpICYgUXQ6OkFsdE1vZGlmaWVyKSAhPSAwOwotICAgIG1fbWV0YUtleSA9IChldmVudC0+ bW9kaWZpZXJzKCkgJiBRdDo6TWV0YU1vZGlmaWVyKSAhPSAwOworICAgIG1fc2hpZnRLZXkgPSAg KGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpTaGlmdE1vZGlmaWVyKTsKKyAgICBtX2N0cmxLZXkg PSAoZXZlbnQtPm1vZGlmaWVycygpICYgUXQ6OkNvbnRyb2xNb2RpZmllcik7CisgICAgbV9hbHRL ZXkgPSAgKGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpBbHRNb2RpZmllcik7CisgICAgbV9tZXRh S2V5ID0gKGV2ZW50LT5tb2RpZmllcnMoKSAmIFF0OjpNZXRhTW9kaWZpZXIpOwogfQogCiB9Cg==