39766 2010-05-26 13:29:29 -0700 [Qt] ScreenQt.cpp has coding-style errors 2010-06-13 23:21:06 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230845 0 agbakken 2010-05-26 13:29:29 -0700 WebCore/platform/qt/ScreenQt.cpp:33: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/ScreenQt.cpp:36: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/ScreenQt.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 1 files 230909 1 57146 agbakken 2010-05-26 14:36:20 -0700 Created attachment 57146 Patch that fixes the coding style issues 231083 2 peojala11 2010-05-26 21:44:48 -0700 QtTriaged 231393 3 57146 levin 2010-05-27 11:19:47 -0700 Comment on attachment 57146 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234469 4 57941 agbakken 2010-06-04 18:46:20 -0700 Created attachment 57941 Patch 234572 5 57941 commit-queue 2010-06-05 01:17:21 -0700 Comment on attachment 57941 Patch Rejecting patch 57941 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: ng Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19055 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14082 tests run. 203.02s total testing time 14081 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3106070 237628 6 57941 eric 2010-06-13 17:05:40 -0700 Comment on attachment 57941 Patch Flaky test. 237722 7 57941 commit-queue 2010-06-13 23:20:58 -0700 Comment on attachment 57941 Patch Clearing flags on attachment: 57941 Committed r61109: <http://trac.webkit.org/changeset/61109> 237723 8 commit-queue 2010-06-13 23:21:06 -0700 All reviewed patches have been landed. Closing bug. 57146 2010-05-26 14:36:20 -0700 2010-06-04 18:46:15 -0700 Patch that fixes the coding style issues patch.39766 text/plain 1415 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2NyZWVuUXQuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc2NgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2NyZWVuUXQuY3BwOgorCiAyMDEw LTA1LTI2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPamFuLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JlZW5RdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JlZW5RdC5jcHAJKHJldmlzaW9uIDYwMjQ3 KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JlZW5RdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIzLDE4ICsyMywxOCBAQAogICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQogICogT0YgTElBQklMSVRZLCBXSEVUSEVS IElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCiAgKiAoSU5DTFVESU5HIE5F R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK LSAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuIAorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9G IFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCiAjaW5jbHVkZSAiY29uZmln LmgiCiAjaW5jbHVkZSAiU2NyZWVuLmgiCiAKLSNpbmNsdWRlICJQYWdlLmgiCisjaW5jbHVkZSAi RmxvYXRSZWN0LmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJGcmFtZVZpZXcuaCIK LSNpbmNsdWRlICJXaWRnZXQuaCIKICNpbmNsdWRlICJJbnRSZWN0LmgiCi0jaW5jbHVkZSAiRmxv YXRSZWN0LmgiCisjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIldpZGdldC5oIgogCiAjaW5j bHVkZSA8UUFwcGxpY2F0aW9uPgogI2luY2x1ZGUgPFFEZXNrdG9wV2lkZ2V0Pgo= 57941 2010-06-04 18:46:20 -0700 2010-06-13 23:20:58 -0700 Patch bug-39766-20100604184618.patch text/plain 1468 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uZDEyZDM0NDI1NjA3MGEy YzI0ZTAxYzQ4ZTc1ZTMxZWI5NmM5NTYyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNjcmVlblF0LmNwcCBoYXMgY29kaW5nLXN0 eWxlIGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mzk3NjYKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NjcmVlblF0LmNwcDoKKwogMjAxMC0w Ni0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9T Y3JlZW5RdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1NjcmVlblF0LmNwcAppbmRleCBkZWYx OTk1MTIyOTY5YzU5OTNkMWMwZmE4N2MwOTNhNDM5ODQ2ZjU1Li5kNjQ4YzUzMTVmY2UxNjY0Y2Qx Y2RlYjQzZTZjMzNhMTZhOGRjOTNjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Nj cmVlblF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1NjcmVlblF0LmNwcApAQCAtMjMs MTggKzIzLDE4IEBACiAgKiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VW RVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCiAgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKICAqIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICog T0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBT VUNIIERBTUFHRS4gCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIK ICNpbmNsdWRlICJTY3JlZW4uaCIKIAotI2luY2x1ZGUgIlBhZ2UuaCIKKyNpbmNsdWRlICJGbG9h dFJlY3QuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgotI2lu Y2x1ZGUgIldpZGdldC5oIgogI2luY2x1ZGUgIkludFJlY3QuaCIKLSNpbmNsdWRlICJGbG9hdFJl Y3QuaCIKKyNpbmNsdWRlICJQYWdlLmgiCisjaW5jbHVkZSAiV2lkZ2V0LmgiCiAKICNpbmNsdWRl IDxRQXBwbGljYXRpb24+CiAjaW5jbHVkZSA8UURlc2t0b3BXaWRnZXQ+Cg==