39763 2010-05-26 13:27:32 -0700 [Qt] SharedTimerQt.cpp has coding-style errors 2010-06-04 22:51:47 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230842 0 agbakken 2010-05-26 13:27:32 -0700 WebCore/platform/qt/SharedTimerQt.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/qt/SharedTimerQt.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 1 files 230906 1 57143 agbakken 2010-05-26 14:35:04 -0700 Created attachment 57143 Patch that fixes the coding style issues 231079 2 peojala11 2010-05-26 21:42:45 -0700 QtTriaged 231397 3 57143 levin 2010-05-27 11:20:20 -0700 Comment on attachment 57143 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234465 4 57938 agbakken 2010-06-04 18:43:22 -0700 Created attachment 57938 Patch 234514 5 57938 eric 2010-06-04 22:00:57 -0700 Comment on attachment 57938 Patch LGTM. 234539 6 57938 commit-queue 2010-06-04 22:51:40 -0700 Comment on attachment 57938 Patch Clearing flags on attachment: 57938 Committed r60736: <http://trac.webkit.org/changeset/60736> 234540 7 commit-queue 2010-06-04 22:51:47 -0700 All reviewed patches have been landed. Closing bug. 57143 2010-05-26 14:35:04 -0700 2010-06-04 18:43:16 -0700 Patch that fixes the coding style issues patch.39763 text/plain 1353 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2hhcmVkVGltZXJRdC5jcHAgaGFzIGNvZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NzYzCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0LmNw cDoKKwogMjAxMC0wNS0yNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgT2phbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvU2hhcmVkVGlt ZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9TaGFyZWRUaW1lclF0 LmNwcAkocmV2aXNpb24gNjAyNDcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L1NoYXJlZFRpbWVy UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNCwxOCArMjQsMTcgQEAKICAqIFBST0ZJVFM7IE9S IEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkK ICAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwg T1IgVE9SVAogICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJ TiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFE VklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLiAKKyAqIE9GIFRISVMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CiAgKi8KIAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAKLSNpbmNsdWRlIDx3dGYvQ3VycmVudFRp bWUuaD4KLQogI2luY2x1ZGUgPFFCYXNpY1RpbWVyPgogI2luY2x1ZGUgPFFDb3JlQXBwbGljYXRp b24+CiAjaW5jbHVkZSA8UURlYnVnPgogI2luY2x1ZGUgPFFQb2ludGVyPgorI2luY2x1ZGUgPHd0 Zi9DdXJyZW50VGltZS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK 57938 2010-06-04 18:43:22 -0700 2010-06-04 22:51:40 -0700 Patch bug-39763-20100604184320.patch text/plain 1411 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uYmZlYjNiZjUxZDY3MzQ3 MWZjMzhjMzliMTVmZjZmNjEyNWI5MTlhZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNoYXJlZFRpbWVyUXQuY3BwIGhhcyBjb2Rp bmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTc2MworCisgICAgICAgICogcGxhdGZvcm0vcXQvU2hhcmVkVGltZXJRdC5jcHA6 CisKIDIwMTAtMDYtMDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vcXQvU2hhcmVkVGltZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1NoYXJlZFRp bWVyUXQuY3BwCmluZGV4IDdjMGZkMDUxMWQ2MTJkZDk2YmZmMmJhNzkwYmQ0MjI2Y2I5ZGVlMTUu LjhhNmJkODE5NDhjY2ViZjgzMzM4ZDMyMmE5YTE0NjE4MDQwMGNmMmQgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vcXQvU2hhcmVkVGltZXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9xdC9TaGFyZWRUaW1lclF0LmNwcApAQCAtMjQsMTggKzI0LDE3IEBACiAgKiBQUk9GSVRTOyBP UiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZ CiAgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFks IE9SIFRPUlQKICAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcg SU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4gCisgKiBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogICovCiAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgogCi0jaW5jbHVkZSA8d3RmL0N1cnJlbnRU aW1lLmg+Ci0KICNpbmNsdWRlIDxRQmFzaWNUaW1lcj4KICNpbmNsdWRlIDxRQ29yZUFwcGxpY2F0 aW9uPgogI2luY2x1ZGUgPFFEZWJ1Zz4KICNpbmNsdWRlIDxRUG9pbnRlcj4KKyNpbmNsdWRlIDx3 dGYvQ3VycmVudFRpbWUuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCg==