39762 2010-05-26 13:27:01 -0700 [Qt] SoundQt.cpp has coding-style errors 2010-06-04 22:14:53 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue levin peojala11 oldest_to_newest 230841 0 agbakken 2010-05-26 13:27:01 -0700 WebCore/platform/qt/SoundQt.cpp:30: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/qt/SoundQt.cpp:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 1 files 230903 1 57142 agbakken 2010-05-26 14:34:41 -0700 Created attachment 57142 Patch that fixes the coding style issues 231078 2 peojala11 2010-05-26 21:42:00 -0700 QtTriaged 231398 3 57142 levin 2010-05-27 11:20:30 -0700 Comment on attachment 57142 Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. 234463 4 57936 agbakken 2010-06-04 18:42:08 -0700 Created attachment 57936 Patch 234513 5 57936 eric 2010-06-04 22:00:28 -0700 Comment on attachment 57936 Patch LGTM. 234525 6 57936 commit-queue 2010-06-04 22:14:47 -0700 Comment on attachment 57936 Patch Clearing flags on attachment: 57936 Committed r60733: <http://trac.webkit.org/changeset/60733> 234526 7 commit-queue 2010-06-04 22:14:53 -0700 All reviewed patches have been landed. Closing bug. 57142 2010-05-26 14:34:41 -0700 2010-06-04 18:42:03 -0700 Patch that fixes the coding style issues patch.39762 text/plain 894 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U291bmRRdC5jcHAgaGFzIGNvZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NzYyCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Tb3VuZFF0LmNwcDoKKwogMjAxMC0w NS0yNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgT2phbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvU291bmRRdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9Tb3VuZFF0LmNwcAkocmV2aXNpb24gNjAyNDcpCisr KyBXZWJDb3JlL3BsYXRmb3JtL3F0L1NvdW5kUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiwx MSArMjYsMTAgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiU291bmQu aCIKIAogI2luY2x1ZGUgPFFBcHBsaWNhdGlvbj4KIAotI2luY2x1ZGUgIlNvdW5kLmgiCi0KIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBzeXN0ZW1CZWVwKCkK 57936 2010-06-04 18:42:08 -0700 2010-06-04 22:14:46 -0700 Patch bug-39762-20100604184207.patch text/plain 946 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uNDNhMzVhZGVmNTc3M2E3 ZGZiMmNmOWZlZWJiMWMzMGQ3ZWNiMTdlNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNvdW5kUXQuY3BwIGhhcyBjb2Rpbmctc3R5 bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zOTc2MgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU291bmRRdC5jcHA6CisKIDIwMTAtMDYt MDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvU291 bmRRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1NvdW5kUXQuY3BwCmluZGV4IDA5OTYzMjhk ZDAzNzhhNGUxODU1NmRlMTdhODE3MjM1NTkyN2FjOGMuLmJmOWUxNDI2YWYwYzhkMmI4ZmNjMmNl YzY2NDQyOTE2MTk2Y2ZmM2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvU291bmRR dC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Tb3VuZFF0LmNwcApAQCAtMjYsMTEgKzI2 LDEwIEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlNvdW5kLmgiCiAK ICNpbmNsdWRlIDxRQXBwbGljYXRpb24+CiAKLSNpbmNsdWRlICJTb3VuZC5oIgotCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIHZvaWQgc3lzdGVtQmVlcCgpCg==