39761 2010-05-26 13:25:46 -0700 TemporaryLinkStubsQt.cpp has coding-style errors 2010-06-04 22:27:57 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue eric levin ossy peojala11 oldest_to_newest 230838 0 agbakken 2010-05-26 13:25:46 -0700 WebCore/platform/qt/TemporaryLinkStubsQt.cpp:35: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:43: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:46: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:47: "Cursor.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:39 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:49: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:51: "GraphicsContext.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:46 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:53: "IntPoint.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:44 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:56: "loader.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:48 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:57: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:69: "Widget.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:45 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:72: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 12 in 1 files 230902 1 57141 agbakken 2010-05-26 14:34:08 -0700 Created attachment 57141 Patch that fixes the coding style issues 231030 2 levin 2010-05-26 18:16:13 -0700 "No new tests. (OOPS!)" issue again. 231077 3 peojala11 2010-05-26 21:41:30 -0700 QtTriaged 234462 4 57935 agbakken 2010-06-04 18:37:39 -0700 Created attachment 57935 Patch 234524 5 57935 eric 2010-06-04 22:14:37 -0700 Comment on attachment 57935 Patch I wonder if all these includes are still needed. The Qt port is mature enough it shouldn't really have a TemporaryLinkStubs file anymore. 234531 6 57935 commit-queue 2010-06-04 22:27:51 -0700 Comment on attachment 57935 Patch Clearing flags on attachment: 57935 Committed r60734: <http://trac.webkit.org/changeset/60734> 234532 7 commit-queue 2010-06-04 22:27:57 -0700 All reviewed patches have been landed. Closing bug. 57141 2010-05-26 14:34:08 -0700 2010-06-04 18:37:35 -0700 Patch that fixes the coding style issues patch.39761 text/plain 1781 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGVtcG9yYXJ5TGlua1N0dWJzUXQuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc2MQorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvVGVtcG9yYXJ5 TGlua1N0dWJzUXQuY3BwOgorCiAyMDEwLTA1LTI2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPamFuLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9xdC9UZW1wb3JhcnlMaW5rU3R1YnNRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9xdC9UZW1wb3JhcnlMaW5rU3R1YnNRdC5jcHAJKHJldmlzaW9uIDYwMjQ3KQorKysgV2Vi Q29yZS9wbGF0Zm9ybS9xdC9UZW1wb3JhcnlMaW5rU3R1YnNRdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTMzLDI3ICszMywyMSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogCiAjaW5jbHVkZSAiQVhP YmplY3RDYWNoZS5oIgotI2luY2x1ZGUgIkROUy5oIgogI2luY2x1ZGUgIkNhY2hlZFJlc291cmNl LmgiCiAjaW5jbHVkZSAiQ29va2llSmFyLmgiCiAjaW5jbHVkZSAiQ3Vyc29yLmgiCisjaW5jbHVk ZSAiRE5TLmgiCisjaW5jbHVkZSAiRlRQRGlyZWN0b3J5RG9jdW1lbnQuaCIKKyNpbmNsdWRlICJG aWxlU3lzdGVtLmgiCiAjaW5jbHVkZSAiRm9udC5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5j bHVkZSAiRnJhbWVMb2FkZXIuaCIKLSNpbmNsdWRlICJGVFBEaXJlY3RvcnlEb2N1bWVudC5oIgot I2luY2x1ZGUgIkludFBvaW50LmgiCi0jaW5jbHVkZSAiV2lkZ2V0LmgiCi0jaW5jbHVkZSAiR3Jh cGhpY3NDb250ZXh0LmgiCi0jaW5jbHVkZSAiQ3Vyc29yLmgiCi0jaW5jbHVkZSAibG9hZGVyLmgi Ci0jaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1 ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkljb25Mb2FkZXIuaCIKICNpbmNsdWRl ICJJbnRQb2ludC5oIgogI2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJMYW5ndWFnZS5oIgot I2luY2x1ZGUgImxvYWRlci5oIgogI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKICNpbmNs dWRlICJOb2RlLmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKQEAgLTY3LDkgKzYxLDEx IEBACiAjaW5jbHVkZSAiU3lzdGVtVGltZS5oIgogI2luY2x1ZGUgIlRleHRCb3VuZGFyaWVzLmgi CiAjaW5jbHVkZSAiV2lkZ2V0LmgiCisjaW5jbHVkZSAibG9hZGVyLmgiCisKKyNpbmNsdWRlIDxm bG9hdC5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+Ci0jaW5jbHVk ZSA8ZmxvYXQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIHVzaW5nIG5hbWVz cGFjZSBXZWJDb3JlOwo= 57935 2010-06-04 18:37:39 -0700 2010-06-04 22:27:50 -0700 Patch bug-39761-20100604183738.patch text/plain 1841 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uNmE5MmU2OTcxNTNmZTBi ZWIxMzE0ODYyNmQ4M2U0ZDhmYzU1M2RlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZW1wb3JhcnlMaW5rU3R1YnNRdC5jcHAgaGFzIGNv ZGluZy1zdHlsZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM5NzYxCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9UZW1wb3JhcnlMaW5rU3R1 YnNRdC5jcHA6CisKIDIwMTAtMDYtMDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vcXQvVGVtcG9yYXJ5TGlua1N0dWJzUXQuY3BwIGIvV2ViQ29yZS9wbGF0 Zm9ybS9xdC9UZW1wb3JhcnlMaW5rU3R1YnNRdC5jcHAKaW5kZXggNDMyYmQyYjNjNjU4YTMzODc1 NjI4MGZjZTdmY2U3ZDg4ZDUzNjk4Yi4uNTFlMjViOGZkNTM3YjQ0MDQwNzhhMDUzNjMzZDZiOTJm MjE4YTM0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9UZW1wb3JhcnlMaW5rU3R1 YnNRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9UZW1wb3JhcnlMaW5rU3R1YnNRdC5j cHAKQEAgLTMzLDI3ICszMywyMSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogCiAjaW5jbHVkZSAi QVhPYmplY3RDYWNoZS5oIgotI2luY2x1ZGUgIkROUy5oIgogI2luY2x1ZGUgIkNhY2hlZFJlc291 cmNlLmgiCiAjaW5jbHVkZSAiQ29va2llSmFyLmgiCiAjaW5jbHVkZSAiQ3Vyc29yLmgiCisjaW5j bHVkZSAiRE5TLmgiCisjaW5jbHVkZSAiRlRQRGlyZWN0b3J5RG9jdW1lbnQuaCIKKyNpbmNsdWRl ICJGaWxlU3lzdGVtLmgiCiAjaW5jbHVkZSAiRm9udC5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAj aW5jbHVkZSAiRnJhbWVMb2FkZXIuaCIKLSNpbmNsdWRlICJGVFBEaXJlY3RvcnlEb2N1bWVudC5o IgotI2luY2x1ZGUgIkludFBvaW50LmgiCi0jaW5jbHVkZSAiV2lkZ2V0LmgiCi0jaW5jbHVkZSAi R3JhcGhpY3NDb250ZXh0LmgiCi0jaW5jbHVkZSAiQ3Vyc29yLmgiCi0jaW5jbHVkZSAibG9hZGVy LmgiCi0jaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2lu Y2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkljb25Mb2FkZXIuaCIKICNpbmNs dWRlICJJbnRQb2ludC5oIgogI2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJMYW5ndWFnZS5o IgotI2luY2x1ZGUgImxvYWRlci5oIgogI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKICNp bmNsdWRlICJOb2RlLmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKQEAgLTY3LDkgKzYx LDExIEBACiAjaW5jbHVkZSAiU3lzdGVtVGltZS5oIgogI2luY2x1ZGUgIlRleHRCb3VuZGFyaWVz LmgiCiAjaW5jbHVkZSAiV2lkZ2V0LmgiCisjaW5jbHVkZSAibG9hZGVyLmgiCisKKyNpbmNsdWRl IDxmbG9hdC5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+Ci0jaW5j bHVkZSA8ZmxvYXQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIHVzaW5nIG5h bWVzcGFjZSBXZWJDb3JlOwo=