39759 2010-05-26 13:23:59 -0700 WidgetQt.cpp has coding-style errors 2010-06-04 22:39:54 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue peojala11 oldest_to_newest 230836 0 agbakken 2010-05-26 13:23:59 -0700 WebCore/platform/qt/WidgetQt.cpp:41: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/WidgetQt.cpp:50: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/WidgetQt.cpp:52: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 1 files 230900 1 57139 agbakken 2010-05-26 14:33:02 -0700 Created attachment 57139 Patch that fixes the coding style issues 231021 2 57139 levin 2010-05-26 17:52:22 -0700 Comment on attachment 57139 Patch that fixes the coding style issues > + > + No new tests. (OOPS!) You need to remove this. Instead in this case, it should say something like "No functionality change, so no new tests." 231075 3 peojala11 2010-05-26 21:40:30 -0700 QtTriaged 234461 4 57934 agbakken 2010-06-04 18:34:13 -0700 Created attachment 57934 Patch 234533 5 57934 commit-queue 2010-06-04 22:39:49 -0700 Comment on attachment 57934 Patch Clearing flags on attachment: 57934 Committed r60735: <http://trac.webkit.org/changeset/60735> 234534 6 commit-queue 2010-06-04 22:39:54 -0700 All reviewed patches have been landed. Closing bug. 57139 2010-05-26 14:33:02 -0700 2010-06-04 18:34:10 -0700 Patch that fixes the coding style issues patch.39759 text/plain 1187 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2lkZ2V0UXQuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc1OQorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvV2lkZ2V0UXQuY3BwOgorCiAyMDEw LTA1LTI2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPamFuLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaWRnZXRRdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaWRnZXRRdC5jcHAJKHJldmlzaW9uIDYwMjQ3 KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaWRnZXRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTM3LDE5ICszNywxOCBAQAogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUg Ikhvc3RXaW5kb3cuaCIKICNpbmNsdWRlICJJbnRSZWN0LmgiCi0jaW5jbHVkZSAiU2Nyb2xsVmll dy5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUVdlYlBhZ2VDbGll bnQuaCIKKyNpbmNsdWRlICJTY3JvbGxWaWV3LmgiCiAKICNpbmNsdWRlICJxd2ViZnJhbWUuaCIK ICNpbmNsdWRlICJxd2ViZnJhbWVfcC5oIgogI2luY2x1ZGUgInF3ZWJwYWdlLmgiCiAKICNpbmNs dWRlIDxRQ29yZUFwcGxpY2F0aW9uPgotI2luY2x1ZGUgPFFQYWludGVyPgotI2luY2x1ZGUgPFFQ YWludEVuZ2luZT4KLQogI2luY2x1ZGUgPFFEZWJ1Zz4KKyNpbmNsdWRlIDxRUGFpbnRFbmdpbmU+ CisjaW5jbHVkZSA8UVBhaW50ZXI+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAo= 57934 2010-06-04 18:34:13 -0700 2010-06-04 22:39:48 -0700 Patch bug-39759-20100604183412.patch text/plain 1235 agbakken ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZiN2VkMmU2ZTdjZGYwNjc1MTQxY2M5ZTA3MjU4YjQzNTVkYTljYy4uZDcwZjRjMDc1YzFkNDc5 ZDMyMDYxODRiZjI1NDBkMTUzZTcwNTRmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wNCAgQW5k ZXJzIEJha2tlbiAgPGFnYmFra2VuQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaWRnZXRRdC5jcHAgaGFzIGNvZGluZy1zdHlsZSBl cnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5 NzU5CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9XaWRnZXRRdC5jcHA6CisKIDIwMTAtMDYtMDQg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBH YXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvV2lkZ2V0 UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaWRnZXRRdC5jcHAKaW5kZXggNDMyNTJhOGM0 ZjEzZTBkNmJkODYwNTZiMzdkNGUyMmZjZWI5NjcwZS4uMDM4YTA3ZjYzNGZlY2U0MzVjNjUyYjIy N2ZmNWZiN2RlZWQ3ZGRiNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaWRnZXRR dC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaWRnZXRRdC5jcHAKQEAgLTM3LDE5ICsz NywxOCBAQAogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkhvc3RXaW5k b3cuaCIKICNpbmNsdWRlICJJbnRSZWN0LmgiCi0jaW5jbHVkZSAiU2Nyb2xsVmlldy5oIgogI2lu Y2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUVdlYlBhZ2VDbGllbnQuaCIKKyNp bmNsdWRlICJTY3JvbGxWaWV3LmgiCiAKICNpbmNsdWRlICJxd2ViZnJhbWUuaCIKICNpbmNsdWRl ICJxd2ViZnJhbWVfcC5oIgogI2luY2x1ZGUgInF3ZWJwYWdlLmgiCiAKICNpbmNsdWRlIDxRQ29y ZUFwcGxpY2F0aW9uPgotI2luY2x1ZGUgPFFQYWludGVyPgotI2luY2x1ZGUgPFFQYWludEVuZ2lu ZT4KLQogI2luY2x1ZGUgPFFEZWJ1Zz4KKyNpbmNsdWRlIDxRUGFpbnRFbmdpbmU+CisjaW5jbHVk ZSA8UVBhaW50ZXI+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAo=