39758 2010-05-26 12:59:00 -0700 Heap::allocate should search a word at a time 2010-05-27 14:45:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 nlawrence nlawrence commit-queue ggaren nlawrence slewis oldest_to_newest 230823 0 nlawrence 2010-05-26 12:59:00 -0700 Currently, Heap::allocate is searching for a new cell in the bitmap a single bit at a time. This can be improved by searching a word at a time in the bitmap when our first guess fails. 230825 1 57126 nlawrence 2010-05-26 13:00:03 -0700 Created attachment 57126 suggested patch 230833 2 57126 ggaren 2010-05-26 13:10:20 -0700 Comment on attachment 57126 suggested patch + if (!~block->marked.bits[m_heap.nextCell >> 5]) + m_heap.nextCell = (m_heap.nextCell & (~0x1F)) + 32; I think this code might be wrong on 64bit. Also, would be nice to encapsulate these bitops in the CollectorBitmap interface. Let's talk about this in person. 230878 3 57132 nlawrence 2010-05-26 14:04:56 -0700 Created attachment 57132 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. Hey, I uploaded the patch to the correct bug this time! 230882 4 57132 ggaren 2010-05-26 14:10:59 -0700 Comment on attachment 57132 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. r=me 231437 5 57132 ggaren 2010-05-27 13:30:05 -0700 Comment on attachment 57132 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. Let's have auto-Eric take a crack at committing this. 231472 6 57132 commit-queue 2010-05-27 14:45:22 -0700 Comment on attachment 57132 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. Clearing flags on attachment: 57132 Committed r60323: <http://trac.webkit.org/changeset/60323> 231473 7 commit-queue 2010-05-27 14:45:28 -0700 All reviewed patches have been landed. Closing bug. 57126 2010-05-26 13:00:03 -0700 2010-05-26 14:04:56 -0700 suggested patch nlawrence-jsc-wordalloc.patch text/plain 748 nlawrence SW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAJKHJldmlzaW9uIDYwMTc2KQor KysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zOTQsNyArMzk0LDExIEBAIGFsbG9jYXRlOgogICAgICAgICAgICAgICAgICsrbV9oZWFwLm5l eHRDZWxsOwogICAgICAgICAgICAgICAgIHJldHVybiBjZWxsOwogICAgICAgICAgICAgfQotICAg ICAgICB9IHdoaWxlICgrK21faGVhcC5uZXh0Q2VsbCAhPSBIZWFwQ29uc3RhbnRzOjpjZWxsc1Bl ckJsb2NrKTsKKyAgICAgICAgICAgIGlmICghfmJsb2NrLT5tYXJrZWQuYml0c1ttX2hlYXAubmV4 dENlbGwgPj4gNV0pCisgICAgICAgICAgICAgICAgbV9oZWFwLm5leHRDZWxsID0gKG1faGVhcC5u ZXh0Q2VsbCAmICh+MHgxRikpICsgMzI7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgKyttX2hlYXAubmV4dENlbGw7CisgICAgICAgIH0gd2hpbGUgKG1faGVhcC5uZXh0Q2VsbCAh PSBIZWFwQ29uc3RhbnRzOjpjZWxsc1BlckJsb2NrKTsKICAgICAgICAgbV9oZWFwLm5leHRDZWxs ID0gMDsKICAgICB9IHdoaWxlICgrK21faGVhcC5uZXh0QmxvY2sgIT0gbV9oZWFwLnVzZWRCbG9j a3MpOwogCg== 57132 2010-05-26 14:04:56 -0700 2010-05-27 14:45:22 -0700 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. nlawrence-jsc-wordalloc.patch text/plain 2166 nlawrence SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYwMjQ1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMjYgIE5hdGhhbiBM YXdyZW5jZSAgPG5sYXdyZW5jZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2Vv ZmZyZXkgR2FyZW4uCisKKyAgICAgICAgU2VhcmNoIGZvciB0aGUgbmV3IGFsbG9jYXRpb24gb25l IHdvcmQgYXQgYSB0aW1lLiAgSW1wcm92ZXMKKyAgICAgICAgcGVyZm9ybWFuY2Ugb24gU3VuU3Bp ZGVyIGJ5IGFwcHJveGltYXRlbHkgMSUuCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM5NzU4CisKKyAgICAgICAgKiBydW50aW1lL0NvbGxlY3Rvci5jcHA6 CisgICAgICAgIChKU0M6OkhlYXA6OmFsbG9jYXRlKToKKyAgICAgICAgKiBydW50aW1lL0NvbGxl Y3Rvci5oOgorICAgICAgICAoSlNDOjpDb2xsZWN0b3JCaXRtYXA6OmFkdmFuY2VUb05leHRQb3Nz aWJsZUZyZWVDZWxsKToKKwogMjAxMC0wNS0yNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBw bGUuY29tPgogCiAgICAgICAgIEZpeGVkIGJ1aWxkIGZhaWx1cmUgY2F1c2VkIGJ5IG1lcmdlLgpJ bmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmNwcAkocmV2aXNpb24gNjAxNzYpCisr KyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTM5NCw3ICszOTQsOCBAQCBhbGxvY2F0ZToKICAgICAgICAgICAgICAgICArK21faGVhcC5uZXh0 Q2VsbDsKICAgICAgICAgICAgICAgICByZXR1cm4gY2VsbDsKICAgICAgICAgICAgIH0KLSAgICAg ICAgfSB3aGlsZSAoKyttX2hlYXAubmV4dENlbGwgIT0gSGVhcENvbnN0YW50czo6Y2VsbHNQZXJC bG9jayk7CisgICAgICAgICAgICBibG9jay0+bWFya2VkLmFkdmFuY2VUb05leHRQb3NzaWJsZUZy ZWVDZWxsKG1faGVhcC5uZXh0Q2VsbCk7CisgICAgICAgIH0gd2hpbGUgKG1faGVhcC5uZXh0Q2Vs bCAhPSBIZWFwQ29uc3RhbnRzOjpjZWxsc1BlckJsb2NrKTsKICAgICAgICAgbV9oZWFwLm5leHRD ZWxsID0gMDsKICAgICB9IHdoaWxlICgrK21faGVhcC5uZXh0QmxvY2sgIT0gbV9oZWFwLnVzZWRC bG9ja3MpOwogCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmgJKHJldmlzaW9uIDYw MTc2KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuaAkod29ya2luZyBjb3B5 KQpAQCAtMjIwLDYgKzIyMCwxMyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdm9pZCBzZXQo c2l6ZV90IG4pIHsgYml0c1tuID4+IDVdIHw9ICgxIDw8IChuICYgMHgxRikpOyB9IAogICAgICAg ICB2b2lkIGNsZWFyKHNpemVfdCBuKSB7IGJpdHNbbiA+PiA1XSAmPSB+KDEgPDwgKG4gJiAweDFG KSk7IH0gCiAgICAgICAgIHZvaWQgY2xlYXJBbGwoKSB7IG1lbXNldChiaXRzLCAwLCBzaXplb2Yo Yml0cykpOyB9CisgICAgICAgIEFMV0FZU19JTkxJTkUgdm9pZCBhZHZhbmNlVG9OZXh0UG9zc2li bGVGcmVlQ2VsbChzaXplX3QmIHN0YXJ0Q2VsbCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYg KCF+Yml0c1tzdGFydENlbGwgPj4gNV0pCisgICAgICAgICAgICAgICAgc3RhcnRDZWxsID0gKHN0 YXJ0Q2VsbCAmICh+MHgxRikpICsgMzI7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgKytzdGFydENlbGw7CisgICAgICAgIH0KICAgICAgICAgc2l6ZV90IGNvdW50KHNpemVfdCBz dGFydENlbGwgPSAwKQogICAgICAgICB7CiAgICAgICAgICAgICBzaXplX3QgcmVzdWx0ID0gMDsK