39756 2010-05-26 11:59:00 -0700 Must not cast between CFNumberRef and CFBooleanRef 2010-05-26 12:08:18 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 230807 0 eric.carlson 2010-05-26 11:59:00 -0700 CoreFoundation toll-free bridging assumes that if the value passed to CFBooleanGetValue is not a CFBooleanRef, it is some objc value and calls objc_msgSend to get the -boolValue. QTMovieVisualContext::getCGImageOptions adds a CFNumberRef with a value of 1 to a dictionary for a key that is expected to be a CFBoolean, it should add kCFBooleanTrue instead. 230808 1 eric.carlson 2010-05-26 11:59:31 -0700 <rdar://problem/8030739> 230810 2 57124 eric.carlson 2010-05-26 12:02:26 -0700 Created attachment 57124 proposed patch 230812 3 eric.carlson 2010-05-26 12:08:18 -0700 http://trac.webkit.org/changeset/60245 57124 2010-05-26 12:02:26 -0700 2010-05-26 12:05:17 -0700 proposed patch cfboolean_patch.txt text/plain 1533 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMjYgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTXVzdCBub3QgY2FzdCBiZXR3ZWVuIENGTnVtYmVyUmVmIGFuZCBDRkJvb2xlYW5SZWYuCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MDMwNzM5PiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NzU2CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy93aW4vUVRNb3ZpZVZpc3VhbENvbnRleHQuY3BwOgorICAgICAgICAoUVRNb3ZpZVZpc3Vh bENvbnRleHQ6OmdldENHSW1hZ2VPcHRpb25zKTogUXVpY2tUaW1lIGFzc3VtZXMgdGhhdCB0aGUg dmFsdWUgYXNzb2NpYXRlZCAKKyAgICAgICAgd2l0aCBrQ1ZQaXhlbEJ1ZmZlckNHSW1hZ2VDb21w YXRpYmlsaXR5S2V5IGlzIGEgQ0ZCb29sZWFuLCBzbyBhZGQgb25lLgorCiAyMDEwLTA1LTI2ICBY YW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBHVEsrIGJ1aWxkIGZpeCwg c3RyaWtlIHR3by4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1FUTW92aWVW aXN1YWxDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3dpbi9RVE1vdmllVmlzdWFsQ29udGV4dC5jcHAJKHJldmlzaW9uIDYwMTc5KQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vUVRNb3ZpZVZpc3VhbENvbnRleHQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xODcsNyArMTg3LDcgQEAgQ0ZEaWN0aW9uYXJ5UmVmIFFUTW92aWVWaXN1YWxD b250ZXh0OjpnZQogICAgICAgICBTZXROdW1iZXJWYWx1ZShwaXhlbEJ1ZmZlck9wdGlvbnMsIGtD VlBpeGVsQnVmZmVyQnl0ZXNQZXJSb3dBbGlnbm1lbnRLZXksIDE2KTsKIAogICAgICAgICAvLyBj b21wYXRhYmlsaXR5Ci0gICAgICAgIFNldE51bWJlclZhbHVlKHBpeGVsQnVmZmVyT3B0aW9ucywg a0NWUGl4ZWxCdWZmZXJDR0ltYWdlQ29tcGF0aWJpbGl0eUtleSwgMSk7CisgICAgICAgIENGRGlj dGlvbmFyeVNldFZhbHVlKHBpeGVsQnVmZmVyT3B0aW9ucywga0NWUGl4ZWxCdWZmZXJDR0ltYWdl Q29tcGF0aWJpbGl0eUtleSwga0NGQm9vbGVhblRydWUpOwogICAgICAKICAgICAgICAgLy8gUVQg VmlzdWFsIENvbnRleHQgYXR0cmlidXRlcwogICAgICAgICB2aXN1YWxDb250ZXh0T3B0aW9ucyA9 IENGRGljdGlvbmFyeUNyZWF0ZU11dGFibGUoa0NGQWxsb2NhdG9yRGVmYXVsdCwgMCwK