39752 2010-05-26 10:40:22 -0700 [chromium] Windows key should be supported by NativeWebKeyboardEvent 2010-06-04 11:49:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue hbono webkit.review.bot oldest_to_newest 230766 0 jcivelli 2010-05-26 10:40:22 -0700 The left and right Windows keys (VK_LWIN and VK_RWIN) should be supported by NativeWebKeyboardEvent. 230769 1 57116 jcivelli 2010-05-26 10:57:21 -0700 Created attachment 57116 First version of patch 230795 2 webkit.review.bot 2010-05-26 11:35:39 -0700 Attachment 57116 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 Last 3072 characters of output: e comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:183: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:184: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:185: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:186: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:187: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:188: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:189: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:190: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:191: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:192: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:193: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:194: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:195: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:196: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:197: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:198: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:199: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:200: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:201: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:202: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:203: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:204: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:205: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:206: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/src/gtk/WebInputEventFactory.cpp:207: One space before end of line comments [whitespace/comments] [5] Total errors found: 54 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 230874 3 jcivelli 2010-05-26 13:55:49 -0700 I believe the style of the CL is OK. It is complaining that there is more than 1 space before the // comment, but I am just being consistent with the file style (aligning all // comments). 234310 4 57116 commit-queue 2010-06-04 11:49:02 -0700 Comment on attachment 57116 First version of patch Clearing flags on attachment: 57116 Committed r60692: <http://trac.webkit.org/changeset/60692> 234311 5 commit-queue 2010-06-04 11:49:08 -0700 All reviewed patches have been landed. Closing bug. 57116 2010-05-26 10:57:21 -0700 2010-06-04 11:49:02 -0700 First version of patch win_keys.patch text/plain 4686 jcivelli SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjYgIEpheSBDaXZlbGxpICA8amNpdmVsbGlAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtjaHJvbWl1bV0gQWRkaW5nIHN1cHBvcnQgZm9yIHRoZSBsZWZ0IGFuZCByaWdodCBXaW5kb3dz IGtleXMgdG8gdGhlCisgICAgICAgICAgICAgICAgICAgTmF0aXZlV2ViS2V5Ym9hcmRFdmVudC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NzUyCisK KyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lvbkd0ay5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjp3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KToKKwogMjAxMC0wNS0y NiAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmll d2VkIGJ1aWxkIGZpeCBmb3IgV2luZG93cyArIGNsZWFuIHVwIHRoZSBWaXN1YWwgU3R1ZGlvIHBy b2plY3QuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVDb252ZXJzaW9u R3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVD b252ZXJzaW9uR3RrLmNwcAkocmV2aXNpb24gNjAyNDIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2No cm9taXVtL0tleUNvZGVDb252ZXJzaW9uR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc2LDgg KzI3NiwxMCBAQCBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBrCiAgICAg Y2FzZSBHREtfWjoKICAgICAgICAgcmV0dXJuIFZLRVlfWjsgLy8gICg1QSkgWiBrZXkgY2FzZSAn eic6IGNhc2UgJ1onOiByZXR1cm4gMHg1QTsKICAgICBjYXNlIEdES19NZXRhX0w6CisgICAgY2Fz ZSBHREtfU3VwZXJfTDoKICAgICAgICAgcmV0dXJuIFZLRVlfTFdJTjsgLy8gKDVCKSBMZWZ0IFdp bmRvd3Mga2V5IChNaWNyb3NvZnQgTmF0dXJhbCBrZXlib2FyZCkKICAgICBjYXNlIEdES19NZXRh X1I6CisgICAgY2FzZSBHREtfU3VwZXJfUjoKICAgICAgICAgcmV0dXJuIFZLRVlfUldJTjsgLy8g KDVDKSBSaWdodCBXaW5kb3dzIGtleSAoTmF0dXJhbCBrZXlib2FyZCkKICAgICAgICAgLy8gVktF WV9TTEVFUCAoNUYpIENvbXB1dGVyIFNsZWVwIGtleQogICAgICAgICAvLyBWS0VZX1NFUEFSQVRP UiAoNkMpIFNlcGFyYXRvciBrZXkKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjAyNDIpCisr KyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDUtMjYgIEpheSBDaXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0g QWRkaW5nIHN1cHBvcnQgZm9yIHRoZSBsZWZ0IGFuZCByaWdodCBXaW5kb3dzIGtleXMgdG8gdGhl CisgICAgICAgICAgICAgICAgICAgTmF0aXZlV2ViS2V5Ym9hcmRFdmVudC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NzUyCisKKyAgICAgICAgKiBz cmMvZ3RrL1dlYklucHV0RXZlbnRGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Z2RrRXZl bnRUb1dpbmRvd3NLZXlDb2RlKToKKwogMjAxMC0wNS0yNiAgSmVyZW15IE9ybG93ICA8am9ybG93 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGNocm9taXVtIGJ1aWxkIGZpeApJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9ndGsvV2ViSW5wdXRFdmVudEZhY3RvcnkuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvZ3RrL1dlYklucHV0RXZlbnRGYWN0b3J5 LmNwcAkocmV2aXNpb24gNjAyNDIpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL2d0ay9XZWJJbnB1 dEV2ZW50RmFjdG9yeS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MSw2ICsxNTEsNjAgQEAgc3Rh dGljIGludCBnZGtFdmVudFRvV2luZG93c0tleUNvZGUoY29ucwogICAgICAgICBHREtfcGVyaW9k LCAgICAgICAgLy8gMHgzQzogR0RLX3BlcmlvZAogICAgICAgICBHREtfc2xhc2gsICAgICAgICAg Ly8gMHgzRDogR0RLX3NsYXNoCiAgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDNFOiBH REtfU2hpZnRfUgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHgzRjoKKyAgICAgICAg MCwgICAgICAgICAgICAgICAgIC8vIDB4NDA6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAv LyAweDQxOgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg0MjoKKyAgICAgICAgMCwg ICAgICAgICAgICAgICAgIC8vIDB4NDM6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAw eDQ0OgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg0NToKKyAgICAgICAgMCwgICAg ICAgICAgICAgICAgIC8vIDB4NDY6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDQ3 OgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg0ODoKKyAgICAgICAgMCwgICAgICAg ICAgICAgICAgIC8vIDB4NDk6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDRBOgor ICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg0QjoKKyAgICAgICAgMCwgICAgICAgICAg ICAgICAgIC8vIDB4NEM6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDREOgorICAg ICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg0RToKKyAgICAgICAgMCwgICAgICAgICAgICAg ICAgIC8vIDB4NEY6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDUwOgorICAgICAg ICAwLCAgICAgICAgICAgICAgICAgLy8gMHg1MToKKyAgICAgICAgMCwgICAgICAgICAgICAgICAg IC8vIDB4NTI6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDUzOgorICAgICAgICAw LCAgICAgICAgICAgICAgICAgLy8gMHg1NDoKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8v IDB4NTU6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDU2OgorICAgICAgICAwLCAg ICAgICAgICAgICAgICAgLy8gMHg1NzoKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4 NTg6CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDU5OgorICAgICAgICAwLCAgICAg ICAgICAgICAgICAgLy8gMHg1QToKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4NUI6 CisgICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDVDOgorICAgICAgICAwLCAgICAgICAg ICAgICAgICAgLy8gMHg1RDoKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4NUU6Cisg ICAgICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDVGOgorICAgICAgICAwLCAgICAgICAgICAg ICAgICAgLy8gMHg2MDoKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4NjE6CisgICAg ICAgIDAsICAgICAgICAgICAgICAgICAvLyAweDYyOgorICAgICAgICAwLCAgICAgICAgICAgICAg ICAgLy8gMHg2MzoKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4NjQ6CisgICAgICAg IDAsICAgICAgICAgICAgICAgICAvLyAweDY1OgorICAgICAgICAwLCAgICAgICAgICAgICAgICAg Ly8gMHg2NjoKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4Njc6CisgICAgICAgIDAs ICAgICAgICAgICAgICAgICAvLyAweDY4OgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8g MHg2OToKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4NkE6CisgICAgICAgIDAsICAg ICAgICAgICAgICAgICAvLyAweDZCOgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg2 QzoKKyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4NkQ6CisgICAgICAgIDAsICAgICAg ICAgICAgICAgICAvLyAweDZFOgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg2RjoK KyAgICAgICAgMCwgICAgICAgICAgICAgICAgIC8vIDB4NzA6CisgICAgICAgIDAsICAgICAgICAg ICAgICAgICAvLyAweDcxOgorICAgICAgICAwLCAgICAgICAgICAgICAgICAgLy8gMHg3MjoKKyAg ICAgICAgR0RLX1N1cGVyX0wsICAgICAgIC8vIDB4NzM6IEdES19TdXBlcl9MCisgICAgICAgIEdE S19TdXBlcl9SLCAgICAgICAvLyAweDc0OiBHREtfU3VwZXJfUgogICAgIH07CiAKICAgICAvLyB8 d2luZG93c0tleUNvZGV8IGhhcyB0byBpbmNsdWRlIGEgdmFsaWQgdmlydHVhbC1rZXkgY29kZSBl dmVuIHdoZW4gd2UK