39741 2010-05-26 09:12:03 -0700 qt_class.cpp has coding-style errors 2010-05-27 06:02:40 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue peojala11 oldest_to_newest 230730 0 agbakken 2010-05-26 09:12:03 -0700 WebCore/bridge/qt/qt_class.cpp:21: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/bridge/qt/qt_class.cpp:23: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/bridge/qt/qt_class.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebCore/bridge/qt/qt_class.cpp:144: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebCore/bridge/qt/qt_class.cpp:148: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebCore/bridge/qt/qt_class.cpp:161: Declaration has space between type name and * in QObject *child [whitespace/declaration] [3] WebCore/bridge/qt/qt_class.cpp:198: Declaration has space between type name and * in QObject *child [whitespace/declaration] [3] WebCore/bridge/qt/qt_class.cpp:140: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 8 in 1 files dfb-47 [flow:~/dev/WebKit/WebCore/bridge/qt] 230739 1 57103 agbakken 2010-05-26 09:49:10 -0700 Created attachment 57103 Patch that fixes the coding style issues 231068 2 peojala11 2010-05-26 21:35:31 -0700 QtTriaged 231254 3 57103 commit-queue 2010-05-27 06:02:33 -0700 Comment on attachment 57103 Patch that fixes the coding style issues Clearing flags on attachment: 57103 Committed r60296: <http://trac.webkit.org/changeset/60296> 231255 4 commit-queue 2010-05-27 06:02:40 -0700 All reviewed patches have been landed. Closing bug. 57103 2010-05-26 09:49:10 -0700 2010-05-27 06:02:32 -0700 Patch that fixes the coding style issues patch.39741 text/plain 3924 agbakken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDI0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMjYgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg cXRfY2xhc3MuY3BwIGhhcyBjb2Rpbmctc3R5bGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTc0MQorCisgICAgICAgIEZpeCB3ZWJraXQg Y29kaW5nIHN0eWxlIGlzc3VlcyBpbiBxdF9jbGFzcy5jcHAKKworICAgICAgICAqIGJyaWRnZS9x dC9xdF9jbGFzcy5jcHA6CisgICAgICAgIChKU0M6OkJpbmRpbmdzOjpRdENsYXNzOjpmaWVsZE5h bWVkKToKKwogMjAxMC0wNS0yNiAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBmb3IgV2luZG93cyArIGNsZWFuIHVwIHRo ZSB4Y29kZSBwcm9qZWN0LgpJbmRleDogV2ViQ29yZS9icmlkZ2UvcXQvcXRfY2xhc3MuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvYnJpZGdlL3F0L3F0X2NsYXNzLmNwcAkocmV2aXNpb24gNjAw OTUpCisrKyBXZWJDb3JlL2JyaWRnZS9xdC9xdF9jbGFzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE4LDE0ICsxOCwxNCBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJJ ZGVudGlmaWVyLmgiCi0KICNpbmNsdWRlICJxdF9jbGFzcy5oIgorCisjaW5jbHVkZSAiSWRlbnRp Zmllci5oIgogI2luY2x1ZGUgInF0X2luc3RhbmNlLmgiCiAjaW5jbHVkZSAicXRfcnVudGltZS5o IgogCi0jaW5jbHVkZSA8cW1ldGFvYmplY3QuaD4KICNpbmNsdWRlIDxxZGVidWcuaD4KKyNpbmNs dWRlIDxxbWV0YW9iamVjdC5oPgogCiBuYW1lc3BhY2UgSlNDIHsKIG5hbWVzcGFjZSBCaW5kaW5n cyB7CkBAIC0xNDQsMjEgKzE0NCwxOSBAQCBGaWVsZCogUXRDbGFzczo6ZmllbGROYW1lZChjb25z dCBJZGVudGlmCiAgICAgICAgICAgICBpZiAoZi0+ZmllbGRUeXBlKCkgPT0gUXRGaWVsZDo6TWV0 YVByb3BlcnR5KQogICAgICAgICAgICAgICAgIHJldHVybiBmOwogI2lmbmRlZiBRVF9OT19QUk9Q RVJUSUVTCi0gICAgICAgICAgICBlbHNlIGlmIChmLT5maWVsZFR5cGUoKSA9PSBRdEZpZWxkOjpE eW5hbWljUHJvcGVydHkpIHsKKyAgICAgICAgICAgIGlmIChmLT5maWVsZFR5cGUoKSA9PSBRdEZp ZWxkOjpEeW5hbWljUHJvcGVydHkpIHsKICAgICAgICAgICAgICAgICBpZiAob2JqLT5keW5hbWlj UHJvcGVydHlOYW1lcygpLmluZGV4T2YoYXNjaWkpID49IDApCiAgICAgICAgICAgICAgICAgICAg IHJldHVybiBmOwotICAgICAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAgICAgICAv LyBEeW5hbWljIHByb3BlcnR5IHRoYXQgZGlzYXBwZWFyZWQKLSAgICAgICAgICAgICAgICAgICAg cXRpbnN0LT5tX2ZpZWxkcy5yZW1vdmUobmFtZSk7Ci0gICAgICAgICAgICAgICAgICAgIGRlbGV0 ZSBmOwotICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAvLyBEeW5hbWljIHByb3Bl cnR5IHRoYXQgZGlzYXBwZWFyZWQKKyAgICAgICAgICAgICAgICBxdGluc3QtPm1fZmllbGRzLnJl bW92ZShuYW1lKTsKKyAgICAgICAgICAgICAgICBkZWxldGUgZjsKICAgICAgICAgICAgIH0KICNl bmRpZgogICAgICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICAgICAgY29uc3QgUUxpc3Q8UU9i amVjdCo+JiBjaGlsZHJlbiA9IG9iai0+Y2hpbGRyZW4oKTsKICAgICAgICAgICAgICAgICBjb25z dCBpbnQgY291bnQgPSBjaGlsZHJlbi5zaXplKCk7CiAgICAgICAgICAgICAgICAgZm9yIChpbnQg aW5kZXggPSAwOyBpbmRleCA8IGNvdW50OyArK2luZGV4KSB7Ci0gICAgICAgICAgICAgICAgICAg IFFPYmplY3QgKmNoaWxkID0gY2hpbGRyZW4uYXQoaW5kZXgpOworICAgICAgICAgICAgICAgICAg ICBRT2JqZWN0KiBjaGlsZCA9IGNoaWxkcmVuLmF0KGluZGV4KTsKICAgICAgICAgICAgICAgICAg ICAgaWYgKGNoaWxkLT5vYmplY3ROYW1lKCkgPT0gbmFtZSkKICAgICAgICAgICAgICAgICAgICAg ICAgIHJldHVybiBmOwogICAgICAgICAgICAgICAgIH0KQEAgLTE5NSw3ICsxOTMsNyBAQCBGaWVs ZCogUXRDbGFzczo6ZmllbGROYW1lZChjb25zdCBJZGVudGlmCiAgICAgICAgIGNvbnN0IFFMaXN0 PFFPYmplY3QqPiYgY2hpbGRyZW4gPSBvYmotPmNoaWxkcmVuKCk7CiAgICAgICAgIGNvbnN0IGlu dCBjb3VudCA9IGNoaWxkcmVuLmNvdW50KCk7CiAgICAgICAgIGZvciAoaW5kZXggPSAwOyBpbmRl eCA8IGNvdW50OyArK2luZGV4KSB7Ci0gICAgICAgICAgICBRT2JqZWN0ICpjaGlsZCA9IGNoaWxk cmVuLmF0KGluZGV4KTsKKyAgICAgICAgICAgIFFPYmplY3QqIGNoaWxkID0gY2hpbGRyZW4uYXQo aW5kZXgpOwogICAgICAgICAgICAgaWYgKGNoaWxkLT5vYmplY3ROYW1lKCkgPT0gbmFtZSkgewog ICAgICAgICAgICAgICAgIGYgPSBuZXcgUXRGaWVsZChjaGlsZCk7CiAgICAgICAgICAgICAgICAg cXRpbnN0LT5tX2ZpZWxkcy5pbnNlcnQobmFtZSwgZik7CkBAIC0yMDUsMjMgKzIwMywyMiBAQCBG aWVsZCogUXRDbGFzczo6ZmllbGROYW1lZChjb25zdCBJZGVudGlmCiAKICAgICAgICAgLy8gTm90 aGluZyBuYW1lZCB0aGlzCiAgICAgICAgIHJldHVybiAwOwotICAgIH0gZWxzZSB7Ci0gICAgICAg IC8vIEZvciBjb21wYXRpYmlsaXR5IHdpdGggcXRzY3JpcHQsIGNhY2hlZCBtZXRob2RzIGRvbid0 IGNhdXNlCi0gICAgICAgIC8vIGVycm9ycyB1bnRpbCB0aGV5IGFyZSBhY2Nlc3NlZCwgc28gZG9u J3QgYmxpbmRseSBjcmVhdGUgYW4gZXJyb3IKLSAgICAgICAgLy8gaGVyZS4KLSAgICAgICAgaWYg KHF0aW5zdC0+bV9tZXRob2RzLmNvbnRhaW5zKGFzY2lpKSkKLSAgICAgICAgICAgIHJldHVybiAw OworICAgIH0KKyAgICAvLyBGb3IgY29tcGF0aWJpbGl0eSB3aXRoIHF0c2NyaXB0LCBjYWNoZWQg bWV0aG9kcyBkb24ndCBjYXVzZQorICAgIC8vIGVycm9ycyB1bnRpbCB0aGV5IGFyZSBhY2Nlc3Nl ZCwgc28gZG9uJ3QgYmxpbmRseSBjcmVhdGUgYW4gZXJyb3IKKyAgICAvLyBoZXJlLgorICAgIGlm IChxdGluc3QtPm1fbWV0aG9kcy5jb250YWlucyhhc2NpaSkpCisgICAgICAgIHJldHVybiAwOwog CiAjaWZuZGVmIFFUX05PX1BST1BFUlRJRVMKLSAgICAgICAgLy8gZGVsZXRlZCBxb2JqZWN0LCBi dXQgY2FuJ3QgdGhyb3cgYW4gZXJyb3IgZnJvbSBoZXJlIChubyBleGVjKQotICAgICAgICAvLyBj cmVhdGUgYSBmYWtlIFF0RmllbGQgdGhhdCB3aWxsIHRocm93IHVwb24gYWNjZXNzCi0gICAgICAg IGlmICghZikgewotICAgICAgICAgICAgZiA9IG5ldyBRdEZpZWxkKGFzY2lpKTsKLSAgICAgICAg ICAgIHF0aW5zdC0+bV9maWVsZHMuaW5zZXJ0KG5hbWUsIGYpOwotICAgICAgICB9Ci0jZW5kaWYK LSAgICAgICAgcmV0dXJuIGY7CisgICAgLy8gZGVsZXRlZCBxb2JqZWN0LCBidXQgY2FuJ3QgdGhy b3cgYW4gZXJyb3IgZnJvbSBoZXJlIChubyBleGVjKQorICAgIC8vIGNyZWF0ZSBhIGZha2UgUXRG aWVsZCB0aGF0IHdpbGwgdGhyb3cgdXBvbiBhY2Nlc3MKKyAgICBpZiAoIWYpIHsKKyAgICAgICAg ZiA9IG5ldyBRdEZpZWxkKGFzY2lpKTsKKyAgICAgICAgcXRpbnN0LT5tX2ZpZWxkcy5pbnNlcnQo bmFtZSwgZik7CiAgICAgfQorI2VuZGlmCisgICAgcmV0dXJuIGY7CiB9CiAKIH0K