39740 2010-05-26 08:29:30 -0700 [style] Allow usage of NULL in gst_*_many() 2010-05-27 02:22:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 39472 1 pnormand webkit-unassigned oldest_to_newest 230719 0 pnormand 2010-05-26 08:29:30 -0700 The cpp style-checker shouldn't warn about usage of NULL in gst_*_many() calls. It can't be replaced by 0, see also Bug 32858. 230725 1 57100 pnormand 2010-05-26 08:40:38 -0700 Created attachment 57100 proposed patch 230873 2 57100 levin 2010-05-26 13:54:45 -0700 Comment on attachment 57100 proposed patch I wonder if it should just be gst_* Care to fix: https://bugs.webkit.org/show_bug.cgi?id=39372 ? (The problem there was g_build_filename. I wonder if the g_ checks should be broadened to g_*). 231153 3 pnormand 2010-05-27 00:21:34 -0700 (In reply to comment #2) > (From update of attachment 57100 [details]) > I wonder if it should just be gst_* > AFAICT it should be enough with gst_*_many. If really needed we can extend this later on, meanwhile I will land this patch :) > Care to fix: https://bugs.webkit.org/show_bug.cgi?id=39372 ? > (The problem there was g_build_filename. I wonder if the g_ checks should be broadened to g_*). Yes it sounds like a good idea, I will tackle the bug above when I get time :) 231191 4 pnormand 2010-05-27 02:22:59 -0700 Landed in http://trac.webkit.org/changeset/60283 Thanks! 57100 2010-05-26 08:40:38 -0700 2010-05-26 13:54:44 -0700 proposed patch proposed-patch.patch text/plain 2830 pnormand RnJvbSAwMDU4NmNkZmQyMTQ5MGY3YzcyYWU0ZjhlYzVjYWI1NWYwMWUzMDg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDI2IE1heSAyMDEwIDE3OjM5OjU4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IHwgICAgNCArKysrCiAuLi4vd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5ICAgICAgICB8ICAgMTIgKysrKysrKysrKysr CiAzIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGRjZjIxYWEuLmYzNGM3YmIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZwor KysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0yNiAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3N0eWxlXSBBbGxvdyB1c2FnZSBvZiBO VUxMIGluIGdzdF8qX21hbnkoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzk3NDAKKworICAgICAgICBEb24ndCB3YXJuIGlmIE5VTEwgaXMgdXNlZCBi eSBnc3RfKl9tYW55KCkgZnVuY3Rpb25zLiBaZXJvIGNhbid0CisgICAgICAgIGJlIHVzZWQgZm9y IHRoZSByZWFzb24gZXhwbGFpbmVkIGluIEJ1ZyAzMjg1OC4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorCiAyMDEwLTA1LTI0ICBUb255IENo YW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11 cmEuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CmluZGV4IDNlNzg3ZDYuLjE1NzAzMzggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0xODcyLDYgKzE4NzIsMTAg QEAgZGVmIGNoZWNrX2Zvcl9udWxsKGZpbGVfZXh0ZW5zaW9uLCBjbGVhbl9saW5lcywgbGluZV9u dW1iZXIsIGVycm9yKToKICAgICBpZiBzZWFyY2gocidcYmdfb2JqZWN0X1tzZ11ldFxiJywgbGlu ZSk6CiAgICAgICAgIHJldHVybgogCisgICAgIyBEb24ndCB3YXJuIGFib3V0IE5VTEwgdXNhZ2Ug aW4gZ3N0XypfbWFueSgpLiBTZWUgQnVnIDM5NzQwCisgICAgaWYgc2VhcmNoKHInXGJnc3RfXHcr X21hbnlcYicsIGxpbmUpOgorICAgICAgICByZXR1cm4KKwogICAgICMgRG9uJ3Qgd2FybiBhYm91 dCBOVUxMIHVzYWdlIGluIGdfc3Rye2pvaW4sY29uY2F0fSgpLiBTZWUgQnVnIDM0ODM0CiAgICAg aWYgc2VhcmNoKHInXGJnX3N0cihqb2lufGNvbmNhdClcYicsIGxpbmUpOgogICAgICAgICByZXR1 cm4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggNWE1YWFiZC4uYWVhMzRjYyAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRl c3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHBfdW5pdHRlc3QucHkKQEAgLTM0MzcsNiArMzQzNywxOCBAQCBjbGFzcyBXZWJLaXRTdHlsZVRl c3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAnZ19vYmplY3Rfc2V0KGZvbywgInBy b3AiLCBiYXIsIE5VTEwpOycsCiAgICAgICAgICAgICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRf bGludCgKKyAgICAgICAgICAgICdnc3RfYmluX2FkZF9tYW55KGZvbywgYmFyLCBib28sIE5VTEwp OycsCisgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAg ICAgICdnc3RfYmluX3JlbW92ZV9tYW55KGZvbywgYmFyLCBib28sIE5VTEwpOycsCisgICAgICAg ICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdnc3RfZWxl bWVudF9saW5rX21hbnkoZm9vLCBiYXIsIGJvbywgTlVMTCk7JywKKyAgICAgICAgICAgICcnKQor ICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2dzdF9lbGVtZW50X3VubGlu a19tYW55KGZvbywgYmFyLCBib28sIE5VTEwpOycsCisgICAgICAgICAgICAnJykKKyAgICAgICAg c2VsZi5hc3NlcnRfbGludCgKICAgICAgICAgICAgICdnY2hhciogcmVzdWx0ID0gZ19zdHJjb25j YXQoInBhcnQxIiwgInBhcnQyIiwgInBhcnQzIiwgTlVMTCk7JywKICAgICAgICAgICAgICcnKQog ICAgICAgICBzZWxmLmFzc2VydF9saW50KAotLSAKMS42LjMuMw==