39718 2010-05-26 03:18:50 -0700 [GTK] Dragging onto the desktop causes a critical GLib warning 2010-06-03 10:52:31 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned commit-queue oldest_to_newest 230635 0 mrobinson 2010-05-26 03:18:50 -0700 The error is: (GtkLauncher:25906): GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' failed 230637 1 57085 mrobinson 2010-05-26 03:24:41 -0700 Created attachment 57085 Patch 231167 2 57085 xan.lopez 2010-05-27 01:09:18 -0700 Comment on attachment 57085 Patch OK. 231241 3 57085 commit-queue 2010-05-27 05:24:24 -0700 Comment on attachment 57085 Patch Rejecting patch 57085 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Xan Lopez', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebKit/gtk/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/gtk/webkit/webkitwebview.cpp Hunk #1 FAILED at 1257. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/gtk/webkit/webkitwebview.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/2561016 231308 4 57085 mrobinson 2010-05-27 08:14:31 -0700 Comment on attachment 57085 Patch Whoops. This was already comitted. Clearing flags. 57085 2010-05-26 03:24:41 -0700 2010-05-27 08:14:31 -0700 Patch bug-39718-20100526122437.patch text/plain 1629 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZDU5NTU5ZGIxYTY5OWFhMzU1OWYwODk0NGJmNTQ3YTQyOTE0OTkyNy4uMGVjYmMwZDYw ODVlOWQzY2EwMTc2ZTU5MjAzMTgxM2I3NWFjZTc4MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx MC0wNS0yNiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRHJhZ2dpbmcg b250byB0aGUgZGVza3RvcCBjYXVzZXMgYSBjcml0aWNhbCBHTGliIHdhcm5pbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NzE4CisKKyAgICAgICAg T25seSBpbmNyZW1lbnQgdGhlIHdpbmRvdyByZWZlcmVuY2UgY291bnQgaWYgaXQgaXMgbm90IG51 bGwgZHVyaW5nIGRyYWctZW5kCisgICAgICAgIHNpZ25hbCBwcm9jZXNzaW5nLgorCisgICAgICAg ICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2Ry YWdfZW5kKTogR3VhcmQgYWdhaW5zdCBudWxsIHdpbmRvdyB2YWx1ZXMuCisKIDIwMTAtMDUtMjQg IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVy aWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAxOGFlYmM2MjUz NjJlMjc5MzQ5OGFlNTAyZjA4ZmFiMWY0Njc1NWU4Li5jNTA4NzI1OWNlYjFlOTk5OTYwMjg2ODQ5 Y2RmMWE5NmYwZDNkYzYyIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTI1 Nyw3ICsxMjU3LDExIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19kcmFnX2VuZChHdGtX aWRnZXQqIHdpZGdldCwgR2RrRHJhZ0NvbnRleHQqIGNvbnRleHQpCiAgICAgR2RrRGlzcGxheSog ZGlzcGxheSA9IGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCk7CiAgICAgZ2RrX2Rpc3BsYXlfZ2V0 X3BvaW50ZXIoZGlzcGxheSwgMCwgJnhSb290LCAmeVJvb3QsICZtb2RpZmllcnMpOwogCi0gICAg ZXZlbnQtPmJ1dHRvbi53aW5kb3cgPSBzdGF0aWNfY2FzdDxHZGtXaW5kb3cqPihnX29iamVjdF9y ZWYoZ2RrX2Rpc3BsYXlfZ2V0X3dpbmRvd19hdF9wb2ludGVyKGRpc3BsYXksICZ4LCAmeSkpKTsK KyAgICBHZGtXaW5kb3cqIHdpbmRvdyA9IGdka19kaXNwbGF5X2dldF93aW5kb3dfYXRfcG9pbnRl cihkaXNwbGF5LCAmeCwgJnkpOworICAgIGlmICh3aW5kb3cpIHsKKyAgICAgICAgZ19vYmplY3Rf cmVmKHdpbmRvdyk7CisgICAgICAgIGV2ZW50LT5idXR0b24ud2luZG93ID0gd2luZG93OworICAg IH0KICAgICBldmVudC0+YnV0dG9uLnggPSB4OwogICAgIGV2ZW50LT5idXR0b24ueSA9IHk7CiAg ICAgZXZlbnQtPmJ1dHRvbi54X3Jvb3QgPSB4Um9vdDsK