3971 2005-07-12 16:32:47 -0700 JS test suite depends on JS 1.2 behavior 2005-07-25 14:01:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 14478 0 ggaren 2005-07-12 16:32:47 -0700 The JS test suite attempts to use version() to travel back to the days of JS 1.2 and test for behaviors that are directly contradictory to the ECMA3 spec. Since we only support JS 1.5/ECMA3, and since version() is only a dummy function in our code, some tests raise false positives. Test failures: js1_2/Array/tostring_1.js js1_2/Array/tostring_2.js 14479 1 2935 ggaren 2005-07-12 16:34:04 -0700 Created attachment 2935 Patch This patch makes the tests expect JS 1.5 results. 14774 2 2935 darin 2005-07-18 07:54:16 -0700 Comment on attachment 2935 Patch I'd like the change to the tests to at least document what's going on rather than simply commenting out the code. When we get new versions of the JS test suite, we may need to merge this change in, and it would be good to make sure it's "self-documenting". I must admit I don't entirely understand why removing this code completely is the best fix, but I think a comment explaining why would probably convince me. 14816 3 2991 ggaren 2005-07-18 11:38:09 -0700 Created attachment 2991 Patch Updated patch to include comment. 2935 2005-07-12 16:34:04 -0700 2005-07-18 11:38:09 -0700 Patch patch.txt text/plain 2373 ggaren PyB0ZXN0cy9tb3ppbGxhL2pzMV8yLy5EU19TdG9yZQpJbmRleDoga2pzL2FycmF5X29iamVjdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFTY3JpcHRDb3JlL2tqcy9hcnJh eV9vYmplY3QuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQzCmRpZmYgLXUgLXIxLjQzIGFy cmF5X29iamVjdC5jcHAKLS0tIGtqcy9hcnJheV9vYmplY3QuY3BwCTMgSnVsIDIwMDUgMTA6NDc6 NTIgLTAwMDAJMS40MworKysga2pzL2FycmF5X29iamVjdC5jcHAJMTIgSnVsIDIwMDUgMjM6MTQ6 MTMgLTAwMDAKQEAgLTQ3NCw3ICs0NzQsNyBAQAogICAgICAgaWYgKGVsZW1lbnQudHlwZSgpICE9 IFVuZGVmaW5lZFR5cGUgJiYgZWxlbWVudC50eXBlKCkgIT0gTnVsbFR5cGUpCiAgICAgICAgIHN0 ciArPSBlbGVtZW50LnRvU3RyaW5nKGV4ZWMpOwogICAgICAgaWYgKCBleGVjLT5oYWRFeGNlcHRp b24oKSApCi0JYnJlYWs7CisgICAgICAgIGJyZWFrOwogICAgIH0KICAgICByZXN1bHQgPSBTdHJp bmcoc3RyKTsKICAgICBicmVhazsKSW5kZXg6IHRlc3RzL21vemlsbGEvanMxXzIvQXJyYXkvdG9z dHJpbmdfMS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUv dGVzdHMvbW96aWxsYS9qczFfMi9BcnJheS90b3N0cmluZ18xLmpzLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjEKZGlmZiAtdSAtcjEuMSB0b3N0cmluZ18xLmpzCi0tLSB0ZXN0cy9tb3ppbGxhL2pz MV8yL0FycmF5L3Rvc3RyaW5nXzEuanMJMTMgT2N0IDIwMDMgMDI6MDU6MzMgLTAwMDAJMS4xCisr KyB0ZXN0cy9tb3ppbGxhL2pzMV8yL0FycmF5L3Rvc3RyaW5nXzEuanMJMTIgSnVsIDIwMDUgMjM6 MTQ6MTMgLTAwMDAKQEAgLTQzLDEyICs0MywxMiBAQAogCiAgICAgdmFyIFZFUlNJT04gPSAwOwog Ci0gICAgaWYgKCB0eXBlb2YgdmVyc2lvbiA9PSAiZnVuY3Rpb24iICkgewotICAgICAgICB2ZXJz aW9uKDEyMCk7Ci0gICAgICAgIFZFUlNJT04gPSAiMTIwIjsKLSAgICB9IGVsc2UgewotICAgICAg ICBmdW5jdGlvbiB2ZXJzaW9uKCkgeyByZXR1cm4gMDsgfTsKLSAgICB9CisvLyAgICBpZiAoIHR5 cGVvZiB2ZXJzaW9uID09ICJmdW5jdGlvbiIgKSB7CisvLyAgICAgICAgdmVyc2lvbigxMjApOwor Ly8gICAgICAgIFZFUlNJT04gPSAiMTIwIjsKKy8vICAgIH0gZWxzZSB7CisvLyAgICAgICAgZnVu Y3Rpb24gdmVyc2lvbigpIHsgcmV0dXJuIDA7IH07CisvLyAgICB9CiAKICAgICB0ZXN0Y2FzZXNb dGMrK10gPSBuZXcgVGVzdENhc2UgKCBTRUNUSU9OLAogICAgICAgICAgICAgICAgICAgICAgICAg InZhciBhID0gbmV3IEFycmF5KCk7IGEudG9TdHJpbmcoKSIsCkluZGV4OiB0ZXN0cy9tb3ppbGxh L2pzMV8yL0FycmF5L3Rvc3RyaW5nXzIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L0phdmFTY3JpcHRDb3JlL3Rlc3RzL21vemlsbGEvanMxXzIvQXJyYXkvdG9zdHJpbmdfMi5qcyx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xCmRpZmYgLXUgLXIxLjEgdG9zdHJpbmdfMi5qcwotLS0g dGVzdHMvbW96aWxsYS9qczFfMi9BcnJheS90b3N0cmluZ18yLmpzCTEzIE9jdCAyMDAzIDAyOjA1 OjMzIC0wMDAwCTEuMQorKysgdGVzdHMvbW96aWxsYS9qczFfMi9BcnJheS90b3N0cmluZ18yLmpz CTEyIEp1bCAyMDA1IDIzOjE0OjEzIC0wMDAwCkBAIC00MSwxMyArNDEsMTMgQEAKICAgICB2YXIg YSA9IFtdOwogCiAKLSAgICBpZiAoIHR5cGVvZiB2ZXJzaW9uID09ICJmdW5jdGlvbiIgKSB7Ci0g ICAgICAgIHdyaXRlTGluZVRvTG9nKCJ2ZXJzaW9uIDEyMCIpOwotICAgICAgICB2ZXJzaW9uKDEy MCk7Ci0gICAgICAgIFZFUlNJT04gPSAiMTIwIjsKLSAgICB9IGVsc2UgewotICAgICAgICBmdW5j dGlvbiB2ZXJzaW9uKCkgeyByZXR1cm4gMDsgfTsKLSAgICB9CisvLyAgICBpZiAoIHR5cGVvZiB2 ZXJzaW9uID09ICJmdW5jdGlvbiIgKSB7CisvLyAgICAgICAgd3JpdGVMaW5lVG9Mb2coInZlcnNp b24gMTIwIik7CisvLyAgICAgICAgdmVyc2lvbigxMjApOworLy8gICAgICAgIFZFUlNJT04gPSAi MTIwIjsKKy8vICAgIH0gZWxzZSB7CisvLyAgICAgICAgZnVuY3Rpb24gdmVyc2lvbigpIHsgcmV0 dXJuIDA7IH07CisvLyAgICB9CiAKICAgICB0ZXN0Y2FzZXNbdGMrK10gPSBuZXcgVGVzdENhc2Ug KCBTRUNUSU9OLAogICAgICAgICAiYS50b1N0cmluZygpIiwK 2991 2005-07-18 11:38:09 -0700 2005-07-22 23:00:43 -0700 Patch patch.txt text/plain 2693 ggaren SW5kZXg6IC4vdGVzdHMvbW96aWxsYS9qczFfMi9BcnJheS90b3N0cmluZ18xLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9KYXZhU2NyaXB0Q29yZS90ZXN0cy9tb3ppbGxhL2pzMV8y L0FycmF5L3Rvc3RyaW5nXzEuanMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC1wIC11 IC1yMS4xIC4vdGVzdHMvbW96aWxsYS9qczFfMi9BcnJheS90b3N0cmluZ18xLmpzCi0tLSAuL3Rl c3RzL21vemlsbGEvanMxXzIvQXJyYXkvdG9zdHJpbmdfMS5qcwkxMyBPY3QgMjAwMyAwMjowNToz MyAtMDAwMAkxLjEKKysrIC4vdGVzdHMvbW96aWxsYS9qczFfMi9BcnJheS90b3N0cmluZ18xLmpz CTE4IEp1bCAyMDA1IDE4OjE5OjQ5IC0wMDAwCkBAIC00MywxMiArNDMsMjYgQEAKIAogICAgIHZh ciBWRVJTSU9OID0gMDsKIAorICAgIC8qIFRoaXMgdGVzdCBhc3N1bWVzIHRoYXQgaWYgdmVyc2lv bigpIGV4aXN0cywgaXQgY2FuIHNldCB0aGUgSmF2YVNjcmlwdCAKKyAgICAgKiBpbnRlcnByZXRl ciB0byBhbiBhcmJpdHJhcnkgdmVyc2lvbi4gVG8gcHJldmVudCB1bmhhbmRsZWQgZXhjZXB0aW9u cyBpbgorICAgICAqIG90aGVyIHRlc3RzLCB0ZXN0a2pzIGltcGxlbWVudHMgdmVyc2lvbigpIGFz IGEgc3R1YiBmdW5jdGlvbiwgYnV0IAorICAgICAqIEphdmFTY3JpcHRDb3JlIGRvZXNuJ3Qgc3Vw cG9ydCBzZXR0aW5nIHRoZSBKYXZhU2NyaXB0IGVuZ2luZSdzIHZlcnNpb24uCisgICAgIAorICAg ICAqIENvbW1lbnRpbmcgb3V0IHRoZSBmb2xsb3dpbmcgbGluZXMgZm9yY2VzIHRoZSB0ZXN0IHRv IGV4cGVjdCBKYXZhU2NyaXB0CisgICAgICogMS41IHJlc3VsdHMuCisgICAgIAorICAgICAqIElm IEphdmFTY3JpcHRDb3JlIGNoYW5nZXMgdG8gc3VwcG9ydCB2ZXJzaW9uaW5nLCB0aGlzIHRlc3Qg c2hvdWxkIHNwbGl0CisgICAgICogaW50byBhIDEuMiB0ZXN0IGluIGpzMV8yLyBhbmQgYSAxLjUg dGVzdCBpbiBqczFfNS8uCisgICAgICovCisgICAgCisgICAgLyoKICAgICBpZiAoIHR5cGVvZiB2 ZXJzaW9uID09ICJmdW5jdGlvbiIgKSB7CiAgICAgICAgIHZlcnNpb24oMTIwKTsKICAgICAgICAg VkVSU0lPTiA9ICIxMjAiOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGZ1bmN0aW9uIHZlcnNpb24o KSB7IHJldHVybiAwOyB9OwogICAgIH0KKyAgICAqLwogCiAgICAgdGVzdGNhc2VzW3RjKytdID0g bmV3IFRlc3RDYXNlICggU0VDVElPTiwKICAgICAgICAgICAgICAgICAgICAgICAgICJ2YXIgYSA9 IG5ldyBBcnJheSgpOyBhLnRvU3RyaW5nKCkiLApJbmRleDogLi90ZXN0cy9tb3ppbGxhL2pzMV8y L0FycmF5L3Rvc3RyaW5nXzIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFT Y3JpcHRDb3JlL3Rlc3RzL21vemlsbGEvanMxXzIvQXJyYXkvdG9zdHJpbmdfMi5qcyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4xCmRpZmYgLXAgLXUgLXIxLjEgLi90ZXN0cy9tb3ppbGxhL2pzMV8y L0FycmF5L3Rvc3RyaW5nXzIuanMKLS0tIC4vdGVzdHMvbW96aWxsYS9qczFfMi9BcnJheS90b3N0 cmluZ18yLmpzCTEzIE9jdCAyMDAzIDAyOjA1OjMzIC0wMDAwCTEuMQorKysgLi90ZXN0cy9tb3pp bGxhL2pzMV8yL0FycmF5L3Rvc3RyaW5nXzIuanMJMTggSnVsIDIwMDUgMTg6MTk6NDkgLTAwMDAK QEAgLTQwLDcgKzQwLDIxIEBACiAKICAgICB2YXIgYSA9IFtdOwogCisgICAgdmFyIFZFUlNJT04g PSAwOwogCisgICAgLyogVGhpcyB0ZXN0IGFzc3VtZXMgdGhhdCBpZiB2ZXJzaW9uKCkgZXhpc3Rz LCBpdCBjYW4gc2V0IHRoZSBKYXZhU2NyaXB0IAorICAgICAqIGludGVycHJldGVyIHRvIGFuIGFy Yml0cmFyeSB2ZXJzaW9uLiBUbyBwcmV2ZW50IHVuaGFuZGxlZCBleGNlcHRpb25zIGluCisgICAg ICogb3RoZXIgdGVzdHMsIHRlc3RranMgaW1wbGVtZW50cyB2ZXJzaW9uKCkgYXMgYSBzdHViIGZ1 bmN0aW9uLCBidXQgCisgICAgICogSmF2YVNjcmlwdENvcmUgZG9lc24ndCBzdXBwb3J0IHNldHRp bmcgdGhlIEphdmFTY3JpcHQgZW5naW5lJ3MgdmVyc2lvbi4KKyAgICAgCisgICAgICogQ29tbWVu dGluZyBvdXQgdGhlIGZvbGxvd2luZyBsaW5lcyBmb3JjZXMgdGhlIHRlc3QgdG8gZXhwZWN0IEph dmFTY3JpcHQKKyAgICAgKiAxLjUgcmVzdWx0cy4KKyAgICAgCisgICAgICogSWYgSmF2YVNjcmlw dENvcmUgY2hhbmdlcyB0byBzdXBwb3J0IHZlcnNpb25pbmcsIHRoaXMgdGVzdCBzaG91bGQgc3Bs aXQKKyAgICAgKiBpbnRvIGEgMS4yIHRlc3QgaW4ganMxXzIvIGFuZCBhIDEuNSB0ZXN0IGluIGpz MV81Ly4KKyAgICAgKi8KKyAgICAKKyAgICAvKgogICAgIGlmICggdHlwZW9mIHZlcnNpb24gPT0g ImZ1bmN0aW9uIiApIHsKICAgICAgICAgd3JpdGVMaW5lVG9Mb2coInZlcnNpb24gMTIwIik7CiAg ICAgICAgIHZlcnNpb24oMTIwKTsKQEAgLTQ4LDYgKzYyLDcgQEAKICAgICB9IGVsc2UgewogICAg ICAgICBmdW5jdGlvbiB2ZXJzaW9uKCkgeyByZXR1cm4gMDsgfTsKICAgICB9CisgICAgKi8KIAog ICAgIHRlc3RjYXNlc1t0YysrXSA9IG5ldyBUZXN0Q2FzZSAoIFNFQ1RJT04sCiAgICAgICAgICJh LnRvU3RyaW5nKCkiLAo=