39684 2010-05-25 12:58:19 -0700 Remove obsolete code from WebKit/chromium/src/FrameLoaderClientImpl.cpp 2010-05-26 14:09:32 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 1 brettw brettw thakis oldest_to_newest 230406 0 brettw 2010-05-25 12:58:19 -0700 The #if !OS(WINDOWS) block in FrameLoaderClientImpl.::createPlugin appears to no longer be necessary and is preventing some things from working. 230408 1 57038 brettw 2010-05-25 13:01:43 -0700 Created attachment 57038 Patch 230409 2 57038 fishd 2010-05-25 13:03:23 -0700 Comment on attachment 57038 Patch > diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog > index 8593698..5fffb0d 100644 > --- a/WebKit/chromium/ChangeLog > +++ b/WebKit/chromium/ChangeLog > @@ -1,3 +1,14 @@ > +2010-05-25 Brett Wilson <brettw@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Remove obsolete code for Mac & Windows plugin creation in the Chromium > + port. This non-Windows code was to prevent a crash which we no longer > + seem to have, and it is preventing other types of plugins from working. > + Add a bug reference here. R=me 230410 3 57039 brettw 2010-05-25 13:04:46 -0700 Created attachment 57039 New patch 230413 4 brettw 2010-05-25 13:14:11 -0700 Fixed in r60178 230881 5 thakis 2010-05-26 14:09:32 -0700 I wanted to remove that today too, to get the default plugin loading on mac and linux. Thanks :-) 57038 2010-05-25 13:01:43 -0700 2010-05-25 13:05:05 -0700 Patch plugin.diff text/plain 1827 brettw ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDg1OTM2OTguLjVmZmZiMGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA1LTI1ICBCcmV0dCBXaWxzb24gIDxicmV0dHdAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBv YnNvbGV0ZSBjb2RlIGZvciBNYWMgJiBXaW5kb3dzIHBsdWdpbiBjcmVhdGlvbiBpbiB0aGUgQ2hy b21pdW0KKyAgICAgICAgcG9ydC4gVGhpcyBub24tV2luZG93cyBjb2RlIHdhcyB0byBwcmV2ZW50 IGEgY3Jhc2ggd2hpY2ggd2Ugbm8gbG9uZ2VyCisgICAgICAgIHNlZW0gdG8gaGF2ZSwgYW5kIGl0 IGlzIHByZXZlbnRpbmcgb3RoZXIgdHlwZXMgb2YgcGx1Z2lucyBmcm9tIHdvcmtpbmcuCisKKyAg ICAgICAgKiBzcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 RnJhbWVMb2FkZXJDbGllbnRJbXBsOjpjcmVhdGVQbHVnaW4pOgorCiAyMDEwLTA1LTI1ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1p dHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVy Q2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1w bC5jcHAKaW5kZXggMTdkOTQxNi4uNjk0ZDdjMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVt L3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMv RnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcApAQCAtMTM3MiwyMCArMTM3Miw2IEBAIFBhc3NSZWZQ dHI8V2lkZ2V0PiBGcmFtZUxvYWRlckNsaWVudEltcGw6OmNyZWF0ZVBsdWdpbigKICAgICBjb25z dCBTdHJpbmcmIG1pbWVUeXBlLAogICAgIGJvb2wgbG9hZE1hbnVhbGx5KQogewotI2lmICFPUyhX SU5ET1dTKQotICAgIC8vIFdlYkNvcmUgYXNrcyB1cyB0byBtYWtlIGEgcGx1Z2luIGV2ZW4gaWYg d2UgZG9uJ3QgaGF2ZSBhCi0gICAgLy8gcmVnaXN0ZXJlZCBoYW5kbGVyLCB3aXRoIGEgY29tbWVu dCBzYXlpbmcgaXQncyBzbyB3ZSBjYW4gZGlzcGxheQotICAgIC8vIHRoZSBicm9rZW4gcGx1Z2lu IGljb24uICBJbiBDaHJvbWl1bSwgd2Ugbm9ybWFsbHkgcmVnaXN0ZXIgYQotICAgIC8vIGZhbGxi YWNrIHBsdWdpbiBoYW5kbGVyIHRoYXQgYWxsb3dzIHlvdSB0byBpbnN0YWxsIGEgbWlzc2luZwot ICAgIC8vIHBsdWdpbi4gIFNpbmNlIHdlIGRvbid0IHlldCBoYXZlIGEgZGVmYXVsdCBwbHVnaW4g aGFuZGxlciwgd2UKLSAgICAvLyBuZWVkIHRvIHJldHVybiBudWxsIGhlcmUgcmF0aGVyIHRoYW4g Z29pbmcgdGhyb3VnaCBhbGwgdGhlCi0gICAgLy8gcGx1Z2luLWNyZWF0aW9uIElQQ3Mgb25seSB0 byBkaXNjb3ZlciB3ZSBkb24ndCBoYXZlIGEgcGx1Z2luCi0gICAgLy8gcmVnaXN0ZXJlZCwgd2hp Y2ggY2F1c2VzIGEgY3Jhc2guCi0gICAgLy8gRklYTUU6IHJlbW92ZSBtZSBvbmNlIHdlIGhhdmUg YSBkZWZhdWx0IHBsdWdpbi4KLSAgICBpZiAob2JqZWN0Q29udGVudFR5cGUodXJsLCBtaW1lVHlw ZSkgIT0gT2JqZWN0Q29udGVudE5ldHNjYXBlUGx1Z2luKQotICAgICAgICByZXR1cm4gMDsKLSNl bmRpZgotCiAgICAgaWYgKCFtX3dlYkZyYW1lLT5jbGllbnQoKSkKICAgICAgICAgcmV0dXJuIDA7 CiAK 57039 2010-05-25 13:04:46 -0700 2010-05-25 13:04:46 -0700 New patch plugin.diff text/plain 1880 brettw ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDg1OTM2OTguLjBhOGNiMGEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTA1LTI1ICBCcmV0dCBXaWxzb24gIDxicmV0dHdAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KKworICAgICAgICBSZW1vdmUgb2Jz b2xldGUgY29kZSBmb3IgTWFjICYgV2luZG93cyBwbHVnaW4gY3JlYXRpb24gaW4gdGhlIENocm9t aXVtCisgICAgICAgIHBvcnQuIFRoaXMgbm9uLVdpbmRvd3MgY29kZSB3YXMgdG8gcHJldmVudCBh IGNyYXNoIHdoaWNoIHdlIG5vIGxvbmdlcgorICAgICAgICBzZWVtIHRvIGhhdmUsIGFuZCBpdCBp cyBwcmV2ZW50aW5nIG90aGVyIHR5cGVzIG9mIHBsdWdpbnMgZnJvbSB3b3JraW5nLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2ODQKKworICAgICAg ICAqIHNyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpGcmFt ZUxvYWRlckNsaWVudEltcGw6OmNyZWF0ZVBsdWdpbik6CisKIDIwMTAtMDUtMjUgIEtlbnQgVGFt dXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkg R2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGll bnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNw cAppbmRleCAxN2Q5NDE2Li42OTRkN2MyIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3Jj L0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFt ZUxvYWRlckNsaWVudEltcGwuY3BwCkBAIC0xMzcyLDIwICsxMzcyLDYgQEAgUGFzc1JlZlB0cjxX aWRnZXQ+IEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6Y3JlYXRlUGx1Z2luKAogICAgIGNvbnN0IFN0 cmluZyYgbWltZVR5cGUsCiAgICAgYm9vbCBsb2FkTWFudWFsbHkpCiB7Ci0jaWYgIU9TKFdJTkRP V1MpCi0gICAgLy8gV2ViQ29yZSBhc2tzIHVzIHRvIG1ha2UgYSBwbHVnaW4gZXZlbiBpZiB3ZSBk b24ndCBoYXZlIGEKLSAgICAvLyByZWdpc3RlcmVkIGhhbmRsZXIsIHdpdGggYSBjb21tZW50IHNh eWluZyBpdCdzIHNvIHdlIGNhbiBkaXNwbGF5Ci0gICAgLy8gdGhlIGJyb2tlbiBwbHVnaW4gaWNv bi4gIEluIENocm9taXVtLCB3ZSBub3JtYWxseSByZWdpc3RlciBhCi0gICAgLy8gZmFsbGJhY2sg cGx1Z2luIGhhbmRsZXIgdGhhdCBhbGxvd3MgeW91IHRvIGluc3RhbGwgYSBtaXNzaW5nCi0gICAg Ly8gcGx1Z2luLiAgU2luY2Ugd2UgZG9uJ3QgeWV0IGhhdmUgYSBkZWZhdWx0IHBsdWdpbiBoYW5k bGVyLCB3ZQotICAgIC8vIG5lZWQgdG8gcmV0dXJuIG51bGwgaGVyZSByYXRoZXIgdGhhbiBnb2lu ZyB0aHJvdWdoIGFsbCB0aGUKLSAgICAvLyBwbHVnaW4tY3JlYXRpb24gSVBDcyBvbmx5IHRvIGRp c2NvdmVyIHdlIGRvbid0IGhhdmUgYSBwbHVnaW4KLSAgICAvLyByZWdpc3RlcmVkLCB3aGljaCBj YXVzZXMgYSBjcmFzaC4KLSAgICAvLyBGSVhNRTogcmVtb3ZlIG1lIG9uY2Ugd2UgaGF2ZSBhIGRl ZmF1bHQgcGx1Z2luLgotICAgIGlmIChvYmplY3RDb250ZW50VHlwZSh1cmwsIG1pbWVUeXBlKSAh PSBPYmplY3RDb250ZW50TmV0c2NhcGVQbHVnaW4pCi0gICAgICAgIHJldHVybiAwOwotI2VuZGlm Ci0KICAgICBpZiAoIW1fd2ViRnJhbWUtPmNsaWVudCgpKQogICAgICAgICByZXR1cm4gMDsKIAo=