39681 2010-05-25 11:51:36 -0700 Web Inspector: Fixes chromium crasher due to passing an empty handle to toWebCoreString() 2010-05-26 19:16:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jaimeyap webkit-unassigned mnaganov pfeldman tony tonyg yurys oldest_to_newest 230387 0 jaimeyap 2010-05-25 11:51:36 -0700 toWebCoreString() in V8Binding.cpp in WebCore will null pointer deref if passed an empty handle. Sometimes when invoking ScriptCallStack::callLocation(), we would get an empty handle for the script name. See: http://code.google.com/p/chromium/issues/detail?id=45004 230389 1 57035 jaimeyap 2010-05-25 11:59:31 -0700 Created attachment 57035 Fixes http://code.google.com/p/chromium/issues/detail?id=45004 230392 2 57035 pfeldman 2010-05-25 12:05:48 -0700 Comment on attachment 57035 Fixes http://code.google.com/p/chromium/issues/detail?id=45004 WebCore/bindings/v8/ScriptCallStack.cpp:75 + *functionName = toWebCoreString(functionNameValue.IsEmpty() ? v8::Undefined() : functionNameValue); You know what toWebCoreString from undefined will look like? (I am not sure). Is that what you need? 230400 3 57037 jaimeyap 2010-05-25 12:42:11 -0700 Created attachment 57037 Returns "" instead of asking toWebCoreString() to stringify Undefined. 231042 4 tony 2010-05-26 19:16:04 -0700 Committed r60266: <http://trac.webkit.org/changeset/60266> 57035 2010-05-25 11:59:31 -0700 2010-05-25 12:42:11 -0700 Fixes http://code.google.com/p/chromium/issues/detail?id=45004 npe-fix.patch text/plain 2065 jaimeyap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDE3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjUgIEphaW1lIFlhcCAgPGphaW1leWFwQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2Ny aXB0Q2FsbFN0YWNrOjpjYWxsTG9jYXRpb24oKSBzb21ldGltZXMgcGFzc2VkIGFuIGVtcHR5IGhh bmRsZSB0bworICAgICAgICB0b1dlYkNvcmVTdHJpbmcoKSBjYXVzaW5nIGEgbnVsbCBwb2ludGVy IGRlcmVmLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mzk2ODEKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdENhbGxTdGFjay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JpcHRDYWxsU3RhY2s6OmNhbGxMb2NhdGlvbik6CisKIDIwMTAtMDUt MjUgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q2FsbFN0 YWNrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENhbGxTdGFj ay5jcHAJKHJldmlzaW9uIDYwMDg3KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDYWxs U3RhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1OCw3IEBAIGJvb2wgU2NyaXB0Q2Fs bFN0YWNrOjpjYWxsTG9jYXRpb24oU3RyaW4KICAgICBpZiAoc3RhY2tUcmFjZS5Jc0VtcHR5KCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoc3RhY2tUcmFjZS0+R2V0RnJhbWVDb3Vu dCgpIDw9IDApIHsKKyAgICAgICAgLy8gU3VjY2Vzc2Z1bGx5IGdyYWJiZWQgc3RhY2sgdHJhY2Us IGJ1dCB0aGVyZSBhcmUgbm8gZnJhbWVzLgogICAgICAgICAvLyBGYWxsYmFjayB0byBzZXR0aW5n IGxpbmVOdW1iZXIgdG8gMCwgYW5kIHNvdXJjZSBhbmQgZnVuY3Rpb24gbmFtZSB0byAidW5kZWZp bmVkIi4KICAgICAgICAgKnNvdXJjZU5hbWUgPSB0b1dlYkNvcmVTdHJpbmcodjg6OlVuZGVmaW5l ZCgpKTsKICAgICAgICAgKnNvdXJjZUxpbmVOdW1iZXIgPSAwOwpAQCAtNjUsOSArNjYsMTMgQEAg Ym9vbCBTY3JpcHRDYWxsU3RhY2s6OmNhbGxMb2NhdGlvbihTdHJpbgogICAgICAgICByZXR1cm4g dHJ1ZTsKICAgICB9CiAgICAgdjg6OkhhbmRsZTx2ODo6U3RhY2tGcmFtZT4gZnJhbWUgPSBzdGFj a1RyYWNlLT5HZXRGcmFtZSgwKTsKLSAgICAqc291cmNlTmFtZSA9IHRvV2ViQ29yZVN0cmluZyhm cmFtZS0+R2V0U2NyaXB0TmFtZSgpKTsKKyAgICAvLyBUaGVyZSBtdXN0IGJlIGF0IGxlYXN0IG9u ZSB2YWxpZCBmcmFtZS4KKyAgICBBU1NFUlQoIWZyYW1lLklzRW1wdHkoKSk7CisgICAgdjg6Okxv Y2FsPHY4OjpTdHJpbmc+IHNvdXJjZU5hbWVWYWx1ZShmcmFtZS0+R2V0U2NyaXB0TmFtZSgpKTsK KyAgICB2ODo6TG9jYWw8djg6OlN0cmluZz4gZnVuY3Rpb25OYW1lVmFsdWUoZnJhbWUtPkdldEZ1 bmN0aW9uTmFtZSgpKTsKKyAgICAqc291cmNlTmFtZSA9IHRvV2ViQ29yZVN0cmluZyhzb3VyY2VO YW1lVmFsdWUuSXNFbXB0eSgpID8gdjg6OlVuZGVmaW5lZCgpIDogc291cmNlTmFtZVZhbHVlKTsK ICAgICAqc291cmNlTGluZU51bWJlciA9IGZyYW1lLT5HZXRMaW5lTnVtYmVyKCk7Ci0gICAgKmZ1 bmN0aW9uTmFtZSA9IHRvV2ViQ29yZVN0cmluZyhmcmFtZS0+R2V0RnVuY3Rpb25OYW1lKCkpOwor ICAgICpmdW5jdGlvbk5hbWUgPSB0b1dlYkNvcmVTdHJpbmcoZnVuY3Rpb25OYW1lVmFsdWUuSXNF bXB0eSgpID8gdjg6OlVuZGVmaW5lZCgpIDogZnVuY3Rpb25OYW1lVmFsdWUpOwogICAgIHJldHVy biB0cnVlOwogfQogCg== 57037 2010-05-25 12:42:11 -0700 2010-05-26 19:16:45 -0700 Returns "" instead of asking toWebCoreString() to stringify Undefined. npe-fix-v2.patch text/plain 2039 jaimeyap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDE3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMjUgIEphaW1lIFlhcCAgPGphaW1leWFwQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2Ny aXB0Q2FsbFN0YWNrOjpjYWxsTG9jYXRpb24oKSBzb21ldGltZXMgcGFzc2VkIGFuIGVtcHR5IGhh bmRsZSB0bworICAgICAgICB0b1dlYkNvcmVTdHJpbmcoKSBjYXVzaW5nIGEgbnVsbCBwb2ludGVy IGRlcmVmLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mzk2ODEKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdENhbGxTdGFjay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTY3JpcHRDYWxsU3RhY2s6OmNhbGxMb2NhdGlvbik6CisKIDIwMTAtMDUt MjUgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q2FsbFN0 YWNrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENhbGxTdGFj ay5jcHAJKHJldmlzaW9uIDYwMDg3KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDYWxs U3RhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCw2ICs1OCw3IEBAIGJvb2wgU2NyaXB0Q2Fs bFN0YWNrOjpjYWxsTG9jYXRpb24oU3RyaW4KICAgICBpZiAoc3RhY2tUcmFjZS5Jc0VtcHR5KCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoc3RhY2tUcmFjZS0+R2V0RnJhbWVDb3Vu dCgpIDw9IDApIHsKKyAgICAgICAgLy8gU3VjY2Vzc2Z1bGx5IGdyYWJiZWQgc3RhY2sgdHJhY2Us IGJ1dCB0aGVyZSBhcmUgbm8gZnJhbWVzLgogICAgICAgICAvLyBGYWxsYmFjayB0byBzZXR0aW5n IGxpbmVOdW1iZXIgdG8gMCwgYW5kIHNvdXJjZSBhbmQgZnVuY3Rpb24gbmFtZSB0byAidW5kZWZp bmVkIi4KICAgICAgICAgKnNvdXJjZU5hbWUgPSB0b1dlYkNvcmVTdHJpbmcodjg6OlVuZGVmaW5l ZCgpKTsKICAgICAgICAgKnNvdXJjZUxpbmVOdW1iZXIgPSAwOwpAQCAtNjUsOSArNjYsMTMgQEAg Ym9vbCBTY3JpcHRDYWxsU3RhY2s6OmNhbGxMb2NhdGlvbihTdHJpbgogICAgICAgICByZXR1cm4g dHJ1ZTsKICAgICB9CiAgICAgdjg6OkhhbmRsZTx2ODo6U3RhY2tGcmFtZT4gZnJhbWUgPSBzdGFj a1RyYWNlLT5HZXRGcmFtZSgwKTsKLSAgICAqc291cmNlTmFtZSA9IHRvV2ViQ29yZVN0cmluZyhm cmFtZS0+R2V0U2NyaXB0TmFtZSgpKTsKKyAgICAvLyBUaGVyZSBtdXN0IGJlIGF0IGxlYXN0IG9u ZSB2YWxpZCBmcmFtZS4KKyAgICBBU1NFUlQoIWZyYW1lLklzRW1wdHkoKSk7CisgICAgdjg6Okxv Y2FsPHY4OjpTdHJpbmc+IHNvdXJjZU5hbWVWYWx1ZShmcmFtZS0+R2V0U2NyaXB0TmFtZSgpKTsK KyAgICB2ODo6TG9jYWw8djg6OlN0cmluZz4gZnVuY3Rpb25OYW1lVmFsdWUoZnJhbWUtPkdldEZ1 bmN0aW9uTmFtZSgpKTsKKyAgICAqc291cmNlTmFtZSA9IHNvdXJjZU5hbWVWYWx1ZS5Jc0VtcHR5 KCkgPyAiIiA6IHRvV2ViQ29yZVN0cmluZyhzb3VyY2VOYW1lVmFsdWUpOworICAgICpmdW5jdGlv bk5hbWUgPSBmdW5jdGlvbk5hbWVWYWx1ZS5Jc0VtcHR5KCkgPyAiIiA6IHRvV2ViQ29yZVN0cmlu ZyhmdW5jdGlvbk5hbWVWYWx1ZSk7CiAgICAgKnNvdXJjZUxpbmVOdW1iZXIgPSBmcmFtZS0+R2V0 TGluZU51bWJlcigpOwotICAgICpmdW5jdGlvbk5hbWUgPSB0b1dlYkNvcmVTdHJpbmcoZnJhbWUt PkdldEZ1bmN0aW9uTmFtZSgpKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=