39680 2010-05-25 10:57:11 -0700 [Qt] Expose the editing behavior setting in DRT to test all editing code paths 2010-06-07 06:57:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 38603 1 tonikitoo tonikitoo eric laszlo.gombos mrobinson ojan oldest_to_newest 230351 0 tonikitoo 2010-05-25 10:57:11 -0700 Expose the editing behavior setting to DRT, as discussed in https://lists.webkit.org/pipermail/webkit-dev/2010-March/012118.html It is a follow of of bug 38603, witch missed the Qt bits. Patch coming ... 230385 1 57034 tonikitoo 2010-05-25 11:44:56 -0700 Created attachment 57034 (committed with r60189, reviewed by Ojan Vafai) patch v1 230497 2 57034 tonikitoo 2010-05-25 15:17:06 -0700 Comment on attachment 57034 (committed with r60189, reviewed by Ojan Vafai) patch v1 (From update of attachment 57034 [details]) Clearing flags on attachment: 57034 Committed r60189: <http://trac.webkit.org/changeset/60189> 232053 3 laszlo.gombos 2010-05-28 20:02:21 -0700 This patch introduced the following warning: webkit/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: In static member function âstatic void DumpRenderTreeSupportQt::setEditingBehavior(QWebPage*, const QString&): webkit/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:479: warning: "coreEditingBehavior" may be used uninitialized in this function 232054 4 57403 laszlo.gombos 2010-05-28 20:04:14 -0700 Created attachment 57403 proposed patch 232158 5 tonikitoo 2010-05-29 20:06:10 -0700 (In reply to comment #3) > This patch introduced the following warning: > > webkit/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: In static member function âstatic void DumpRenderTreeSupportQt::setEditingBehavior(QWebPage*, const QString&): > > webkit/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:479: warning: "coreEditingBehavior" may be used uninitialized in this function My bad. I saw that, and would patch it when I was on a clean tree, but good you came first :) else if (editingBehavior == "mac") coreEditingBehavior = EditingMacBehavior; + else + return; Personally I would add an ASSERT_NOT_REACHED() as well. This shouldn't get never executed at all! other than that, lgtm, thank you Laszlo. 232195 6 57403 eric 2010-05-30 11:15:48 -0700 Comment on attachment 57403 proposed patch Should we log in this case? 232196 7 eric 2010-05-30 11:16:08 -0700 Seems like programmer error to pass a non-supported value here as part of a test case. 232197 8 57403 eric 2010-05-30 11:16:50 -0700 Comment on attachment 57403 proposed patch We could even ASSERT_NOT_REACHED instead of loging. That's probably better. Yeah this should just ASSERT_NOT_REACHED. 232859 9 57572 laszlo.gombos 2010-06-01 11:24:42 -0700 Created attachment 57572 patch v2 - adding ASSERT_NOT_REACHED 232871 10 57572 eric 2010-06-01 11:33:05 -0700 Comment on attachment 57572 patch v2 - adding ASSERT_NOT_REACHED When I add ASSERT_NOT_REACHED I often put a comment as to why it should not be reached. In this case: # You've hit this ASSERT either because the layout test is using an invalid string or because Qt's DumpRenderTree is missing support for that editing behavior. You've added an unconditional return due to missing {} 234652 11 57973 tonikitoo 2010-06-06 05:11:03 -0700 Created attachment 57973 (committed with r60778, reviewed by Kenneth and Eric) patch v2.1 - adding ASSERT_NOT_REACHED given the long delay, I felt free to re-upload the patch adding ASSERT_NOT_REACHED() and enclosing "{...}" to the return statment. 234829 12 57973 tonikitoo 2010-06-07 06:57:24 -0700 Comment on attachment 57973 (committed with r60778, reviewed by Kenneth and Eric) patch v2.1 - adding ASSERT_NOT_REACHED Clearing flags on attachment: 57973 Committed r60778: <http://trac.webkit.org/changeset/60778> 57034 2010-05-25 11:44:56 -0700 2010-05-25 15:17:06 -0700 (committed with r60189, reviewed by Ojan Vafai) patch v1 0001-Qt-Expose-the-editing-behavior-setting-in-DRT-to-tes.patch text/plain 8173 tonikitoo RnJvbSA3Zjc3ZWYyNDk3YjkyMjM0NTVhNzU4NzBkOTMzOTkzMTFlMTFjY2U4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVHVlLCAyNSBNYXkgMjAxMCAxNDozOTowNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gRXhwb3NlIHRoZSBlZGl0aW5nIGJlaGF2aW9yIHNldHRpbmcgaW4gRFJUIHRvIHRlc3QgYWxs IGVkaXRpbmcgY29kZSBwYXRocwogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM5NjgwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25pbyBH b21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CgpXZWJLaXQvcXQ6CgpBZGQgc3VwcG9ydCB0byBR dCdzIERSVCB0byBzZXR0aW5nIHRoZSBlZGl0aW5nIGJlaGF2aW9yLiBQYXRjaCBpcyBhIGZvbGxv dyB1cCBvZgpidWcgMzg2MDMsIHdoaWNoIGp1c3Qgc3R1YmJlZCBvdXQgdGhlIFF0IGJpdHMgb2Yg aXQuCgoqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcDogSW1wbGVt ZW50YXRpb24gb2YgZWRpdGluZyBiZWhhdmlvciBjb250cm9sLgooRHVtcFJlbmRlclRyZWVTdXBw b3J0UXQ6OnNldEVkaXRpbmdCZWhhdmlvcik6CiogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy ZWVTdXBwb3J0UXQuaDoKCldlYktpdFRvb2xzOgoKSW1wbGVtZW50IExheW91dFRlc3RDb250cm9s bGVyOjpzZXRFZGl0aW5nQmVoYXZpb3IgaW4gUXQncyBEUlQuCgoqIER1bXBSZW5kZXJUcmVlL3F0 L0R1bXBSZW5kZXJUcmVlUXQuY3BwOgooV2ViQ29yZTo6RHVtcFJlbmRlclRyZWU6OnJlc2V0VG9D b25zaXN0ZW50U3RhdGVCZWZvcmVUZXN0aW5nKToKKiBEdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRU ZXN0Q29udHJvbGxlclF0LmNwcDoKKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRFZGl0aW5nQmVo YXZpb3IpOgotLS0KIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBS ZW5kZXJUcmVlU3VwcG9ydFF0LmNwcCAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIFdlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oIHwgICAgMSArCiBXZWJL aXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysr KysrKysrKysrKysKIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVl UXQuY3BwIHwgICAgMyArKysKIC4uLi9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJv bGxlclF0LmNwcCAgIHwgICAgMiArLQogNiBmaWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJL aXQvcXQvQ2hhbmdlTG9nCmluZGV4IDFkMWRjMjcuLjU2NjU0MDIgMTAwNjQ0Ci0tLSBhL1dlYktp dC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSw4ICsxLDIyIEBA CisyMDEwLTA1LTI1ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBFeHBvc2Ug dGhlIGVkaXRpbmcgYmVoYXZpb3Igc2V0dGluZyBpbiBEUlQgdG8gdGVzdCBhbGwgZWRpdGluZyBj b2RlIHBhdGhzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zOTY4MAorCisgICAgICAgIEFkZCBzdXBwb3J0IHRvIFF0J3MgRFJUIHRvIHNldHRpbmcgdGhl IGVkaXRpbmcgYmVoYXZpb3IuIFBhdGNoIGlzIGEgZm9sbG93IHVwIG9mCisgICAgICAgIGJ1ZyAz ODYwMywgd2hpY2gganVzdCBzdHViYmVkIG91dCB0aGUgUXQgYml0cyBvZiBpdC4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcDogSW1wbGVtZW50 YXRpb24gb2YgZWRpdGluZyBiZWhhdmlvciBjb250cm9sLgorICAgICAgICAoRHVtcFJlbmRlclRy ZWVTdXBwb3J0UXQ6OnNldEVkaXRpbmdCZWhhdmlvcik6CisgICAgICAgICogV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaDoKKwogMjAxMC0wNS0yNCAgUm9iZXJ0IEhvZ2Fu ICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJv cy4KIAogICAgICAgICBbUXRdIERSVCBTdXBwb3J0IGZvciByZW1vdmVPcmlnaW5BY2Nlc3NXaGl0 ZWxpc3RFbnRyeQogCiAgICAgICAgIFVuc2tpcHMgaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9v cmlnaW4td2hpdGVsaXN0aW5nLXJlbW92YWwuaHRtbAogCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwIGIvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAppbmRleCAxNzYyZjJlLi41 NjdmZTUxIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy ZWVTdXBwb3J0UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVy VHJlZVN1cHBvcnRRdC5jcHAKQEAgLTQ2NiwxNiArNDY2LDMyIEBAIGJvb2wgRHVtcFJlbmRlclRy ZWVTdXBwb3J0UXQ6OmVsZW1lbnREb2VzQXV0b0NvbXBsZXRlRm9yRWxlbWVudFdpdGhJZChRV2Vi RnJhbWUqCiAgICAgaWYgKCFpbnB1dEVsZW1lbnQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAog ICAgIHJldHVybiAoaW5wdXRFbGVtZW50LT5pc1RleHRGaWVsZCgpCiAgICAgICAgICAgICAmJiBp bnB1dEVsZW1lbnQtPmlucHV0VHlwZSgpICE9IEhUTUxJbnB1dEVsZW1lbnQ6OlBBU1NXT1JECiAg ICAgICAgICAgICAmJiBpbnB1dEVsZW1lbnQtPmF1dG9Db21wbGV0ZSgpKTsKIH0KIAordm9pZCBE dW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0RWRpdGluZ0JlaGF2aW9yKFFXZWJQYWdlKiBwYWdl LCBjb25zdCBRU3RyaW5nJiBlZGl0aW5nQmVoYXZpb3IpCit7CisgICAgV2ViQ29yZTo6RWRpdGlu Z0JlaGF2aW9yIGNvcmVFZGl0aW5nQmVoYXZpb3I7CisKKyAgICBpZiAoZWRpdGluZ0JlaGF2aW9y ID09ICJ3aW4iKQorICAgICAgICBjb3JlRWRpdGluZ0JlaGF2aW9yID0gRWRpdGluZ1dpbmRvd3NC ZWhhdmlvcjsKKyAgICBlbHNlIGlmIChlZGl0aW5nQmVoYXZpb3IgPT0gIm1hYyIpCisgICAgICAg IGNvcmVFZGl0aW5nQmVoYXZpb3IgPSBFZGl0aW5nTWFjQmVoYXZpb3I7CisKKyAgICBQYWdlKiBj b3JlUGFnZSA9IFFXZWJQYWdlUHJpdmF0ZTo6Y29yZShwYWdlKTsKKyAgICBpZiAoIWNvcmVQYWdl KQorICAgICAgICByZXR1cm47CisKKyAgICBjb3JlUGFnZS0+c2V0dGluZ3MoKS0+c2V0RWRpdGlu Z0JlaGF2aW9yKGNvcmVFZGl0aW5nQmVoYXZpb3IpOworfQorCiB2b2lkIER1bXBSZW5kZXJUcmVl U3VwcG9ydFF0OjpkdW1wRnJhbWVMb2FkZXIoYm9vbCBiKQogewogICAgIEZyYW1lTG9hZGVyQ2xp ZW50UXQ6OmR1bXBGcmFtZUxvYWRlckNhbGxiYWNrcyA9IGI7CiB9CiAKIHZvaWQgRHVtcFJlbmRl clRyZWVTdXBwb3J0UXQ6OmR1bXBSZXNvdXJjZUxvYWRDYWxsYmFja3MoYm9vbCBiKQogewogICAg IEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmR1bXBSZXNvdXJjZUxvYWRDYWxsYmFja3MgPSBiOwpkaWZm IC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0 LmggYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaApp bmRleCAyODkwZDVjLi5mYzhlYzVkIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaApAQCAtNzMsMTYgKzczLDE3IEBAIHB1YmxpYzoK ICAgICBzdGF0aWMgdm9pZCB3ZWJQYWdlU2V0R3JvdXBOYW1lKFFXZWJQYWdlKiBwYWdlLCBjb25z dCBRU3RyaW5nJiBncm91cE5hbWUpOwogICAgIHN0YXRpYyB2b2lkIGNsZWFyRnJhbWVOYW1lKFFX ZWJGcmFtZSogZnJhbWUpOwogICAgIHN0YXRpYyB2b2lkIG92ZXJ3cml0ZVBsdWdpbkRpcmVjdG9y aWVzKCk7CiAgICAgc3RhdGljIGludCBudW1iZXJPZkFjdGl2ZUFuaW1hdGlvbnMoUVdlYkZyYW1l Kik7CiAgICAgc3RhdGljIGludCBudW1iZXJPZlBhZ2VzKFFXZWJGcmFtZSogZnJhbWUsIGZsb2F0 IHdpZHRoLCBmbG9hdCBoZWlnaHQpOwogICAgIHN0YXRpYyBpbnQgcGFnZU51bWJlckZvckVsZW1l bnRCeUlkKFFXZWJGcmFtZSogZnJhbWUsIGNvbnN0IFFTdHJpbmcmIGlkLCBmbG9hdCB3aWR0aCwg ZmxvYXQgaGVpZ2h0KTsKICAgICBzdGF0aWMgYm9vbCBoYXNEb2N1bWVudEVsZW1lbnQoUVdlYkZy YW1lKiBmcmFtZSk7CiAgICAgc3RhdGljIGJvb2wgZWxlbWVudERvZXNBdXRvQ29tcGxldGVGb3JF bGVtZW50V2l0aElkKFFXZWJGcmFtZSogZnJhbWUsIGNvbnN0IFFTdHJpbmcmIGVsZW1lbnRJZCk7 CisgICAgc3RhdGljIHZvaWQgc2V0RWRpdGluZ0JlaGF2aW9yKFFXZWJQYWdlKiBwYWdlLCBjb25z dCBRU3RyaW5nJiBlZGl0aW5nQmVoYXZpb3IpOwogCiAgICAgc3RhdGljIHZvaWQgd2hpdGVMaXN0 QWNjZXNzRnJvbU9yaWdpbihjb25zdCBRU3RyaW5nJiBzb3VyY2VPcmlnaW4sIGNvbnN0IFFTdHJp bmcmIGRlc3RpbmF0aW9uUHJvdG9jb2wsIGNvbnN0IFFTdHJpbmcmIGRlc3RpbmF0aW9uSG9zdCwg Ym9vbCBhbGxvd0Rlc3RpbmF0aW9uU3ViZG9tYWlucyk7CiAgICAgc3RhdGljIHZvaWQgcmVtb3Zl V2hpdGVMaXN0QWNjZXNzRnJvbU9yaWdpbihjb25zdCBRU3RyaW5nJiBzb3VyY2VPcmlnaW4sIGNv bnN0IFFTdHJpbmcmIGRlc3RpbmF0aW9uUHJvdG9jb2wsIGNvbnN0IFFTdHJpbmcmIGRlc3RpbmF0 aW9uSG9zdCwgYm9vbCBhbGxvd0Rlc3RpbmF0aW9uU3ViZG9tYWlucyk7CiAgICAgc3RhdGljIHZv aWQgcmVzZXRPcmlnaW5BY2Nlc3NXaGl0ZUxpc3RzKCk7CiAKICAgICBzdGF0aWMgaW50IHdvcmtl clRocmVhZENvdW50KCk7CiAKICAgICBzdGF0aWMgUVN0cmluZyBtYXJrZXJUZXh0Rm9yTGlzdEl0 ZW0oY29uc3QgUVdlYkVsZW1lbnQmIGxpc3RJdGVtKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBhZDE1OTU1Li4yNWNiNmZk IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDggKzEsMjIgQEAKKzIwMTAtMDUtMjUgIEFudG9uaW8gR29tZXMgIDx0b25p a2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIEV4cG9zZSB0aGUgZWRpdGluZyBiZWhhdmlvciBzZXR0aW5nIGluIERS VCB0byB0ZXN0IGFsbCBlZGl0aW5nIGNvZGUgcGF0aHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NjgwCisKKyAgICAgICAgSW1wbGVtZW50IExheW91 dFRlc3RDb250cm9sbGVyOjpzZXRFZGl0aW5nQmVoYXZpb3IgaW4gUXQncyBEUlQuCisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkR1bXBSZW5kZXJUcmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGlu Zyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5j cHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0RWRpdGluZ0JlaGF2aW9yKToK KwogMjAxMC0wNS0yNCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsIGFuZCBLZW50IFRhbXVyYSAoZm9yIHRoZSBD aHJvbWl1bSBwYXJ0KS4KIAogICAgICAgICBlZGl0aW5nQmVoYXZpb3Igc2V0dGluZ3MgbmVlZHMg dG8gYmUgc2V0IGJhY2sgdG8gYSByZWFzb25hYmxlIGRlZmF1bHQgYmV0d2VlbiB0ZXN0cwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk0MzMKIAogICAg ICAgICBTaW1pbGFybHkgdG8gcjU5ODYxLCBoYXJkIGNvZGUgdGhlIGRlZmF1bHQgc2V0dGluZyBk dXJpbmcgcmVzZXQgZm9yIEd0ayBhbmQgQ2hyb21pdW0sCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcCBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCmluZGV4IGYxMTlkZDAuLmI1OWFl OGYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJU cmVlUXQuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJU cmVlUXQuY3BwCkBAIC00NTIsMTYgKzQ1MiwxOSBAQCB2b2lkIER1bXBSZW5kZXJUcmVlOjpyZXNl dFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZygpCiAgICAgbV9wYWdlLT5tYWluRnJhbWUo KS0+c2V0U2Nyb2xsQmFyUG9saWN5KFF0OjpWZXJ0aWNhbCwgUXQ6OlNjcm9sbEJhckFzTmVlZGVk KTsKICAgICBtX3BhZ2UtPm1haW5GcmFtZSgpLT5zZXRTY3JvbGxCYXJQb2xpY3koUXQ6Okhvcml6 b250YWwsIFF0OjpTY3JvbGxCYXJBc05lZWRlZCk7CiAKICAgICBXb3JrUXVldWU6OnNoYXJlZCgp LT5jbGVhcigpOwogICAgIFdvcmtRdWV1ZTo6c2hhcmVkKCktPnNldEZyb3plbihmYWxzZSk7CiAK ICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6cmVzZXRPcmlnaW5BY2Nlc3NXaGl0ZUxpc3Rz KCk7CiAKKyAgICAvLyBRdCBkZWZhdWx0cyB0byBXaW5kb3dzIGVkaXRpbmcgYmVoYXZpb3IuCisg ICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNldEVkaXRpbmdCZWhhdmlvcihtX3BhZ2UsICJ3 aW4iKTsKKwogICAgIFFMb2NhbGU6OnNldERlZmF1bHQoUUxvY2FsZTo6YygpKTsKICAgICBzZXRs b2NhbGUoTENfQUxMLCAiIik7CiB9CiAKIHN0YXRpYyBib29sIGlzV2ViSW5zcGVjdG9yVGVzdChj b25zdCBRVXJsJiB1cmwpCiB7CiAgICAgaWYgKHVybC5wYXRoKCkuY29udGFpbnMoImluc3BlY3Rv ci8iKSkKICAgICAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcCBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwCmluZGV4IGIyZDAyODAu LmU2OTY4NzQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91 dFRlc3RDb250cm9sbGVyUXQuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwCkBAIC02MzUsMTMgKzYzNSwxMyBAQCB2b2lkIExh eW91dFRlc3RDb250cm9sbGVyOjpzZXRJY29uRGF0YWJhc2VFbmFibGVkKGJvb2wgZW5hYmxlKQog ICAgIGlmIChlbmFibGUgJiYgIW1fZHJ0LT5wZXJzaXN0ZW50U3RvcmFnZVBhdGgoKS5pc0VtcHR5 KCkpCiAgICAgICAgIFFXZWJTZXR0aW5nczo6c2V0SWNvbkRhdGFiYXNlUGF0aChtX2RydC0+cGVy c2lzdGVudFN0b3JhZ2VQYXRoKCkpOwogICAgIGVsc2UKICAgICAgICAgUVdlYlNldHRpbmdzOjpz ZXRJY29uRGF0YWJhc2VQYXRoKFFTdHJpbmcoKSk7CiB9CiAKIHZvaWQgTGF5b3V0VGVzdENvbnRy b2xsZXI6OnNldEVkaXRpbmdCZWhhdmlvcihjb25zdCBRU3RyaW5nJiBlZGl0aW5nQmVoYXZpb3Ip CiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudC4KKyAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRR dDo6c2V0RWRpdGluZ0JlaGF2aW9yKG1fZHJ0LT53ZWJQYWdlKCksIGVkaXRpbmdCZWhhdmlvcik7 CiB9CiAKIGNvbnN0IHVuc2lnbmVkIExheW91dFRlc3RDb250cm9sbGVyOjptYXhWaWV3V2lkdGgg PSA4MDA7CiBjb25zdCB1bnNpZ25lZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bWF4Vmlld0hlaWdo dCA9IDYwMDsKLS0gCjEuNy4wLjQKCg== 57403 2010-05-28 20:04:14 -0700 2010-06-01 11:24:42 -0700 proposed patch 39680.patch text/plain 1379 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjAzODMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gRXhwb3NlIHRoZSBlZGl0aW5nIGJlaGF2aW9yIHNldHRpbmcgaW4g RFJUIHRvIHRlc3QgYWxsIGVkaXRpbmcgY29kZSBwYXRocworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2ODAKKworICAgICAgICBNYWtlIHNldEVkaXRp bmdCZWhhdmlvcigpIGEgbm8tb3BlcmF0aW9uIGlmIHRoZSBlZGl0aW5nQmVoYXZpb3IKKyAgICAg ICAgYXJndW1lbnQgaXMgbm90IHJlY29nbml6ZWQgdG8gYXZvaWQgdXNpbmcgYW4gdW5pbml0aWFs aXplZCB2YXJpYWJsZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydFF0LmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRFZGl0 aW5nQmVoYXZpb3IpOgorCiAyMDEwLTA1LTI4ICBBbnR0aSBLb2l2aXN0byAgPGtvaXZpc3RvQGlr aS5maT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K SW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydFF0LmNwcAkocmV2aXNpb24gNjAzNzgpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00ODIsNiAr NDgyLDggQEAgdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0RWRpdGluZwogICAgICAg ICBjb3JlRWRpdGluZ0JlaGF2aW9yID0gRWRpdGluZ1dpbmRvd3NCZWhhdmlvcjsKICAgICBlbHNl IGlmIChlZGl0aW5nQmVoYXZpb3IgPT0gIm1hYyIpCiAgICAgICAgIGNvcmVFZGl0aW5nQmVoYXZp b3IgPSBFZGl0aW5nTWFjQmVoYXZpb3I7CisgICAgZWxzZQorICAgICAgICByZXR1cm47CiAKICAg ICBQYWdlKiBjb3JlUGFnZSA9IFFXZWJQYWdlUHJpdmF0ZTo6Y29yZShwYWdlKTsKICAgICBpZiAo IWNvcmVQYWdlKQo= 57572 2010-06-01 11:24:42 -0700 2010-06-06 05:11:03 -0700 patch v2 - adding ASSERT_NOT_REACHED 39680.patch text/plain 1406 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjA0ODkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMDEgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gRXhwb3NlIHRoZSBlZGl0aW5nIGJlaGF2aW9yIHNldHRpbmcgaW4g RFJUIHRvIHRlc3QgYWxsIGVkaXRpbmcgY29kZSBwYXRocworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2ODAKKworICAgICAgICBNYWtlIHNldEVkaXRp bmdCZWhhdmlvcigpIGEgbm8tb3BlcmF0aW9uIGlmIHRoZSBlZGl0aW5nQmVoYXZpb3IKKyAgICAg ICAgYXJndW1lbnQgaXMgbm90IHJlY29nbml6ZWQgdG8gYXZvaWQgdXNpbmcgYW4gdW5pbml0aWFs aXplZCB2YXJpYWJsZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydFF0LmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRFZGl0 aW5nQmVoYXZpb3IpOgorCiAyMDEwLTA2LTAxICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNt YW5uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpJbmRl eDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBw b3J0UXQuY3BwCShyZXZpc2lvbiA2MDQ3OCkKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E dW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4Miw2ICs0ODIs OSBAQCB2b2lkIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRFZGl0aW5nCiAgICAgICAgIGNv cmVFZGl0aW5nQmVoYXZpb3IgPSBFZGl0aW5nV2luZG93c0JlaGF2aW9yOwogICAgIGVsc2UgaWYg KGVkaXRpbmdCZWhhdmlvciA9PSAibWFjIikKICAgICAgICAgY29yZUVkaXRpbmdCZWhhdmlvciA9 IEVkaXRpbmdNYWNCZWhhdmlvcjsKKyAgICBlbHNlCisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hF RCgpOworICAgICAgICByZXR1cm47CiAKICAgICBQYWdlKiBjb3JlUGFnZSA9IFFXZWJQYWdlUHJp dmF0ZTo6Y29yZShwYWdlKTsKICAgICBpZiAoIWNvcmVQYWdlKQo= 57973 2010-06-06 05:11:03 -0700 2010-06-07 06:57:23 -0700 (committed with r60778, reviewed by Kenneth and Eric) patch v2.1 - adding ASSERT_NOT_REACHED 0001-Qt-Expose-the-editing-behavior-setting-in-DRT-to-tes.patch text/plain 2304 tonikitoo RnJvbSBkYzk0OTM1ZTU5NTNjMGMzYmVjZmVhNzU0ZDQ0YWQxYTAzMjg2N2Y1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogU3VuLCA2IEp1biAyMDEwIDA4OjA5OjA2IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW1F0 XSBFeHBvc2UgdGhlIGVkaXRpbmcgYmVoYXZpb3Igc2V0dGluZyBpbiBEUlQgdG8gdGVzdCBhbGwg ZWRpdGluZyBjb2RlIHBhdGhzCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mzk2ODAKClBhdGNoIGJ5IEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4s IExhc3psbyBHb21ib3MgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+IG9uIDIwMTAtMDYtMDYK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpNYWtlIHNldEVkaXRpbmdCZWhhdmlvcigpIGEg bm8tb3BlcmF0aW9uIGlmIHRoZSBlZGl0aW5nQmVoYXZpb3IKYXJndW1lbnQgaXMgbm90IHJlY29n bml6ZWQgdG8gYXZvaWQgdXNpbmcgYW4gdW5pbml0aWFsaXplZCB2YXJpYWJsZS4KCiogV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwOgooRHVtcFJlbmRlclRyZWVTdXBw b3J0UXQ6OnNldEVkaXRpbmdCZWhhdmlvcik6Ci0tLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIC4uLi9xdC9X ZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAgIHwgICAgNCArKysrCiAy IGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggOTQ1 MDk2YS4uNjFjYzdhZSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJL aXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMDYgIEFudG9uaW8gR29t ZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4sIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRXhwb3NlIHRoZSBlZGl0aW5nIGJlaGF2aW9yIHNldHRpbmcgaW4gRFJUIHRv IHRlc3QgYWxsIGVkaXRpbmcgY29kZSBwYXRocworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2ODAKKworICAgICAgICBNYWtlIHNldEVkaXRpbmdCZWhh dmlvcigpIGEgbm8tb3BlcmF0aW9uIGlmIHRoZSBlZGl0aW5nQmVoYXZpb3IKKyAgICAgICAgYXJn dW1lbnQgaXMgbm90IHJlY29nbml6ZWQgdG8gYXZvaWQgdXNpbmcgYW4gdW5pbml0aWFsaXplZCB2 YXJpYWJsZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9y dFF0LmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRFZGl0aW5nQmVo YXZpb3IpOgorCiAyMDEwLTA2LTA0ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5v a2lhLmNvbT4KIAogICAgICAgICBTeW1iaWFuIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1dlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAgYi9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCmluZGV4IDc0MWIw NmEuLjZjM2U1YzkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVu ZGVyVHJlZVN1cHBvcnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBS ZW5kZXJUcmVlU3VwcG9ydFF0LmNwcApAQCAtNDgyLDYgKzQ4MiwxMCBAQCB2b2lkIER1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0OjpzZXRFZGl0aW5nQmVoYXZpb3IoUVdlYlBhZ2UqIHBhZ2UsIGNvbnN0 IFFTdHJpbmcmCiAgICAgICAgIGNvcmVFZGl0aW5nQmVoYXZpb3IgPSBFZGl0aW5nV2luZG93c0Jl aGF2aW9yOwogICAgIGVsc2UgaWYgKGVkaXRpbmdCZWhhdmlvciA9PSAibWFjIikKICAgICAgICAg Y29yZUVkaXRpbmdCZWhhdmlvciA9IEVkaXRpbmdNYWNCZWhhdmlvcjsKKyAgICBlbHNlIHsKKyAg ICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAg ICBQYWdlKiBjb3JlUGFnZSA9IFFXZWJQYWdlUHJpdmF0ZTo6Y29yZShwYWdlKTsKICAgICBpZiAo IWNvcmVQYWdlKQotLSAKMS43LjAuNAoK