39663 2010-05-25 02:07:19 -0700 Update the style guide re: static member variables and structs 2010-05-28 02:02:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow darin tkent oldest_to_newest 230178 0 jorlow 2010-05-25 02:07:19 -0700 Update the style guide re: static member variables and structs 230179 1 56995 jorlow 2010-05-25 02:14:37 -0700 Created attachment 56995 Patch 230295 2 56995 darin 2010-05-25 08:55:15 -0700 Comment on attachment 56995 Patch > -<li>Prefix C++ data members with "m_". > +<li>Prefix C++ class member variables with "m_" and do not make them public. The term "data members" is correct C++ terminology. The term "member variables" is not correct C++ terminology. I would write: Prefix C++ data members with "m_" and static data members with "s_" and do not make them public > +<li>Static member variables should be prefixed with "s_".</li> The correct term is "static data members". 230300 3 jorlow 2010-05-25 09:09:41 -0700 (In reply to comment #2) > (From update of attachment 56995 [details]) > > -<li>Prefix C++ data members with "m_". > > +<li>Prefix C++ class member variables with "m_" and do not make them public. > > The term "data members" is correct C++ terminology. The term "member variables" is not correct C++ terminology. I would write: > > Prefix C++ data members with "m_" and static data members with "s_" and do not make them public Does "C++ data member" imply class (vs. structs)? Even if so, I think we should explicitly explain that public data members are OK with structs but not classes. > > +<li>Static member variables should be prefixed with "s_".</li> > > The correct term is "static data members". I will delete this and mention it above instead. 230636 4 tkent 2010-05-26 03:20:51 -0700 (In reply to comment #3) > Does "C++ data member" imply class (vs. structs)? Even if so, I think we should explicitly explain that public data members are OK with structs but not classes. "data member" is used for structs too in the standard. 230648 5 57088 jorlow 2010-05-26 03:45:04 -0700 Created attachment 57088 Patch 230767 6 57088 darin 2010-05-26 10:49:47 -0700 Comment on attachment 57088 Patch > -<li>Prefix C++ data members with "m_". > +<li>All data members in C++ classes must be private. Static data members should be prefixed by "s_". All other data members should be prefixed by "m_". Why the "must" vs. "should" here? I don’t think we need the word “All”. 231266 7 57233 jorlow 2010-05-27 06:23:18 -0700 Created attachment 57233 Patch 231610 8 jorlow 2010-05-28 02:02:15 -0700 Committed r60346: <http://trac.webkit.org/changeset/60346> 56995 2010-05-25 02:14:37 -0700 2010-05-26 03:44:57 -0700 Patch bug-39663-20100525101435.patch text/plain 2122 jorlow ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggZjRkYWI1MWRhMGIyM2M0N2NjOGY3NzE3NDYyNjM4MWFjMjc4ODYzMS4uODI4NjA5NmRl NDU5MzEwYjgyYmMxZGU5NTU3ZDUxMWFmNzI0YzM3MCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx MC0wNS0yNSAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIHN0eWxlIGd1 aWRlIHJlOiBzdGF0aWMgbWVtYmVyIHZhcmlhYmxlcyBhbmQgc3RydWN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2NjMKKworICAgICAgICBQZXIg RGFyaW4gQWRsZXIncyBwcm9wb3NhbCBvbiB3ZWJraXQtZGV2LgorCisgICAgICAgIEFsbCBzdGF0 aWMgbWVtYmVyIHZhcmlhYmxlcyBzaG91bGQgYmUgcHJlZml4ZWQgd2l0aCBzXy4KKyAgICAgICAg bV8gc2hvdWxkIG5vdCBiZSB1c2VkIGZvciBwdWJsaWMgZGF0YSBtZW1iZXJzIGluIHN0cnVjdHMu CisgICAgICAgIE9ubHkgc3RydWN0cyBzaG91bGQgaGF2ZSBwdWJsaWMgZGF0YSBtZW1iZXJzLgor CisgICAgICAgICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOgorCiAyMDEwLTA1LTI0ICBEYXZp ZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNp ZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHls ZS5odG1sIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKaW5kZXggZTcxNWEy OGQwN2I5MjI0MTg0MjE1OGZlNWM0NzYyZDA5NWUyYWFiMi4uNWQwYjI2OGNmODNhMjAzYThjY2M1 Y2I0ZjFmODMyZDhkYmQ2MGJhNyAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5n LXN0eWxlLmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKQEAg LTUwNiwxMSArNTA2LDE0IEBAIHNob3J0IHRhYnVsYXRpb25JbmRleDsgLy8gYml6YXJyZQogPC9w cmU+CiA8L2xpPgogCi08bGk+UHJlZml4IEMrKyBkYXRhIG1lbWJlcnMgd2l0aCAibV8iLgorPGxp PlByZWZpeCBDKysgY2xhc3MgbWVtYmVyIHZhcmlhYmxlcyB3aXRoICJtXyIgYW5kIGRvIG5vdCBt YWtlIHRoZW0gcHVibGljLgogPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9oND4KIDxwcmUgY2xh c3M9ImNvZGUiPgogY2xhc3MgU3RyaW5nIHsKK3B1YmxpYzoKICAgICAuLi4KKworcHJpdmF0ZToK ICAgICBzaG9ydCBtX2xlbmd0aDsKIH07CiA8L3ByZT4KQEAgLTUxOCw3ICs1MjEsOSBAQCBjbGFz cyBTdHJpbmcgewogPGg0IGNsYXNzPSJ3cm9uZyI+V3Jvbmc6PC9oND4KIDxwcmUgY2xhc3M9ImNv ZGUiPgogY2xhc3MgU3RyaW5nIHsKK3B1YmxpYzoKICAgICAuLi4KKwogICAgIHNob3J0IGxlbmd0 aDsKIH07CiA8L3ByZT4KQEAgLTU5OCw2ICs2MDMsNyBAQCB2b2lkIHNldENvdW50KHNpemVfdCBj b3VudCk7CiB0aGV5IHNob3VsZCByZWFkIGxpa2UgYSBwaHJhc2UgYW5kIGVhY2ggcGllY2Ugb2Yg dGhlIHNlbGVjdG9yIHNob3VsZCAKIHN0YXJ0IHdpdGggYSBsb3dlcmNhc2UgbGV0dGVyIGFuZCB1 c2UgaW50ZXJjYXBzLjwvbGk+CiA8bGk+RW51bSBtZW1iZXJzIHNob3VsZCB1c2VyIEludGVyQ2Fw cyB3aXRoIGFuIGluaXRpYWwgY2FwaXRhbCBsZXR0ZXIuPC9saT4KKzxsaT5TdGF0aWMgbWVtYmVy IHZhcmlhYmxlcyBzaG91bGQgYmUgcHJlZml4ZWQgd2l0aCAic18iLjwvbGk+CiA8bGk+UHJlZmVy IGNvbnN0IHRvICNkZWZpbmUuIFByZWZlciBpbmxpbmUgZnVuY3Rpb25zIHRvIG1hY3Jvcy48L2xp PgogPGxpPiNkZWZpbmVkIGNvbnN0YW50cyBzaG91bGQgdXNlIGFsbCB1cHBlcmNhc2UgbmFtZXMg d2l0aCB3b3JkcyBzZXBhcmF0ZWQgYnkgdW5kZXJzY29yZXMuPC9saT4KIDxsaT4gTWFjcm9zIHRo YXQgZXhwYW5kIHRvIGZ1bmN0aW9uIGNhbGxzIG9yIG90aGVyIG5vbi1jb25zdGFudCBjb21wdXRh dGlvbjogdGhlc2UgCg== 57088 2010-05-26 03:45:04 -0700 2010-05-27 06:23:10 -0700 Patch bug-39663-20100526114502.patch text/plain 1631 jorlow ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggZjRkYWI1MWRhMGIyM2M0N2NjOGY3NzE3NDYyNjM4MWFjMjc4ODYzMS4uODI4NjA5NmRl NDU5MzEwYjgyYmMxZGU5NTU3ZDUxMWFmNzI0YzM3MCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx MC0wNS0yNSAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIHN0eWxlIGd1 aWRlIHJlOiBzdGF0aWMgbWVtYmVyIHZhcmlhYmxlcyBhbmQgc3RydWN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2NjMKKworICAgICAgICBQZXIg RGFyaW4gQWRsZXIncyBwcm9wb3NhbCBvbiB3ZWJraXQtZGV2LgorCisgICAgICAgIEFsbCBzdGF0 aWMgbWVtYmVyIHZhcmlhYmxlcyBzaG91bGQgYmUgcHJlZml4ZWQgd2l0aCBzXy4KKyAgICAgICAg bV8gc2hvdWxkIG5vdCBiZSB1c2VkIGZvciBwdWJsaWMgZGF0YSBtZW1iZXJzIGluIHN0cnVjdHMu CisgICAgICAgIE9ubHkgc3RydWN0cyBzaG91bGQgaGF2ZSBwdWJsaWMgZGF0YSBtZW1iZXJzLgor CisgICAgICAgICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOgorCiAyMDEwLTA1LTI0ICBEYXZp ZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNp ZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHls ZS5odG1sIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKaW5kZXggZTcxNWEy OGQwN2I5MjI0MTg0MjE1OGZlNWM0NzYyZDA5NWUyYWFiMi4uZWE1ZWFhYzYxZTgwYzRhNTBmMDU3 OWE3ZDk0NDAxNTExNThhODU2YiAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5n LXN0eWxlLmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKQEAg LTUwNiwxMSArNTA2LDE0IEBAIHNob3J0IHRhYnVsYXRpb25JbmRleDsgLy8gYml6YXJyZQogPC9w cmU+CiA8L2xpPgogCi08bGk+UHJlZml4IEMrKyBkYXRhIG1lbWJlcnMgd2l0aCAibV8iLgorPGxp PkFsbCBkYXRhIG1lbWJlcnMgaW4gQysrIGNsYXNzZXMgbXVzdCBiZSBwcml2YXRlLiAgU3RhdGlj IGRhdGEgbWVtYmVycyBzaG91bGQgYmUgcHJlZml4ZWQgYnkgInNfIi4gIEFsbCBvdGhlciBkYXRh IG1lbWJlcnMgc2hvdWxkIGJlIHByZWZpeGVkIGJ5ICJtXyIuCiA8aDQgY2xhc3M9InJpZ2h0Ij5S aWdodDo8L2g0PgogPHByZSBjbGFzcz0iY29kZSI+CiBjbGFzcyBTdHJpbmcgeworcHVibGljOgog ICAgIC4uLgorCitwcml2YXRlOgogICAgIHNob3J0IG1fbGVuZ3RoOwogfTsKIDwvcHJlPgpAQCAt NTE4LDcgKzUyMSw5IEBAIGNsYXNzIFN0cmluZyB7CiA8aDQgY2xhc3M9Indyb25nIj5Xcm9uZzo8 L2g0PgogPHByZSBjbGFzcz0iY29kZSI+CiBjbGFzcyBTdHJpbmcgeworcHVibGljOgogICAgIC4u LgorCiAgICAgc2hvcnQgbGVuZ3RoOwogfTsKIDwvcHJlPgo= 57233 2010-05-27 06:23:18 -0700 2010-05-27 13:07:29 -0700 Patch bug-39663-20100527142316.patch text/plain 1625 jorlow ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggZjRkYWI1MWRhMGIyM2M0N2NjOGY3NzE3NDYyNjM4MWFjMjc4ODYzMS4uODI4NjA5NmRl NDU5MzEwYjgyYmMxZGU5NTU3ZDUxMWFmNzI0YzM3MCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx MC0wNS0yNSAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIHN0eWxlIGd1 aWRlIHJlOiBzdGF0aWMgbWVtYmVyIHZhcmlhYmxlcyBhbmQgc3RydWN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2NjMKKworICAgICAgICBQZXIg RGFyaW4gQWRsZXIncyBwcm9wb3NhbCBvbiB3ZWJraXQtZGV2LgorCisgICAgICAgIEFsbCBzdGF0 aWMgbWVtYmVyIHZhcmlhYmxlcyBzaG91bGQgYmUgcHJlZml4ZWQgd2l0aCBzXy4KKyAgICAgICAg bV8gc2hvdWxkIG5vdCBiZSB1c2VkIGZvciBwdWJsaWMgZGF0YSBtZW1iZXJzIGluIHN0cnVjdHMu CisgICAgICAgIE9ubHkgc3RydWN0cyBzaG91bGQgaGF2ZSBwdWJsaWMgZGF0YSBtZW1iZXJzLgor CisgICAgICAgICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOgorCiAyMDEwLTA1LTI0ICBEYXZp ZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNp ZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHls ZS5odG1sIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKaW5kZXggZTcxNWEy OGQwN2I5MjI0MTg0MjE1OGZlNWM0NzYyZDA5NWUyYWFiMi4uMTA1MjdmMjgyYjAxYzkwZTgyNGYx ZDUwOTllM2JjM2IzMWE5MDI1ZiAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5n LXN0eWxlLmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKQEAg LTUwNiwxMSArNTA2LDE0IEBAIHNob3J0IHRhYnVsYXRpb25JbmRleDsgLy8gYml6YXJyZQogPC9w cmU+CiA8L2xpPgogCi08bGk+UHJlZml4IEMrKyBkYXRhIG1lbWJlcnMgd2l0aCAibV8iLgorPGxp PkRhdGEgbWVtYmVycyBpbiBDKysgY2xhc3NlcyBzaG91bGQgYmUgcHJpdmF0ZS4gIFN0YXRpYyBk YXRhIG1lbWJlcnMgc2hvdWxkIGJlIHByZWZpeGVkIGJ5ICJzXyIuICBPdGhlciBkYXRhIG1lbWJl cnMgc2hvdWxkIGJlIHByZWZpeGVkIGJ5ICJtXyIuCiA8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8 L2g0PgogPHByZSBjbGFzcz0iY29kZSI+CiBjbGFzcyBTdHJpbmcgeworcHVibGljOgogICAgIC4u LgorCitwcml2YXRlOgogICAgIHNob3J0IG1fbGVuZ3RoOwogfTsKIDwvcHJlPgpAQCAtNTE4LDcg KzUyMSw5IEBAIGNsYXNzIFN0cmluZyB7CiA8aDQgY2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0Pgog PHByZSBjbGFzcz0iY29kZSI+CiBjbGFzcyBTdHJpbmcgeworcHVibGljOgogICAgIC4uLgorCiAg ICAgc2hvcnQgbGVuZ3RoOwogfTsKIDwvcHJlPgo=