39661 2010-05-25 01:41:50 -0700 Switch HTML parsing benchmark to use document.write instead of innerHTML 2010-05-25 05:55:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 230158 0 abarth 2010-05-25 01:41:50 -0700 Switch HTML parsing benchmark to use document.write instead of innerHTML 230160 1 56990 abarth 2010-05-25 01:43:15 -0700 Created attachment 56990 Patch 230161 2 56990 eric 2010-05-25 01:44:31 -0700 Comment on attachment 56990 Patch OK. How does the performance compare with the original benchmark? Are we still spending a similar amount of time in the tokenizer/parser? Please comment before landing. 230175 3 56990 abarth 2010-05-25 01:59:58 -0700 Comment on attachment 56990 Patch Yeah, it's still spending 10% of its time in parseTag (and 42% in functions below that). 230234 4 56990 commit-queue 2010-05-25 05:55:27 -0700 Comment on attachment 56990 Patch Clearing flags on attachment: 56990 Committed r60157: <http://trac.webkit.org/changeset/60157> 230235 5 commit-queue 2010-05-25 05:55:33 -0700 All reviewed patches have been landed. Closing bug. 56990 2010-05-25 01:43:15 -0700 2010-05-25 05:55:27 -0700 Patch bug-39661-20100525014313.patch text/plain 1466 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzMzODM5ZWE3MmIyMzEwYWRiNmRjODU3OTBlOTg4NjQ0MDFhZDI5Mi4uN2U1N2U0ODhjYmQ5NjE4 YTk4NTBlMDk0MjdmOWI3Mzg1OTUxZmQzYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxOCBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFN3aXRjaCBIVE1MIHBhcnNpbmcgYmVu Y2htYXJrIHRvIHVzZSBkb2N1bWVudC53cml0ZSBpbnN0ZWFkIG9mIGlubmVySFRNTAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2NjEKKworICAgICAg ICBXZSdkIGxpa2UgdG8gZXhlcmNpc2UgdGhlIG1haW4gcGFyc2luZyBwaXBlbGluZSBpbnN0ZWFk IG9mIHRoZSBmcmFnbWVudAorICAgICAgICBwYXJzaW5nIHBpcGVsaW5lLgorCisgICAgICAgICog YmVuY2htYXJrcy9wYXJzZXIvaHRtbC1wYXJzZXIuaHRtbDoKKworMjAxMC0wNS0yNSAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCiAgICAgICAgIENsZWFyIGF0dHJpYnV0ZXMgZm9yIGVhY2ggdGFnIGluIHRoZSBI VE1MNSBwYXJzZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM5NjYwCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmVuY2htYXJrcy9wYXJzZXIvaHRtbC1w YXJzZXIuaHRtbCBiL1dlYkNvcmUvYmVuY2htYXJrcy9wYXJzZXIvaHRtbC1wYXJzZXIuaHRtbApp bmRleCAyNDgxMGRhZGUxNmNhYWFmNTM2ZDI0OGZlZTc3YWRlNTcyM2RmMWZjLi41NmE0MGMzYmY3 YTE5ZGJiOGZiMjZmOWViZDhhNjBhMGIxMjEwNDEyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JlbmNo bWFya3MvcGFyc2VyL2h0bWwtcGFyc2VyLmh0bWwKKysrIGIvV2ViQ29yZS9iZW5jaG1hcmtzL3Bh cnNlci9odG1sLXBhcnNlci5odG1sCkBAIC0yMSw4ICsyMSw5IEBAIGZ1bmN0aW9uIHBhcnNlKGh0 bWwpIHsKICAgICBpZnJhbWUuc3JjID0gImFib3V0OmJsYW5rIjsKICAgICBpZnJhbWUuc3R5bGUu ZGlzcGxheSA9ICJub25lIjsKICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcmFtZSkK LSAgICB2YXIgZGV0YWNoZWRFbGVtZW50ID0gaWZyYW1lLmNvbnRlbnREb2N1bWVudC5jcmVhdGVF bGVtZW50KCJkaXYiKTsKLSAgICBkZXRhY2hlZEVsZW1lbnQuaW5uZXJIVE1MID0gaHRtbDsKKyAg ICBpZnJhbWUuY29udGVudERvY3VtZW50Lm9wZW4oKTsKKyAgICBpZnJhbWUuY29udGVudERvY3Vt ZW50LndyaXRlKGh0bWwpOworICAgIGlmcmFtZS5jb250ZW50RG9jdW1lbnQuY2xvc2UoKTsKICAg ICBkb2N1bWVudC5ib2R5LnJlbW92ZUNoaWxkKGlmcmFtZSkKIH0KIAo=