39658 2010-05-25 01:27:55 -0700 Build fix for JSFunction 2010-05-25 09:52:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned beergun commit-queue joybro201 oldest_to_newest 230150 0 skyul 2010-05-25 01:27:55 -0700 MSVC can't compile one of JSFunction constructors when JIT is disabled. "PassRefPtr<NativeExecutable>" causes the compile error as NativeExecutable is not defined. c:\cygwin\home\kseo\webkitbrew\javascriptcore\wtf\passrefptr.h(66) : error C2027: use of undefined type 'JSC::NativeExecutable' c:\cygwin\home\kseo\webkitbrew\javascriptcore\runtime\jsfunction.h(36) : see declaration of 'JSC::NativeExecutable' c:\cygwin\home\kseo\webkitbrew\javascriptcore\wtf\passrefptr.h(80) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled with [ T=JSC::NativeExecutable ] c:\cygwin\home\kseo\webkitbrew\javascriptcore\wtf\passrefptr.h(80) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)' with [ T=JSC::NativeExecutable ] c:\cygwin\home\kseo\webkitbrew\javascriptcore\runtime\jsfunction.cpp(66) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled with [ T=JSC::NativeExecutable ] c:\cygwin\home\kseo\webkitbrew\javascriptcore\wtf\passrefptr.h(66) : error C2227: left of '->deref' must point to class/struct/union/generic type Add ENABLE(JIT) guard to the constructor. 230151 1 56987 skyul 2010-05-25 01:32:12 -0700 Created attachment 56987 Patch 230323 2 56987 commit-queue 2010-05-25 09:52:09 -0700 Comment on attachment 56987 Patch Clearing flags on attachment: 56987 Committed r60170: <http://trac.webkit.org/changeset/60170> 230324 3 commit-queue 2010-05-25 09:52:14 -0700 All reviewed patches have been landed. Closing bug. 56987 2010-05-25 01:32:12 -0700 2010-05-25 09:52:08 -0700 Patch JSFunction.patch text/plain 2736 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYwMTQ2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMjUgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBCdWlsZCBmaXggZm9yIEpTRnVuY3Rpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NjU4CisKKyAgICAgICAg TVNWQyBjYW4ndCBjb21waWxlIG9uZSBvZiBKU0Z1bmN0aW9uIGNvbnN0cnVjdG9ycyB3aGVuIEpJ VCBpcyBkaXNhYmxlZC4KKyAgICAgICAgIlBhc3NSZWZQdHI8TmF0aXZlRXhlY3V0YWJsZT4iIGNh dXNlcyB0aGUgY29tcGlsZSBlcnJvciBhcyBOYXRpdmVFeGVjdXRhYmxlIGlzIG5vdCBkZWZpbmVk LiAKKyAgICAgICAgQWRkIEVOQUJMRShKSVQpIGd1YXJkIHRvIHRoZSBjb25zdHJ1Y3Rvci4KKwor ICAgICAgICAqIHJ1bnRpbWUvSlNGdW5jdGlvbi5jcHA6CisgICAgICAgIChKU0M6OkpTRnVuY3Rp b246OkpTRnVuY3Rpb24pOgorICAgICAgICAqIHJ1bnRpbWUvSlNGdW5jdGlvbi5oOgorCiAyMDEw LTA1LTI0ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0Z1bmN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT RnVuY3Rpb24uY3BwCShyZXZpc2lvbiA2MDE0MikKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNGdW5jdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2LDIyICs2NiwxNiBAQCBKU0Z1bmN0 aW9uOjpKU0Z1bmN0aW9uKE5vbk51bGxQYXNzUmVmUHRyCiB7CiB9CiAKKyNpZiBFTkFCTEUoSklU KQogSlNGdW5jdGlvbjo6SlNGdW5jdGlvbihFeGVjU3RhdGUqIGV4ZWMsIEpTR2xvYmFsT2JqZWN0 KiBnbG9iYWxPYmplY3QsIE5vbk51bGxQYXNzUmVmUHRyPFN0cnVjdHVyZT4gc3RydWN0dXJlLCBp bnQgbGVuZ3RoLCBjb25zdCBJZGVudGlmaWVyJiBuYW1lLCBQYXNzUmVmUHRyPE5hdGl2ZUV4ZWN1 dGFibGU+IHRodW5rKQogICAgIDogQmFzZShnbG9iYWxPYmplY3QsIHN0cnVjdHVyZSkKLSNpZiBF TkFCTEUoSklUKQogICAgICwgbV9leGVjdXRhYmxlKHRodW5rKQotI2VuZGlmCiAgICAgLCBtX3Nj b3BlQ2hhaW4oZ2xvYmFsT2JqZWN0LT5nbG9iYWxTY29wZUNoYWluKCkpCiB7CiAgICAgcHV0RGly ZWN0KGV4ZWMtPmdsb2JhbERhdGEoKS5wcm9wZXJ0eU5hbWVzLT5uYW1lLCBqc1N0cmluZyhleGVj LCBuYW1lLmlzTnVsbCgpID8gIiIgOiBuYW1lLnVzdHJpbmcoKSksIERvbnREZWxldGUgfCBSZWFk T25seSB8IERvbnRFbnVtKTsKLSNpZiBFTkFCTEUoSklUKQogICAgIHB1dERpcmVjdChleGVjLT5w cm9wZXJ0eU5hbWVzKCkubGVuZ3RoLCBqc051bWJlcihleGVjLCBsZW5ndGgpLCBEb250RGVsZXRl IHwgUmVhZE9ubHkgfCBEb250RW51bSk7Ci0jZWxzZQotICAgIFVOVVNFRF9QQVJBTSh0aHVuayk7 Ci0gICAgVU5VU0VEX1BBUkFNKGxlbmd0aCk7Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0j ZW5kaWYKIH0KKyNlbmRpZgogCiBKU0Z1bmN0aW9uOjpKU0Z1bmN0aW9uKEV4ZWNTdGF0ZSogZXhl YywgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgTm9uTnVsbFBhc3NSZWZQdHI8U3RydWN0 dXJlPiBzdHJ1Y3R1cmUsIGludCBsZW5ndGgsIGNvbnN0IElkZW50aWZpZXImIG5hbWUsIE5hdGl2 ZUZ1bmN0aW9uIGZ1bmMpCiAgICAgOiBCYXNlKGdsb2JhbE9iamVjdCwgc3RydWN0dXJlKQpJbmRl eDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0Z1bmN0aW9uLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0Z1bmN0aW9uLmgJKHJldmlzaW9uIDYwMTQyKQorKysgSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0Z1bmN0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcg KzQ1LDkgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICBwdWJsaWM6CiAgICAgICAgIEpTRnVuY3Rp b24oRXhlY1N0YXRlKiwgSlNHbG9iYWxPYmplY3QqLCBOb25OdWxsUGFzc1JlZlB0cjxTdHJ1Y3R1 cmU+LCBpbnQgbGVuZ3RoLCBjb25zdCBJZGVudGlmaWVyJiwgTmF0aXZlRnVuY3Rpb24pOworI2lm IEVOQUJMRShKSVQpCiAgICAgICAgIEpTRnVuY3Rpb24oRXhlY1N0YXRlKiwgSlNHbG9iYWxPYmpl Y3QqLCBOb25OdWxsUGFzc1JlZlB0cjxTdHJ1Y3R1cmU+LCBpbnQgbGVuZ3RoLCBjb25zdCBJZGVu dGlmaWVyJiwgUGFzc1JlZlB0cjxOYXRpdmVFeGVjdXRhYmxlPik7CisjZW5kaWYKICAgICAgICAg SlNGdW5jdGlvbihFeGVjU3RhdGUqLCBOb25OdWxsUGFzc1JlZlB0cjxGdW5jdGlvbkV4ZWN1dGFi bGU+LCBTY29wZUNoYWluTm9kZSopOwogICAgICAgICB2aXJ0dWFsIH5KU0Z1bmN0aW9uKCk7CiAK