3965 2005-07-12 11:12:47 -0700 IndexToNameMap::IndexToNameMap has n-squared behavior 2008-09-21 23:15:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ggaren webkit-unassigned darin ddkilzer ian zwarich oldest_to_newest 14450 0 ggaren 2005-07-12 11:12:47 -0700 For each argument, it searches through each argument to check for duplicate parameter names. A better solution would move FunctionImp::getParameterName into IndexToNameMap::IndexToNameMap, and use a hash table to keep track of already seen parameter names --> better modularity and O(1) behavior. 75866 1 20224 ddkilzer 2008-03-30 15:36:52 -0700 Created attachment 20224 Sample SunSpider test SunSpider-0.9 doesn't use the "arguments" object from within a function, so it can't be used to test the performance of the IndexToNameMap constructor code. This is a test that may be dropped into the SunSpider directory to be run. I'm sure it doesn't mimic any real-world usage of arguments, but it does exercise the code in the IndexToNameMap constructor. 76432 2 20370 ddkilzer 2008-04-06 11:52:28 -0700 Created attachment 20370 Script to generate function args test suite This script generates tests for use with SunSpider. It tests passing 0 to 10 arguments to eleven different functions, each of which have 0 to 10 arguments, for a total of 121 tests. The script should be run from the checked-out SunSpider directory, and generates files of the form: function-args-M-N.js where "M" is the number arguments the function is defined with and N is the number of arguments actually passed to that function. Note that the script outputs a list of function names to stdout, which need to be added to tests/LIST before running SunSpider: $ ./sunspider --shell ../WebKitBuild/Release/testkjs --tests function-args --run 25 92054 3 ddkilzer 2008-09-21 18:50:00 -0700 See Bug 20815 Comment #7. 92064 4 darin 2008-09-21 19:32:30 -0700 I eliminated IndexToNameMap in http://trac.webkit.org/changeset/36743 and I believe this bug is fixed now. 92085 5 ddkilzer 2008-09-21 23:15:58 -0700 (In reply to comment #4) > I eliminated IndexToNameMap in http://trac.webkit.org/changeset/36743 and I > believe this bug is fixed now. See Bug 20972. 20224 2008-03-30 15:36:52 -0700 2008-04-06 11:52:28 -0700 Sample SunSpider test function-args.js text/javascript 3374 ddkilzer dmFyIGFyZ3M7CnZhciBhcmdDb3VudDsKCmZ1bmN0aW9uIGYwKCkKewogICAgYXJnQ291bnQgPSBh cmd1bWVudHMubGVuZ3RoOwogICAgYXJncyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24gZjEocSkK ewogICAgYXJnQ291bnQgPSBhcmd1bWVudHMubGVuZ3RoOwogICAgYXJncyA9IGFyZ3VtZW50czsK fQoKZnVuY3Rpb24gZjIocSwgcikKewogICAgYXJnQ291bnQgPSBhcmd1bWVudHMubGVuZ3RoOwog ICAgYXJncyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24gZjMocSwgciwgcykKewogICAgYXJnQ291 bnQgPSBhcmd1bWVudHMubGVuZ3RoOwogICAgYXJncyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24g ZjQocSwgciwgcywgdCkKewogICAgYXJnQ291bnQgPSBhcmd1bWVudHMubGVuZ3RoOwogICAgYXJn cyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24gZjUocSwgciwgcywgdCwgdSkKewogICAgYXJnQ291 bnQgPSBhcmd1bWVudHMubGVuZ3RoOwogICAgYXJncyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24g ZjYocSwgciwgcywgdCwgdSwgdikKewogICAgYXJnQ291bnQgPSBhcmd1bWVudHMubGVuZ3RoOwog ICAgYXJncyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24gZjcocSwgciwgcywgdCwgdSwgdiwgdykK ewogICAgYXJnQ291bnQgPSBhcmd1bWVudHMubGVuZ3RoOwogICAgYXJncyA9IGFyZ3VtZW50czsK fQoKZnVuY3Rpb24gZjgocSwgciwgcywgdCwgdSwgdiwgdywgeCkKewogICAgYXJnQ291bnQgPSBh cmd1bWVudHMubGVuZ3RoOwogICAgYXJncyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24gZjkocSwg ciwgcywgdCwgdSwgdiwgdywgeCwgeSkKewogICAgYXJnQ291bnQgPSBhcmd1bWVudHMubGVuZ3Ro OwogICAgYXJncyA9IGFyZ3VtZW50czsKfQoKZnVuY3Rpb24gZjEwKHEsIHIsIHMsIHQsIHUsIHYs IHcsIHgsIHksIHopCnsKICAgIGFyZ0NvdW50ID0gYXJndW1lbnRzLmxlbmd0aDsKICAgIGFyZ3Mg PSBhcmd1bWVudHM7Cn0KCmZvciAodmFyIGkgPSAwOyBpIDwgMzAwOyBpKyspIHsKCmYwKCk7CmYw KDEpOwpmMCgxLCAyKTsKZjAoMSwgMiwgMyk7CmYwKDEsIDIsIDMsIDQpOwpmMCgxLCAyLCAzLCA0 LCA1KTsKZjAoMSwgMiwgMywgNCwgNSwgNik7CmYwKDEsIDIsIDMsIDQsIDUsIDYsIDcpOwpmMCgx LCAyLCAzLCA0LCA1LCA2LCA3LCA4KTsKZjAoMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOSk7CmYw KDEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDksIDEwKTsKCmYxKCk7CmYxKDEpOwpmMSgxLCAyKTsK ZjEoMSwgMiwgMyk7CmYxKDEsIDIsIDMsIDQpOwpmMSgxLCAyLCAzLCA0LCA1KTsKZjEoMSwgMiwg MywgNCwgNSwgNik7CmYxKDEsIDIsIDMsIDQsIDUsIDYsIDcpOwpmMSgxLCAyLCAzLCA0LCA1LCA2 LCA3LCA4KTsKZjEoMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOSk7CmYxKDEsIDIsIDMsIDQsIDUs IDYsIDcsIDgsIDksIDEwKTsKCmYyKCk7CmYyKDEpOwpmMigxLCAyKTsKZjIoMSwgMiwgMyk7CmYy KDEsIDIsIDMsIDQpOwpmMigxLCAyLCAzLCA0LCA1KTsKZjIoMSwgMiwgMywgNCwgNSwgNik7CmYy KDEsIDIsIDMsIDQsIDUsIDYsIDcpOwpmMigxLCAyLCAzLCA0LCA1LCA2LCA3LCA4KTsKZjIoMSwg MiwgMywgNCwgNSwgNiwgNywgOCwgOSk7CmYyKDEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDksIDEw KTsKCmYzKCk7CmYzKDEpOwpmMygxLCAyKTsKZjMoMSwgMiwgMyk7CmYzKDEsIDIsIDMsIDQpOwpm MygxLCAyLCAzLCA0LCA1KTsKZjMoMSwgMiwgMywgNCwgNSwgNik7CmYzKDEsIDIsIDMsIDQsIDUs IDYsIDcpOwpmMygxLCAyLCAzLCA0LCA1LCA2LCA3LCA4KTsKZjMoMSwgMiwgMywgNCwgNSwgNiwg NywgOCwgOSk7CmYzKDEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDksIDEwKTsKCmY0KCk7CmY0KDEp OwpmNCgxLCAyKTsKZjQoMSwgMiwgMyk7CmY0KDEsIDIsIDMsIDQpOwpmNCgxLCAyLCAzLCA0LCA1 KTsKZjQoMSwgMiwgMywgNCwgNSwgNik7CmY0KDEsIDIsIDMsIDQsIDUsIDYsIDcpOwpmNCgxLCAy LCAzLCA0LCA1LCA2LCA3LCA4KTsKZjQoMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOSk7CmY0KDEs IDIsIDMsIDQsIDUsIDYsIDcsIDgsIDksIDEwKTsKCmY1KCk7CmY1KDEpOwpmNSgxLCAyKTsKZjUo MSwgMiwgMyk7CmY1KDEsIDIsIDMsIDQpOwpmNSgxLCAyLCAzLCA0LCA1KTsKZjUoMSwgMiwgMywg NCwgNSwgNik7CmY1KDEsIDIsIDMsIDQsIDUsIDYsIDcpOwpmNSgxLCAyLCAzLCA0LCA1LCA2LCA3 LCA4KTsKZjUoMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOSk7CmY1KDEsIDIsIDMsIDQsIDUsIDYs IDcsIDgsIDksIDEwKTsKCmY2KCk7CmY2KDEpOwpmNigxLCAyKTsKZjYoMSwgMiwgMyk7CmY2KDEs IDIsIDMsIDQpOwpmNigxLCAyLCAzLCA0LCA1KTsKZjYoMSwgMiwgMywgNCwgNSwgNik7CmY2KDEs IDIsIDMsIDQsIDUsIDYsIDcpOwpmNigxLCAyLCAzLCA0LCA1LCA2LCA3LCA4KTsKZjYoMSwgMiwg MywgNCwgNSwgNiwgNywgOCwgOSk7CmY2KDEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDksIDEwKTsK CmY3KCk7CmY3KDEpOwpmNygxLCAyKTsKZjcoMSwgMiwgMyk7CmY3KDEsIDIsIDMsIDQpOwpmNygx LCAyLCAzLCA0LCA1KTsKZjcoMSwgMiwgMywgNCwgNSwgNik7CmY3KDEsIDIsIDMsIDQsIDUsIDYs IDcpOwpmNygxLCAyLCAzLCA0LCA1LCA2LCA3LCA4KTsKZjcoMSwgMiwgMywgNCwgNSwgNiwgNywg OCwgOSk7CmY3KDEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDksIDEwKTsKCmY4KCk7CmY4KDEpOwpm OCgxLCAyKTsKZjgoMSwgMiwgMyk7CmY4KDEsIDIsIDMsIDQpOwpmOCgxLCAyLCAzLCA0LCA1KTsK ZjgoMSwgMiwgMywgNCwgNSwgNik7CmY4KDEsIDIsIDMsIDQsIDUsIDYsIDcpOwpmOCgxLCAyLCAz LCA0LCA1LCA2LCA3LCA4KTsKZjgoMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOSk7CmY4KDEsIDIs IDMsIDQsIDUsIDYsIDcsIDgsIDksIDEwKTsKCmY5KCk7CmY5KDEpOwpmOSgxLCAyKTsKZjkoMSwg MiwgMyk7CmY5KDEsIDIsIDMsIDQpOwpmOSgxLCAyLCAzLCA0LCA1KTsKZjkoMSwgMiwgMywgNCwg NSwgNik7CmY5KDEsIDIsIDMsIDQsIDUsIDYsIDcpOwpmOSgxLCAyLCAzLCA0LCA1LCA2LCA3LCA4 KTsKZjkoMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOSk7CmY5KDEsIDIsIDMsIDQsIDUsIDYsIDcs IDgsIDksIDEwKTsKCmYxMCgpOwpmMTAoMSk7CmYxMCgxLCAyKTsKZjEwKDEsIDIsIDMpOwpmMTAo MSwgMiwgMywgNCk7CmYxMCgxLCAyLCAzLCA0LCA1KTsKZjEwKDEsIDIsIDMsIDQsIDUsIDYpOwpm MTAoMSwgMiwgMywgNCwgNSwgNiwgNyk7CmYxMCgxLCAyLCAzLCA0LCA1LCA2LCA3LCA4KTsKZjEw KDEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDkpOwpmMTAoMSwgMiwgMywgNCwgNSwgNiwgNywgOCwg OSwgMTApOwoKfQo= 20370 2008-04-06 11:52:28 -0700 2008-04-06 11:52:28 -0700 Script to generate function args test suite generate-function-args-tests.pl text/plain 568 ddkilzer IyEvdXNyL2Jpbi9wZXJsIC13Cgp1c2Ugc3RyaWN0OwoKJFsgPSAxOwoKZm9yIG15ICRpICgwLi4x MCkgewogICAgZm9yIG15ICRqICgwLi4xMCkgewogICAgICAgIG9wZW4oRklMRSwgIj4iLCAidGVz dHMvZnVuY3Rpb24tYXJncy0kaS0kai5qcyIpIG9yIGRpZSAiJCEiOwogICAgICAgIG15ICRhcmdz ID0gJGkgPT0gMCA/ICIiIDogam9pbigiLCAiLCAoJ2EnLi4naicpWzEuLiRpXSk7CiAgICAgICAg bXkgJHZhbHVlcyA9ICRqID09IDAgPyAiIiA6IGpvaW4oIiwgIiwgKDEuLjEwKVsxLi4kal0pOwog ICAgICAgIHByaW50IEZJTEUgPDxFTkQ7CnZhciBhcmdzOwp2YXIgYXJnQ291bnQ7CgpmdW5jdGlv biBmJHtpfSgke2FyZ3N9KQp7CiAgICBhcmdDb3VudCA9IGFyZ3VtZW50cy5sZW5ndGg7CiAgICBh cmdzID0gYXJndW1lbnRzOwp9Cgpmb3IgKHZhciBpID0gMDsgaSA8IDMwMDAwOyBpKyspIHsKICAg ZiR7aX0oJHt2YWx1ZXN9KTsKfQpFTkQKICAgICAgICBwcmludCBTVERPVVQgImZ1bmN0aW9uLWFy Z3MtJGktJGpcbiI7CiAgICAgICAgY2xvc2UoRklMRSkgb3IgZGllICIkISI7CiAgICB9Cn0KCg==