39609 2010-05-24 12:52:01 -0700 [Qt] Running with accelerated compositing enabled sometimes result in a crash 2010-05-25 14:28:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All CLOSED FIXED Qt P3 Critical --- 35784 1 kenneth kenneth commit-queue hausmann noam oldest_to_newest 229857 0 kenneth 2010-05-24 12:52:01 -0700 Hovering over the red points on panic.com/transmit is a good way to reproduce the crash #0 0x00007ffff4fa0734 in QScopedPointer<QObjectData, QScopedPointerDeleter<QObjectData> >::data (this=0x8) at ../../include/QtCore/../../../qt/src/corelib/tools/qscopedpointer.h:135 #1 0x00007ffff57abd16 in qGetPtrHelper<QScopedPointer<QObjectData, QScopedPointerDeleter<QObjectData> > > (p=...) at ../../include/QtCore/../../../qt/src/corelib/global/qglobal.h:2337 #2 0x00007ffff57ac408 in QGraphicsScene::d_func (this=0x0) at /home/kenneth/repo/Qt/qt/src/gui/graphicsview/qgraphicsscene.h:297 #3 0x00007ffff57d2d15 in QGraphicsScene::update (this=0x0, rect=...) at /home/kenneth/repo/Qt/qt/src/gui/graphicsview/qgraphicsscene.cpp:3205 #4 0x00007ffff74e451d in WebCore::OpacityAnimationQt::applyFrame(double const&, double const&, double) () from /home/kenneth/repo/Qt/WebKitBuild/Release/bin/../lib/libQtWebKit.so.4 #5 0x00007ffff74e49c5 in WebCore::AnimationQt<double>::updateCurrentTime(int) () from /home/kenneth/repo/Qt/WebKitBuild/Release/bin/../lib/libQtWebKit.so.4 #6 0x00007ffff4861747 in QAbstractAnimation::setCurrentTime (this=0xc55f40, msecs=16) at /home/kenneth/repo/Qt/qt/src/corelib/animation/qabstractanimation.cpp:739 #7 0x00007ffff4860302 in QUnifiedTimer::updateAnimationsTime (this=0x973e80) at /home/kenneth/repo/Qt/qt/src/corelib/animation/qabstractanimation.cpp:223 #8 0x00007ffff4860661 in QUnifiedTimer::timerEvent (this=0x973e80, event=0x7fffffffda10) at /home/kenneth/repo/Qt/qt/src/corelib/animation/qabstractanimation.cpp:279 #9 0x00007ffff49d87a1 in QObject::event (this=0x973e80, e=0x7fffffffda10) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qobject.cpp:1175 #10 0x00007ffff4fb13f8 in QApplicationPrivate::notify_helper (this=0x7040f0, receiver=0x973e80, e=0x7fffffffda10) at /home/kenneth/repo/Qt/qt/src/gui/kernel/qapplication.cpp:4358 #11 0x00007ffff4fae90f in QApplication::notify (this=0x7fffffffdeb0, receiver=0x973e80, e=0x7fffffffda10) at /home/kenneth/repo/Qt/qt/src/gui/kernel/qapplication.cpp:3762 #12 0x00007ffff49bd3d8 in QCoreApplication::notifyInternal (this=0x7fffffffdeb0, receiver=0x973e80, event=0x7fffffffda10) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qcoreapplication.cpp:732 #13 0x00007ffff4f9fb85 in QCoreApplication::sendEvent (receiver=0x973e80, event=0x7fffffffda10) at ../../include/QtCore/../../../qt/src/corelib/kernel/qcoreapplication.h:215 #14 0x00007ffff4a0019d in QTimerInfoList::activateTimers (this=0x711980) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qeventdispatcher_unix.cpp:602 #15 0x00007ffff49fb2ab in timerSourceDispatch (source=0x711920) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qeventdispatcher_glib.cpp:184 #16 0x00007ffff49fb392 in idleTimerSourceDispatch (source=0x7119e0) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qeventdispatcher_glib.cpp:231 #17 0x00007ffff2a0f87a in g_main_dispatch (context=0x70fe10) at gmain.c:1960 #18 IA__g_main_context_dispatch (context=0x70fe10) at gmain.c:2513 #19 0x00007ffff2a13208 in g_main_context_iterate (context=0x70fe10, block=1, dispatch=1, self=<value optimized out>) at gmain.c:2591 #20 0x00007ffff2a133cc in IA__g_main_context_iteration (context=0x70fe10, may_block=1) at gmain.c:2654 #21 0x00007ffff49fc743 in QEventDispatcherGlib::processEvents (this=0x70de30, flags=...) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qeventdispatcher_glib.cpp:412 #22 0x00007ffff509e6f0 in QGuiEventDispatcherGlib::processEvents (this=0x70de30, flags=...) at /home/kenneth/repo/Qt/qt/src/gui/kernel/qguieventdispatcher_glib.cpp:204 #23 0x00007ffff49ba3d0 in QEventLoop::processEvents (this=0x7fffffffdde0, flags=...) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qeventloop.cpp:149 #24 0x00007ffff49ba526 in QEventLoop::exec (this=0x7fffffffdde0, flags=...) at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qeventloop.cpp:201 #25 0x00007ffff49bdad4 in QCoreApplication::exec () at /home/kenneth/repo/Qt/qt/src/corelib/kernel/qcoreapplication.cpp:1009 #26 0x00007ffff4fae496 in QApplication::exec () at /home/kenneth/repo/Qt/qt/src/gui/kernel/qapplication.cpp:3637 229913 1 56928 kenneth 2010-05-24 14:39:20 -0700 Created attachment 56928 Patch 229982 2 56928 laszlo.gombos 2010-05-24 16:48:42 -0700 Comment on attachment 56928 Patch lgtm, r+. 230191 3 56928 commit-queue 2010-05-25 02:52:02 -0700 Comment on attachment 56928 Patch Rejecting patch 56928 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: e Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 18298 test cases. fast/workers/storage/execute-sql-args-worker.html -> crashed Exiting early after 1 failures. 14489 tests run. 611.92s total testing time 14488 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/2302606 230228 4 56928 kenneth 2010-05-25 05:25:02 -0700 Comment on attachment 56928 Patch Seems to have been hit by a flaky test. 230232 5 56928 commit-queue 2010-05-25 05:44:46 -0700 Comment on attachment 56928 Patch Clearing flags on attachment: 56928 Committed r60156: <http://trac.webkit.org/changeset/60156> 230233 6 commit-queue 2010-05-25 05:44:51 -0700 All reviewed patches have been landed. Closing bug. 230461 7 hausmann 2010-05-25 14:28:26 -0700 Revision r60156 cherry-picked into qtwebkit-2.0 with commit 482eba3190c6d7a81d3f4b1c38ebf6354da8ad09 56928 2010-05-24 14:39:20 -0700 2010-05-25 05:44:45 -0700 Patch 0001-Qt-Running-with-accelerated-compositing-enabled-some.patch text/plain 2517 kenneth RnJvbSA3YTk1YjlkZGZmMzc2M2EwNTM1YWYyMTE0ZWEzNzFjZmJmZjY4YjZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aC5j aHJpc3RpYW5zZW5Ab3BlbmJvc3NhLm9yZz4KRGF0ZTogTW9uLCAyNCBNYXkgMjAxMCAxODozODo0 OCAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0gUnVubmluZyB3aXRoIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nIGVuYWJsZWQgc29tZXRpbWVzIHJlc3VsdCBpbiBhIGNyYXNoCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk2MDkKClJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgoKQ2hlY2sgaWYgd2UgaGF2ZSBhIHNjZW5lIGJlZm9yZSBhcHBseWluZyB0aGUgd29y a2Fyb3VuZCBmb3IKdGhlIFFHcmFwaGljc1NjZW5lIGJ1ZyB3aGVyZSBvcGFjaXR5IGNoYW5nZSBk b2Vzbid0IGFsd2F5cyBoYXZlCmltbWVkaWF0ZSBlZmZlY3QuCgoqIHBsYXRmb3JtL2dyYXBoaWNz L3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHA6CihXZWJDb3JlOjpPcGFjaXR5QW5pbWF0aW9uUXQ6OmFw cGx5RnJhbWUpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvR3JhcGhpY3NMYXllclF0LmNwcCB8ICAgIDMgKystCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1MjNmNmY0Li5kYWViZWUyIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEwLTA1LTI0ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGguY2hy aXN0aWFuc2VuQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBSdW5uaW5nIHdpdGggYWNjZWxlcmF0ZWQgY29tcG9zaXRp bmcgZW5hYmxlZCBzb21ldGltZXMgcmVzdWx0IGluIGEgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NjA5CisKKyAgICAgICAgQ2hlY2sgaWYg d2UgaGF2ZSBhIHNjZW5lIGJlZm9yZSBhcHBseWluZyB0aGUgd29ya2Fyb3VuZCBmb3IKKyAgICAg ICAgdGhlIFFHcmFwaGljc1NjZW5lIGJ1ZyB3aGVyZSBvcGFjaXR5IGNoYW5nZSBkb2Vzbid0IGFs d2F5cyBoYXZlCisgICAgICAgIGltbWVkaWF0ZSBlZmZlY3QuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6T3Bh Y2l0eUFuaW1hdGlvblF0OjphcHBseUZyYW1lKToKKwogMjAxMC0wNS0yNCAgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzTGF5ZXJRdC5jcHAKaW5kZXggOWYzNmIyYS4uYmU1NDczNSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcApAQCAtMTM2MSwxMyAr MTM2MSwxNCBAQCBwdWJsaWM6CiAgICAgICAgIGlmIChtX2ZpbGxzRm9yd2FyZHMpCiAgICAgICAg ICAgICBzZXRDdXJyZW50VGltZSgxKTsKICAgICB9CisKICAgICB2aXJ0dWFsIHZvaWQgYXBwbHlG cmFtZShjb25zdCBxcmVhbCYgZnJvbVZhbHVlLCBjb25zdCBxcmVhbCYgdG9WYWx1ZSwgcXJlYWwg cHJvZ3Jlc3MpCiAgICAgewogICAgICAgICBxcmVhbCBvcGFjaXR5ID0gcUJvdW5kKHFyZWFsKDAp LCBmcm9tVmFsdWUgKyAodG9WYWx1ZSAtIGZyb21WYWx1ZSkgKiBwcm9ncmVzcywgcXJlYWwoMSkp OwogCiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEgaGFjaywgZHVlIHRvIGEgcHJvYmFibGUg UUdyYXBoaWNzU2NlbmUgYnVnLgogICAgICAgICAvLyBXaXRob3V0IHRoaXMgdGhlIG9wYWNpdHkg Y2hhbmdlIGRvZXNuJ3QgYWx3YXlzIGhhdmUgaW1tZWRpYXRlIGVmZmVjdC4KLSAgICAgICAgaWYg KCFtX2xheWVyLmRhdGEoKS0+b3BhY2l0eSgpICYmIG9wYWNpdHkpCisgICAgICAgIGlmIChtX2xh eWVyLmRhdGEoKS0+c2NlbmUoKSAmJiAhbV9sYXllci5kYXRhKCktPm9wYWNpdHkoKSAmJiBvcGFj aXR5KQogICAgICAgICAgICAgbV9sYXllci5kYXRhKCktPnNjZW5lKCktPnVwZGF0ZSgpOwogCiAg ICAgICAgIG1fbGF5ZXIuZGF0YSgpLT5tX2xheWVyLT5zZXRPcGFjaXR5KG9wYWNpdHkpOwotLSAK MS43LjAuMwoK