39606 2010-05-24 11:15:55 -0700 Land tests for <rdar://problem/3277733>: \ in JavaScript mishandled when encoding is Japanese 2010-05-31 02:23:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap abarth eric hamaji webkit.review.bot oldest_to_newest 229819 0 ap 2010-05-24 11:15:55 -0700 This is an ancient bug, fixed before having regression tests became a policy. 229821 1 ap 2010-05-24 11:21:23 -0700 The bug itself was fixed in http://trac.webkit.org/changeset/4502. 229822 2 56906 ap 2010-05-24 11:21:48 -0700 Created attachment 56906 proposed patch 229839 3 ap 2010-05-24 11:53:51 -0700 Note that this test behaves differently in browser - IE displays yen signs here, and it looks like bug 24906 didn't help this case. The should be still fine for DumpRenderTree text-only mode. 229840 4 ap 2010-05-24 11:55:25 -0700 Maybe it's because the tests use Shift-JIS? 231287 5 56906 hamaji 2010-05-27 07:23:36 -0700 Comment on attachment 56906 proposed patch Looks good, except for a few style nitpicks. LooksLayoutTests/fast/encoding/yentest.html:13 + // document.write("one backslash inline: " + "\" + "<br>"); We can remove this line? LayoutTests/fast/encoding/resources/yentestexternal2.js:2 + document.write("two backslashes external: \\ <br>"); It would be better to indent lines in functions. LayoutTests/fast/encoding/resources/yentestexternal2.js:1 + function writeYenExternal() { It would be better to break line between () and { to be consistent with C++ coding style. LayoutTests/fast/encoding/resources/yentestexternal.js:1 + function writeYenExternal() { The same comment as yenexternal2.js 231289 6 hamaji 2010-05-27 07:29:10 -0700 (In reply to comment #4) > Maybe it's because the tests use Shift-JIS? Yes. Only EUC-JP and Shift_JIS_X0213-2000 contents are transcoded for now. I believe we should add at least Shift_JIS and ISO-2022-JP families. FYI, I've never seen a website which specifies charset=Shift_JIS_X0213-2000 and I'm guessing the person who added Shift_JIS_X0213-2000 intended to add Shift_JIS... 231348 7 ap 2010-05-27 10:21:19 -0700 > Shift_JIS_X0213-2000 intended to add Shift_JIS... It is also possible that at the time, encoding name was normalized by ICU, so Shift_JIS was actually covered. 231355 8 ap 2010-05-27 10:34:03 -0700 Committed <http://trac.webkit.org/changeset/60311>. > + // document.write("one backslash inline: " + "\" + "<br>"); > We can remove this line? Addressed the comments. I usually try to keep layout tests close to original form, because we get more accidental testing that way. If we never land commented out code, how would we be sure that it's not executed? And how would we know that non-indented code in functions works well? It's rather frequent that such accidental testing helps catch a bug. But many others disagree with that approach, and prefer to keep layout tests clean. 231402 9 webkit.review.bot 2010-05-27 11:31:31 -0700 http://trac.webkit.org/changeset/60311 might have broken Qt Linux Release 232293 10 hamaji 2010-05-31 02:23:51 -0700 > > + // document.write("one backslash inline: " + "\" + "<br>"); > > We can remove this line? > > Addressed the comments. I usually try to keep layout tests close to original form, because we get more accidental testing that way. If we never land commented out code, how would we be sure that it's not executed? And how would we know that non-indented code in functions works well? It's rather frequent that such accidental testing helps catch a bug. Very interesting. Usually, I'm trying to create a small and clean layout tests to make the point of a test clearer. I can also understand your opinion. Having diversity in our tests could be helpful. Maybe we should land both tests when the original report is quite different from the minimal test? 56906 2010-05-24 11:21:48 -0700 2010-05-27 07:23:35 -0700 proposed patch yentest.txt text/plain 4919 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwMDc0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMjQgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NjA2 CisgICAgICAgIExhbmQgdGVzdHMgZm9yIDxyZGFyOi8vcHJvYmxlbS8zMjc3NzMzPjogXCBpbiBK YXZhU2NyaXB0IG1pc2hhbmRsZWQgd2hlbiBlbmNvZGluZyBpcyBKYXBhbmVzZQorCisgICAgICAg ICogZmFzdC9lbmNvZGluZy9yZXNvdXJjZXMveWVudGVzdGV4dGVybmFsLmpzOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2VuY29kaW5nL3Jlc291cmNlcy95ZW50ZXN0ZXh0ZXJuYWwyLmpzOiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2VuY29kaW5nL3llbnRlc3QtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2VuY29kaW5nL3llbnRlc3QuaHRtbDogQWRkZWQuCisgICAgICAgICog ZmFzdC9lbmNvZGluZy95ZW50ZXN0Mi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZW5jb2RpbmcveWVudGVzdDIuaHRtbDogQWRkZWQuCisKIDIwMTAtMDUtMjQgIFNoaW5pY2hp cm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJy b2tlbiBRdCB0ZXN0IGZpeC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcveWVudGVz dDItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZW5jb2Rpbmcv eWVudGVzdDItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9l bmNvZGluZy95ZW50ZXN0Mi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNSBA QAordHdvIGJhY2tzbGFzaGVzIGV4dGVybmFsOiBcIAorb25lIGJhY2tzbGFzaCBleHRlcm5hbDog Cit0d28gYmFja3NsYXNoZXMgaW5saW5lOiBcIAorb25lIGJhY2tzbGFzaCBpbmxpbmU6IAorCgpQ cm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL3llbnRlc3QyLWV4 cGVjdGVkLnR4dApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWlu Ck5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2VuY29kaW5nL3llbnRlc3QyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9l bmNvZGluZy95ZW50ZXN0Mi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9l bmNvZGluZy95ZW50ZXN0Mi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE2IEBACis8SFRN TD4KKzxIRUFEPgorPE1FVEEgSFRUUC1FUVVJVj0iQ29udGVudC1UeXBlIiBDT05URU5UPSJ0ZXh0 L2h0bWw7IGNoYXJzZXQ9c2hpZnQtamlzIj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMveWVudGVz dGV4dGVybmFsMi5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4KKzwvSEVBRD4K KzxCT0RZPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCit3cml0ZVllbkV4dGVybmFsKCk7 Citkb2N1bWVudC53cml0ZSgidHdvIGJhY2tzbGFzaGVzIGlubGluZTogXFwgPGJyPiIpOworZG9j dW1lbnQud3JpdGUoIm9uZSBiYWNrc2xhc2ggaW5saW5lOiBcIDxicj4iKTsKKzwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9l bmNvZGluZy95ZW50ZXN0Mi5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICAr IHRleHQvaHRtbAoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcveWVudGVzdC1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy95ZW50ZXN0 LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZW5jb2Rpbmcv eWVudGVzdC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAordHdvIGJh Y2tzbGFzaGVzIGV4dGVybmFsOiBcCit0d28gYmFja3NsYXNoZXMgaW5saW5lOiBcCisKClByb3Bl cnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcveWVudGVzdC1leHBlY3Rl ZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFpbgpOYW1l OiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9lbmNv ZGluZy95ZW50ZXN0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGlu Zy95ZW50ZXN0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5n L3llbnRlc3QuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNiBAQAorPEhUTUw+Cis8SEVB RD4KKzxNRVRBIEhUVFAtRVFVSVY9IkNvbnRlbnQtVHlwZSIgQ09OVEVOVD0idGV4dC9odG1sOyBj aGFyc2V0PXNoaWZ0LWppcyI+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3llbnRlc3RleHRlcm5h bC5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4KKzwvSEVBRD4KKzxCT0RZPgor PHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCit3cml0ZVllbkV4dGVybmFsKCk7Citkb2N1bWVu dC53cml0ZSgidHdvIGJhY2tzbGFzaGVzIGlubGluZTogIiArICJcXCIgKyAiPGJyPiIpOworLy8g ZG9jdW1lbnQud3JpdGUoIm9uZSBiYWNrc2xhc2ggaW5saW5lOiAiICsgIlwiICsgIjxicj4iKTsK Kzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0 VGVzdHMvZmFzdC9lbmNvZGluZy95ZW50ZXN0Lmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWlt ZS10eXBlCiAgICsgdGV4dC9odG1sCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9y ZXNvdXJjZXMveWVudGVzdGV4dGVybmFsMi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2VuY29kaW5nL3Jlc291cmNlcy95ZW50ZXN0ZXh0ZXJuYWwyLmpzCShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9yZXNvdXJjZXMveWVudGVzdGV4dGVybmFsMi5q cwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitmdW5jdGlvbiB3cml0ZVllbkV4dGVybmFs KCkgeworZG9jdW1lbnQud3JpdGUoInR3byBiYWNrc2xhc2hlcyBleHRlcm5hbDogXFwgPGJyPiIp OworZG9jdW1lbnQud3JpdGUoIm9uZSBiYWNrc2xhc2ggZXh0ZXJuYWw6IFwgPGJyPiIpOworfQoK UHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9yZXNvdXJjZXMv eWVudGVzdGV4dGVybmFsMi5qcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0 ZXh0L3BsYWluCk5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2VuY29kaW5nL3Jlc291cmNlcy95ZW50ZXN0ZXh0ZXJuYWwuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9yZXNvdXJjZXMveWVudGVzdGV4dGVybmFs LmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9yZXNvdXJjZXMv eWVudGVzdGV4dGVybmFsLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK2Z1bmN0aW9u IHdyaXRlWWVuRXh0ZXJuYWwoKSB7Citkb2N1bWVudC53cml0ZSgidHdvIGJhY2tzbGFzaGVzIGV4 dGVybmFsOiAiICsgIlxcIiArICI8YnI+Iik7Cit9CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlv dXRUZXN0cy9mYXN0L2VuY29kaW5nL3Jlc291cmNlcy95ZW50ZXN0ZXh0ZXJuYWwuanMKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFpbgpOYW1lOiBzdm46ZW9sLXN0 eWxlCiAgICsgbmF0aXZlCgo=