39587 2010-05-24 03:09:06 -0700 Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h 2010-05-24 21:11:09 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 0 bulach webkit-unassigned tkent oldest_to_newest 229680 0 bulach 2010-05-24 03:09:06 -0700 Previous change https://bugs.webkit.org/show_bug.cgi?id=39440 introduced a public dependency on wtf/HashMap.h This prevents WebGeolocationService.h to be included in test_shell. Need to hide this dependency by adding WebGeolocationServiceMockImpl. 229693 1 56869 bulach 2010-05-24 04:18:55 -0700 Created attachment 56869 Patch 229697 2 56869 tkent 2010-05-24 04:40:39 -0700 Comment on attachment 56869 Patch OK 230065 3 56869 tkent 2010-05-24 20:59:31 -0700 Comment on attachment 56869 Patch I'll land this manually. 230069 4 56869 tkent 2010-05-24 21:11:01 -0700 Comment on attachment 56869 Patch Clearing flags on attachment: 56869 Committed r60121: <http://trac.webkit.org/changeset/60121> 230070 5 tkent 2010-05-24 21:11:09 -0700 All reviewed patches have been landed. Closing bug. 56869 2010-05-24 04:18:55 -0700 2010-05-24 21:11:00 -0700 Patch bug-39587-20100524121854.patch text/plain 6341 bulach ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDA3ZTZlZGIyZTE2MDVjMDU3Y2E1M2VmNzQzODBiNjNkZjBhMWM3ZTUu LmU3NWZjZjc5ZjQxYTk2NzE5M2JhYTRhODUzZTNmMmVjMzVlNTJlOGUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDEwLTA1LTI0ICBNYXJjdXMgQnVsYWNoICA8YnVsYWNoQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbY2hyb21pdW1dIEFkZHMgV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9ja0ltcGwgdG8gcmVtb3Zl IHB1YmxpYyBkZXBlbmRlbmN5IG9uIHd0Zi9IYXNoTWFwLmgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NTg3CisKKyAgICAgICAgKiBwdWJsaWMvV2Vi R2VvbG9jYXRpb25TZXJ2aWNlTW9jay5oOgorICAgICAgICAqIHNyYy9XZWJHZW9sb2NhdGlvblNl cnZpY2VNb2NrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9j a0ltcGw6On5XZWJHZW9sb2NhdGlvblNlcnZpY2VNb2NrSW1wbCk6CisgICAgICAgIChXZWJLaXQ6 OldlYkdlb2xvY2F0aW9uU2VydmljZU1vY2s6OmNyZWF0ZVdlYkdlb2xvY2F0aW9uU2VydmljZU1v Y2spOgorICAgICAgICAoV2ViS2l0OjpXZWJHZW9sb2NhdGlvblNlcnZpY2VNb2NrSW1wbDo6cmVx dWVzdFBlcm1pc3Npb25Gb3JGcmFtZSk6CisgICAgICAgIChXZWJLaXQ6OldlYkdlb2xvY2F0aW9u U2VydmljZU1vY2tJbXBsOjphdHRhY2hCcmlkZ2UpOgorICAgICAgICAoV2ViS2l0OjpXZWJHZW9s b2NhdGlvblNlcnZpY2VNb2NrSW1wbDo6ZGV0YWNoQnJpZGdlKToKKwogMjAxMC0wNS0yMSAgVG9u eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4g VmFmYWkuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdlb2xvY2F0aW9u U2VydmljZU1vY2suaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR2VvbG9jYXRpb25TZXJ2 aWNlTW9jay5oCmluZGV4IDI4NWY3MGM4NGZmZDNhMGQwODk0YWMyMTRkYjVjZDUwMDYzZjA1ZTAu LmQxYTE0NmIyNzE5Zjk4OWFjODhiNmIwYmU5YWU2MjFlY2M1MTc0MGQgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9jay5oCisrKyBiL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9jay5oCkBAIC0zMiw3 ICszMiw2IEBACiAjZGVmaW5lIFdlYkdlb2xvY2F0aW9uU2VydmljZU1vY2tfaAogCiAjaW5jbHVk ZSAiV2ViR2VvbG9jYXRpb25TZXJ2aWNlLmgiCi0jaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KIAog bmFtZXNwYWNlIFdlYktpdCB7CiAKQEAgLTQwLDE4ICszOSwxMiBAQCBjbGFzcyBXZWJTdHJpbmc7 CiAKIGNsYXNzIFdlYkdlb2xvY2F0aW9uU2VydmljZU1vY2sgOiBwdWJsaWMgV2ViR2VvbG9jYXRp b25TZXJ2aWNlIHsKIHB1YmxpYzoKKyAgICBzdGF0aWMgV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9j ayogY3JlYXRlV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9jaygpOwogICAgIHN0YXRpYyB2b2lkIHNl dE1vY2tHZW9sb2NhdGlvblBlcm1pc3Npb24oYm9vbCBhbGxvd2VkKTsKICAgICBzdGF0aWMgdm9p ZCBzZXRNb2NrR2VvbG9jYXRpb25Qb3NpdGlvbihkb3VibGUgbGF0aXR1ZGUsIGRvdWJsZSBsb25n aXR1ZGUsIGRvdWJsZSBhY2N1cmFjeSk7CiAgICAgc3RhdGljIHZvaWQgc2V0TW9ja0dlb2xvY2F0 aW9uRXJyb3IoaW50IGVycm9yQ29kZSwgY29uc3QgV2ViU3RyaW5nJiBtZXNzYWdlKTsKIAotICAg IHZpcnR1YWwgdm9pZCByZXF1ZXN0UGVybWlzc2lvbkZvckZyYW1lKGludCBicmlkZ2VJZCwgY29u c3QgV2ViVVJMJiB1cmwpOwotICAgIHZpcnR1YWwgaW50IGF0dGFjaEJyaWRnZShXZWJHZW9sb2Nh dGlvblNlcnZpY2VCcmlkZ2UqKTsKLSAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoQnJpZGdlKGludCBi cmlkZ2VJZCk7Ci0KLXByaXZhdGU6Ci0gICAgdHlwZWRlZiBIYXNoTWFwPGludCwgV2ViR2VvbG9j YXRpb25TZXJ2aWNlQnJpZGdlKj4gSWRUb0JyaWRnZU1hcDsKLSAgICBJZFRvQnJpZGdlTWFwIG1f aWRUb0JyaWRnZU1hcDsKLQorcHJvdGVjdGVkOgogICAgIHN0YXRpYyBib29sIHNfbW9ja0dlb2xv Y2F0aW9uUGVybWlzc2lvbjsKIH07CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9jay5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdl b2xvY2F0aW9uU2VydmljZU1vY2suY3BwCmluZGV4IDJlZWQzNTI5ZGI4NTk4NDM0M2M2YjJmZmZl OGI4YmE4OTYwZWZjZDguLjAwZDgxOWI0M2VmNmU3OTQ2YmNiZGFjNmVkN2YyZDhhODBmODZlY2Eg MTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9j ay5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHZW9sb2NhdGlvblNlcnZpY2VNb2Nr LmNwcApAQCAtMzYsNiArMzYsNyBAQAogI2luY2x1ZGUgIkdlb2xvY2F0aW9uU2VydmljZU1vY2su aCIKICNpbmNsdWRlICJXZWJTdHJpbmcuaCIKICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4K KyNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogCiAjaWYgRU5BQkxFKEdFT0xPQ0FUSU9OKQogCkBA IC0xMjEsOCArMTIyLDI1IEBAIHZvaWQgR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW1Nb2NrOjpn ZW9sb2NhdGlvblNlcnZpY2VFcnJvck9jY3VycmVkKEdlb2xvY2F0aW9uCiAKIG5hbWVzcGFjZSBX ZWJLaXQgewogCitjbGFzcyBXZWJHZW9sb2NhdGlvblNlcnZpY2VNb2NrSW1wbCA6IHB1YmxpYyBX ZWJHZW9sb2NhdGlvblNlcnZpY2VNb2NrIHsKK3B1YmxpYzoKKyAgICB2aXJ0dWFsIH5XZWJHZW9s b2NhdGlvblNlcnZpY2VNb2NrSW1wbCgpIHsgfQorICAgIHZpcnR1YWwgdm9pZCByZXF1ZXN0UGVy bWlzc2lvbkZvckZyYW1lKGludCBicmlkZ2VJZCwgY29uc3QgV2ViVVJMJiB1cmwpOworICAgIHZp cnR1YWwgaW50IGF0dGFjaEJyaWRnZShXZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2UqKTsKKyAg ICB2aXJ0dWFsIHZvaWQgZGV0YWNoQnJpZGdlKGludCBicmlkZ2VJZCk7CisKK3ByaXZhdGU6Cisg ICAgdHlwZWRlZiBIYXNoTWFwPGludCwgV2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlKj4gSWRU b0JyaWRnZU1hcDsKKyAgICBJZFRvQnJpZGdlTWFwIG1faWRUb0JyaWRnZU1hcDsKK307CisKIGJv b2wgV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9jazo6c19tb2NrR2VvbG9jYXRpb25QZXJtaXNzaW9u ID0gZmFsc2U7CiAKK1dlYkdlb2xvY2F0aW9uU2VydmljZU1vY2sqIFdlYkdlb2xvY2F0aW9uU2Vy dmljZU1vY2s6OmNyZWF0ZVdlYkdlb2xvY2F0aW9uU2VydmljZU1vY2soKQoreworICAgIHJldHVy biBuZXcgV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9ja0ltcGw7Cit9CisKIHZvaWQgV2ViR2VvbG9j YXRpb25TZXJ2aWNlTW9jazo6c2V0TW9ja0dlb2xvY2F0aW9uUGVybWlzc2lvbihib29sIGFsbG93 ZWQpCiB7CiAgICAgc19tb2NrR2VvbG9jYXRpb25QZXJtaXNzaW9uID0gYWxsb3dlZDsKQEAgLTE0 Miw3ICsxNjAsNyBAQCB2b2lkIFdlYkdlb2xvY2F0aW9uU2VydmljZU1vY2s6OnNldE1vY2tHZW9s b2NhdGlvbkVycm9yKGludCBlcnJvckNvZGUsIGNvbnN0IFdlYgogICAgIEdlb2xvY2F0aW9uU2Vy dmljZU1vY2s6OnNldEVycm9yKHBvc2l0aW9uRXJyb3IpOwogfQogCi12b2lkIFdlYkdlb2xvY2F0 aW9uU2VydmljZU1vY2s6OnJlcXVlc3RQZXJtaXNzaW9uRm9yRnJhbWUoaW50IGJyaWRnZUlkLCBj b25zdCBXZWJVUkwmIHVybCkKK3ZvaWQgV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9ja0ltcGw6OnJl cXVlc3RQZXJtaXNzaW9uRm9yRnJhbWUoaW50IGJyaWRnZUlkLCBjb25zdCBXZWJVUkwmIHVybCkK IHsKICAgICBJZFRvQnJpZGdlTWFwOjppdGVyYXRvciBpdGVyID0gbV9pZFRvQnJpZGdlTWFwLmZp bmQoYnJpZGdlSWQpOwogICAgIGlmIChpdGVyID09IG1faWRUb0JyaWRnZU1hcC5lbmQoKSkKQEAg LTE1MCw3ICsxNjgsNyBAQCB2b2lkIFdlYkdlb2xvY2F0aW9uU2VydmljZU1vY2s6OnJlcXVlc3RQ ZXJtaXNzaW9uRm9yRnJhbWUoaW50IGJyaWRnZUlkLCBjb25zdCBXZQogICAgIGl0ZXItPnNlY29u ZC0+c2V0SXNBbGxvd2VkKHNfbW9ja0dlb2xvY2F0aW9uUGVybWlzc2lvbik7CiB9CiAKLWludCBX ZWJHZW9sb2NhdGlvblNlcnZpY2VNb2NrOjphdHRhY2hCcmlkZ2UoV2ViR2VvbG9jYXRpb25TZXJ2 aWNlQnJpZGdlKiBicmlkZ2UpCitpbnQgV2ViR2VvbG9jYXRpb25TZXJ2aWNlTW9ja0ltcGw6OmF0 dGFjaEJyaWRnZShXZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2UqIGJyaWRnZSkKIHsKICAgICBz dGF0aWMgaW50IG5leHRBdmFpbGFibGVXYXRjaElkID0gMTsKICAgICAvLyBJbiBjYXNlIG9mIG92 ZXJmbG93LCBtYWtlIHN1cmUgdGhlIElEIHJlbWFpbnMgcG9zaXRpdmUsIGJ1dCByZXVzZSB0aGUg SUQgdmFsdWVzLgpAQCAtMTYwLDcgKzE3OCw3IEBAIGludCBXZWJHZW9sb2NhdGlvblNlcnZpY2VN b2NrOjphdHRhY2hCcmlkZ2UoV2ViR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlKiBicmlkZ2UpCiAg ICAgcmV0dXJuIG5leHRBdmFpbGFibGVXYXRjaElkKys7CiB9CiAKLXZvaWQgV2ViR2VvbG9jYXRp b25TZXJ2aWNlTW9jazo6ZGV0YWNoQnJpZGdlKGludCBicmlkZ2VJZCkKK3ZvaWQgV2ViR2VvbG9j YXRpb25TZXJ2aWNlTW9ja0ltcGw6OmRldGFjaEJyaWRnZShpbnQgYnJpZGdlSWQpCiB7CiAgICAg bV9pZFRvQnJpZGdlTWFwLnJlbW92ZShicmlkZ2VJZCk7CiB9CmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggZjQ4ZTAzMTc0MGMw M2MwNzg5YjRlNGQzZDk2YjM4MDM4YjExMDMwOS4uNDRlMWRhMjU2ZjM4NzJlZmFiMjc5ZDQ3OTI3 YWNiZDAzYjE3NDU4ZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dl YktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA1LTI0ICBNYXJjdXMg QnVsYWNoICA8YnVsYWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEFkZHMgV2ViR2VvbG9jYXRpb25TZXJ2 aWNlTW9ja0ltcGwgdG8gcmVtb3ZlIHB1YmxpYyBkZXBlbmRlbmN5IG9uIHd0Zi9IYXNoTWFwLmgK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NTg3CisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHA6CisgICAg ICAgIChXZWJWaWV3SG9zdDo6Z2VvbG9jYXRpb25TZXJ2aWNlKToKKwogMjAxMC0wNS0yNCAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMg SmVyZG9uZWsuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9XZWJWaWV3SG9zdC5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9X ZWJWaWV3SG9zdC5jcHAKaW5kZXggZWI0NGMyYTZhOGIzODc4YTAwNWJlZWI3ZGNlODhmMTA5ZjNh MDgzMy4uMWExM2FjZWU2OGNjMjJjOTZmYTQ0NDYxM2UyM2QyOTBiNmUyMzYxOCAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCisr KyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcApA QCAtNTMxLDcgKzUzMSw3IEBAIFdlYk5vdGlmaWNhdGlvblByZXNlbnRlciogV2ViVmlld0hvc3Q6 Om5vdGlmaWNhdGlvblByZXNlbnRlcigpCiBXZWJLaXQ6OldlYkdlb2xvY2F0aW9uU2VydmljZSog V2ViVmlld0hvc3Q6Omdlb2xvY2F0aW9uU2VydmljZSgpCiB7CiAgICAgaWYgKCFtX2dlb2xvY2F0 aW9uU2VydmljZU1vY2suZ2V0KCkpCi0gICAgICAgIG1fZ2VvbG9jYXRpb25TZXJ2aWNlTW9jay5z ZXQobmV3IFdlYkdlb2xvY2F0aW9uU2VydmljZU1vY2spOworICAgICAgICBtX2dlb2xvY2F0aW9u U2VydmljZU1vY2suc2V0KFdlYkdlb2xvY2F0aW9uU2VydmljZU1vY2s6OmNyZWF0ZVdlYkdlb2xv Y2F0aW9uU2VydmljZU1vY2soKSk7CiAgICAgcmV0dXJuIG1fZ2VvbG9jYXRpb25TZXJ2aWNlTW9j ay5nZXQoKTsKIH0KIAo=