39585 2010-05-24 02:29:53 -0700 Web Inspector: '?' and '/' typed at console prompt are not properly handled 2010-05-28 03:20:55 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq webkit-unassigned bweinstein commit-queue joepeck kcbanner keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 229666 0 caseq 2010-05-24 02:29:53 -0700 '?' and '/' invoke help screen even when typed at console prompt. 229668 1 56865 caseq 2010-05-24 02:34:53 -0700 Created attachment 56865 patch 229671 2 56865 yurys 2010-05-24 02:40:50 -0700 Comment on attachment 56865 patch WebCore/inspector/front-end/inspector.js:715 + event.preventDefault(); why not return from here? 229678 3 56867 caseq 2010-05-24 02:49:22 -0700 Created attachment 56867 patch Indeed, we better return instantly upon catching our key. Thanks for spotting this -- it's been so for quite a few revisions! 229852 4 ap 2010-05-24 12:36:24 -0700 > '?' and '/' invoke help screen even when typed at console prompt. Why not mention that in ChangeLog? The current ChangeLog is super unhelpful - it tell neither what is fixed, nor how. 230082 5 56867 commit-queue 2010-05-24 21:40:20 -0700 Comment on attachment 56867 patch Clearing flags on attachment: 56867 Committed r60126: <http://trac.webkit.org/changeset/60126> 230083 6 commit-queue 2010-05-24 21:40:26 -0700 All reviewed patches have been landed. Closing bug. 231627 7 pfeldman 2010-05-28 03:20:55 -0700 *** Bug 39862 has been marked as a duplicate of this bug. *** 56865 2010-05-24 02:34:53 -0700 2010-05-24 02:49:22 -0700 patch help-screen-invocation.diff text/plain 2881 caseq SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDA2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMjQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCBoYW5kbGluZyBvZiBiYXJlICcvJyBhbmQgJz8nIGF0IGNvbnNvbGUgcHJvbXB0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk1ODUKKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLmRvY3VtZW50S2V5RG93bik6CisKIDIwMTAtMDUtMjMgIFNoaW5pY2hpcm8gSGFt YWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkg UHJvc2t1cnlha292LgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9y LmpzCShyZXZpc2lvbiA2MDA2NCkKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTcwNSwxOSArNzA1LDE5IEBAIFdlYkluc3BlY3Rv ci5fcmVnaXN0ZXJTaG9ydGN1dHMgPSBmdW5jdGkKIAogV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5 RG93biA9IGZ1bmN0aW9uKGV2ZW50KQogeworICAgIHZhciBpc0luRWRpdE1vZGUgPSBldmVudC50 YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcygidGV4dC1wcm9tcHQiKSB8fCBXZWJJ bnNwZWN0b3IuaXNFZGl0aW5nQW55RmllbGQoKTsKICAgICBjb25zdCBoZWxwS2V5ID0gV2ViSW5z cGVjdG9yLmlzTWFjKCkgPyAiVSswMDNGIiA6ICJVKzAwQkYiOyAvLyAiPyIgZm9yIGJvdGggcGxh dGZvcm1zCiAKICAgICBpZiAoZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIkYxIiB8fAotICAgICAg ICAoZXZlbnQua2V5SWRlbnRpZmllciA9PT0gaGVscEtleSAmJiAoIVdlYkluc3BlY3Rvci5pc0Vk aXRpbmdBbnlGaWVsZCgpIHx8IGV2ZW50Lm1ldGFLZXkpKSkgewotICAgICAgICAgICAgV2ViSW5z cGVjdG9yLnNob3J0Y3V0c0hlbHAuc2hvdygpOwotICAgICAgICAgICAgZXZlbnQuc3RvcFByb3Bh Z2F0aW9uKCk7Ci0gICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICAo ZXZlbnQua2V5SWRlbnRpZmllciA9PT0gaGVscEtleSAmJiBldmVudC5zaGlmdEtleSAmJiAoIWlz SW5FZGl0TW9kZSB8fCBldmVudC5tZXRhS2V5KSkpIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLnNo b3J0Y3V0c0hlbHAuc2hvdygpOworICAgICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsKKyAg ICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICB9CiAKICAgICBpZiAoV2ViSW5zcGVj dG9yLmlzRWRpdGluZ0FueUZpZWxkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHZhciBpc0lu VGV4dFByb21wdCA9IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJ0 ZXh0LXByb21wdCIpOwogICAgIGlmICh0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQgJiYgdGhpcy5j dXJyZW50Rm9jdXNFbGVtZW50LmhhbmRsZUtleUV2ZW50KSB7CiAgICAgICAgIHRoaXMuY3VycmVu dEZvY3VzRWxlbWVudC5oYW5kbGVLZXlFdmVudChldmVudCk7CiAgICAgICAgIGlmIChldmVudC5o YW5kbGVkKSB7CkBAIC03MzcsNyArNzM3LDcgQEAgV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5RG93 biA9IGZ1bmN0aW9uKAogICAgIHZhciBpc01hYyA9IFdlYkluc3BlY3Rvci5pc01hYygpOwogICAg IHN3aXRjaCAoZXZlbnQua2V5SWRlbnRpZmllcikgewogICAgICAgICBjYXNlICJMZWZ0IjoKLSAg ICAgICAgICAgIHZhciBpc0JhY2tLZXkgPSAhaXNJblRleHRQcm9tcHQgJiYgKGlzTWFjID8gZXZl bnQubWV0YUtleSA6IGV2ZW50LmN0cmxLZXkpOworICAgICAgICAgICAgdmFyIGlzQmFja0tleSA9 ICFpc0luRWRpdE1vZGUgJiYgKGlzTWFjID8gZXZlbnQubWV0YUtleSA6IGV2ZW50LmN0cmxLZXkp OwogICAgICAgICAgICAgaWYgKGlzQmFja0tleSAmJiB0aGlzLl9wYW5lbEhpc3RvcnkuY2FuR29C YWNrKCkpIHsKICAgICAgICAgICAgICAgICB0aGlzLl9wYW5lbEhpc3RvcnkuZ29CYWNrKCk7CiAg ICAgICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKQEAgLTc0NSw3ICs3NDUsNyBA QCBXZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duID0gZnVuY3Rpb24oCiAgICAgICAgICAgICBi cmVhazsKIAogICAgICAgICBjYXNlICJSaWdodCI6Ci0gICAgICAgICAgICB2YXIgaXNGb3J3YXJk S2V5ID0gIWlzSW5UZXh0UHJvbXB0ICYmIChpc01hYyA/IGV2ZW50Lm1ldGFLZXkgOiBldmVudC5j dHJsS2V5KTsKKyAgICAgICAgICAgIHZhciBpc0ZvcndhcmRLZXkgPSAhaXNJbkVkaXRNb2RlICYm IChpc01hYyA/IGV2ZW50Lm1ldGFLZXkgOiBldmVudC5jdHJsS2V5KTsKICAgICAgICAgICAgIGlm IChpc0ZvcndhcmRLZXkgJiYgdGhpcy5fcGFuZWxIaXN0b3J5LmNhbkdvRm9yd2FyZCgpKSB7CiAg ICAgICAgICAgICAgICAgdGhpcy5fcGFuZWxIaXN0b3J5LmdvRm9yd2FyZCgpOwogICAgICAgICAg ICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Cg== 56867 2010-05-24 02:49:22 -0700 2010-05-24 21:40:19 -0700 patch help-screen-invocation.diff text/plain 2898 caseq SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDA2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMjQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCBoYW5kbGluZyBvZiBiYXJlICcvJyBhbmQgJz8nIGF0IGNvbnNvbGUgcHJvbXB0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk1ODUKKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLmRvY3VtZW50S2V5RG93bik6CisKIDIwMTAtMDUtMjMgIFNoaW5pY2hpcm8gSGFt YWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkg UHJvc2t1cnlha292LgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9y LmpzCShyZXZpc2lvbiA2MDA2NCkKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTcwNSwxOSArNzA1LDIwIEBAIFdlYkluc3BlY3Rv ci5fcmVnaXN0ZXJTaG9ydGN1dHMgPSBmdW5jdGkKIAogV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5 RG93biA9IGZ1bmN0aW9uKGV2ZW50KQogeworICAgIHZhciBpc0luRWRpdE1vZGUgPSBldmVudC50 YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcygidGV4dC1wcm9tcHQiKSB8fCBXZWJJ bnNwZWN0b3IuaXNFZGl0aW5nQW55RmllbGQoKTsKICAgICBjb25zdCBoZWxwS2V5ID0gV2ViSW5z cGVjdG9yLmlzTWFjKCkgPyAiVSswMDNGIiA6ICJVKzAwQkYiOyAvLyAiPyIgZm9yIGJvdGggcGxh dGZvcm1zCiAKICAgICBpZiAoZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIkYxIiB8fAotICAgICAg ICAoZXZlbnQua2V5SWRlbnRpZmllciA9PT0gaGVscEtleSAmJiAoIVdlYkluc3BlY3Rvci5pc0Vk aXRpbmdBbnlGaWVsZCgpIHx8IGV2ZW50Lm1ldGFLZXkpKSkgewotICAgICAgICAgICAgV2ViSW5z cGVjdG9yLnNob3J0Y3V0c0hlbHAuc2hvdygpOwotICAgICAgICAgICAgZXZlbnQuc3RvcFByb3Bh Z2F0aW9uKCk7Ci0gICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICAo ZXZlbnQua2V5SWRlbnRpZmllciA9PT0gaGVscEtleSAmJiBldmVudC5zaGlmdEtleSAmJiAoIWlz SW5FZGl0TW9kZSB8fCBldmVudC5tZXRhS2V5KSkpIHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLnNo b3J0Y3V0c0hlbHAuc2hvdygpOworICAgICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsKKyAg ICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KIAog ICAgIGlmIChXZWJJbnNwZWN0b3IuaXNFZGl0aW5nQW55RmllbGQoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgdmFyIGlzSW5UZXh0UHJvbXB0ID0gZXZlbnQudGFyZ2V0LmVuY2xvc2luZ05vZGVP clNlbGZXaXRoQ2xhc3MoInRleHQtcHJvbXB0Iik7CiAgICAgaWYgKHRoaXMuY3VycmVudEZvY3Vz RWxlbWVudCAmJiB0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQuaGFuZGxlS2V5RXZlbnQpIHsKICAg ICAgICAgdGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50LmhhbmRsZUtleUV2ZW50KGV2ZW50KTsKICAg ICAgICAgaWYgKGV2ZW50LmhhbmRsZWQpIHsKQEAgLTczNyw3ICs3MzgsNyBAQCBXZWJJbnNwZWN0 b3IuZG9jdW1lbnRLZXlEb3duID0gZnVuY3Rpb24oCiAgICAgdmFyIGlzTWFjID0gV2ViSW5zcGVj dG9yLmlzTWFjKCk7CiAgICAgc3dpdGNoIChldmVudC5rZXlJZGVudGlmaWVyKSB7CiAgICAgICAg IGNhc2UgIkxlZnQiOgotICAgICAgICAgICAgdmFyIGlzQmFja0tleSA9ICFpc0luVGV4dFByb21w dCAmJiAoaXNNYWMgPyBldmVudC5tZXRhS2V5IDogZXZlbnQuY3RybEtleSk7CisgICAgICAgICAg ICB2YXIgaXNCYWNrS2V5ID0gIWlzSW5FZGl0TW9kZSAmJiAoaXNNYWMgPyBldmVudC5tZXRhS2V5 IDogZXZlbnQuY3RybEtleSk7CiAgICAgICAgICAgICBpZiAoaXNCYWNrS2V5ICYmIHRoaXMuX3Bh bmVsSGlzdG9yeS5jYW5Hb0JhY2soKSkgewogICAgICAgICAgICAgICAgIHRoaXMuX3BhbmVsSGlz dG9yeS5nb0JhY2soKTsKICAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwpA QCAtNzQ1LDcgKzc0Niw3IEBAIFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24gPSBmdW5jdGlv bigKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIGNhc2UgIlJpZ2h0IjoKLSAgICAgICAg ICAgIHZhciBpc0ZvcndhcmRLZXkgPSAhaXNJblRleHRQcm9tcHQgJiYgKGlzTWFjID8gZXZlbnQu bWV0YUtleSA6IGV2ZW50LmN0cmxLZXkpOworICAgICAgICAgICAgdmFyIGlzRm9yd2FyZEtleSA9 ICFpc0luRWRpdE1vZGUgJiYgKGlzTWFjID8gZXZlbnQubWV0YUtleSA6IGV2ZW50LmN0cmxLZXkp OwogICAgICAgICAgICAgaWYgKGlzRm9yd2FyZEtleSAmJiB0aGlzLl9wYW5lbEhpc3RvcnkuY2Fu R29Gb3J3YXJkKCkpIHsKICAgICAgICAgICAgICAgICB0aGlzLl9wYW5lbEhpc3RvcnkuZ29Gb3J3 YXJkKCk7CiAgICAgICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsK