39584 2010-05-24 01:31:53 -0700 webkit-patch land calls scm.changed_files 4 times! 2010-05-24 21:28:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth cjerdonek commit-queue mjs ojan oldest_to_newest 229650 0 eric 2010-05-24 01:31:53 -0700 webkit-patch land calls scm.create_patch 4 times! webkit-patch land --verbose will show you: webkitpy.common.system: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.09s webkitpy.common.system: [DEBUG] "git rev-parse --git-dir" took 0.01s webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.01s webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.23s webkitpy.common.system: [DEBUG] "git diff -r --name-status -C -M --no-ext-diff --full-index HEAD" took 26.24s Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog Fetching: https://bugs.webkit.org/show_bug.cgi?id=39208&ctype=xml Guessing "Chris Jerdonek" as reviewer from attachment 56222 on bug 39208. webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.09s webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.21s webkitpy.common.system: [DEBUG] "git diff -r --name-status -C -M --no-ext-diff --full-index HEAD" took 26.59s webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.31s webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.34s webkitpy.common.system: [DEBUG] "git diff -r --name-status -C -M --no-ext-diff --full-index HEAD" took 26.57s Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog webkitpy.common.system: [DEBUG] "git config webkit-patch.squash" took 0.14s webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.39s webkitpy.common.system: [DEBUG] "git diff HEAD --name-only" took 28.41s webkitpy.common.system: [DEBUG] "git log --pretty=oneline HEAD...trunk" took 0.29s webkitpy.common.system: [DEBUG] "git commit --all -F -" took 40.12s Notice that the I spent nearly 2 minutes waiting for it to run the same diff command 4 times! 229653 1 eric 2010-05-24 01:34:10 -0700 Actually, it's scm.changed_files() at fault here. 229654 2 eric 2010-05-24 01:55:04 -0700 Ok, so 3 of those were scm.changed_files, and one of those was scm.working_directory_is_clean. I have a patch to get rid of two of the changed_files calls. Not sure about the scm.working_directory_is_clean call yet. 229656 3 56862 eric 2010-05-24 02:00:25 -0700 Created attachment 56862 Patch 229664 4 56862 abarth 2010-05-24 02:22:40 -0700 Comment on attachment 56862 Patch Ok. 230078 5 56862 commit-queue 2010-05-24 21:28:27 -0700 Comment on attachment 56862 Patch Clearing flags on attachment: 56862 Committed r60124: <http://trac.webkit.org/changeset/60124> 230079 6 commit-queue 2010-05-24 21:28:36 -0700 All reviewed patches have been landed. Closing bug. 56862 2010-05-24 02:00:25 -0700 2010-05-24 21:28:26 -0700 Patch bug-39584-20100524020024.patch text/plain 4159 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmNDhlMDMxNzQwYzAzYzA3ODliNGU0ZDNkOTZiMzgwMzhiMTEwMzA5Li5lNTBiMTAz M2QwZTJlNmRlNDNmMjZjZmE4MGE4NzQwMmMxODhiZGEwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAK IDIwMTAtMDUtMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBsYW5kIGNh bGxzIHNjbS5jaGFuZ2VkX2ZpbGVzIDQgdGltZXMhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTU4NAorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0ZXN0LnB5OgorICAgICAgICAgLSBBc3NlcnQg dGhhdCB3ZSBkb24ndCBjYWxsIG1vZGlmaWVkX2NoYW5nZWxvZ3MgdG9vIG9mdGVuLgorICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy91cGRhdGVjaGFuZ2Vsb2dzd2l0aHJldmll d2VyLnB5OgorICAgICAgICAgLSBVc2UgY2FjaGVkIGNoYW5nZWxvZ3MgbGlzdCBpbnN0ZWFkIG9m IGNhbGxpbmcgbW9kaWZpZWRfY2hhbmdlbG9ncyBkaXJlY3RseS4KKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3Rvb2wvc3RlcHMvdmFsaWRhdGVyZXZpZXdlci5weToKKyAgICAgICAgIC0gZGl0 dG8uCisKKzIwMTAtMDUtMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAgICAg ICAgIFJldmlld2VkIGJ5IENocmlzIEplcmRvbmVrLgogCiAgICAgICAgIHdlYmtpdC1wYXRjaCBu ZWVkcyAtLXZlcmJvc2UgZmxhZyB0byBlbmFibGUgREVCVUcgbG9nZ2luZwpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0 ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25s b2FkX3VuaXR0ZXN0LnB5CmluZGV4IDRkZDlkN2Y0YzE5N2RjNDk3NDBjMTMzOTAwZjNhZDMyMmU5 MjcwNzcuLjA4YTQzNzdmMzRkYTdkZTA3ODY1NDdiMGJjMzBjMWQ1YmVmZmQxMTIgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZF91 bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvZG93bmxvYWRfdW5pdHRlc3QucHkKQEAgLTkyLDcgKzkyLDEzIEBAIGNsYXNzIERvd25sb2Fk Q29tbWFuZHNUZXN0KENvbW1hbmRzVGVzdCk6CiAKICAgICBkZWYgdGVzdF9sYW5kX2RpZmYoc2Vs Zik6CiAgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJCdWlsZGluZyBXZWJLaXRcblJ1bm5pbmcg UHl0aG9uIHVuaXQgdGVzdHNcblJ1bm5pbmcgUGVybCB1bml0IHRlc3RzXG5SdW5uaW5nIEphdmFT Y3JpcHRDb3JlIHRlc3RzXG5SdW5uaW5nIHJ1bi13ZWJraXQtdGVzdHNcblVwZGF0aW5nIGJ1ZyA0 MlxuIgotICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMoTGFuZCgpLCBbNDJdLCBv cHRpb25zPXNlbGYuX2RlZmF1bHRfb3B0aW9ucygpLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRf c3RkZXJyKQorICAgICAgICBtb2NrX3Rvb2wgPSBNb2NrVG9vbCgpCisgICAgICAgIG1vY2tfdG9v bC5zY20oKS5jcmVhdGVfcGF0Y2ggPSBNb2NrKCkKKyAgICAgICAgbW9ja190b29sLmNoZWNrb3V0 KCkubW9kaWZpZWRfY2hhbmdlbG9ncyA9IE1vY2socmV0dXJuX3ZhbHVlPVtdKQorICAgICAgICBz ZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMoTGFuZCgpLCBbNDJdLCBvcHRpb25zPXNlbGYuX2Rl ZmF1bHRfb3B0aW9ucygpLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyLCB0b29sPW1v Y2tfdG9vbCkKKyAgICAgICAgIyBNYWtlIHN1cmUgd2UncmUgbm90IGNhbGxpbmcgZXhwZW5zaXZl IGNhbGxzIHRvbyBvZnRlbi4KKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChtb2NrX3Rvb2wuc2Nt KCkuY3JlYXRlX3BhdGNoLmNhbGxfY291bnQsIDApCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo bW9ja190b29sLmNoZWNrb3V0KCkubW9kaWZpZWRfY2hhbmdlbG9ncy5jYWxsX2NvdW50LCAxKQog CiAgICAgZGVmIHRlc3RfY2hlY2tfc3R5bGUoc2VsZik6CiAgICAgICAgIGV4cGVjdGVkX3N0ZGVy ciA9ICJQcm9jZXNzaW5nIDEgcGF0Y2ggZnJvbSAxIGJ1Zy5cblVwZGF0aW5nIHdvcmtpbmcgZGly ZWN0b3J5XG5Qcm9jZXNzaW5nIHBhdGNoIDE5NyBmcm9tIGJ1ZyA0Mi5cblJ1bm5pbmcgY2hlY2st d2Via2l0LXN0eWxlXG4iCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvc3RlcHMvdXBkYXRlY2hhbmdlbG9nc3dpdGhyZXZpZXdlci5weSBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy91cGRhdGVjaGFuZ2Vsb2dzd2l0aHJldmlld2Vy LnB5CmluZGV4IDk3NDAwMTM2ODY2YTc1MWFjZWI2MjFhOWY4M2Q1NTY3MjU2NzJhYTcuLmVmNGJh YTI1MTI0MTNlNTZkZDlmYjllMWZmOTc0YjZkYjhmMmJlNzQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy91cGRhdGVjaGFuZ2Vsb2dzd2l0aHJldmll d2VyLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy91cGRh dGVjaGFuZ2Vsb2dzd2l0aHJldmlld2VyLnB5CkBAIC03MCw1ICs3MCw1IEBAIGNsYXNzIFVwZGF0 ZUNoYW5nZUxvZ3NXaXRoUmV2aWV3ZXIoQWJzdHJhY3RTdGVwKToKICAgICAgICAgICAgIHJldHVy bgogCiAgICAgICAgIG9zLmNoZGlyKHNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKLSAg ICAgICAgZm9yIGNoYW5nZWxvZ19wYXRoIGluIHNlbGYuX3Rvb2wuY2hlY2tvdXQoKS5tb2RpZmll ZF9jaGFuZ2Vsb2dzKHNlbGYuX29wdGlvbnMuZ2l0X2NvbW1pdCwgc2VsZi5fb3B0aW9ucy5zcXVh c2gpOgorICAgICAgICBmb3IgY2hhbmdlbG9nX3BhdGggaW4gc2VsZi5jYWNoZWRfbG9va3VwKHN0 YXRlLCAiY2hhbmdlbG9ncyIpOgogICAgICAgICAgICAgQ2hhbmdlTG9nKGNoYW5nZWxvZ19wYXRo KS5zZXRfcmV2aWV3ZXIocmV2aWV3ZXIpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvc3RlcHMvdmFsaWRhdGVyZXZpZXdlci5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy92YWxpZGF0ZXJldmlld2VyLnB5CmluZGV4IDY2ZWU1 YjdmYzE5OTk0NTM3MmQ0NWQzYTgzODY4ZDQxNDVkMGIzNWYuLjlmNGQ0NGUwYjZjNWIwOWE2YTRh MzhmNDVmZjBjYmNlZDUzZDViNWMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy92YWxpZGF0ZXJldmlld2VyLnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy92YWxpZGF0ZXJldmlld2VyLnB5CkBAIC02Myw3ICs2 Myw3IEBAIGNsYXNzIFZhbGlkYXRlUmV2aWV3ZXIoQWJzdHJhY3RTdGVwKToKICAgICAgICAgIyBG SVhNRTogV2Ugc2hvdWxkIGZpZ3VyZSBvdXQgaG93IHRvIGhhbmRsZSB0aGUgY3VycmVudCB3b3Jr aW5nCiAgICAgICAgICMgICAgICAgIGRpcmVjdG9yeSBpc3N1ZSBtb3JlIGdsb2JhbGx5LgogICAg ICAgICBvcy5jaGRpcihzZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpCi0gICAgICAgIGZv ciBjaGFuZ2Vsb2dfcGF0aCBpbiBzZWxmLl90b29sLmNoZWNrb3V0KCkubW9kaWZpZWRfY2hhbmdl bG9ncyhzZWxmLl9vcHRpb25zLmdpdF9jb21taXQsIHNlbGYuX29wdGlvbnMuc3F1YXNoKToKKyAg ICAgICAgZm9yIGNoYW5nZWxvZ19wYXRoIGluIHNlbGYuY2FjaGVkX2xvb2t1cChzdGF0ZSwgImNo YW5nZWxvZ3MiKToKICAgICAgICAgICAgIGNoYW5nZWxvZ19lbnRyeSA9IENoYW5nZUxvZyhjaGFu Z2Vsb2dfcGF0aCkubGF0ZXN0X2VudHJ5KCkKICAgICAgICAgICAgIGlmIHNlbGYuX2hhc192YWxp ZF9yZXZpZXdlcihjaGFuZ2Vsb2dfZW50cnkpOgogICAgICAgICAgICAgICAgIGNvbnRpbnVlCg==