39567 2010-05-23 07:49:29 -0700 [GTK] Configure script should check the required GTK+ version 2010-06-01 17:10:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P4 Normal --- 0 joone webkit-unassigned bunk commit-queue gustavo xan.lopez oldest_to_newest 229480 0 56824 joone 2010-05-23 07:49:29 -0700 Created attachment 56824 modified configure.ac The current configure script doesn't check the required GTK+ version to 2.18 If the installed GTK+ is prior to 2.18, you can see the following build break message. WebCore/platform/gtk/ScrollbarGtk.cpp:211: error: ‘gtk_widget_get_has_window’ was not declared in this scope gtk_widget_get_has_window API has been introduced since 2.18 Therefore we need to modify configure.ac as follows, diff --git a/configure.ac b/configure.ac index 9757541..a076e35 100644 --- a/configure.ac +++ b/configure.ac @@ -205,7 +205,7 @@ LIBXML_REQUIRED_VERSION=2.6 # minimum GTK+ base dependencies PANGO_REQUIRED_VERSION=1.12 -GTK_REQUIRED_VERSION=2.10 +GTK_REQUIRED_VERSION=2.18 229660 1 xan.lopez 2010-05-24 02:08:35 -0700 (In reply to comment #0) > Created an attachment (id=56824) [details] > modified configure.ac > > The current configure script doesn't check the required GTK+ version to 2.18 > If the installed GTK+ is prior to 2.18, you can see the following build break message. > > WebCore/platform/gtk/ScrollbarGtk.cpp:211: error: ‘gtk_widget_get_has_window’ was not declared in this scope > > gtk_widget_get_has_window API has been introduced since 2.18 > Therefore we need to modify configure.ac as follows, > > diff --git a/configure.ac b/configure.ac > index 9757541..a076e35 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -205,7 +205,7 @@ LIBXML_REQUIRED_VERSION=2.6 > > # minimum GTK+ base dependencies > PANGO_REQUIRED_VERSION=1.12 > -GTK_REQUIRED_VERSION=2.10 > +GTK_REQUIRED_VERSION=2.18 The required GTK+ version is 2.10, not 2.18. If we fail to compile with it then it's just a mistake, not intentional. In the case of gtk_widget_get_has_window this should be fixed in WebCore/platform/gtk/GtkVersioning.h, so not sure what's going on. Are you using svn trunk? 229730 2 joone 2010-05-24 07:05:47 -0700 I'm using git trunk. I think that GtkVersioning.h should be included in WebCore/platform/gtk/ScrollbarGtk.cpp 229870 3 gustavo 2010-05-24 13:30:54 -0700 (In reply to comment #2) > I'm using git trunk. > > I think that GtkVersioning.h should be included in WebCore/platform/gtk/ScrollbarGtk.cpp That sounds right to me. Want to make a patch with a changelog? =) 230183 4 xan.lopez 2010-05-25 02:24:14 -0700 (In reply to comment #2) > I'm using git trunk. > > I think that GtkVersioning.h should be included in WebCore/platform/gtk/ScrollbarGtk.cpp Duh, of course. As Gustavo says, a patch is welcome :) 230243 5 57012 joone 2010-05-25 06:32:30 -0700 Created attachment 57012 Proposed patch Hi~ I made a patch. Thanks! 230372 6 57012 xan.lopez 2010-05-25 11:14:47 -0700 Comment on attachment 57012 Proposed patch r=me 230479 7 bunk 2010-05-25 15:02:56 -0700 (In reply to comment #1) > The required GTK+ version is 2.10, not 2.18. If we fail to compile with it then it's just a mistake, not intentional. In the case of gtk_widget_get_has_window this should be fixed in WebCore/platform/gtk/GtkVersioning.h, so not sure what's going on. Are you using svn trunk? Please have a look at #37085 where I try to explain why GTK+ versions < 2.18 are unlikely to be used in practice due to the high glib dependency. 231207 8 57012 commit-queue 2010-05-27 03:39:42 -0700 Comment on attachment 57012 Proposed patch Clearing flags on attachment: 57012 Committed r60288: <http://trac.webkit.org/changeset/60288> 231208 9 commit-queue 2010-05-27 03:39:47 -0700 All reviewed patches have been landed. Closing bug. 232750 10 gustavo 2010-06-01 07:57:17 -0700 (In reply to comment #7) > Please have a look at #37085 where I try to explain why GTK+ versions < 2.18 are unlikely to be used in practice due to the high glib dependency. I said exactly that some time ago, and someone then explained to me that the reason we try to support 2.10 is because that's what Maemo had, and people saw it as a good thing to have (given it was not too complex). Maemo5 has moved to GTK+ 2.14, it seems, so the reasons to support something older than 2.14 may soon be gone. 232996 11 bunk 2010-06-01 17:10:15 -0700 (In reply to comment #10) > (In reply to comment #7) > > Please have a look at #37085 where I try to explain why GTK+ versions < 2.18 are unlikely to be used in practice due to the high glib dependency. > > I said exactly that some time ago, and someone then explained to me that the reason we try to support 2.10 is because that's what Maemo had, and people saw it as a good thing to have (given it was not too complex). Maemo5 has moved to GTK+ 2.14, it seems, so the reasons to support something older than 2.14 may soon be gone. Supporting GTK+ 2.14 alone won't help you for Maemo. Maemo 5 ships with glib 2.20, and that is too old for the libsoup versions required by WebKitGTK+, and for WebKitGTK+ itself. 56824 2010-05-23 07:49:29 -0700 2010-05-23 07:49:29 -0700 modified configure.ac gtk_version.diff text/plain 330 joone ZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCA5NzU3NTQxLi5h MDc2ZTM1IDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0y MDUsNyArMjA1LDcgQEAgTElCWE1MX1JFUVVJUkVEX1ZFUlNJT049Mi42CiAKICMgbWluaW11bSBH VEsrIGJhc2UgZGVwZW5kZW5jaWVzCiBQQU5HT19SRVFVSVJFRF9WRVJTSU9OPTEuMTIKLUdUS19S RVFVSVJFRF9WRVJTSU9OPTIuMTAKK0dUS19SRVFVSVJFRF9WRVJTSU9OPTIuMTgKIAogIyBvcHRp b25hbCBtb2R1bGVzCiBMSUJYU0xUX1JFUVVJUkVEX1ZFUlNJT049MS4xLjcK 57012 2010-05-25 06:32:30 -0700 2010-05-27 03:39:41 -0700 Proposed patch webkitGtk.diff text/plain 922 joone ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTk4MTIzMC4uMGY5NGE0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0yNSAgSm9vbmUgSHVyICA8 am9vbmVAa2xkcC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIEd0a1ZlcnNpb25pbmcuaCBpbiBTY3JvbGxiYWNrR3RrLmNwcCBmb3IgbWFp bnRhaW5pbmcgY29tcGF0aWJpbGl0eSB3aXRoIHRoZSBwcmV2aW91cyBHVEsrCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NTY3CisKKyAgICAgICAg KiBwbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyR3RrLmNwcDoKKwogMjAxMC0wNS0yNSAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXgg Q2hyb21pdW0gTWFjIFJlbGVhc2UgYnVpbGQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9TY3JvbGxiYXJHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyR3Rr LmNwcAppbmRleCAwMGNiY2YwLi4zZDRjYzQ3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9TY3JvbGxiYXJHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJh ckd0ay5jcHAKQEAgLTIwLDYgKzIwLDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRl ICJTY3JvbGxiYXJHdGsuaCIKIAorI2luY2x1ZGUgIkd0a1ZlcnNpb25pbmcuaCIKICNpbmNsdWRl ICJJbnRSZWN0LmgiCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiRnJh bWVWaWV3LmgiCg==