39504 2010-05-21 11:35:34 -0700 Fix MIPS JIT DoubleGreaterThanOrEqual Operands 2010-05-28 19:54:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 fu webkit-unassigned commit-queue oldest_to_newest 229021 0 fu 2010-05-21 11:35:34 -0700 There is a typo in MIPS JIT for DoubleGreaterThanOrEqual. Two operands of left and right need to be swapped. Thanks! 229023 1 56733 fu 2010-05-21 11:41:28 -0700 Created attachment 56733 Swapped two operands Here is the patch 229027 2 56733 eric 2010-05-21 11:59:59 -0700 Comment on attachment 56733 Swapped two operands Please fix the ChangeLog to mention which test this fixes. If it does not fix a test, please add one. 229060 3 56739 fu 2010-05-21 13:07:38 -0700 Created attachment 56739 Updated ChangeLog This patch fixed two layout tests as follows. fast/js/comparison-operators-greater.html fast/js/comparison-operators-less.html The ChangeLog is updated to mention these two patches. Thanks! Regards, Chao-ying 229194 4 fu 2010-05-21 17:52:35 -0700 Note that the two layout tests failed on MIPS after tests are added recently, I spent some time debugging them and found out that the operands are swapped incorrectly in MIPS JIT for c.nge.d instructions. Thanks! 231996 5 56739 eric 2010-05-28 16:02:47 -0700 Comment on attachment 56739 Updated ChangeLog Thank you for updating the ChagneLog. Fantastic patch now that I can clearly see what it fixes from the ChangeLog. 232051 6 56739 commit-queue 2010-05-28 19:54:31 -0700 Comment on attachment 56739 Updated ChangeLog Clearing flags on attachment: 56739 Committed r60383: <http://trac.webkit.org/changeset/60383> 232052 7 commit-queue 2010-05-28 19:54:36 -0700 All reviewed patches have been landed. Closing bug. 56733 2010-05-21 11:41:28 -0700 2010-05-21 13:07:38 -0700 Swapped two operands mips-jit20100521.diff text/plain 1232 fu SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5OTQxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMjEgIENoYW8teWlu ZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBNSVBTIEpJVCBEb3VibGVHcmVhdGVyVGhhbk9yRXF1YWwgT3BlcmFu ZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NTA0 CisKKyAgICAgICAgU3dhcHBlZCB0d28gb3BlcmFuZHMgb2YgbGVmdCBhbmQgcmlnaHQgZm9yIERv dWJsZUdyZWF0ZXJUaGFuT3JFcXVhbC4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2Vt Ymxlck1JUFMuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpicmFuY2hEb3Vi bGUpOgorCiAyMDEwLTA1LTIxICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCShyZXZpc2lvbiA1OTc5OCkKKysrIEph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAkod29ya2luZyBjb3B5 KQpAQCAtMTY3NCw3ICsxNjc0LDcgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuIGJyYW5j aEZhbHNlKCk7IC8vIGZhbHNlCiAgICAgICAgIH0KICAgICAgICAgaWYgKGNvbmQgPT0gRG91Ymxl R3JlYXRlclRoYW5PckVxdWFsKSB7Ci0gICAgICAgICAgICBtX2Fzc2VtYmxlci5jbmdlZChyaWdo dCwgbGVmdCk7CisgICAgICAgICAgICBtX2Fzc2VtYmxlci5jbmdlZChsZWZ0LCByaWdodCk7CiAg ICAgICAgICAgICByZXR1cm4gYnJhbmNoRmFsc2UoKTsgLy8gZmFsc2UKICAgICAgICAgfQogICAg ICAgICBpZiAoY29uZCA9PSBEb3VibGVMZXNzVGhhbikgewo= 56739 2010-05-21 13:07:38 -0700 2010-05-28 19:54:31 -0700 Updated ChangeLog mips-jit20100521-new.diff text/plain 1386 fu SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5OTQxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMjEgIENoYW8teWlu ZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBNSVBTIEpJVCBEb3VibGVHcmVhdGVyVGhhbk9yRXF1YWwgT3BlcmFu ZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NTA0 CisKKyAgICAgICAgU3dhcHBlZCB0d28gb3BlcmFuZHMgb2YgbGVmdCBhbmQgcmlnaHQgZm9yIERv dWJsZUdyZWF0ZXJUaGFuT3JFcXVhbC4KKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlZCB0d28gbGF5 b3V0IHRlc3RzIGFzIGZvbGxvd3MuCisgICAgICAgIGZhc3QvanMvY29tcGFyaXNvbi1vcGVyYXRv cnMtZ3JlYXRlci5odG1sCisgICAgICAgIGZhc3QvanMvY29tcGFyaXNvbi1vcGVyYXRvcnMtbGVz cy5odG1sCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAg ICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6YnJhbmNoRG91YmxlKToKKwogMjAxMC0wNS0y MSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEdlb2ZmcmV5IEdhcmVuLgpJbmRleDogSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyTUlQUy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlck1JUFMuaAkocmV2aXNpb24gNTk3OTgpCisrKyBKYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHdvcmtpbmcgY29weSkKQEAgLTE2NzQsNyArMTY3 NCw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHJldHVybiBicmFuY2hGYWxzZSgpOyAvLyBmYWxz ZQogICAgICAgICB9CiAgICAgICAgIGlmIChjb25kID09IERvdWJsZUdyZWF0ZXJUaGFuT3JFcXVh bCkgewotICAgICAgICAgICAgbV9hc3NlbWJsZXIuY25nZWQocmlnaHQsIGxlZnQpOworICAgICAg ICAgICAgbV9hc3NlbWJsZXIuY25nZWQobGVmdCwgcmlnaHQpOwogICAgICAgICAgICAgcmV0dXJu IGJyYW5jaEZhbHNlKCk7IC8vIGZhbHNlCiAgICAgICAgIH0KICAgICAgICAgaWYgKGNvbmQgPT0g RG91YmxlTGVzc1RoYW4pIHsK