39503 2010-05-21 11:22:01 -0700 incorrect selection with absolutely positioned div. 2011-09-19 14:50:41 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan rniwa cshu darin enrica eric hyatt kenneth mitz rniwa simon.fraser tonikitoo oldest_to_newest 229015 0 56732 ojan 2010-05-21 11:22:01 -0700 Created attachment 56732 test case See the test case. 469686 1 rniwa 2011-09-19 14:26:36 -0700 The problem is that RenderBlock::positionForPoint assumes that the lastChildBox is not positioned. if (lastChildBox() && contentsY > lastChildBox()->y()) { for (RenderBox* childBox = lastChildBox(); childBox; childBox = childBox->previousSiblingBox()) { if (isChildHitTestCandidate(childBox)) return positionForPointRespectingEditingBoundaries(this, childBox, pointInContents); } } else { +mitz since this code was added in http://trac.webkit.org/changeset/42467. 469692 2 107921 rniwa 2011-09-19 14:36:18 -0700 Created attachment 107921 fixes the bug 469695 3 107921 rniwa 2011-09-19 14:39:28 -0700 Comment on attachment 107921 fixes the bug Oops, something's wrong with my patch. 469697 4 kenneth 2011-09-19 14:42:36 -0700 > LayoutTests/ChangeLog:9 > + with a absolutely positioned last child. WebKit should place the caret on the left of the first line I guess it is "an absolutely" 469700 5 107921 rniwa 2011-09-19 14:46:20 -0700 Comment on attachment 107921 fixes the bug Nope. My patch is fine. I was commenting out some code to verify my test and had forgotten to rebuild before running the test. 469702 6 107921 kenneth 2011-09-19 14:47:17 -0700 Comment on attachment 107921 fixes the bug Nice test and good catch, r=me 469703 7 rniwa 2011-09-19 14:47:52 -0700 (In reply to comment #6) > (From update of attachment 107921 [details]) > Nice test and good catch, r=me Thanks for the review! WIll fix "a absolutely". 469705 8 rniwa 2011-09-19 14:50:41 -0700 Committed r95478: <http://trac.webkit.org/changeset/95478> 56732 2010-05-21 11:22:01 -0700 2010-05-21 11:22:01 -0700 test case scratch.html text/html 281 ojan U3RhcnQgaW4gdGhlIG1pZGRsZSBvZiB0aGlzIGxpbmUgYW5kIGRyYWcgYWxsIHRoZSB3YXkgdG8g dGhlIGxlZnQuCjxkaXY+VGhlIHNlbGVjdGlvbiBzaG91bGQgYmUgZnJvbSB0aGUgbWlkZGxlIG9m IHRoZSBsaW5lIHRvIHRoZSBzdGFydCBvZiB0aGUgbGluZS4gSW5zdGVhZCBpdCdzIGZyb20gdGhl IG1pZGRsZSBvZiB0aGUgbGluZSB0byB0aGUgZW5kIG9mIHRoZSBsaW5lLjwvZGl2Pgo8ZGl2IHN0 eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTsgdG9wOjBweDsgcmlnaHQ6MHB4OyI+PC9kaXY+IAo= 107921 2011-09-19 14:36:18 -0700 2011-09-19 14:47:17 -0700 fixes the bug bug-39503-20110919143617.patch text/plain 5257 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NDc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDktMTkgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgaW5jb3JyZWN0IHNlbGVjdGlvbiB3 aXRoIGFic29sdXRlbHkgcG9zaXRpb25lZCBkaXYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTUwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSBhIGZhbHNlIGFzc3Vt cHRpb24gaW4gUmVuZGVyQmxvY2s6OnBvc2l0aW9uRm9yUG9pbnQuIEJlY2F1c2UgdGhlIGxhc3Qg Y2hpbGQgYm94CisgICAgICAgIGNhbiBiZSBwb3NpdGlvbmVkLCBmbG9hdGVkLCBpbnZpc2libGUs IGV0Yy4uLiwgd2UgY2FuJ3QgYWx3YXlzIHRydXN0IGxhc3QgY2hpbGQncyBsb2dpY2FsVG9wIHRv IHRlbGwgdXMKKyAgICAgICAgd2hldGhlciBhIGdpdmVuIHBvaW50IGlzIGluc2lkZSBvciBiZWxv dyB0aGUgbGFzdCBjaGlsZCBib3guCisKKyAgICAgICAgRml4ZWQgdGhlIGJ1ZyBieSB1c2luZyB0 aGUgbGFzdCBoaXQtdGVzdCBjYW5kaWRhdGUgaW5zdGVhZC4KKworICAgICAgICBUZXN0OiBlZGl0 aW5nL3NlbGVjdGlvbi9ibG9jay13aXRoLXBvc2l0aW9uZWQtbGFzdGNoaWxkLmh0bWwKKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCbG9jazo6cG9zaXRpb25Gb3JQb2ludCk6CisKIDIwMTEtMDktMTkgIERtaXRyeSBUaXRvdiAg PGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBDcmFzaCBhZnRlciBt YWdpYyBpZnJhbWUgdHJhbnNmZXIgZm9yIFBlcHBlci9OYUNsIHBsdWdpbnMuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDk1NDE4KQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDM0NSwxMiArNDM0NSwxNCBAQCBWaXNpYmxlUG9zaXRpb24gUmVuZGVyQmxvY2s6OnBvc2l0 aW9uRm9yCiAgICAgaWYgKGNoaWxkcmVuSW5saW5lKCkpCiAgICAgICAgIHJldHVybiBwb3NpdGlv bkZvclBvaW50V2l0aElubGluZUNoaWxkcmVuKHBvaW50SW5Mb2dpY2FsQ29udGVudHMpOwogCi0g ICAgaWYgKGxhc3RDaGlsZEJveCgpICYmIHBvaW50SW5Db250ZW50cy55KCkgPiBsYXN0Q2hpbGRC b3goKS0+bG9naWNhbFRvcCgpKSB7Ci0gICAgICAgIGZvciAoUmVuZGVyQm94KiBjaGlsZEJveCA9 IGxhc3RDaGlsZEJveCgpOyBjaGlsZEJveDsgY2hpbGRCb3ggPSBjaGlsZEJveC0+cHJldmlvdXNT aWJsaW5nQm94KCkpIHsKLSAgICAgICAgICAgIGlmIChpc0NoaWxkSGl0VGVzdENhbmRpZGF0ZShj aGlsZEJveCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIHBvc2l0aW9uRm9yUG9pbnRSZXNwZWN0 aW5nRWRpdGluZ0JvdW5kYXJpZXModGhpcywgY2hpbGRCb3gsIHBvaW50SW5Db250ZW50cyk7Ci0g ICAgICAgIH0KLSAgICB9IGVsc2UgeworICAgIFJlbmRlckJveCogbGFzdENhbmRpZGF0ZUJveCA9 IGxhc3RDaGlsZEJveCgpOworICAgIHdoaWxlIChsYXN0Q2FuZGlkYXRlQm94ICYmICFpc0NoaWxk SGl0VGVzdENhbmRpZGF0ZShsYXN0Q2FuZGlkYXRlQm94KSkKKyAgICAgICAgbGFzdENhbmRpZGF0 ZUJveCA9IGxhc3RDYW5kaWRhdGVCb3gtPnByZXZpb3VzU2libGluZ0JveCgpOworCisgICAgaWYg KGxhc3RDYW5kaWRhdGVCb3gpIHsKKyAgICAgICAgaWYgKHBvaW50SW5Db250ZW50cy55KCkgPiBs YXN0Q2FuZGlkYXRlQm94LT5sb2dpY2FsVG9wKCkpCisgICAgICAgICAgICByZXR1cm4gcG9zaXRp b25Gb3JQb2ludFJlc3BlY3RpbmdFZGl0aW5nQm91bmRhcmllcyh0aGlzLCBsYXN0Q2FuZGlkYXRl Qm94LCBwb2ludEluQ29udGVudHMpOworCiAgICAgICAgIGZvciAoUmVuZGVyQm94KiBjaGlsZEJv eCA9IGZpcnN0Q2hpbGRCb3goKTsgY2hpbGRCb3g7IGNoaWxkQm94ID0gY2hpbGRCb3gtPm5leHRT aWJsaW5nQm94KCkpIHsKICAgICAgICAgICAgIC8vIFdlIGhpdCBjaGlsZCBpZiBvdXIgY2xpY2sg aXMgYWJvdmUgdGhlIGJvdHRvbSBvZiBpdHMgcGFkZGluZyBib3ggKGxpa2UgSUU2LzcgYW5kIEZG MykuCiAgICAgICAgICAgICBpZiAoaXNDaGlsZEhpdFRlc3RDYW5kaWRhdGUoY2hpbGRCb3gpICYm IHBvaW50SW5Db250ZW50cy55KCkgPCBjaGlsZEJveC0+bG9naWNhbEJvdHRvbSgpKQpJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gOTU0NzQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wOS0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KKworICAgICAgICBpbmNvcnJlY3Qgc2VsZWN0aW9uIHdpdGggYWJzb2x1dGVseSBw b3NpdGlvbmVkIGRpdi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM5NTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QgZm9yIHBsYWNpbmcgdGhlIGNhcmV0IGluc2lk ZSBhIGJsb2NrIHdpdGggbXVsdGlwbGUgbG9naWNhbCBsaW5lcworICAgICAgICB3aXRoIGEgYWJz b2x1dGVseSBwb3NpdGlvbmVkIGxhc3QgY2hpbGQuIFdlYktpdCBzaG91bGQgcGxhY2UgdGhlIGNh cmV0IG9uIHRoZSBsZWZ0IG9mIHRoZSBmaXJzdCBsaW5lCisgICAgICAgIChpbnN0ZWFkIG9mIGFm dGVyIHRoZSBsYXN0IGxpbmUpIHdoZW4gdGhlIHVzZXIgY2xpY2tzIG9uIHRoZSBsZWZ0IG9mIHRo ZSBmaXJzdCBsaW5lLgorCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vYmxvY2std2l0aC1w b3NpdGlvbmVkLWxhc3RjaGlsZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRp bmcvc2VsZWN0aW9uL2Jsb2NrLXdpdGgtcG9zaXRpb25lZC1sYXN0Y2hpbGQuaHRtbDogQWRkZWQu CisKIDIwMTEtMDktMTkgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW0Nocm9taXVtXSBDcmFzaCBhZnRlciBtYWdpYyBpZnJhbWUgdHJhbnNmZXIgZm9yIFBl cHBlci9OYUNsIHBsdWdpbnMuCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9i bG9jay13aXRoLXBvc2l0aW9uZWQtbGFzdGNoaWxkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9ibG9jay13aXRoLXBvc2l0aW9uZWQtbGFz dGNoaWxkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL2Jsb2NrLXdpdGgtcG9zaXRpb25lZC1sYXN0Y2hpbGQtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAKK0NsaWNrIG9uIHRoZSBsZWZ0IG9mIHRoaXMgbGlu ZS4KK0NhcmV0IHNob3VsZCBOT1QgYmUgcGxhY2VkIGluIHRoaXMgbGluZSwKK1BBU1MKKwpJbmRl eDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vYmxvY2std2l0aC1wb3NpdGlvbmVkLWxh c3RjaGlsZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9u L2Jsb2NrLXdpdGgtcG9zaXRpb25lZC1sYXN0Y2hpbGQuaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2Jsb2NrLXdpdGgtcG9zaXRpb25lZC1sYXN0Y2hp bGQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMCBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxib2R5PgorPGRpdiBzdHlsZT0icGFkZGluZzogMjBweDsiIGNvbnRlbnRlZGl0YWJs ZT5DbGljayBvbiB0aGUgbGVmdCBvZiB0aGlzIGxpbmUuCis8ZGl2PkNhcmV0IHNob3VsZCBOT1Qg YmUgcGxhY2VkIGluIHRoaXMgbGluZSw8L2Rpdj4KKzxkaXYgc3R5bGU9InBvc2l0aW9uOmFic29s dXRlOyB0b3A6MHB4OyByaWdodDowcHg7Ij48L2Rpdj4KKzwvZGl2PgorPHByZT48c2NyaXB0Pgor CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LmJvZHku Y2hpbGRyZW5bMF07CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oY29udGFpbmVyLm9mZnNl dExlZnQgKyA1LCBjb250YWluZXIub2Zmc2V0VG9wICsgNSk7CisgICAgZXZlbnRTZW5kZXIubW91 c2VEb3duKCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworCisgICAgaWYgKCFnZXRTZWxl Y3Rpb24oKS5pc0NvbGxhcHNlZCkKKyAgICAgICAgZG9jdW1lbnQud3JpdGVsbignRkFJTCAtIHNl bGVjdGlvbiB3YXMgbm90IGNvbGxhcHNlZCcpOworICAgIGVsc2UgaWYgKGdldFNlbGVjdGlvbigp LmJhc2VOb2RlICE9IGNvbnRhaW5lci5maXJzdENoaWxkKQorICAgICAgICBkb2N1bWVudC53cml0 ZWxuKCdGQUlMIC0gY2FyZXQgd2FzIG5vdCBpbiB0aGUgZmlyc3QgbGluZScpOworICAgIGVsc2Ug aWYgKGdldFNlbGVjdGlvbigpLmJhc2VPZmZzZXQpCisgICAgICAgIGRvY3VtZW50LndyaXRlbG4o J0ZBSUwgLSBjYXJldCB3YXMgbm90IG9uIHRoZSBsZWZ0IGVkZ2UnKTsKKyAgICBlbHNlCisgICAg ICAgIGRvY3VtZW50LndyaXRlbG4oJ1BBU1MnKTsKK30KKworPC9zY3JpcHQ+PC9wcmU+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==