39492 2010-05-21 08:38:06 -0700 QtWebkit fails to load http://upg.de, because MIME type is TEXT/HTML 2010-06-14 10:48:20 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED http://upg.de Qt P2 Normal --- 0 adjam7 webkit-unassigned adjam7 charles.wei commit-queue darin staikos oldest_to_newest 228929 0 adjam7 2010-05-21 08:38:06 -0700 I tried loading this page with rekonq & arora. They basically have the same behavior trying to download the page instead of showing it. Further investigation shows that the site comes with an upper case mimetype ( "TEXT/HTML; CHARSET=ISO-8859-1" ) that is unknown to QtWebkit :) 230077 1 56969 charles.wei 2010-05-24 21:28:09 -0700 Created attachment 56969 Make the MIME type to lower before check for policy with the Qt porting, make the MIME type lower before checking the policy for it , this fixes the problem. Another way to fix it is to add the MIME type in upper case to the MIME type repository , but that's much more work than this. 235079 2 charles.wei 2010-06-07 18:09:11 -0700 As a patch submitter, I am expecting an explanation from the reviewer to deny the patch. I am frustrated the reviewer denied it without a reason. 235088 3 charles.wei 2010-06-07 19:00:59 -0700 I am raising the review flag to get the attention of the reviewer, and please comment and suggest if denied. 235108 4 56969 staikos 2010-06-07 19:51:15 -0700 Comment on attachment 56969 Make the MIME type to lower before check for policy You should make a copy of the string, if this happens to be correct. const_cast is not correct. 235146 5 58113 charles.wei 2010-06-07 23:21:15 -0700 Created attachment 58113 patch_v2 Addressing the comments by the reviewer, to make a local copy of the MIME type string instead of const_cast the copy of the input MIMEType parameter. 237458 6 58113 eric 2010-06-12 20:52:47 -0700 Comment on attachment 58113 patch_v2 MIMEType as an argument name violates the style guidelines. We shoudl fix that to mimeType while here. Otherwise looks fine. I'm slightly surprised this isn't already tested, but I'm glad you added a test. The tests appear to be copied twice. r- for that at least. 237529 7 58585 charles.wei 2010-06-13 02:28:38 -0700 Created attachment 58585 removing the redundent test code removing the duplicated test code. 237682 8 58585 staikos 2010-06-13 20:44:50 -0700 Comment on attachment 58585 removing the redundent test code Looks corrected to me. The argument name can be corrected as a separate style-fixing patch. This one doesn't add invalid style. 237726 9 58585 commit-queue 2010-06-13 23:32:12 -0700 Comment on attachment 58585 removing the redundent test code Clearing flags on attachment: 58585 Committed r61110: <http://trac.webkit.org/changeset/61110> 237727 10 commit-queue 2010-06-13 23:32:18 -0700 All reviewed patches have been landed. Closing bug. 237728 11 darin 2010-06-13 23:35:04 -0700 Does not seem right to call makeLower here. The functions should be checking without being case sensitive. The test is great, but the fix seems wrong. 237792 12 staikos 2010-06-14 06:16:01 -0700 I agree the fix is suboptimal, but I think it's still correct. Let's fix the bug, optimize after. 237904 13 darin 2010-06-14 10:48:20 -0700 My putting makeLower here we fix one case, but leave broken any other code paths using these functions. 56969 2010-05-24 21:28:09 -0700 2010-06-07 23:21:15 -0700 Make the MIME type to lower before check for policy 39492.patch text/plain 3424 charles.wei SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjAxMjMpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMjQgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53 ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCB0aGUgUXRXZWJLaXQgd2hpY2ggZG9lc24ndCByZWNvZ25pemUg dGhlIE1JTUUgdHlwZSBvZiBURVhUL0hUTUwgaW4gdXBwZXIgY2FzZQorICAgICAgICBodHRwOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYmlnLmNnaT9pZD0zOTQ5MgorCisgICAgICAgICogV2ViQ29y ZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZUxvYWRlckNsaWVudFF0OjpjYW5TaG93TUlNRVR5cGUpOgorCiAyMDEwLTA1LTI0ICBSb2JlcnQg SG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8g R29tYm9zLgpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50 UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudFF0LmNwcAkocmV2aXNpb24gNjAxMTMpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0Miw2ICs1NDIs NyBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmZpbmlzaGVkTG9hZGluCiAKIGJvb2wgRnJh bWVMb2FkZXJDbGllbnRRdDo6Y2FuU2hvd01JTUVUeXBlKGNvbnN0IFN0cmluZyYgTUlNRVR5cGUp IGNvbnN0CiB7CisgICAgY29uc3RfY2FzdDxTdHJpbmcmPihNSU1FVHlwZSkubWFrZUxvd2VyKCk7 CiAgICAgaWYgKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlwZShNSU1F VHlwZSkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MDEyMykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEwLTA1LTI0ICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5j bj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 IGNhc2UgdG8gdmVyaWZ5IHRoYXQgTUlNRSB0eXBlIGluIHVwcGVyIGNhc2UgKFRFWFQvSFRNTCkg aXMgc3VwcG9ydGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zOTQ5MgorCisgICAgICAgICogaHR0cC90ZXN0cy9taW1lL3Jlc291cmNlcy91cHBlcmNh c2UtbWltZS10eXBlLnBocDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9taW1lL3VwcGVy Y2FzZS1taW1lLXR5cGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3Rz L21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS5odG1sOiBBZGRlZC4KKwogMjAxMC0wNS0yNCAgUm9i ZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFz emxvIEdvbWJvcy4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWltZS91cHBlcmNhc2Ut bWltZS10eXBlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK0lmIHRoaXMgdGV4dCBpcyBzaG93biwg dGhhdCBtZWFucyB0aGUgbmV3IGRvY3VtZW50IHdhcyBzdWNjZXNzZnVsbHkgbG9hZGVkLgpJbmRl eDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3VwcGVyY2FzZS1taW1lLXR5cGUuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUt dHlwZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3Vw cGVyY2FzZS1taW1lLXR5cGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNSBAQAorPGh0 bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxh eW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3RzKCkgeworICAgd2luZG93 LmxvY2F0aW9uLmFzc2lnbigncmVzb3VyY2VzL3VwcGVyY2FzZS1taW1lLXR5cGUucGhwJyk7Cit9 Cis8L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdHMoKTsiPgorRkFJTAorPC9ib2R5Pgor PC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3Jlc291cmNlcy91cHBl cmNhc2UtbWltZS10eXBlLnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L21pbWUvcmVzb3VyY2VzL3VwcGVyY2FzZS1taW1lLXR5cGUucGhwCShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3Jlc291cmNlcy91cHBlcmNhc2UtbWltZS10eXBl LnBocAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPD9waHAKK2hlYWRlcigiQ29udGVu dC1UeXBlOiBURVhUL0hUTUwiKTsKKz8+Cis8aHRtbD4KKzxzY3JpcHQ+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp OworCis8L3NjcmlwdD4KKzxib2R5PgorSWYgdGhpcyB0ZXh0IGlzIHNob3duLCB0aGF0IG1lYW5z IHRoZSBuZXcgZG9jdW1lbnQgd2FzIHN1Y2Nlc3NmdWxseSBsb2FkZWQuCis8L2JvZHk+Cis8L2h0 bWw+Cg== 58113 2010-06-07 23:21:15 -0700 2010-06-13 02:28:38 -0700 patch_v2 39492.patch text/plain 4504 charles.wei SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjA4MjEpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMDcgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53 ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCB0aGUgUXRXZWJLaXQgd2hpY2ggZG9lc24ndCByZWNvZ25pemUg dGhlIE1JTUUgdHlwZSBvZiBURVhUL0hUTUwgaW4gdXBwZXJjYXNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTQ5MgorCisgICAgICAgICogV2ViQ29y ZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZUxvYWRlckNsaWVudFF0OjpjYW5TaG93TUlNRVR5cGUpOgorCiAyMDEwLTA2LTA3ICBBbmRlcnMg QmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlk IExldmluLgpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50 UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudFF0LmNwcAkocmV2aXNpb24gNjA4MjApCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0MiwxNCArNTQy LDE2IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRRdDo6ZmluaXNoZWRMb2FkaW4KIAogYm9vbCBG cmFtZUxvYWRlckNsaWVudFF0OjpjYW5TaG93TUlNRVR5cGUoY29uc3QgU3RyaW5nJiBNSU1FVHlw ZSkgY29uc3QKIHsKLSAgICBpZiAoTUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRJbWFnZU1J TUVUeXBlKE1JTUVUeXBlKSkKKyAgICBTdHJpbmcgdHlwZSA9IE1JTUVUeXBlOworICAgIHR5cGUu bWFrZUxvd2VyKCk7CisgICAgaWYgKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VN SU1FVHlwZSh0eXBlKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBpZiAoTUlNRVR5cGVS ZWdpc3RyeTo6aXNTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlKE1JTUVUeXBlKSkKKyAgICBpZiAo TUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlKHR5cGUpKQogICAg ICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIGlmIChtX2ZyYW1lICYmIG1fZnJhbWUtPnNldHRpbmdz KCkgICYmIG1fZnJhbWUtPnNldHRpbmdzKCktPmFyZVBsdWdpbnNFbmFibGVkKCkKLSAgICAgICAg JiYgUGx1Z2luRGF0YWJhc2U6Omluc3RhbGxlZFBsdWdpbnMoKS0+aXNNSU1FVHlwZVJlZ2lzdGVy ZWQoTUlNRVR5cGUpKQorICAgICAgICAmJiBQbHVnaW5EYXRhYmFzZTo6aW5zdGFsbGVkUGx1Z2lu cygpLT5pc01JTUVUeXBlUmVnaXN0ZXJlZCh0eXBlKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAK ICAgICByZXR1cm4gZmFsc2U7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MDgyMSkKKysrIExheW91dFRl c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA2LTA3 ICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IGFzZSB0byB2ZXJp ZnkgdGhhdCBNSU1FIHR5cGUgaW4gdXBwc2VyY2FzZSAoVEVYVC9IVE1MKSBpcyBzdXBwb3J0ZWQu CisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21pbWUvcmVzb3VyY2VzL3VwcGVyY2FzZS1taW1lLXR5 cGUucGhwOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUt dHlwZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbWltZS91cHBl cmNhc2UtbWltZS10eXBlLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA2LTA3ICBNYXJ0aW4gUm9iaW5z b24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIg SHVudC4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWltZS91cHBlcmNhc2UtbWltZS10 eXBlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21p bWUvdXBwZXJjYXNlLW1pbWUtdHlwZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMiBAQAorSWYgdGhpcyB0ZXh0IGlzIHNob3duLCB0aGF0 IG1lYW5zIHRoZSBuZXcgZG9jdW1lbnQgd2FzIHN1Y2Nlc3NmdWxseSBsb2FkZWQuCitJZiB0aGlz IHRleHQgaXMgc2hvd24sIHRoYXQgbWVhbnMgdGhlIG5ldyBkb2N1bWVudCB3YXMgc3VjY2Vzc2Z1 bGx5IGxvYWRlZC4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWltZS91cHBlcmNhc2Ut bWltZS10eXBlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1l L3VwcGVyY2FzZS1taW1lLXR5cGUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbWltZS91cHBlcmNhc2UtbWltZS10eXBlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMzAgQEAKKzxodG1sPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorCitmdW5jdGlvbiBydW5UZXN0 cygpIHsKKyAgIHdpbmRvdy5sb2NhdGlvbi5hc3NpZ24oJ3Jlc291cmNlcy91cHBlcmNhc2UtbWlt ZS10eXBlLnBocCcpOworfQorPC9zY3JpcHQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3RzKCk7Ij4K K0ZBSUwKKzwvYm9keT4KKzwvaHRtbD4KKzxodG1sPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxE b25lKCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorCitmdW5j dGlvbiBydW5UZXN0cygpIHsKKyAgIHdpbmRvdy5sb2NhdGlvbi5hc3NpZ24oJ3Jlc291cmNlcy91 cHBlcmNhc2UtbWltZS10eXBlLnBocCcpOworfQorPC9zY3JpcHQ+Cis8Ym9keSBvbmxvYWQ9InJ1 blRlc3RzKCk7Ij4KK0ZBSUwKKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbWltZS9yZXNvdXJjZXMvdXBwZXJjYXNlLW1pbWUtdHlwZS5waHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3Jlc291cmNlcy91cHBlcmNhc2UtbWlt ZS10eXBlLnBocAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWltZS9y ZXNvdXJjZXMvdXBwZXJjYXNlLW1pbWUtdHlwZS5waHAJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MjYgQEAKKzw/cGhwCitoZWFkZXIoIkNvbnRlbnQtVHlwZTogVEVYVC9IVE1MIik7Cis/PgorPGh0 bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgIGxheW91 dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKworPC9zY3JpcHQ+Cis8Ym9keT4KK0lmIHRo aXMgdGV4dCBpcyBzaG93biwgdGhhdCBtZWFucyB0aGUgbmV3IGRvY3VtZW50IHdhcyBzdWNjZXNz ZnVsbHkgbG9hZGVkLgorPC9ib2R5PgorPC9odG1sPgorPD9waHAKK2hlYWRlcigiQ29udGVudC1U eXBlOiBURVhUL0hUTUwiKTsKKz8+Cis8aHRtbD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwor Cis8L3NjcmlwdD4KKzxib2R5PgorSWYgdGhpcyB0ZXh0IGlzIHNob3duLCB0aGF0IG1lYW5zIHRo ZSBuZXcgZG9jdW1lbnQgd2FzIHN1Y2Nlc3NmdWxseSBsb2FkZWQuCis8L2JvZHk+Cis8L2h0bWw+ Cg== 58585 2010-06-13 02:28:38 -0700 2010-06-13 23:32:11 -0700 removing the redundent test code 39492.patch text/plain 3977 charles.wei SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjEwODcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMTMgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53 ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCB0aGUgUXRXZWJLaXQgd2hpY2ggZG9lc24ndCByZWNvZ25pemUg dGhlIE1JTUUgdHlwZSBvZiBIVE1ML1RFWFQgaW4gdXBwZXJjYXNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTQ5MgorCisgICAgICAgICogV2ViQ29y ZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZUxvYWRlckNsaWVudFF0OjpjYW5TaG93TUlNRVR5cGUpOgorCiAyMDEwLTA2LTEyICBEYXdpdCBB bGVtYXllaHUgIDxhZGF3aXRAa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRo IFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFt ZUxvYWRlckNsaWVudFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAJKHJldmlzaW9uIDYxMDg0KQorKysgV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC01NDIsMTQgKzU0MiwxNiBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmZpbmlzaGVkTG9h ZGluCiAKIGJvb2wgRnJhbWVMb2FkZXJDbGllbnRRdDo6Y2FuU2hvd01JTUVUeXBlKGNvbnN0IFN0 cmluZyYgTUlNRVR5cGUpIGNvbnN0CiB7Ci0gICAgaWYgKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3Vw cG9ydGVkSW1hZ2VNSU1FVHlwZShNSU1FVHlwZSkpCisgICAgU3RyaW5nIHR5cGUgPSBNSU1FVHlw ZTsKKyAgICB0eXBlLm1ha2VMb3dlcigpOworICAgIGlmIChNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1 cHBvcnRlZEltYWdlTUlNRVR5cGUodHlwZSkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAg aWYgKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkTm9uSW1hZ2VNSU1FVHlwZShNSU1FVHlw ZSkpCisgICAgaWYgKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkTm9uSW1hZ2VNSU1FVHlw ZSh0eXBlKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBpZiAobV9mcmFtZSAmJiBtX2Zy YW1lLT5zZXR0aW5ncygpICAmJiBtX2ZyYW1lLT5zZXR0aW5ncygpLT5hcmVQbHVnaW5zRW5hYmxl ZCgpCi0gICAgICAgICYmIFBsdWdpbkRhdGFiYXNlOjppbnN0YWxsZWRQbHVnaW5zKCktPmlzTUlN RVR5cGVSZWdpc3RlcmVkKE1JTUVUeXBlKSkKKyAgICAgICAgJiYgUGx1Z2luRGF0YWJhc2U6Omlu c3RhbGxlZFBsdWdpbnMoKS0+aXNNSU1FVHlwZVJlZ2lzdGVyZWQodHlwZSkpCiAgICAgICAgIHJl dHVybiB0cnVlOwogCiAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjEwODcp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBA QAorMjAxMC0wNi0xMyAgQ2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1vYmlsZS5jb20u Y24+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz dCBjYXNlIHRvIHZlcmlmeSB0aGF0IE1JTUUgdHlwZSBpbiB1cHBlcmNhc2UgKFRFWFQvSFRNTCkg aXMgc3VwcG9ydGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzk0OTIKKworICAgICAgICAqIGh0dHAvdGVzdHMvbWltZS9yZXNvdXJjZXMvdXBwZXJj YXNlLW1pbWUtdHlwZS5waHA6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbWltZS91cHBl cmNhc2UtbWltZS10eXBlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0 cy9taW1lL3VwcGVyY2FzZS1taW1lLXR5cGUuaHRtbDogQWRkZWQuCisKIDIwMTAtMDYtMTIgIERt aXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2Vk LCB1cGRhdGUgQ2hyb21pdW0gZXhwZWN0ZWQgcmVzdWx0IGZvbGxvd2luZyByNjEwNzEuCkluZGV4 OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3VwcGVyY2Fz ZS1taW1lLXR5cGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9taW1lL3VwcGVyY2FzZS1taW1lLXR5cGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQpAQCAtMCwwICsxIEBACitJZiB0aGlzIHRleHQgaXMgc2hvd24sIHRoYXQgbWVhbnMgdGhlIG5l dyBkb2N1bWVudCB3YXMgc3VjY2Vzc2Z1bGx5IGxvYWRlZC4KSW5kZXg6IExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbWltZS91cHBlcmNhc2UtbWltZS10eXBlLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3VwcGVyY2FzZS1taW1lLXR5cGUuaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWltZS91cHBlcmNhc2UtbWltZS10eXBl Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTUgQEAKKzxodG1sPgorPHNjcmlwdD4KK2lm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci53YWl0VW50aWxEb25lKCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OworfQorCitmdW5jdGlvbiBydW5UZXN0cygpIHsKKyAgIHdpbmRvdy5sb2NhdGlvbi5hc3NpZ24o J3Jlc291cmNlcy91cHBlcmNhc2UtbWltZS10eXBlLnBocCcpOworfQorPC9zY3JpcHQ+Cis8Ym9k eSBvbmxvYWQ9InJ1blRlc3RzKCk7Ij4KK0ZBSUwKKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExh eW91dFRlc3RzL2h0dHAvdGVzdHMvbWltZS9yZXNvdXJjZXMvdXBwZXJjYXNlLW1pbWUtdHlwZS5w aHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3Jlc291cmNlcy91 cHBlcmNhc2UtbWltZS10eXBlLnBocAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAv dGVzdHMvbWltZS9yZXNvdXJjZXMvdXBwZXJjYXNlLW1pbWUtdHlwZS5waHAJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTMgQEAKKzw/cGhwCitoZWFkZXIoIkNvbnRlbnQtVHlwZTogVEVYVC9IVE1M Iik7Cis/PgorPGh0bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKKyAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKworPC9zY3JpcHQ+Cis8 Ym9keT4KK0lmIHRoaXMgdGV4dCBpcyBzaG93biwgdGhhdCBtZWFucyB0aGUgbmV3IGRvY3VtZW50 IHdhcyBzdWNjZXNzZnVsbHkgbG9hZGVkLgorPC9ib2R5PgorPC9odG1sPgo=