39472 2010-05-20 23:27:02 -0700 [GStreamer] multiple video sink support 2010-06-25 00:07:08 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 39474 39740 39202 1 pnormand webkit-unassigned gustavo slomo oldest_to_newest 228765 0 pnormand 2010-05-20 23:27:02 -0700 For video fullscreen support it would be nice if the player could do the rendering using autovideosink. This requires the current playbin2 video-sink to be a bin internally rendering to the webkit videosink and, when needed for fullscreen, autovideosink. For this to work on application-side, gst XOverlay support is also needed in GStreamerGWorld, otherwise autovideosink (on gtk port) will internally create and show an X11 window. 231753 1 57337 pnormand 2010-05-28 10:01:22 -0700 Created attachment 57337 proposed patch 232822 2 pnormand 2010-06-01 10:37:24 -0700 Sebastian, can you have a look at the patch when you get some time please? :) 233656 3 slomo 2010-06-03 01:11:35 -0700 Looks good, yes 241172 4 pnormand 2010-06-22 00:57:30 -0700 Gustavo, would you have time to take a look? Bug 39474 too if possible. Sebastian did one pass on the patches already, some time ago :) 242488 5 57337 gustavo 2010-06-24 06:49:19 -0700 Comment on attachment 57337 proposed patch It looks very good to me. The only improvement I suggest is not creating member variables for the queue and the tee. They are completely useless - you are not even using them when enabling fullscreen, so just make them variables scoped to the createGSTPlayBin function, please, unless you have a good reason to keep them. I would prefer having more descriptive names for the queue and tee elements, too "t" does the job, but we can do better, I guess? =) 242867 6 pnormand 2010-06-25 00:07:08 -0700 Landed as http://trac.webkit.org/changeset/61834 with the suggested fixes. Thanks for the review :) 57337 2010-05-28 10:01:22 -0700 2010-06-24 06:49:19 -0700 proposed patch proposed-patch.patch text/plain 7285 pnormand RnJvbSAwMjIzNzM1YTY5YzJjNTkxYTA0YTg4M2MzZTQxNGYyNjA5OTE3ODcwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDI4IE1heSAyMDEwIDE2OjU3OjQ3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE5ICsrKysrKwogLi4uL2dzdHJlYW1lci9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgIDY3ICsrKysrKysrKysrKystLS0tLS0KIC4uLi9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggICAgICAgIHwgICAgNSArLQog MyBmaWxlcyBjaGFuZ2VkLCA2OSBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDAxMGQ4 MTguLjA0ZjY2Y2YgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDUtMjggIFBoaWxpcHBlIE5vcm1hbmQg IDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtHU3RyZWFtZXJdIG11bHRpcGxlIHZpZGVvIHNpbmsgc3VwcG9ydAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk0NzIKKwor ICAgICAgICBQbGF5YmluMiB2aWRlby1zaW5rIGlzIG5vdyBhIGJpbiBjb250YWluaW5nIGEgdGVl IGVsZW1lbnQgY2FwYWJsZQorICAgICAgICBvZiBkaXNwYXRjaGluZyB0aGUgYnVmZmVycyB0byBt dWx0aXBsZSB2aWRlbyBzaW5rcy4gQnkgZGVmYXVsdAorICAgICAgICBvbmx5IG91ciB3ZWJraXQg dmlkZW8gc2luayBpcyB1c2VkLiBUaGlzIHdpbGwgYWxsb3cKKyAgICAgICAgR1N0cmVhbWVyR1dv cmxkIHRvIGFkZCBzdXBwb3J0IGZvciBhdXRvdmlkZW9zaW5rIGluIHRoZSBmdXR1cmUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l cjo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6fk1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcik6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Om5hdHVyYWxTaXpl KToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRl R1NUUGxheUJpbik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oOgorCiAyMDEwLTA1LTI3ICBDaHJpcyBGbGVpemFjaCAg PGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgTm8gcmV2aWV3LCBidWlsZCBmaXhhZ2Uu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBkNjE5ZTE0Li4wMzY0 N2UyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTI3Niw3ICsy NzYsNyBAQCBib29sIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aXNBdmFpbGFibGUoKQog TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIo TWVkaWFQbGF5ZXIqIHBsYXllcikKICAgICA6IG1fcGxheWVyKHBsYXllcikKICAgICAsIG1fcGxh eUJpbigwKQotICAgICwgbV92aWRlb1NpbmsoMCkKKyAgICAsIG1fd2Via2l0VmlkZW9TaW5rKDAp CiAgICAgLCBtX2Zwc1NpbmsoMCkKICAgICAsIG1fc291cmNlKDApCiAgICAgLCBtX3NlZWtUaW1l KDApCkBAIC0zMjcsMjAgKzMyNywxNiBAQCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6On5N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIoKQogICAgICAgICBtX3NvdXJjZSA9IDA7CiAgICAg fQogCisgICAgaWYgKG1fdmlkZW9TaW5rQmluKSB7CisgICAgICAgIGdzdF9vYmplY3RfdW5yZWYo bV92aWRlb1NpbmtCaW4pOworICAgICAgICBtX3ZpZGVvU2lua0JpbiA9IDA7CisgICAgfQorCiAg ICAgaWYgKG1fcGxheUJpbikgewogICAgICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUobV9wbGF5 QmluLCBHU1RfU1RBVEVfTlVMTCk7CiAgICAgICAgIGdzdF9vYmplY3RfdW5yZWYoR1NUX09CSkVD VChtX3BsYXlCaW4pKTsKICAgICB9CiAKLSAgICBpZiAobV92aWRlb1NpbmspIHsKLSAgICAgICAg Z19vYmplY3RfdW5yZWYobV92aWRlb1NpbmspOwotICAgICAgICBtX3ZpZGVvU2luayA9IDA7Ci0g ICAgfQotCi0gICAgaWYgKG1fZnBzU2luaykgewotICAgICAgICBnX29iamVjdF91bnJlZihtX2Zw c1NpbmspOwotICAgICAgICBtX2Zwc1NpbmsgPSAwOwotICAgIH0KIH0KIAogdm9pZCBNZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXI6OmxvYWQoY29uc3QgU3RyaW5nJiB1cmwpCkBAIC01MTUsNyAr NTExLDcgQEAgSW50U2l6ZSBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Om5hdHVyYWxTaXpl KCkgY29uc3QKICAgICBpZiAoIWhhc1ZpZGVvKCkpCiAgICAgICAgIHJldHVybiBJbnRTaXplKCk7 CiAKLSAgICBHc3RQYWQqIHBhZCA9IGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKG1fdmlkZW9T aW5rLCAic2luayIpOworICAgIEdzdFBhZCogcGFkID0gZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19w YWQobV93ZWJraXRWaWRlb1NpbmssICJzaW5rIik7CiAgICAgaWYgKCFwYWQpCiAgICAgICAgIHJl dHVybiBJbnRTaXplKCk7CiAKQEAgLTEzNDksNyArMTM0NSw2IEBAIGJvb2wgTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpzdXBwb3J0c0Z1bGxzY3JlZW4oKSBjb25zdAogICAgIHJldHVybiB0 cnVlOwogfQogCi0KIFBsYXRmb3JtTWVkaWEgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpw bGF0Zm9ybU1lZGlhKCkgY29uc3QKIHsKICAgICBQbGF0Zm9ybU1lZGlhIHA7CkBAIC0xMzkzLDI2 ICsxMzg4LDU2IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpjcmVhdGVHU1RQ bGF5QmluKCkKICAgICBnX3NpZ25hbF9jb25uZWN0KG1fcGxheUJpbiwgIm5vdGlmeTo6c291cmNl IiwgR19DQUxMQkFDSyhtZWRpYVBsYXllclByaXZhdGVTb3VyY2VDaGFuZ2VkQ2FsbGJhY2spLCB0 aGlzKTsKICAgICBnX3NpZ25hbF9jb25uZWN0KG1fcGxheUJpbiwgIm5vdGlmeTo6bXV0ZSIsIEdf Q0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlTXV0ZUNoYW5nZWRDYWxsYmFjayksIHRoaXMpOwog Ci0gICAgbV92aWRlb1NpbmsgPSB3ZWJraXRfdmlkZW9fc2lua19uZXcoKTsKKyAgICBtX3dlYmtp dFZpZGVvU2luayA9IHdlYmtpdF92aWRlb19zaW5rX25ldygpOworCisgICAgZ19zaWduYWxfY29u bmVjdChtX3dlYmtpdFZpZGVvU2luaywgInJlcGFpbnQtcmVxdWVzdGVkIiwgR19DQUxMQkFDSyht ZWRpYVBsYXllclByaXZhdGVSZXBhaW50Q2FsbGJhY2spLCB0aGlzKTsKKworICAgIG1fdmlkZW9T aW5rQmluID0gZ3N0X2Jpbl9uZXcoInNpbmsiKTsKKyAgICBtX3RlZSA9IGdzdF9lbGVtZW50X2Zh Y3RvcnlfbWFrZSgidGVlIiwgInQiKTsKKyAgICBtX3F1ZXVlMSA9IGdzdF9lbGVtZW50X2ZhY3Rv cnlfbWFrZSgicXVldWUiLCAicTEiKTsKIAotICAgIGdfb2JqZWN0X3JlZl9zaW5rKG1fdmlkZW9T aW5rKTsKKyAgICAvLyBUYWtlIG93bmVyc2hpcC4KKyAgICBnX29iamVjdF9yZWZfc2luayhtX3Zp ZGVvU2lua0Jpbik7CisKKyAgICAvLyBCdWlsZCBhIG5ldyB2aWRlbyBzaW5rIGNvbnNpc3Rpbmcg b2YgYSBiaW4gY29udGFpbmluZyBhIHRlZQorICAgIC8vIChtZWFudCB0byBkaXN0cmlidXRlIGRh dGEgdG8gbXVsdGlwbGUgdmlkZW8gc2lua3MpIGFuZCBvdXIKKyAgICAvLyBpbnRlcm5hbCB2aWRl byBzaW5rLiBGb3IgZnVsbHNjcmVlbiB3ZSBjcmVhdGUgYW4gYXV0b3ZpZGVvc2luaworICAgIC8v IGFuZCBpbml0aWFsbHkgYmxvY2sgdGhlIGRhdGEgZmxvdyB0b3dhcmRzIGl0IGFuZCBjb25maWd1 cmUgaXQKKworICAgIGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTihtX3ZpZGVvU2lua0JpbiksIG1f dGVlLCBtX3F1ZXVlMSwgTlVMTCk7CisKKyAgICAvLyBMaW5rIGEgbmV3IHNyYyBwYWQgZnJvbSB0 ZWUgdG8gcXVldWUxLgorICAgIEdzdFBhZCogc3JjUGFkID0gZ3N0X2VsZW1lbnRfZ2V0X3JlcXVl c3RfcGFkKG1fdGVlLCAic3JjJWQiKTsKKyAgICBHc3RQYWQqIHNpbmtQYWQgPSBnc3RfZWxlbWVu dF9nZXRfc3RhdGljX3BhZChtX3F1ZXVlMSwgInNpbmsiKTsKKyAgICBnc3RfcGFkX2xpbmsoc3Jj UGFkLCBzaW5rUGFkKTsKKyAgICBnc3Rfb2JqZWN0X3VucmVmKEdTVF9PQkpFQ1Qoc3JjUGFkKSk7 CisgICAgZ3N0X29iamVjdF91bnJlZihHU1RfT0JKRUNUKHNpbmtQYWQpKTsKIAogICAgIFdURkxv Z0NoYW5uZWwqIGNoYW5uZWwgPSBnZXRDaGFubmVsRnJvbU5hbWUoIk1lZGlhIik7CiAgICAgaWYg KGNoYW5uZWwtPnN0YXRlID09IFdURkxvZ0NoYW5uZWxPbikgewogICAgICAgICBtX2Zwc1Npbmsg PSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoImZwc2Rpc3BsYXlzaW5rIiwgInNpbmsiKTsKICAg ICAgICAgaWYgKGdfb2JqZWN0X2NsYXNzX2ZpbmRfcHJvcGVydHkoR19PQkpFQ1RfR0VUX0NMQVNT KG1fZnBzU2luayksICJ2aWRlby1zaW5rIikpIHsKLSAgICAgICAgICAgIGdfb2JqZWN0X3NldCht X2Zwc1NpbmssICJ2aWRlby1zaW5rIiwgbV92aWRlb1NpbmssIE5VTEwpOwotICAgICAgICAgICAg Z19vYmplY3RfcmVmX3NpbmsobV9mcHNTaW5rKTsKLSAgICAgICAgICAgIGdfb2JqZWN0X3NldCht X3BsYXlCaW4sICJ2aWRlby1zaW5rIiwgbV9mcHNTaW5rLCBOVUxMKTsKKyAgICAgICAgICAgIGdf b2JqZWN0X3NldChtX2Zwc1NpbmssICJ2aWRlby1zaW5rIiwgbV93ZWJraXRWaWRlb1NpbmssIE5V TEwpOworICAgICAgICAgICAgZ3N0X2Jpbl9hZGQoR1NUX0JJTihtX3ZpZGVvU2lua0JpbiksIG1f ZnBzU2luayk7CisgICAgICAgICAgICBnc3RfZWxlbWVudF9saW5rKG1fcXVldWUxLCBtX2Zwc1Np bmspOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgbV9mcHNTaW5rID0gMDsKLSAgICAg ICAgICAgIGdfb2JqZWN0X3NldChtX3BsYXlCaW4sICJ2aWRlby1zaW5rIiwgbV92aWRlb1Npbmss IE5VTEwpOworICAgICAgICAgICAgZ3N0X2Jpbl9hZGQoR1NUX0JJTihtX3ZpZGVvU2lua0Jpbiks IG1fd2Via2l0VmlkZW9TaW5rKTsKKyAgICAgICAgICAgIGdzdF9lbGVtZW50X2xpbmsobV9xdWV1 ZTEsIG1fd2Via2l0VmlkZW9TaW5rKTsKICAgICAgICAgICAgIExPR19WRVJCT1NFKE1lZGlhLCAi Q2FuJ3QgZGlzcGxheSBGUFMgc3RhdGlzdGljcywgeW91IG5lZWQgZ3N0LXBsdWdpbnMtYmFkID49 IDAuMTAuMTgiKTsKICAgICAgICAgfQotICAgIH0gZWxzZQotICAgICAgICBnX29iamVjdF9zZXQo bV9wbGF5QmluLCAidmlkZW8tc2luayIsIG1fdmlkZW9TaW5rLCBOVUxMKTsKKyAgICB9IGVsc2Ug eworICAgICAgICBnc3RfYmluX2FkZChHU1RfQklOKG1fdmlkZW9TaW5rQmluKSwgbV93ZWJraXRW aWRlb1NpbmspOworICAgICAgICBnc3RfZWxlbWVudF9saW5rKG1fcXVldWUxLCBtX3dlYmtpdFZp ZGVvU2luayk7CisgICAgfQorCisgICAgLy8gQWRkIGEgZ2hvc3RwYWQgdG8gdGhlIGJpbiBzbyBp dCBjYW4gcHJveHkgdG8gdGVlLgorICAgIEdzdFBhZCogcGFkID0gZ3N0X2VsZW1lbnRfZ2V0X3N0 YXRpY19wYWQobV90ZWUsICJzaW5rIik7CisgICAgZ3N0X2VsZW1lbnRfYWRkX3BhZChtX3ZpZGVv U2lua0JpbiwgZ3N0X2dob3N0X3BhZF9uZXcoInNpbmsiLCBwYWQpKTsKKyAgICBnc3Rfb2JqZWN0 X3VucmVmKEdTVF9PQkpFQ1QocGFkKSk7CiAKLSAgICBnX3NpZ25hbF9jb25uZWN0KG1fdmlkZW9T aW5rLCAicmVwYWludC1yZXF1ZXN0ZWQiLCBHX0NBTExCQUNLKG1lZGlhUGxheWVyUHJpdmF0ZVJl cGFpbnRDYWxsYmFjayksIHRoaXMpOworICAgIC8vIFNldCB0aGUgYmluIGFzIHZpZGVvIHNpbmsg b2YgcGxheWJpbi4KKyAgICBnX29iamVjdF9zZXQobV9wbGF5QmluLCAidmlkZW8tc2luayIsIG1f dmlkZW9TaW5rQmluLCBOVUxMKTsKIH0KIAogfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuaAppbmRleCA4MWY5MGI4Li44MWJkYWZhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuaApAQCAtMTQ2LDcgKzE0NiwxMCBAQCBjbGFzcyBNZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIgOiBwdWJsaWMgTWVkaWFQbGF5ZXJQcml2YXRlSW50ZXJmYWNlIHsKICAgICAgICAgcHJp dmF0ZToKICAgICAgICAgICAgIE1lZGlhUGxheWVyKiBtX3BsYXllcjsKICAgICAgICAgICAgIEdz dEVsZW1lbnQqIG1fcGxheUJpbjsKLSAgICAgICAgICAgIEdzdEVsZW1lbnQqIG1fdmlkZW9TaW5r OworICAgICAgICAgICAgR3N0RWxlbWVudCogbV93ZWJraXRWaWRlb1Npbms7CisgICAgICAgICAg ICBHc3RFbGVtZW50KiBtX3ZpZGVvU2lua0JpbjsKKyAgICAgICAgICAgIEdzdEVsZW1lbnQqIG1f dGVlOworICAgICAgICAgICAgR3N0RWxlbWVudCogbV9xdWV1ZTE7CiAgICAgICAgICAgICBHc3RF bGVtZW50KiBtX2Zwc1Npbms7CiAgICAgICAgICAgICBHc3RFbGVtZW50KiBtX3NvdXJjZTsKICAg ICAgICAgICAgIEdzdENsb2NrVGltZSBtX3NlZWtUaW1lOwotLSAKMS42LjMuMw==