39462 2010-05-20 17:52:38 -0700 Remove custom bindings for NamedNodeMap.setNamedItem and NamedNodeMap.setNamedItemNS 2010-05-22 16:26:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jschuh webkit-unassigned commit-queue jschuh oldest_to_newest 228663 0 jschuh 2010-05-20 17:52:38 -0700 Remove custom bindings for NamedNodeMap.setNamedItem and NamedNodeMap.setNamedItemNS 228664 1 56655 jschuh 2010-05-20 17:58:47 -0700 Created attachment 56655 Patch 228914 2 jschuh 2010-05-21 08:01:30 -0700 This removes custom binding code that was made redundant by: http://trac.webkit.org/changeset/59866 229346 3 56655 commit-queue 2010-05-22 16:26:51 -0700 Comment on attachment 56655 Patch Clearing flags on attachment: 56655 Committed r60022: <http://trac.webkit.org/changeset/60022> 229347 4 commit-queue 2010-05-22 16:26:55 -0700 All reviewed patches have been landed. Closing bug. 56655 2010-05-20 17:58:47 -0700 2010-05-22 16:26:50 -0700 Patch bug-39462-20100520175846.patch text/plain 5503 jschuh SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTg3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDUtMjAgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIGN1c3RvbSBiaW5kaW5ncyBmb3IgTmFtZWROb2RlTWFwLnNldE5hbWVkSXRlbSBhbmQg LnNldE5hbWVkSXRlbU5TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTQ2MgorCisgICAgICAgIEN1c3RvbSBiaW5kaW5ncyBhcmUgbm8gbG9uZ2VyIG5l ZWRlZCBiZWNhdXNlIG9yaWdpbiBjaGVja3Mgd2VyZSBtb3ZlZAorICAgICAgICBvdXQgb2YgdGhl IGJpbmRpbmdzIGJ5OiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81OTg2NgorCisg ICAgICAgIEJlaGF2aW9yIGlzbid0IGNoYW5nZWQgYW5kIGlzIGNvdmVyZWQgYnkgZXhpc3Rpbmcg dGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU05hbWVkTm9kZU1hcEN1c3RvbS5jcHA6 CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4TmFtZWROb2RlTWFwQ3VzdG9tLmNwcDoK KyAgICAgICAgKiBkb20vTmFtZWROb2RlTWFwLmlkbDoKKwogMjAxMC0wNS0yMCAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQu CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmFtZWROb2RlTWFwQ3VzdG9tLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmFtZWROb2RlTWFwQ3VzdG9tLmNwcAko cmV2aXNpb24gNTk4NzYpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmFtZWROb2RlTWFwQ3Vz dG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUsMzggKzM1LDYgQEAgdXNpbmcgbmFtZXNwYWNl IEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1KU1ZhbHVlIEpTTmFtZWROb2RlTWFwOjpz ZXROYW1lZEl0ZW0oRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQotewotICAg IE5hbWVkTm9kZU1hcCogaW1wID0gc3RhdGljX2Nhc3Q8TmFtZWROb2RlTWFwKj4oaW1wbCgpKTsK LSAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKLSAgICBOb2RlKiBuZXdOb2RlID0gdG9Ob2RlKGFy Z3MuYXQoMCkpOwotCi0gICAgaWYgKG5ld05vZGUgJiYgbmV3Tm9kZS0+bm9kZVR5cGUoKSA9PSBO b2RlOjpBVFRSSUJVVEVfTk9ERSAmJiBpbXAtPmVsZW1lbnQoKSkgewotICAgICAgICBpZiAoIWFs bG93U2V0dGluZ1NyY1RvSmF2YXNjcmlwdFVSTChleGVjLCBpbXAtPmVsZW1lbnQoKSwgbmV3Tm9k ZS0+bm9kZU5hbWUoKSwgbmV3Tm9kZS0+bm9kZVZhbHVlKCkpKQotICAgICAgICAgICAgcmV0dXJu IGpzTnVsbCgpOwotICAgIH0KLQotICAgIEpTVmFsdWUgcmVzdWx0ID0gdG9KUyhleGVjLCBnbG9i YWxPYmplY3QoKSwgV1RGOjpnZXRQdHIoaW1wLT5zZXROYW1lZEl0ZW0obmV3Tm9kZSwgZWMpKSk7 Ci0gICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIGVjKTsKLSAgICByZXR1cm4gcmVzdWx0OwotfQot Ci1KU1ZhbHVlIEpTTmFtZWROb2RlTWFwOjpzZXROYW1lZEl0ZW1OUyhFeGVjU3RhdGUqIGV4ZWMs IGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCi17Ci0gICAgTmFtZWROb2RlTWFwKiBpbXAgPSBzdGF0aWNf Y2FzdDxOYW1lZE5vZGVNYXAqPihpbXBsKCkpOwotICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwot ICAgIE5vZGUqIG5ld05vZGUgPSB0b05vZGUoYXJncy5hdCgwKSk7Ci0KLSAgICBpZiAobmV3Tm9k ZSAmJiBuZXdOb2RlLT5ub2RlVHlwZSgpID09IE5vZGU6OkFUVFJJQlVURV9OT0RFICYmIGltcC0+ ZWxlbWVudCgpKSB7Ci0gICAgICAgIGlmICghYWxsb3dTZXR0aW5nU3JjVG9KYXZhc2NyaXB0VVJM KGV4ZWMsIGltcC0+ZWxlbWVudCgpLCBuZXdOb2RlLT5ub2RlTmFtZSgpLCBuZXdOb2RlLT5ub2Rl VmFsdWUoKSkpCi0gICAgICAgICAgICByZXR1cm4ganNOdWxsKCk7Ci0gICAgfQotCi0gICAgSlNW YWx1ZSByZXN1bHQgPSB0b0pTKGV4ZWMsIGdsb2JhbE9iamVjdCgpLCBXVEY6OmdldFB0cihpbXAt PnNldE5hbWVkSXRlbU5TKG5ld05vZGUsIGVjKSkpOwotICAgIHNldERPTUV4Y2VwdGlvbihleGVj LCBlYyk7Ci0gICAgcmV0dXJuIHJlc3VsdDsKLX0KLQogYm9vbCBKU05hbWVkTm9kZU1hcDo6Y2Fu R2V0SXRlbXNGb3JOYW1lKEV4ZWNTdGF0ZSosIE5hbWVkTm9kZU1hcCogaW1wbCwgY29uc3QgSWRl bnRpZmllciYgcHJvcGVydHlOYW1lKQogewogICAgIHJldHVybiBpbXBsLT5nZXROYW1lZEl0ZW0o aWRlbnRpZmllclRvU3RyaW5nKHByb3BlcnR5TmFtZSkpOwpJbmRleDogV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhOYW1lZE5vZGVNYXBDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TmFtZWROb2RlTWFwQ3VzdG9tLmNwcAkocmV2aXNpb24g NTk4NzYpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE5hbWVkTm9kZU1hcEN1c3Rv bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc1LDQ4ICs3NSw2IEBAIHY4OjpIYW5kbGU8djg6OlZh bHVlPiBWOE5hbWVkTm9kZU1hcDo6bmEKICAgICByZXR1cm4gdG9WOChyZXN1bHQucmVsZWFzZSgp KTsKIH0KIAotdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4TmFtZWROb2RlTWFwOjpzZXROYW1lZEl0 ZW1OU0NhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCi17Ci0gICAgSU5DX1NUQVRT KCJET00uTmFtZWROb2RlTWFwLnNldE5hbWVkSXRlbU5TIik7Ci0gICAgTmFtZWROb2RlTWFwKiBp bXAgPSBWOE5hbWVkTm9kZU1hcDo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7Ci0gICAgTm9kZSog bmV3Tm9kZSA9IFY4Tm9kZTo6SGFzSW5zdGFuY2UoYXJnc1swXSkgPyBWOE5vZGU6OnRvTmF0aXZl KHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QoYXJnc1swXSkpIDogMDsKLQotICAgIGlmIChu ZXdOb2RlICYmIG5ld05vZGUtPm5vZGVUeXBlKCkgPT0gTm9kZTo6QVRUUklCVVRFX05PREUgJiYg aW1wLT5lbGVtZW50KCkpIHsKLSAgICAgICAgaWYgKCFWOEJpbmRpbmdTZWN1cml0eTo6YWxsb3dT ZXR0aW5nU3JjVG9KYXZhc2NyaXB0VVJMKFY4QmluZGluZ1N0YXRlOjpPbmx5KCksIGltcC0+ZWxl bWVudCgpLCBuZXdOb2RlLT5ub2RlTmFtZSgpLCBuZXdOb2RlLT5ub2RlVmFsdWUoKSkpCi0gICAg ICAgICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7Ci0gICAgfQotCi0gICAgRXhj ZXB0aW9uQ29kZSBlYyA9IDA7Ci0gICAgUmVmUHRyPE5vZGU+IHJlc3VsdCA9IGltcC0+c2V0TmFt ZWRJdGVtTlMobmV3Tm9kZSwgZWMpOwotICAgIGlmIChVTkxJS0VMWShlYykpIHsKLSAgICAgICAg dGhyb3dFcnJvcihlYyk7Ci0gICAgICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4oKTsK LSAgICB9Ci0KLSAgICByZXR1cm4gdG9WOChyZXN1bHQucmVsZWFzZSgpKTsKLX0KLQotdjg6Okhh bmRsZTx2ODo6VmFsdWU+IFY4TmFtZWROb2RlTWFwOjpzZXROYW1lZEl0ZW1DYWxsYmFjayhjb25z dCB2ODo6QXJndW1lbnRzICYgYXJncykKLXsKLSAgICBJTkNfU1RBVFMoIkRPTS5OYW1lZE5vZGVN YXAuc2V0TmFtZWRJdGVtIik7Ci0gICAgTmFtZWROb2RlTWFwKiBpbXAgPSBWOE5hbWVkTm9kZU1h cDo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7Ci0gICAgTm9kZSogbmV3Tm9kZSA9IFY4Tm9kZTo6 SGFzSW5zdGFuY2UoYXJnc1swXSkgPyBWOE5vZGU6OnRvTmF0aXZlKHY4OjpIYW5kbGU8djg6Ok9i amVjdD46OkNhc3QoYXJnc1swXSkpIDogMDsKLQotICAgIGlmIChuZXdOb2RlICYmIG5ld05vZGUt Pm5vZGVUeXBlKCkgPT0gTm9kZTo6QVRUUklCVVRFX05PREUgJiYgaW1wLT5lbGVtZW50KCkpIHsK LSAgICAgIGlmICghVjhCaW5kaW5nU2VjdXJpdHk6OmFsbG93U2V0dGluZ1NyY1RvSmF2YXNjcmlw dFVSTChWOEJpbmRpbmdTdGF0ZTo6T25seSgpLCBpbXAtPmVsZW1lbnQoKSwgbmV3Tm9kZS0+bm9k ZU5hbWUoKSwgbmV3Tm9kZS0+bm9kZVZhbHVlKCkpKQotICAgICAgICAgICAgcmV0dXJuIHY4OjpI YW5kbGU8djg6OlZhbHVlPigpOwotICAgIH0KLQotICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwot ICAgIFJlZlB0cjxOb2RlPiByZXN1bHQgPSBpbXAtPnNldE5hbWVkSXRlbShuZXdOb2RlLCBlYyk7 Ci0gICAgaWYgKFVOTElLRUxZKGVjKSkgewotICAgICAgICB0aHJvd0Vycm9yKGVjKTsKLSAgICAg ICAgcmV0dXJuIHY4OjpIYW5kbGU8djg6OlZhbHVlPigpOwotICAgIH0KLQotICAgIHJldHVybiB0 b1Y4KHJlc3VsdC5yZWxlYXNlKCkpOwotfQotCiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChO YW1lZE5vZGVNYXAqIGltcGwpCiB7CiAgICAgaWYgKCFpbXBsKQpJbmRleDogV2ViQ29yZS9kb20v TmFtZWROb2RlTWFwLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAu aWRsCShyZXZpc2lvbiA1OTg3NikKKysrIFdlYkNvcmUvZG9tL05hbWVkTm9kZU1hcC5pZGwJKHdv cmtpbmcgY29weSkKQEAgLTI4LDcgKzI4LDcgQEAgbW9kdWxlIGNvcmUgewogCiAgICAgICAgIE5v ZGUgZ2V0TmFtZWRJdGVtKGluIERPTVN0cmluZyBuYW1lKTsKIAotICAgICAgICBbQ3VzdG9tXSBO b2RlIHNldE5hbWVkSXRlbShpbiBOb2RlIG5vZGUpCisgICAgICAgIE5vZGUgc2V0TmFtZWRJdGVt KGluIE5vZGUgbm9kZSkKICAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwogCiAgICAg ICAgIE5vZGUgcmVtb3ZlTmFtZWRJdGVtKGluIERPTVN0cmluZyBuYW1lKQpAQCAtNDYsNyArNDYs NyBAQCBtb2R1bGUgY29yZSB7CiAgICAgICAgICAgICAvLyBGSVhNRTogdGhlIGltcGxlbWVudGF0 aW9uIGRvZXMgdGFrZSBhbiBleGNlcHRpb25jb2RlIHBhcmFtZXRlci4KICAgICAgICAgICAgIC8q cmFpc2VzKERPTUV4Y2VwdGlvbikqLzsKIAotICAgICAgICBbQ3VzdG9tXSBOb2RlIHNldE5hbWVk SXRlbU5TKGluIE5vZGUgbm9kZSkKKyAgICAgICAgTm9kZSBzZXROYW1lZEl0ZW1OUyhpbiBOb2Rl IG5vZGUpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAogICAgICAgICBbT2xk U3R5bGVPYmpDXSBOb2RlIHJlbW92ZU5hbWVkSXRlbU5TKGluIFtDb252ZXJ0TnVsbFRvTnVsbFN0 cmluZ10gRE9NU3RyaW5nIG5hbWVzcGFjZVVSSSwgCg==