39457 2010-05-20 16:47:15 -0700 REGRESSION(r53637): DivX plug-in fails to start until window is resized 2010-05-20 20:21:20 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://www.divx.com/fr/software/download/installed/chromium InRadar P2 Normal --- 1 jhoneycutt jhoneycutt oldest_to_newest 228628 0 jhoneycutt 2010-05-20 16:47:15 -0700 The video on the page above doesn't start playing until the window is resized. <rdar://problem/8006102> 228658 1 56652 jhoneycutt 2010-05-20 17:44:02 -0700 Created attachment 56652 patch 228671 2 56652 simon.fraser 2010-05-20 18:26:32 -0700 Comment on attachment 56652 patch > diff --git a/WebCore/plugins/win/PluginViewWin.cpp b/WebCore/plugins/win/PluginViewWin.cpp > index 96fa9e4..baef667 100644 > --- a/WebCore/plugins/win/PluginViewWin.cpp > +++ b/WebCore/plugins/win/PluginViewWin.cpp > @@ -610,6 +610,9 @@ void PluginView::paint(GraphicsContext* context, const IntRect& rect) > if (context->paintingDisabled()) > return; > > + // Ensure that we have called SetWindow before we try to paint. > + setNPWindowRect(frameRect()); Plugins may do significant work every time setWindow() is called. Can we be smarter about detecting when it needs to be called (e.g .by remembering the last frameRect that we called it with)? 228693 3 jhoneycutt 2010-05-20 19:02:41 -0700 (In reply to comment #2) > (From update of attachment 56652 [details]) > > diff --git a/WebCore/plugins/win/PluginViewWin.cpp b/WebCore/plugins/win/PluginViewWin.cpp > > index 96fa9e4..baef667 100644 > > --- a/WebCore/plugins/win/PluginViewWin.cpp > > +++ b/WebCore/plugins/win/PluginViewWin.cpp > > @@ -610,6 +610,9 @@ void PluginView::paint(GraphicsContext* context, const IntRect& rect) > > if (context->paintingDisabled()) > > return; > > > > + // Ensure that we have called SetWindow before we try to paint. > > + setNPWindowRect(frameRect()); > > Plugins may do significant work every time setWindow() is called. Can we be smarter about detecting when it needs to be called (e.g .by remembering the last frameRect that we called it with)? I'm not sure why setNPWindowRect() doesn't already do this, but I'm wary about changing that. To fix this bug, it should only be necessary to call setNPWindowRect here if we haven't called NPP_SetWindow yet. I'll update the patch to do that. 228700 4 56661 jhoneycutt 2010-05-20 19:18:36 -0700 Created attachment 56661 patch v2 228720 5 jhoneycutt 2010-05-20 20:21:20 -0700 Landed in r59904. 56652 2010-05-20 17:44:02 -0700 2010-05-20 19:18:36 -0700 patch 0001-REGRESSION-r53637-DivX-plug-in-fails-to-start-until-.patch text/plain 3403 jhoneycutt RnJvbSBmN2U4YjRhMWUxMDFjY2ExOGI4MzQzM2YwZGNjODI5M2VmNTY3MTNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogVGh1LCAyMCBNYXkgMjAxMCAxNzo0MTo1OCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFJF R1JFU1NJT04ocjUzNjM3KTogRGl2WCBwbHVnLWluIGZhaWxzIHRvIHN0YXJ0IHVudGlsIHdpbmRv dyBpcyByZXNpemVkCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk0 NTcKIDxyZGFyOi8vcHJvYmxlbS84MDA2MTAyPgoKQmVmb3JlIHI1MzYzNywgd2UgY2FsbGVkIFdp ZGdldDo6bW92ZSgpICh3aGljaCBjYXVzZWQgdXMgdG8gY2FsbApOUFBfU2V0V2luZG93KSBiZWZv cmUgcGFpbnRpbmcgYSBwbHVnLWluLiByNTM2MzcgcmVtb3ZlZCB0aGUgY2FsbCB0bwpXaWRnZXQ6 Om1vdmUoKSwgYW5kIHdlIGVuZCB1cCBuZXZlciBjYWxsaW5nIE5QUF9TZXRXaW5kb3cgZm9yIHBs dWctaW5zCndpdGggdGhlICJEZWZlckZpcnN0U2V0V2luZG93Q2FsbCIgcXVpcmssIGluY2x1ZGlu ZyB0aGUgRGl2WCBwbHVnLWluLgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIG1hbnVh bC10ZXN0cy9kaXZ4LXBsdWdpbi1mYWlscy10by1kcmF3Lmh0bWw6IEFkZGVkLgoKKiBwbHVnaW5z L3dpbi9QbHVnaW5WaWV3V2luLmNwcDoKKFdlYkNvcmU6OlBsdWdpblZpZXc6OnBhaW50KToKQ2Fs bCBzZXROUFdpbmRvd1JlY3QoKSBiZWZvcmUgcGFpbnRpbmcgdG8gZW5zdXJlIHRoYXQgTlBQX1Nl dFdpbmRvdyBnZXRzCmNhbGxlZC4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKysrKysrKysKIC4uLi9tYW51 YWwtdGVzdHMvZGl2eC1wbHVnaW4tZmFpbHMtdG8tZHJhdy5odG1sICAgIHwgICAxMiArKysrKysr KysrKysKIFdlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAgICAgICAgICAgICAg IHwgICAgMyArKysKIDMgZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlv bnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBXZWJDb3JlL21hbnVhbC10ZXN0cy9kaXZ4LXBsdWdp bi1mYWlscy10by1kcmF3Lmh0bWwKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdlY2JjODIuLjA3Zjk5MDAgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIw MTAtMDUtMjAgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OKHI1MzYzNyk6IERpdlggcGx1Zy1pbiBmYWlscyB0byBzdGFydCB1bnRpbCB3 aW5kb3cgaXMgcmVzaXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzk0NTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgwMDYxMDI+CisKKyAgICAg ICAgQmVmb3JlIHI1MzYzNywgd2UgY2FsbGVkIFdpZGdldDo6bW92ZSgpICh3aGljaCBjYXVzZWQg dXMgdG8gY2FsbAorICAgICAgICBOUFBfU2V0V2luZG93KSBiZWZvcmUgcGFpbnRpbmcgYSBwbHVn LWluLiByNTM2MzcgcmVtb3ZlZCB0aGUgY2FsbCB0bworICAgICAgICBXaWRnZXQ6Om1vdmUoKSwg YW5kIHdlIGVuZCB1cCBuZXZlciBjYWxsaW5nIE5QUF9TZXRXaW5kb3cgZm9yIHBsdWctaW5zCisg ICAgICAgIHdpdGggdGhlICJEZWZlckZpcnN0U2V0V2luZG93Q2FsbCIgcXVpcmssIGluY2x1ZGlu ZyB0aGUgRGl2WCBwbHVnLWluLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogbWFudWFsLXRlc3RzL2RpdngtcGx1Z2luLWZhaWxzLXRvLWRyYXcuaHRt bDogQWRkZWQuCisKKyAgICAgICAgKiBwbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnBhaW50KToKKyAgICAgICAgQ2FsbCBzZXROUFdp bmRvd1JlY3QoKSBiZWZvcmUgcGFpbnRpbmcgdG8gZW5zdXJlIHRoYXQgTlBQX1NldFdpbmRvdyBn ZXRzCisgICAgICAgIGNhbGxlZC4KKwogMjAxMC0wNS0xOCAgRGFuaWVsIENoZW5nICA8ZGNoZW5n QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlciwgSmlhbiBM aS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFsLXRlc3RzL2RpdngtcGx1Z2luLWZhaWxzLXRv LWRyYXcuaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2RpdngtcGx1Z2luLWZhaWxzLXRvLWRy YXcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi41NzI0NGI3Ci0tLSAv ZGV2L251bGwKKysrIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvZGl2eC1wbHVnaW4tZmFpbHMtdG8t ZHJhdy5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzxodG1sPgorPGJvZHk+CitUaGlzIGlzIGEgbWFu dWFsIHRlc3QgZm9yCis8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzk0NTciPkJ1ZyAjMzk0NTc8L2E+LiBJdAorcmVxdWlyZXMgdGhhdCB5b3UgaGF2ZSB0 aGUgRGl2WCBwbHVnLWluIGluc3RhbGxlZC48YnI+PGJyPgorCitUaGUgcGx1Zy1pbiBiZWxvdyBz aG91bGQgbm90IGFwcGVhciBhcyBhIHdoaXRlIGJveCBidXQgYXMgYSB2aWRlbyBwbGF5ZXIgd2l0 aAorY29udHJvbHMuPGJyPjxicj4KKworPGVtYmVkIHR5cGU9InZpZGVvL2RpdngiIHdpZHRoPTMy MCBoZWlnaHQ9MjQwPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVn aW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmll d1dpbi5jcHAKaW5kZXggOTZmYTllNC4uYmFlZjY2NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVn aW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdp blZpZXdXaW4uY3BwCkBAIC02MTAsNiArNjEwLDkgQEAgdm9pZCBQbHVnaW5WaWV3OjpwYWludChH cmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEludFJlY3QmIHJlY3QpCiAgICAgaWYgKGNv bnRleHQtPnBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwogCisgICAgLy8gRW5z dXJlIHRoYXQgd2UgaGF2ZSBjYWxsZWQgU2V0V2luZG93IGJlZm9yZSB3ZSB0cnkgdG8gcGFpbnQu CisgICAgc2V0TlBXaW5kb3dSZWN0KGZyYW1lUmVjdCgpKTsKKwogICAgIGlmIChtX2lzV2luZG93 ZWQpIHsKICNpZiAhT1MoV0lOQ0UpCiAgICAgICAgIGlmIChjb250ZXh0LT5zaG91bGRJbmNsdWRl Q2hpbGRXaW5kb3dzKCkpCi0tIAoxLjYuNS4yLjE0My5nOGNjNjIKCg== 56661 2010-05-20 19:18:36 -0700 2010-05-20 19:51:13 -0700 patch v2 0001-REGRESSION-r53637-DivX-plug-in-fails-to-start-until-.patch text/plain 5147 jhoneycutt RnJvbSAyYjg0M2JkMjQ0ZmQxZGE4MGU0MDIxN2UxZjVlZmRmMjcwODU4NWRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogVGh1LCAyMCBNYXkgMjAxMCAxNzo0MTo1OCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFJF R1JFU1NJT04ocjUzNjM3KTogRGl2WCBwbHVnLWluIGZhaWxzIHRvIHN0YXJ0IHVudGlsIHdpbmRv dyBpcyByZXNpemVkCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk0 NTcKIDxyZGFyOi8vcHJvYmxlbS84MDA2MTAyPgoKQmVmb3JlIHI1MzYzNywgd2UgY2FsbGVkIFdp ZGdldDo6bW92ZSgpICh3aGljaCBjYXVzZWQgdXMgdG8gY2FsbApOUFBfU2V0V2luZG93KSBiZWZv cmUgcGFpbnRpbmcgYSBwbHVnLWluLiByNTM2MzcgcmVtb3ZlZCB0aGUgY2FsbCB0bwpXaWRnZXQ6 Om1vdmUoKSwgYW5kIHdlIGVuZCB1cCBuZXZlciBjYWxsaW5nIE5QUF9TZXRXaW5kb3cgZm9yIHBs dWctaW5zCndpdGggdGhlICJEZWZlckZpcnN0U2V0V2luZG93Q2FsbCIgcXVpcmssIGluY2x1ZGlu ZyB0aGUgRGl2WCBwbHVnLWluLgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIG1hbnVh bC10ZXN0cy9kaXZ4LXBsdWdpbi1mYWlscy10by1kcmF3Lmh0bWw6IEFkZGVkLgoKKiBwbHVnaW5z L1BsdWdpblZpZXcuY3BwOgooV2ViQ29yZTo6UGx1Z2luVmlldzo6UGx1Z2luVmlldyk6CkluaXRp YWxpemUgbmV3IG1lbWJlciB0byBmYWxzZS4KCiogcGx1Z2lucy9QbHVnaW5WaWV3Lmg6CkFkZGVk IG5ldyBtZW1iZXIuCgoqIHBsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwOgooV2ViQ29yZTo6 UGx1Z2luVmlldzo6cGFpbnQpOgpDYWxsIHNldE5QV2luZG93UmVjdCgpIGJlZm9yZSBwYWludGlu ZyB0byBlbnN1cmUgdGhhdCBOUFBfU2V0V2luZG93IGdldHMKY2FsbGVkLgooV2ViQ29yZTo6UGx1 Z2luVmlldzo6c2V0TlBXaW5kb3dSZWN0KToKU2V0IG1faGF2ZUNhbGxlZFNldFdpbmRvdy4KLS0t CiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg MjkgKysrKysrKysrKysrKysrKysrKysKIC4uLi9tYW51YWwtdGVzdHMvZGl2eC1wbHVnaW4tZmFp bHMtdG8tZHJhdy5odG1sICAgIHwgICAxMiArKysrKysrKwogV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXcuY3BwICAgICAgICAgICAgICAgICAgICAgfCAgICAxICsKIFdlYkNvcmUvcGx1Z2lucy9Q bHVnaW5WaWV3LmggICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArCiBXZWJDb3JlL3BsdWdp bnMvd2luL1BsdWdpblZpZXdXaW4uY3BwICAgICAgICAgICAgICB8ICAgIDYgKysrKwogNSBmaWxl cyBjaGFuZ2VkLCA1MCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUg MTAwNjQ0IFdlYkNvcmUvbWFudWFsLXRlc3RzL2RpdngtcGx1Z2luLWZhaWxzLXRvLWRyYXcuaHRt bAoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggN2VjYmM4Mi4uNzEyZDM5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxMC0wNS0yMCAgSm9uIEhvbmV5 Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjUzNjM3 KTogRGl2WCBwbHVnLWluIGZhaWxzIHRvIHN0YXJ0IHVudGlsIHdpbmRvdyBpcyByZXNpemVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTQ1NworICAg ICAgICA8cmRhcjovL3Byb2JsZW0vODAwNjEwMj4KKworICAgICAgICBCZWZvcmUgcjUzNjM3LCB3 ZSBjYWxsZWQgV2lkZ2V0Ojptb3ZlKCkgKHdoaWNoIGNhdXNlZCB1cyB0byBjYWxsCisgICAgICAg IE5QUF9TZXRXaW5kb3cpIGJlZm9yZSBwYWludGluZyBhIHBsdWctaW4uIHI1MzYzNyByZW1vdmVk IHRoZSBjYWxsIHRvCisgICAgICAgIFdpZGdldDo6bW92ZSgpLCBhbmQgd2UgZW5kIHVwIG5ldmVy IGNhbGxpbmcgTlBQX1NldFdpbmRvdyBmb3IgcGx1Zy1pbnMKKyAgICAgICAgd2l0aCB0aGUgIkRl ZmVyRmlyc3RTZXRXaW5kb3dDYWxsIiBxdWlyaywgaW5jbHVkaW5nIHRoZSBEaXZYIHBsdWctaW4u CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtYW51 YWwtdGVzdHMvZGl2eC1wbHVnaW4tZmFpbHMtdG8tZHJhdy5odG1sOiBBZGRlZC4KKworICAgICAg ICAqIHBsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3 OjpQbHVnaW5WaWV3KToKKyAgICAgICAgSW5pdGlhbGl6ZSBuZXcgbWVtYmVyIHRvIGZhbHNlLgor CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3Lmg6CisgICAgICAgIEFkZGVkIG5ldyBtZW1i ZXIuCisKKyAgICAgICAgKiBwbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBsdWdpblZpZXc6OnBhaW50KToKKyAgICAgICAgQ2FsbCBzZXROUFdpbmRvd1Jl Y3QoKSBiZWZvcmUgcGFpbnRpbmcgdG8gZW5zdXJlIHRoYXQgTlBQX1NldFdpbmRvdyBnZXRzCisg ICAgICAgIGNhbGxlZC4KKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldE5QV2luZG93 UmVjdCk6CisgICAgICAgIFNldCBtX2hhdmVDYWxsZWRTZXRXaW5kb3cuCisKIDIwMTAtMDUtMTgg IERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIsIEppYW4gTGkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL21hbnVhbC10ZXN0 cy9kaXZ4LXBsdWdpbi1mYWlscy10by1kcmF3Lmh0bWwgYi9XZWJDb3JlL21hbnVhbC10ZXN0cy9k aXZ4LXBsdWdpbi1mYWlscy10by1kcmF3Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uNTcyNDRiNwotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3Rz L2RpdngtcGx1Z2luLWZhaWxzLXRvLWRyYXcuaHRtbApAQCAtMCwwICsxLDEyIEBACis8aHRtbD4K Kzxib2R5PgorVGhpcyBpcyBhIG1hbnVhbCB0ZXN0IGZvcgorPGEgaHJlZj0iaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NDU3Ij5CdWcgIzM5NDU3PC9hPi4gSXQKK3Jl cXVpcmVzIHRoYXQgeW91IGhhdmUgdGhlIERpdlggcGx1Zy1pbiBpbnN0YWxsZWQuPGJyPjxicj4K KworVGhlIHBsdWctaW4gYmVsb3cgc2hvdWxkIG5vdCBhcHBlYXIgYXMgYSB3aGl0ZSBib3ggYnV0 IGFzIGEgdmlkZW8gcGxheWVyIHdpdGgKK2NvbnRyb2xzLjxicj48YnI+CisKKzxlbWJlZCB0eXBl PSJ2aWRlby9kaXZ4IiB3aWR0aD0zMjAgaGVpZ2h0PTI0MD4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcCBiL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmNwcAppbmRleCAyM2RhOTI4Li5jMTkwYjExIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZp ZXcuY3BwCkBAIC04NDgsNiArODQ4LDcgQEAgUGx1Z2luVmlldzo6UGx1Z2luVmlldyhGcmFtZSog cGFyZW50RnJhbWUsIGNvbnN0IEludFNpemUmIHNpemUsIFBsdWdpblBhY2thZ2UqIHAKICAgICAs IG1faXNKYXZhU2NyaXB0UGF1c2VkKGZhbHNlKQogICAgICwgbV9pc0hhbHRlZChmYWxzZSkKICAg ICAsIG1faGFzQmVlbkhhbHRlZChmYWxzZSkKKyAgICAsIG1faGF2ZUNhbGxlZFNldFdpbmRvdyhm YWxzZSkKIHsKICAgICBpZiAoIW1fcGx1Z2luKSB7CiAgICAgICAgIG1fc3RhdHVzID0gUGx1Z2lu U3RhdHVzQ2FuTm90RmluZFBsdWdpbjsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVn aW5WaWV3LmggYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCmluZGV4IDFiYzI4ODguLjA5 ZTQyZTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgKKysrIGIvV2Vi Q29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaApAQCAtMzgxLDYgKzM4MSw4IEBAIHByaXZhdGU6CiAg ICAgICAgIGJvb2wgbV9pc0hhbHRlZDsKICAgICAgICAgYm9vbCBtX2hhc0JlZW5IYWx0ZWQ7CiAK KyAgICAgICAgYm9vbCBtX2hhdmVDYWxsZWRTZXRXaW5kb3c7CisKICAgICAgICAgc3RhdGljIFBs dWdpblZpZXcqIHNfY3VycmVudFBsdWdpblZpZXc7CiAgICAgfTsKIApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy93aW4v UGx1Z2luVmlld1dpbi5jcHAKaW5kZXggOTZmYTllNC4uM2IyODJlMiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMv d2luL1BsdWdpblZpZXdXaW4uY3BwCkBAIC02MTAsNiArNjEwLDEwIEBAIHZvaWQgUGx1Z2luVmll dzo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiByZWN0KQog ICAgIGlmIChjb250ZXh0LT5wYWludGluZ0Rpc2FibGVkKCkpCiAgICAgICAgIHJldHVybjsKIAor ICAgIC8vIEVuc3VyZSB0aGF0IHdlIGhhdmUgY2FsbGVkIFNldFdpbmRvdyBiZWZvcmUgd2UgdHJ5 IHRvIHBhaW50LgorICAgIGlmICghbV9oYXZlQ2FsbGVkU2V0V2luZG93KQorICAgICAgICBzZXRO UFdpbmRvd1JlY3QoZnJhbWVSZWN0KCkpOworCiAgICAgaWYgKG1faXNXaW5kb3dlZCkgewogI2lm ICFPUyhXSU5DRSkKICAgICAgICAgaWYgKGNvbnRleHQtPnNob3VsZEluY2x1ZGVDaGlsZFdpbmRv d3MoKSkKQEAgLTgxNSw2ICs4MTksOCBAQCB2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93UmVj dChjb25zdCBJbnRSZWN0JiByZWN0KQogICAgICAgICBtX3BsdWdpbi0+cGx1Z2luRnVuY3MoKS0+ c2V0d2luZG93KG1faW5zdGFuY2UsICZtX25wV2luZG93KTsKICAgICAgICAgc2V0Q2FsbGluZ1Bs dWdpbihmYWxzZSk7CiAKKyAgICAgICAgbV9oYXZlQ2FsbGVkU2V0V2luZG93ID0gdHJ1ZTsKKwog ICAgICAgICBpZiAoIW1faXNXaW5kb3dlZCkKICAgICAgICAgICAgIHJldHVybjsKIAotLSAKMS42 LjUuMi4xNDMuZzhjYzYyCgo=